• unknown's avatar
    Fixed portability issue in my_thr_init.c (was added in my last push) · 7191e775
    unknown authored
    Fixed compiler warnings (detected by VC++):
    - Removed not used variables
    - Added casts
    - Fixed wrong assignments to bool
    - Fixed wrong calls with bool arguments
    - Added missing argument to store(longlong), which caused wrong store method to be called.
    
    
    
    client/mysqldump.c:
      Removed compiler warning
    heap/hp_clear.c:
      Removed compiler warning
    include/my_global.h:
      Removed compiler warning
    include/my_tree.h:
      Changed memory limits from int to ulong
      (Allowed me to get rid of some compiler warnings)
    myisam/mi_create.c:
      Removed compiler warning
    myisam/myisampack.c:
      Removed compiler warning
    mysys/base64.c:
      Removed compiler warning
    mysys/my_thr_init.c:
      Fixed portability issue (detected on windows)
      Added DBUG_ASSERT to detect if we call my_thread_end() too many times
      Don't wait if THR_thread_count == -1 (error condition)
    mysys/tree.c:
      Removed compiler warning
    sql/field.cc:
      Removed compiler warning
      Fixed wrong parameter to check_date()
      Added missing argument to store(longlong)
    sql/ha_archive.cc:
      Removed compiler warning
    sql/ha_federated.cc:
      Removed compiler warning
    sql/ha_innodb.cc:
      Removed not used variable
    sql/handler.cc:
      Removed not used variable
      Fixed wrong if (we didn't detect if rollback or commit failed). Not critical as value is not yet used
    sql/item.cc:
      Removed compiler warning
    sql/item_func.cc:
      Removed compiler warning
    sql/item_strfunc.cc:
      Removed compiler warning
    sql/item_timefunc.cc:
      Removed compiler warning
    sql/log.cc:
      Removed compiler warning
    sql/mysql_priv.h:
      Removed compiler warning
    sql/opt_range.cc:
      Removed compiler warning
    sql/password.c:
      Removed compiler warning
    sql/set_var.cc:
      Removed compiler warning
    sql/slave.cc:
      Removed compiler warning
    sql/sp.cc:
      Removed compiler warning
    sql/sp_cache.cc:
      Removed compiler warning
    sql/sp_head.cc:
      Removed compiler warning
      Adjusted argument to reserve() to not use up too much memory that we are probably not going to need
    sql/sql_acl.cc:
      Added missing argument to store(longlong)
    sql/sql_base.cc:
      Removed compiler warning
    sql/sql_db.cc:
      Removed compiler warning
    sql/sql_delete.cc:
      Removed compiler warning
    sql/sql_handler.cc:
      Removed not used variable
    sql/sql_lex.h:
      Removed not used variable
    sql/sql_prepare.cc:
      Removed not used variable
    sql/sql_rename.cc:
      Removed not used variable
    sql/sql_select.cc:
      Fixed that select_options are not 'cut'
      Removed some not used variables
      Removed compiler warnings by adding cast
    sql/sql_show.cc:
      Removed not used variables
      Added missing argument to store(longlong)
      Removed compiler warnings
    sql/sql_trigger.cc:
      Removed not used variables
      Added cast to remove compiler warnings
    sql/sql_update.cc:
      Fixed wrong set of bool variable
    sql/sql_view.cc:
      Removed not used variables
      Added cast to get rid of compiler warnings
    sql-common/client.c:
      Fixed compiler warning
    sql-common/my_time.c:
      Fixed wrong argument to check_date()
      Added casts to get rid of compiler warnings
    sql/sql_yacc.yy:
      Removed not used variable
    sql/uniques.cc:
      Changes memory size from uint to ulong
      Added casts to get rid of compiler warnings
    strings/ctype-simple.c:
      Fixed cast to get rid of compiler warnings
    7191e775
tree.c 19.2 KB