• unknown's avatar
    BUG#21856: Prepared Statements: crash if bad create · ef2d2165
    unknown authored
    When statement to be prepared contained CREATE PROCEDURE, CREATE FUNCTION
    or CREATE TRIGGER statements with a syntax error in it, the preparation
    would fail with syntax error message, but the memory could be corrupted.
    
    The problem occurred because we switch memroot when parse stored
    routine or trigger definitions, and on parse error we restored the
    original memroot only after performing some memory operations.  In more
    detail:
     - prepared statement would activate its own memory root to parse
       the definition of the stored procedure.
     - SP would reset this memory root with its own memory root to
       parse SP statements
     - a syntax error would happen
     - prepared statement would restore the original memory root
     - stored procedure would restore what it thinks was the original
       memory root, but actually was the statement memory root.
    That led to double free - in destruction of the statement and in
    a next call to mysql_parse().
    
    The solution is to restore memroot right after the failed parsing.
    
    
    mysql-test/r/ps.result:
      Add result for bug#21856: Prepared Statements: crash if bad create.
    mysql-test/t/ps.test:
      Add test case for bug#21856: Prepared Statements: crash if bad create.
    sql/sql_parse.cc:
      On parse error if thd->lex->sphead is set we have to free sp_head object
      to restore statement memroot, if it was switched during parsing.
      
      The change here is for safety, currently query_cache_abort() and
      lex->unit.cleanup() calls do not use current memroot.
    sql/sql_prepare.cc:
      On parse error if thd->lex->sphead is set we have to free sp_head object
      to restore statement memroot, if it was switched during parsing.
    ef2d2165
sql_parse.cc 222 KB