• Jon Olav Hauglid's avatar
    Backport of revno: 2617.68.13 · f3e9b392
    Jon Olav Hauglid authored
    Introduce a counter for protection against global read lock on thread level.
    
    The functions for protection against global read lock sometimes need a local
    variable to signal when the protection is set, and hence need to be released.
    It would be better to control this behaviour via a counter on the THD struct,
    telling how many times the protection has been claimed by the current thread.
    A side-effect of the fix is that if protection is claimed twice for a thread,
    only a simple increment is required for the second claim, instead of a
    mutex-protected increment of the global variable protect_against_global_read_lock.
    
    
    sql/lock.cc:
      Count how many times that we have claimed protection against global read lock.
      Assert that we really have the protection when releasing it.
      Added comments to all functions operating on global_read_lock.
    sql/sql_class.cc:
      Added the counter variable global_read_lock_protection.
    sql/sql_class.h:
      Added the counter variable global_read_lock_protection.
    sql/sql_parse.cc:
      Replaced test on local variable need_start_waiting with test on
      thd->global_read_lock_protection.
    sql/sql_table.cc:
      Replaced test on local variable need_start_waiting with test on
      thd->global_read_lock_protection.
    sql/sql_trigger.cc:
      Inserted test on thd->global_read_lock_protection.
    f3e9b392
sql_parse.cc 229 KB