Commit 0aca4f00 authored by Bjorn Munch's avatar Bjorn Munch

Bug #46625 Pushbuild2: does not notice test failure in "Innodb Plugin" mode

Disallow (and don't use) space in combination names
parent fabde82d
...@@ -539,11 +539,11 @@ sub collect_one_suite($) ...@@ -539,11 +539,11 @@ sub collect_one_suite($)
push(@{$new_test->{slave_opt}}, "--plugin_load=innodb=$plugin_filename;innodb_locks=$plugin_filename"); push(@{$new_test->{slave_opt}}, "--plugin_load=innodb=$plugin_filename;innodb_locks=$plugin_filename");
if ($new_test->{combination}) if ($new_test->{combination})
{ {
$new_test->{combination}.= ' + InnoDB plugin'; $new_test->{combination}.= '+innodb_plugin';
} }
else else
{ {
$new_test->{combination}= 'InnoDB plugin'; $new_test->{combination}= 'innodb_plugin';
} }
push(@new_cases, $new_test); push(@new_cases, $new_test);
} }
......
...@@ -3247,6 +3247,12 @@ sub run_testcase ($) { ...@@ -3247,6 +3247,12 @@ sub run_testcase ($) {
mtr_verbose("Running test:", $tinfo->{name}); mtr_verbose("Running test:", $tinfo->{name});
# Allow only alpanumerics pluss _ - + . in combination names
my $combination= $tinfo->{combination};
if ($combination && $combination !~ /^\w[\w-\.\+]+$/)
{
mtr_error("Combination '$combination' contains illegal characters");
}
# ------------------------------------------------------- # -------------------------------------------------------
# Init variables that can change between each test case # Init variables that can change between each test case
# ------------------------------------------------------- # -------------------------------------------------------
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment