merge the recovery changes found by barry and rich during a code review to main closes[t:2231]

git-svn-id: file:///svn/toku/tokudb@16298 c7de825b-a66e-492c-adef-691d508d4ae1

newbrt/tests/recovery-cbegin-cend-hello.c

+// test recovery of a clean shutdown
+
 #include "test.h"
 #include "includes.h"
 

newbrt/tests/recovery-cbegin.c

@@ -17,6 +17,8 @@ run_test(void) {
     r = toku_logger_open(TESTDIR, logger); assert(r == 0);
     LSN beginlsn;
     r = toku_log_begin_checkpoint(logger, &beginlsn, TRUE, 0); assert(r == 0);
+    r = toku_log_end_checkpoint(logger, NULL, TRUE, beginlsn.lsn, 0); assert(r == 0);
+    r = toku_log_begin_checkpoint(logger, &beginlsn, TRUE, 0); assert(r == 0);
     r = toku_logger_close(&logger); assert(r == 0);
 
     // run recovery

newbrt/tests/recovery-fopen-missing-file.c

@@ -17,6 +17,10 @@ run_test(void) {
     TOKULOGGER logger;
     r = toku_logger_create(&logger); assert(r == 0);
     r = toku_logger_open(TESTDIR, logger); assert(r == 0);
+    LSN beginlsn;
+    r = toku_log_begin_checkpoint(logger, &beginlsn, TRUE, 0); assert(r == 0);
+    r = toku_log_end_checkpoint(logger, NULL, TRUE, beginlsn.lsn, 0); assert(r == 0);
+
     BYTESTRING iname  = { strlen("missing_tokudb_file"), "missing_tokudb_file" };
     FILENUM filenum = {42};
     uint32_t treeflags = 0;

newbrt/tests/recovery-hello.c

+// test recovery of "hello" comments
+
 #include "test.h"
 #include "includes.h"
 
@@ -16,7 +18,13 @@ run_test(void) {
     r = toku_logger_create(&logger); assert(r == 0);
     r = toku_logger_open(TESTDIR, logger); assert(r == 0);
     BYTESTRING hello  = { strlen("hello"), "hello" };
-    r = toku_log_comment(logger, NULL, TRUE, 0, hello);
+    r = toku_log_comment(logger, NULL, TRUE, 0, hello); assert(r == 0);
+    LSN beginlsn;
+    r = toku_log_begin_checkpoint(logger, &beginlsn, TRUE, 0); assert(r == 0);
+    r = toku_log_end_checkpoint(logger, NULL, TRUE, beginlsn.lsn, 0); assert(r == 0);
+    r = toku_log_comment(logger, NULL, TRUE, 0, hello); assert(r == 0);
+    BYTESTRING there  = { strlen("there"), "there" };
+    r = toku_log_comment(logger, NULL, TRUE, 0, there); assert(r == 0);
     r = toku_logger_close(&logger); assert(r == 0);
 
     // run recovery

newbrt/tests/recovery-no-datadir.c

+// test recovery with no data directory 
+
 #include "test.h"
 #include "includes.h"
 

newbrt/tests/recovery-no-log.c

+// test recovery with no log
+
 #include "test.h"
 #include "includes.h"
 

newbrt/tests/recovery-no-logdir.c

+// test recovery with a NULL log directory
+
 #include "test.h"
 #include "includes.h"