Commit 4fb05bf0 authored by Leif Walsh's avatar Leif Walsh Committed by Yoni Fogel

refs #5368 make conditions for running helgrind/drd more explicit


git-svn-id: file:///svn/toku/tokudb@48353 c7de825b-a66e-492c-adef-691d508d4ae1
parent 0f6877c2
...@@ -92,13 +92,12 @@ if (BUILD_TESTING OR BUILD_FT_TESTS) ...@@ -92,13 +92,12 @@ if (BUILD_TESTING OR BUILD_FT_TESTS)
include(CMakeDependentOption) include(CMakeDependentOption)
set(helgrind_drd_depend_conditions "") set(helgrind_drd_depend_conditions "")
## helgrind and drd are bad at dealing with freebsd's pthreads ## Helgrind and DRD explicitly state that they only run with the Linux
## implementation, see pkg-message at ## glibc-2.3 NPTL threading implementation [1,2]. If this ever changes
## http://www.freebsdports.info/ports/devel/valgrind.html ## we can enable helgrind and drd on other systems.
list(APPEND helgrind_drd_depend_conditions "NOT CMAKE_SYSTEM_NAME STREQUAL FreeBSD") ## [1]: http://valgrind.org/docs/manual/hg-manual.html#hg-manual.effective-use
## supposedly it's bad on darwin too, don't have a link for that, maybe ## [2]: http://valgrind.org/docs/manual/drd-manual.html#drd-manual.limitations
## worth re-checking list(APPEND helgrind_drd_depend_conditions "CMAKE_SYSTEM_NAME STREQUAL Linux")
list(APPEND helgrind_drd_depend_conditions "NOT CMAKE_SYSTEM_NAME STREQUAL Darwin")
## no point doing it with gcov ## no point doing it with gcov
list(APPEND helgrind_drd_depend_conditions "NOT USE_GCOV") list(APPEND helgrind_drd_depend_conditions "NOT USE_GCOV")
cmake_dependent_option(RUN_DRD_TESTS "Run some tests under drd." ON cmake_dependent_option(RUN_DRD_TESTS "Run some tests under drd." ON
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment