Commit 55b3c844 authored by Vladislav Vaintroub's avatar Vladislav Vaintroub

Small mysql_install_db.exe fixes

- Use lc-messages-dir instead of deprecated --language when running mysqld in bootstrap mode.
- Add some verbosity to mysql_install_db.exe when it runs in course of MSI installation.
parent f33178b9
...@@ -54,6 +54,7 @@ static char *opt_os_password; ...@@ -54,6 +54,7 @@ static char *opt_os_password;
static my_bool opt_default_user; static my_bool opt_default_user;
static my_bool opt_allow_remote_root_access; static my_bool opt_allow_remote_root_access;
static my_bool opt_skip_networking; static my_bool opt_skip_networking;
static my_bool opt_verbose_bootstrap;
static my_bool verbose_errors; static my_bool verbose_errors;
...@@ -83,6 +84,8 @@ static struct my_option my_long_options[]= ...@@ -83,6 +84,8 @@ static struct my_option my_long_options[]=
0, 0}, 0, 0},
{"silent", 's', "Print less information", &opt_silent, {"silent", 's', "Print less information", &opt_silent,
&opt_silent, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0}, &opt_silent, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
{"verbose-bootstrap", 'o', "Include mysqld bootstrap output",&opt_verbose_bootstrap,
&opt_verbose_bootstrap, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
{0, 0, 0, 0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0} {0, 0, 0, 0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0}
}; };
...@@ -244,11 +247,12 @@ static char *init_bootstrap_command_line(char *cmdline, size_t size) ...@@ -244,11 +247,12 @@ static char *init_bootstrap_command_line(char *cmdline, size_t size)
get_basedir(basedir, sizeof(basedir), mysqld_path); get_basedir(basedir, sizeof(basedir), mysqld_path);
my_snprintf(cmdline, size-1, my_snprintf(cmdline, size-1,
"\"\"%s\" --no-defaults --bootstrap" "\"\"%s\" --no-defaults %s --bootstrap"
" \"--language=%s\\share\\english\"" " \"--lc-messages-dir=%s/share\""
" --basedir=. --datadir=. --default-storage-engine=myisam" " --basedir=. --datadir=. --default-storage-engine=myisam"
" --max_allowed_packet=9M --loose-skip-innodb" " --max_allowed_packet=9M --loose-skip-innodb"
" --net-buffer-length=16k\"", mysqld_path, basedir); " --net-buffer-length=16k\"", mysqld_path,
opt_verbose_bootstrap?"--console":"", basedir );
return cmdline; return cmdline;
} }
...@@ -552,7 +556,9 @@ static int create_db_instance() ...@@ -552,7 +556,9 @@ static int create_db_instance()
/* Do mysqld --bootstrap. */ /* Do mysqld --bootstrap. */
init_bootstrap_command_line(cmdline, sizeof(cmdline)); init_bootstrap_command_line(cmdline, sizeof(cmdline));
/* verbose("Executing %s", cmdline); */
if(opt_verbose_bootstrap)
printf("Executing %s\n", cmdline);
in= popen(cmdline, "wt"); in= popen(cmdline, "wt");
if (!in) if (!in)
......
...@@ -692,7 +692,7 @@ ...@@ -692,7 +692,7 @@
<CustomAction Id='PresetDatabaseProperties' BinaryKey='wixca.dll' DllEntry='PresetDatabaseProperties' /> <CustomAction Id='PresetDatabaseProperties' BinaryKey='wixca.dll' DllEntry='PresetDatabaseProperties' />
<CustomAction Id="CreateDatabaseCommand" Property="CreateDatabase" <CustomAction Id="CreateDatabaseCommand" Property="CreateDatabase"
Value= Value=
"&quot;[#F.bin.mysql_install_db.exe]&quot; &quot;--service=[SERVICENAME]&quot; --port=[PORT] &quot;--password=[ESCAPEDPASSWORD]&quot; &quot;--datadir=[DATADIR]\&quot; [SKIPNETWORKING] [ALLOWREMOTEROOTACCESS] [DEFAULTUSER]" "&quot;[#F.bin.mysql_install_db.exe]&quot; &quot;--service=[SERVICENAME]&quot; --port=[PORT] &quot;--password=[ESCAPEDPASSWORD]&quot; &quot;--datadir=[DATADIR]\&quot; [SKIPNETWORKING] [ALLOWREMOTEROOTACCESS] [DEFAULTUSER] --verbose-bootstrap"
Execute="immediate" Execute="immediate"
HideTarget="yes" HideTarget="yes"
/> />
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment