Commit 625ddcd5 authored by Luis Soares's avatar Luis Soares

BUG#48048: Deprecated constructs need removal in Betony

Post-push fix: Removed MTRv1 arguments according to the
original patch. Although there is a version check, the patch
was pushed to a 5.1 GA staging tree, while the version check 
considers version 5.2. This makes the deprecated parameters 
to be used, despite the fact that they are not valid anymore.

Part of MTRv1 is currently used in RQG semisync test, and this
was causing the test to fail on slave startup.

It should be safe to uncomment when merging up to celosia.
parent bcb25587
...@@ -4024,15 +4024,26 @@ sub mysqld_arguments ($$$$) { ...@@ -4024,15 +4024,26 @@ sub mysqld_arguments ($$$$) {
} }
else else
{ {
if ($mysql_version_id < 50200) # NOTE: the backport (see BUG#48048) originally removed the
{ # commented out lines below. However, given that they are
mtr_add_arg($args, "%s--master-user=root", $prefix); # protected with a version check (< 50200) now, it should be
mtr_add_arg($args, "%s--master-connect-retry=1", $prefix); # safe to keep them. The problem is that the backported patch
mtr_add_arg($args, "%s--master-host=127.0.0.1", $prefix); # was into a 5.1 GA codebase - mysql-5.1-rep+2 tree - so
mtr_add_arg($args, "%s--master-password=", $prefix); # version is 501XX, consequently check becomes worthless. It
mtr_add_arg($args, "%s--master-port=%d", $prefix, # should be safe to uncomment them when merging up to 5.5.
$master->[0]->{'port'}); # First master #
} # RQG semisync test runs on the 5.1 GA tree and needs MTR v1.
# This was causing the test to fail (slave would not start
# due to unrecognized option(s)).
# if ($mysql_version_id < 50200)
# {
# mtr_add_arg($args, "%s--master-user=root", $prefix);
# mtr_add_arg($args, "%s--master-connect-retry=1", $prefix);
# mtr_add_arg($args, "%s--master-host=127.0.0.1", $prefix);
# mtr_add_arg($args, "%s--master-password=", $prefix);
# mtr_add_arg($args, "%s--master-port=%d", $prefix,
# $master->[0]->{'port'}); # First master
# }
my $slave_server_id= 2 + $idx; my $slave_server_id= 2 + $idx;
my $slave_rpl_rank= $slave_server_id; my $slave_rpl_rank= $slave_server_id;
mtr_add_arg($args, "%s--server-id=%d", $prefix, $slave_server_id); mtr_add_arg($args, "%s--server-id=%d", $prefix, $slave_server_id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment