turn on -Werror for icc builds. addresses #1185

git-svn-id: file:///svn/tokudb.1131b+1080a+1185@6409 c7de825b-a66e-492c-adef-691d508d4ae1

newbrt/tests/Makefile

@@ -38,6 +38,7 @@ CFLAGS = -Wall $(FORMAT) $(OPTFLAGS) $(GCOV_FLAGS) $(PROF_FLAGS) $(FPICFLAGS) $(
 ifneq ($(CC),icc)
  CFLAGS += -Werror -Wextra -Wcast-align -Wbad-function-cast -Wmissing-noreturn -g3 -ggdb3
 else
+ CFLAGS += -Werror
  CFLAGS += -g 
  CFLAGS += -diag-disable 177     # Don't complain about static variables that are not used.
  CFLAGS += -diag-disable 981     # Don't complain about "operands are evaluated in unspecified order".  This seems to be generated whenever more than one argument to a function or operand is computed by function call.

newbrt/tests/cachetable-rename-test.c

@@ -174,25 +174,11 @@ static void test_rename (void) {
 }
 
 int main (int argc, const char *argv[]) {
-    // defaults
-    int do_malloc_fail = 0;
-
     // parse args
     default_parse_args(argc, argv);
-    int i;
-    for (i=1; i<argc; i++) {
-        const char *arg = argv[i];
-        if (strcmp(arg, "-v") == 0) {
-            verbose++;
-            continue;
-        }
-        if (strcmp(arg, "-malloc-fail") == 0) {
-            do_malloc_fail = 1;
-            continue;
-        }
-    }
 
     // run tests
+    int i;
     for (i=0; i<1; i++) 
         test_rename();
     return 0;