Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
81332ff9
Commit
81332ff9
authored
Sep 19, 2007
by
marko
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
branches/zip: Improve Valgrind instrumentation in the merge block I/O
of fast index creation.
parent
8b4d7880
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
6 deletions
+10
-6
row/row0merge.c
row/row0merge.c
+10
-6
No files found.
row/row0merge.c
View file @
81332ff9
...
@@ -41,7 +41,7 @@ Completed by Sunny Bains and Marko Makela
...
@@ -41,7 +41,7 @@ Completed by Sunny Bains and Marko Makela
/* Block size for I/O operations in merge sort */
/* Block size for I/O operations in merge sort */
typedef
byte
row_merge_block_t
[
1
048576
];
typedef
byte
row_merge_block_t
[
1
6384
];
/* Secondary buffer for I/O operations of merge records */
/* Secondary buffer for I/O operations of merge records */
...
@@ -776,6 +776,8 @@ row_merge_write_rec(
...
@@ -776,6 +776,8 @@ row_merge_write_rec(
return
(
NULL
);
return
(
NULL
);
}
}
UNIV_MEM_ALLOC
(
block
[
0
],
sizeof
block
[
0
]);
/* Copy the rest. */
/* Copy the rest. */
b
=
block
[
0
];
b
=
block
[
0
];
memcpy
(
b
,
buf
[
0
]
+
avail_size
,
size
-
avail_size
);
memcpy
(
b
,
buf
[
0
]
+
avail_size
,
size
-
avail_size
);
...
@@ -807,16 +809,15 @@ row_merge_write_eof(
...
@@ -807,16 +809,15 @@ row_merge_write_eof(
ut_ad
(
foffs
);
ut_ad
(
foffs
);
*
b
++
=
0
;
*
b
++
=
0
;
#ifdef UNIV_DEBUG_VALGRIND
UNIV_MEM_ASSERT_RW
(
block
[
0
],
b
-
block
[
0
]);
/* The rest of the block is uninitialized. Initialize it
UNIV_MEM_ASSERT_W
(
block
[
0
],
sizeof
block
[
0
]);
to avoid bogus warnings. */
UNIV_MEM_VALID
(
block
[
0
],
sizeof
block
[
0
]);
memset
(
b
,
0
,
block
[
1
]
-
b
);
#endif
/* UNIV_DEBUG_VALGRIND */
if
(
!
row_merge_write
(
fd
,
(
*
foffs
)
++
,
block
))
{
if
(
!
row_merge_write
(
fd
,
(
*
foffs
)
++
,
block
))
{
return
(
NULL
);
return
(
NULL
);
}
}
UNIV_MEM_ALLOC
(
block
[
0
],
sizeof
block
[
0
]);
return
(
block
[
0
]);
return
(
block
[
0
]);
}
}
...
@@ -1023,6 +1024,7 @@ row_merge_read_clustered_index(
...
@@ -1023,6 +1024,7 @@ row_merge_read_clustered_index(
goto
func_exit
;
goto
func_exit
;
}
}
UNIV_MEM_ALLOC
(
block
[
0
],
sizeof
block
[
0
]);
merge_buf
[
i
]
=
row_merge_buf_empty
(
buf
);
merge_buf
[
i
]
=
row_merge_buf_empty
(
buf
);
}
}
...
@@ -1215,6 +1217,8 @@ row_merge(
...
@@ -1215,6 +1217,8 @@ row_merge(
||
!
row_merge_write
(
of
.
fd
,
of
.
offset
++
,
block
))
{
||
!
row_merge_write
(
of
.
fd
,
of
.
offset
++
,
block
))
{
return
(
DB_CORRUPTION
);
return
(
DB_CORRUPTION
);
}
}
UNIV_MEM_ALLOC
(
block
[
0
],
sizeof
block
[
0
]);
}
}
/* Swap file descriptors for the next pass. */
/* Swap file descriptors for the next pass. */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment