Commit b6e826ba authored by Vladislav Vaintroub's avatar Vladislav Vaintroub

MDEV-10118 : do not suggest upgrade from MySQL 5.7 to MariaDB 10.x in the...

MDEV-10118 : do not suggest upgrade from MySQL 5.7 to MariaDB 10.x in the installer. Do not lauch upgrade wizard after installation
parent cee9ab9d
...@@ -81,8 +81,10 @@ void normalize_path(char *path, size_t size) ...@@ -81,8 +81,10 @@ void normalize_path(char *path, size_t size)
and services. We do not want to mess up with these installations. We will and services. We do not want to mess up with these installations. We will
just ignore such services, pretending it is not MySQL. just ignore such services, pretending it is not MySQL.
@return We also exclude MySQL5.7+ since we cannot upgrade it (and it is not an upgrade anyway)
TRUE, if this service should be excluded from UI lists etc (OEM install)
@return
TRUE, if this service should be excluded from UI lists etc
FALSE otherwise. FALSE otherwise.
*/ */
BOOL exclude_service(mysqld_service_properties *props) BOOL exclude_service(mysqld_service_properties *props)
...@@ -104,7 +106,12 @@ BOOL exclude_service(mysqld_service_properties *props) ...@@ -104,7 +106,12 @@ BOOL exclude_service(mysqld_service_properties *props)
if (strstr(buf, exclude_patterns[i])) if (strstr(buf, exclude_patterns[i]))
return TRUE; return TRUE;
} }
if ((props->version_major == 0) ||
(props->version_major > 5 && props->version_major < 10) ||
(props->version_major == 5 && props->version_minor > 6))
{
return TRUE;
}
return FALSE; return FALSE;
} }
......
...@@ -886,11 +886,11 @@ extern "C" UINT __stdcall CheckServiceUpgrades(MSIHANDLE hInstall) ...@@ -886,11 +886,11 @@ extern "C" UINT __stdcall CheckServiceUpgrades(MSIHANDLE hInstall)
(QUERY_SERVICE_CONFIGW*)(void *)config_buffer; (QUERY_SERVICE_CONFIGW*)(void *)config_buffer;
DWORD needed; DWORD needed;
BOOL ok= QueryServiceConfigW(service, config,sizeof(config_buffer), BOOL ok= QueryServiceConfigW(service, config,sizeof(config_buffer),
&needed); &needed) && (config->dwStartType != SERVICE_DISABLED);
CloseServiceHandle(service); CloseServiceHandle(service);
if (ok) if (ok)
{ {
mysqld_service_properties props; mysqld_service_properties props;
if (get_mysql_service_properties(config->lpBinaryPathName, &props)) if (get_mysql_service_properties(config->lpBinaryPathName, &props))
continue; continue;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment