1. 15 Nov, 2011 5 commits
    • Dmitry Lenev's avatar
      Fix for bug#12695572 - "IMPROVE MDL PERFORMANCE IN PRE-VISTA · 02e1d6e6
      Dmitry Lenev authored
      BY CACHING OR REDUCING CREATEEVENT CALLS".
       
      5.5 versions of MySQL server performed worse than 5.1 versions 
      under single-connection workload in autocommit mode on Windows XP.
       
      Part of this slowdown can be attributed to overhead associated
      with constant creation/destruction of MDL_lock objects in the MDL
      subsystem. The problem is that creation/destruction of these
      objects causes creation and destruction of associated
      synchronization primitives, which are expensive on Windows XP.
       
      This patch tries to alleviate this problem by introducing a cache
      of unused MDL_object_lock objects. Instead of destroying such
      objects we put them into the cache and then reuse with a new
      key when creation of a new object is requested.
      
      To limit the size of this cache, a new --metadata-locks-cache-size
      start-up parameter was introduced.
      02e1d6e6
    • Luis Soares's avatar
      BUG#11760927 · e5aa632c
      Luis Soares authored
      Follow up to fix freebsd compile issue.
      e5aa632c
    • Luis Soares's avatar
      BUG#11760927 · 677d5805
      Luis Soares authored
      Automerged approved bzr bundle in latest mysql-5.5.
      677d5805
    • Nirbhay Choubey's avatar
      Bug#11827359 60223: MYSQL_UPGRADE PROBLEM WITH · 0c509745
      Nirbhay Choubey authored
                          OPTION SKIP-WRITE-BINLOG
      
      System tables were not getting upgraded when
      mysql_upgrade was run with --skip-write-binlog
      option. (Same for --write-binlog.) Also, with
      this option, mysql_upgrade_info file was not
      getting created after the upgrade.
      
      mysql_upgrade makes use of mysql client tool in
      order to run upgrade scripts, while doing so it
      passes some of the command line options (used to
      start mysql_upgrade) directly to mysql client.
      The reason behind this bug being, some options
      like skip-write-binlog and upgrade-system-tables
      were being passed to mysql tool along with other
      options, and hence mysql execution failed due
      presence of these invalid options.
      
      Fixed this issue by filtering out the above mentioned
      options from the list of options that will be passed to
      mysql and mysqlcheck tools. However, since --write-binlog
      is supported by mysqlcheck, this option would be used
      explicitly while running mysqlcheck. (not part of patch,
      already there)
      
      Checking the contents of general log after the upgrade
      is not doable via an mtr test. So performed manual test.
      Added a test to verify the creation of mysql_upgrade_info.
      0c509745
    • Tor Didriksen's avatar
      Bug#13261955 TRUNCATE(DBL_MAX) RETURNS DBL_MAX RATHER THAN 'INF' · 99230c9b
      Tor Didriksen authored
      my_double_round(DBL_MAX, -12, ....)
      should return 'inf' rather than DBL_MAX
      
      The problem is that floor(value/tmp) * tmp
      is inlined, and optimized away.
      
      The solution seems to be to prevent inlining by pre-computing value/tmp and
      storing it in a variable.
      
      No new test case: main.type_float fails without this patch.
      99230c9b
  2. 11 Nov, 2011 3 commits
    • chuck.bell@oracle.com's avatar
      BUG#12929028: mysql_plugin : the --mysqld option is required, but not used · c54d88c3
      chuck.bell@oracle.com authored
      This patch corrects a defect whereby the --mysqld, --my-print-defaults, 
      and --plugin-ini were required. These options are not required and the
      code has been fixed accordingly.
      c54d88c3
    • Luis Soares's avatar
      BUG#11760927: 53375: RBR + NO PK => HIGH LOAD ON SLAVE (TABLE · 595a007d
      Luis Soares authored
                    SCAN/CPU) => SLAVE FAILURE
      
      When a statement containing a large amount of ROWs to be applied on
      the slave, and the slave's table does not contain a PK, it can take a
      considerable amount of time to find and change all the rows that are
      to be changed.
      
      The proper slave enhancement will be implemented in WL 5597. However,
      in this bug we are making it clear to the user what the problem is, by
      printing a message to the error log if the execution time, for a given
      statement in RBR, takes more than LONG_FIND_ROW_THRESHOLD (set to 60
      seconds). This shall help the DBA to diagnose what's happening when
      facing a slave server that is quiet for no apparent reason...
      
      The note is only printed to the error log if log_warnings is set to be
      greater than 1.
      595a007d
    • Sneha Modi's avatar
      BUG#11748731 - 37248: SOME 'BIG' TESTS FAILING ON 6.0 : · 7ca801fe
      Sneha Modi authored
      A change has been made in the sql/sql_table.cc file to include debug_sync.
      7ca801fe
  3. 10 Nov, 2011 8 commits
  4. 09 Nov, 2011 3 commits
  5. 08 Nov, 2011 4 commits
  6. 07 Nov, 2011 3 commits
    • Marko Mäkelä's avatar
      Merge mysql-5.1 to mysql-5.5. · 82642cd3
      Marko Mäkelä authored
      82642cd3
    • Marko Mäkelä's avatar
      Add debug assertions to catch Bug#13345378 earlier. · 2cb3c205
      Marko Mäkelä authored
      In all callers of row_sel_convert_mysql_key_to_innobase(), assert
      that the converted key is empty or nonempty when it should be.
      2cb3c205
    • Marko Mäkelä's avatar
      Bug#13340047 LATCHING ORDER VIOLATION IN IBUF_SET_ENTRY_COUNTER() · 0532b38f
      Marko Mäkelä authored
      ibuf_insert_low(), the only caller of ibuf_set_entry_counter(), will
      have latched an insert buffer bitmap page in bitmap_mtr before
      invoking ibuf_set_entry_counter(). The latching order forbids any
      further pages to be latched.
      
      ibuf_set_entry_counter(): Renamed to ibuf_get_entry_counter(),
      simplified the code and added comments.
      
      Added the following symbols for predefined field numbers in change
      buffer records:
      
      #define IBUF_REC_FIELD_SPACE	0	/*!< in the pre-4.1 format,
      					the page number. later, the space_id */
      #define IBUF_REC_FIELD_MARKER	1	/*!< starting with 4.1, a marker
      					consisting of 1 byte that is 0 */
      #define IBUF_REC_FIELD_PAGE	2	/*!< starting with 4.1, the
      					page number */
      #define IBUF_REC_FIELD_METADATA	3	/* the metadata field */
      #define IBUF_REC_FIELD_USER	4	/* first user field */
      
      rb:802 approved by Sunny Bains
      0532b38f
  7. 04 Nov, 2011 1 commit
  8. 03 Nov, 2011 5 commits
  9. 02 Nov, 2011 3 commits
  10. 01 Nov, 2011 2 commits
  11. 31 Oct, 2011 2 commits
  12. 28 Oct, 2011 1 commit
    • Andrei Elkin's avatar
      BUG#11763573 · e0660442
      Andrei Elkin authored
      post-push fixes for show_slave_io_error= 1 of wait_for_slave_io_error.inc;
      Unix and win format path specifically so few tests have to change show_slave_io_error
      to zero.
      e0660442