1. 05 Nov, 2010 4 commits
    • Guilhem Bichot's avatar
      Fix for BUG#57316 "It is not clear how to disable autocommit" · 03b9e738
      Guilhem Bichot authored
      add boolean command-line option --autocommit.
      
      mysql-test/mysql-test-run.pl:
        do in --gdb like in --ddd: to let the developer debug the startup
        phase (like command-line options parsing), don't "run".
        It's the third time I do this change, it was previously lost
        by merges, port of 6.0 to next-mr...
      mysql-test/r/mysqld--help-notwin.result:
        new command-line option
      mysql-test/r/mysqld--help-win.result:
        a Linux user's best guess at what the Windows result should be
      mysql-test/suite/sys_vars/inc/autocommit_func2.inc:
        new test
      mysql-test/suite/sys_vars/t/autocommit_func2-master.opt:
        test new option
      mysql-test/suite/sys_vars/t/autocommit_func3-master.opt:
        test new option
      sql/mysqld.cc:
        new --autocommit
      sql/mysqld.h:
        new --autocommit
      sql/sql_partition.cc:
        What matters to this partitioning quote is to have
        the OPTION_QUOTE_SHOW_CREATE flag down, it's all
        that append_identifier() uses. So we make it explicit.
      03b9e738
    • Luis Soares's avatar
      BUG 57899: merged bzr bundle #2 from bug report into latest · 7b0db1e9
      Luis Soares authored
                 mysql-5.5-bugteam.
      7b0db1e9
    • Luis Soares's avatar
      BUG 57899: merged bzr bundle #1 from bug report into latest · 2fb040e0
      Luis Soares authored
                 mysql-5.5-bugteam.
      2fb040e0
    • Luis Soares's avatar
      BUG#57899: Certain reserved words should not be reserved · aafb35d0
      Luis Soares authored
      Small fix for the test case. The column named "slow" was
      used twice in the SELECTs. As a consequence, the column
      named "ignore_server_ids" was not used.
      
      To fix this we simply replace the second column selected 
      named "slow" with a column named "ignore_server_ids".
      aafb35d0
  2. 04 Nov, 2010 5 commits
    • Jorgen Loland's avatar
      Bug#57882 - Item_func_conv_charset::val_str(String*): · f0ce6787
      Jorgen Loland authored
                  Assertion `fixed == 1' failed
      
      Followup patch. Test case relied on system variable that is
      only available if replication is compiled in. Replaced with
      variable available in all builds.
      
      mysql-test/r/errors.result:
        Test case relied on system variable that is only available if
        replication is compiled in. Replaced with variable available in
        all builds.
      mysql-test/t/errors.test:
        Test case relied on system variable that is only available if
        replication is compiled in. Replaced with variable available in
        all builds.
      f0ce6787
    • smenon's avatar
      merge · a9a6cd13
      smenon authored
      a9a6cd13
    • smenon's avatar
      Bug #57746: Win directory of source distribution - out-of-date files / support for new files · 0752b54a
      smenon authored
      (win/README updated with some more changes)
      0752b54a
    • Jorgen Loland's avatar
      Bug#57882 - Item_func_conv_charset::val_str(String*): · 64bee6fd
      Jorgen Loland authored
                  Assertion `fixed == 1' failed
      
      (also fixes duplicate bug 57515)
      
      agg_item_set_converter() (item.cc) handles conversion of 
      character sets by creating a new Item. fix_fields() is then 
      called on this newly created item. Prior to this patch, it was
      not checked whether fix_fields() was successful or not. Thus, 
      agg_item_set_converter() would return success even when an 
      error occured. This patch makes it return error (TRUE) if 
      fix_fields() fails.
      
      mysql-test/r/errors.result:
        Add test for BUG#57882
      mysql-test/t/errors.test:
        Add test for BUG#57882
      sql/item.cc:
        Make agg_item_set_converter() return with error if fix_fields() 
        on the newly created converted item fails.
      64bee6fd
    • He Zhenxing's avatar
      BUG#47027 delegates_init() failure is not user friendly (usability issue) · 6429e7d3
      He Zhenxing authored
            
      Function delegetas_init() did not report proper error messages
      when there are failures, which made it hard to know where the problem
      occurred.
      
      Fixed the problem by adding specific error message for every possible
      place that can fail. And since these failures are supposed to never
      happen, ask the user to report a bug if they happened.
      6429e7d3
  3. 03 Nov, 2010 9 commits
  4. 02 Nov, 2010 5 commits
  5. 01 Nov, 2010 5 commits
  6. 31 Oct, 2010 2 commits
    • Gleb Shchepa's avatar
      71082fd1
    • Gleb Shchepa's avatar
      Bug #52160: crash and inconsistent results when grouping · 20d70497
      Gleb Shchepa authored
                  by a function and column
      
      The bugreport reveals two different bugs about grouping
      on a function:
      
      1) grouping by the TIME_TO_SEC function result caused
         a server crash or wrong results and
      2) grouping by the function returning a blob caused
         an unexpected "Duplicate entry" error and wrong
         result.
      
      Details for the 1st bug:
      
      TIME_TO_SEC() returns NULL if its argument is invalid (empty
      string for example). Thus its nullability depends not only
      on the nullability of its arguments but also on their values.
      Fixed by (overoptimistically) setting TIME_TO_SEC() to be
      nullable despite the nullability of its arguments.
      
      Details for the 2nd bug:
      
      The server is unable to create indices on blobs without
      explicit blob key part length. However, this fact was
      ignored for blob function result fields of GROUP BY
      intermediate tables.
      Fixed by disabling GROUP BY index creation for blob
      function result fields like regular blob fields.
      
      
      mysql-test/r/func_time.result:
        Test case for bug #52160.
      mysql-test/r/type_blob.result:
        Test case for bug #52160.
      mysql-test/t/func_time.test:
        Test case for bug #52160.
      mysql-test/t/type_blob.test:
        Test case for bug #52160.
      sql/item_timefunc.h:
        Bug #52160: crash and inconsistent results when grouping
                    by a function and column
        
        TIME_TO_SEC() returns NULL if its argument is invalid (empty
        string for example). Thus its nullability depends not only
        Fixed by (overoptimistically) setting TIME_TO_SEC() to be
        nullable despite the nullability of its arguments.
      sql/sql_select.cc:
        Bug #52160: crash and inconsistent results when grouping
                    by a function and column
        
        The server is unable to create indices on blobs without
        explicit blob key part length. However, this fact was
        ignored for blob function result fields of GROUP BY
        intermediate tables.
        Fixed by disabling GROUP BY index creation for blob
        function result fields like regular blob fields.
      20d70497
  7. 29 Oct, 2010 3 commits
  8. 28 Oct, 2010 2 commits
    • Calvin Sun's avatar
      Bug#52062: Compiler warning in os0file.c on windows 64-bit · 460ad14e
      Calvin Sun authored
      On Windows, the parameter for number of bytes passed into WriteFile()
      and ReadFile() is DWORD. Casting is needed to silence the warning on
      64-bit Windows.
      
      Also, adding several asserts to ensure the variable for number of bytes
      is no more than 32 bits, even on 64-bit Windows.
      
      This is for InnoDB Plugin.
      
      rb://415
      Approved by: Inaam
      460ad14e
    • Calvin Sun's avatar
      Bug#52062: Compiler warning in os0file.c on windows 64-bit · 16feea41
      Calvin Sun authored
      On Windows, the parameter for number of bytes passed into WriteFile()
      and ReadFile() is DWORD. Casting is needed to silence the warning on
      64-bit Windows.
      
      Also, adding several asserts to ensure the variable for number of bytes
      is no more than 32 bits, even on 64-bit Windows.
      
      This is for built-in InnoDB.
      
      rb://415
      Approved by: Inaam
      16feea41
  9. 27 Oct, 2010 1 commit
  10. 29 Oct, 2010 3 commits
  11. 28 Oct, 2010 1 commit
    • Vasil Dimov's avatar
      Fix a compilation warning: · e3decfa0
      Vasil Dimov authored
      /export/home/pb2/build/sb_0-2459340-1288264809.63/mysql-5.5.8-ga/storage/innobase/os/os0sync.c: In function 'os_cond_wait_timed':
      /export/home/pb2/build/sb_0-2459340-1288264809.63/mysql-5.5.8-ga/storage/innobase/os/os0sync.c:184: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'time_t'
      gmake[2]: *** [storage/innobase/CMakeFiles/innobase.dir/os/os0sync.c.o] Error 1 
      e3decfa0