1. 01 Apr, 2010 40 commits
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 09a8580b
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6718 | marko | 2010-02-16 15:06:16 +0200 (Tue, 16 Feb 2010) | 1 line
      branches/zip: Fix a comment.
      09a8580b
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · f957ec3d
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6717 | marko | 2010-02-16 14:53:20 +0200 (Tue, 16 Feb 2010) | 2 lines
      branches/zip: log_reserve_and_write_fast(): Correct a race condition
      in UNIV_LOG_LSN_DEBUG.  This could have caused Issue #440.
      f957ec3d
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 2eb1bb6b
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6715 | sunny | 2010-02-16 10:14:21 +0200 (Tue, 16 Feb 2010) | 1 line
      branches/zip: Fix comment. Non functional change.
      2eb1bb6b
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 8d04789f
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6714 | sunny | 2010-02-16 10:12:25 +0200 (Tue, 16 Feb 2010) | 2 lines
      branches/zip: Update the comments and fix the whitespace issues.
      See rb://255 Approved by: Marko
      8d04789f
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 745b7e8e
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6713 | sunny | 2010-02-16 10:12:17 +0200 (Tue, 16 Feb 2010) | 7 lines
      branches/zip: Change the bit fields back to ulint. Bit fields were causing
      problems with concurrency on SMP systems because of word packing issues.
      The number of trx_t's in a system is not sufficient enough to require that
      we try and save a few bytes in the data structure.
      
      See rb://255 for details.
      745b7e8e
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 8b3a014e
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6712 | marko | 2010-02-16 10:05:36 +0200 (Tue, 16 Feb 2010) | 2 lines
      branches/zip: trx_lists_init_at_db_start(): Assert that the kernel_mutex
      is held by the caller.
      8b3a014e
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · d74c008d
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6707 | inaam | 2010-02-12 19:22:35 +0200 (Fri, 12 Feb 2010) | 4 lines
      branches/zip
      
      ChangeLog entry for r6674.
      d74c008d
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 84eb1908
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6675 | marko | 2010-02-11 22:41:11 +0200 (Thu, 11 Feb 2010) | 1 line
      branches/zip: Remove bogus debug assertions introduced in r6660.
      84eb1908
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#49535. · f6beb765
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6674 | inaam | 2010-02-11 17:54:44 +0200 (Thu, 11 Feb 2010) | 16 lines
      branches/zip bug# 49535
      
      This is a backport of r4924.
      mem_heap_get_size() scans all allocated blocks to calculate the total
      size of the heap. This patch introduces a new, total_size, field in
      mem_block_info_struct. This field is valid only for base block 
      (i.e.: the first block allocated for the heap) and is set to
      ULINT_UNDEFINED in other blocks.
      This considerably improves the performance of redo scan during recovery.
      
      rb://108 issue#216
      
      Approved by: Heikki
      f6beb765
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 08ed716d
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6673 | marko | 2010-02-11 13:09:48 +0200 (Thu, 11 Feb 2010) | 9 lines
      branches/zip: Relax a debug assertion about a missing BLOB. (Issue #452)
      When rolling back an incomplete transaction in purge, tolerate missing
      BLOBs also in update undo, when undoing an INSERT by updating a delete-marked
      record, and the delete-marked record is no longer needed.
      Previously, we only tolerated missing BLOBs in insert undo.
      This merely fixes a debug assertion; the code performed correctly
      without UNIV_DEBUG.
      
      rb://249 approved by Sunny Bains.
      08ed716d
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · d4c7bd2f
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6672 | marko | 2010-02-11 13:01:18 +0200 (Thu, 11 Feb 2010) | 1 line
      branches/zip: Introduce thr_is_recv().
      d4c7bd2f
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 4ccf8bff
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6660 | marko | 2010-02-11 11:21:11 +0200 (Thu, 11 Feb 2010) | 7 lines
      branches/zip: Clarify the rollback of INSERT by UPDATE of delete-marked rec.
      
      row_undo_mod_remove_clust_low(): Augment the function comment.
      
      row_undo_mod_remove_clust_low(), row_undo_mod_del_mark_or_remove_sec_low(),
      row_undo_mod_del_mark_or_remove_sec(), row_undo_mod_upd_del_sec():
      Add ut_ad(node->rec_type == TRX_UNDO_UPD_DEL_REC);
      4ccf8bff
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 058fdb11
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6639 | marko | 2010-02-10 13:11:04 +0200 (Wed, 10 Feb 2010) | 1 line
      branches/zip: trx_rseg_create(): Unused function, remove.
      058fdb11
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 6f31e79a
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6635 | marko | 2010-02-10 11:07:05 +0200 (Wed, 10 Feb 2010) | 4 lines
      branches/zip: Clean up after r6559.  Now that
      btr_pcur_open_with_no_init() is a macro, do not mix preprocessor
      directives in the macro invocation, because it is implementation-defined
      whether that is going to work.
      6f31e79a
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 286dc23a
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6633 | marko | 2010-02-10 10:40:55 +0200 (Wed, 10 Feb 2010) | 31 lines
      branches/zip: Merge revisions 6538:6613 from branches/5.1:
      
        ------------------------------------------------------------------------
        r6545 | jyang | 2010-02-03 03:57:32 +0200 (Wed, 03 Feb 2010) | 8 lines
        Changed paths:
           M /branches/5.1/lock/lock0lock.c
      
        branches/5.1: Fix bug #49001, "SHOW INNODB STATUS deadlock info
        incorrect when deadlock detection aborts". Print the correct
        lock owner when recursive function lock_deadlock_recursive()
        exceeds its maximum depth LOCK_MAX_DEPTH_IN_DEADLOCK_CHECK.
      
        rb://217, approved by Marko.
        ------------------------------------------------------------------------
        r6613 | inaam | 2010-02-09 20:23:09 +0200 (Tue, 09 Feb 2010) | 11 lines
        Changed paths:
           M /branches/5.1/buf/buf0buf.c
           M /branches/5.1/buf/buf0rea.c
           M /branches/5.1/include/buf0rea.h
      
        branches/5.1: Fix Bug #38901
        InnoDB logs error repeatedly when trying to load page into buffer pool
      
        In buf_page_get_gen() if we are unable to read a page (because of
        corruption or some other reason) we keep on retrying. This fills up
        error log with millions of entries in no time and we'd eventually run
        out of disk space. This patch limits the number of attempts that we
        make (currently set to 100) and after that we abort with a message.
      
        rb://241 Approved by: Heikki
        ------------------------------------------------------------------------
      286dc23a
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 14a3a2b4
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6631 | marko | 2010-02-10 09:19:52 +0200 (Wed, 10 Feb 2010) | 1 line
      branches/zip: Document r6614 in ChangeLog.
      14a3a2b4
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 838285eb
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6614 | inaam | 2010-02-09 20:26:23 +0200 (Tue, 09 Feb 2010) | 7 lines
      branches/plugin rb://242
      
      Let the master thread sleep if the amount of work to be done is
      calibrated as taking less than a second.
      
      Approved by: Heikki
      838285eb
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · b07ee7ab
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6612 | marko | 2010-02-09 14:32:39 +0200 (Tue, 09 Feb 2010) | 3 lines
      branches/zip: recv_recovery_rollback_active():
      Drop the temporary tables and indexes after enabling sync order checks.
      This should not make any difference. This could have been done in r6611.
      b07ee7ab
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · d0c71187
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6611 | marko | 2010-02-09 14:28:25 +0200 (Tue, 09 Feb 2010) | 11 lines
      branches/zip: Roll back dictionary transaction(s) before scanning *.ibd files
      
      innobase_start_or_create_for_mysql(): Roll back data dictionary
      transactions before scanning the *.ibd files. Then, data dictionary
      records can be loaded to the cache before opening the *.ibd files.
      
      recv_recovery_rollback_active(): Refactored from
      recv_recovery_from_checkpoint_finish().
      
      rb://235, committing without review, because this is needed for
      TablespaceDictionary.
      d0c71187
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 54ed7dc2
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6610 | marko | 2010-02-09 13:53:59 +0200 (Tue, 09 Feb 2010) | 17 lines
      branches/zip: When dropping temporary indexes and tables at startup,
      first load them to the data dictionary cache and use the normal
      routines for dropping tables or indexes.  This should reduce the
      risk of bugs and also make the code compatible with the upcoming
      TablespaceDictionary implementation.
      
      DICT_SYS_INDEXES_NAME_FIELD: The clustered index position of SYS_INDEXES.NAME.
      
      row_merge_drop_temp_indexes(): Scan SYS_INDEXES for tables containing
      temporary indexes, and load the tables as needed. Invoke
      row_merge_drop_index() to drop the indexes.
      
      row_mysql_drop_temp_tables(): Scan SYS_TABLES for temporary tables,
      load them with dict_load_table() and drop them with
      row_drop_table_for_mysql().
      
      rb://251, not yet reviewed
      54ed7dc2
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 5416c10b
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6609 | marko | 2010-02-09 13:45:40 +0200 (Tue, 09 Feb 2010) | 1 line
      branches/zip: dict_field_print_low(): Add const qualifier.
      5416c10b
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · f64b9eaa
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6608 | marko | 2010-02-09 11:02:37 +0200 (Tue, 09 Feb 2010) | 1 line
      branches/zip: ha_innobase::add_index(): Check for !innodb_table.
      f64b9eaa
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 0bc041ea
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6595 | marko | 2010-02-08 13:53:02 +0200 (Mon, 08 Feb 2010) | 1 line
      branches/zip: btr_pcur_commit(): Unused function, remove.
      0bc041ea
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 051e2e4b
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6594 | marko | 2010-02-08 12:55:04 +0200 (Mon, 08 Feb 2010) | 2 lines
      branches/zip: rec_get_nth_field_offs_old():
      Replace if (!cond) ut_error; tests with ut_a(cond).
      051e2e4b
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 1a9d1bf9
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6591 | marko | 2010-02-08 10:06:39 +0200 (Mon, 08 Feb 2010) | 3 lines
      branches/zip: row_merge_drop_index(): Remove redundant condition
      on SYS_INDEXES.TABLE_ID.  INDEX_ID must be instance-widely unique,
      because SYS_FIELDS is not indexed by TABLE_ID.
      1a9d1bf9
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 5721a38f
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6560 | sunny | 2010-02-04 16:11:23 +0200 (Thu, 04 Feb 2010) | 7 lines
      branches/zip: Remove the additional check introduced in r6534 which tries
      to check if the joining transaction has any other transactions waiting on
      its locks. This optimization results in excessive deadlocks when running
      Sysbench with a large number of threads. The function seems to return
      FALSE positives.
      
      rb://250
      5721a38f
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 30ddb931
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6559 | marko | 2010-02-04 13:21:18 +0200 (Thu, 04 Feb 2010) | 14 lines
      branches/zip: Pass the file name and line number of the caller of the
      b-tree cursor functions to the buffer pool requests, in order to make
      the latch diagnostics more accurate.
      
      buf_page_optimistic_get_func(): Renamed to buf_page_optimistic_get().
      
      btr_page_get_father_node_ptr(), btr_insert_on_non_leaf_level(),
      btr_pcur_open(), btr_pcur_open_with_no_init(), btr_pcur_open_on_user_rec(),
      btr_pcur_open_at_rnd_pos(), btr_pcur_restore_position(),
      btr_cur_open_at_index_side(), btr_cur_open_at_rnd_pos():
      Rename the function to _func and add the parameters file, line.
      Define wrapper macros with __FILE__, __LINE__.
      
      btr_cur_search_to_nth_level(): Add the parameters file, line.
      30ddb931
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#35077. · 1222f0a6
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6548 | marko | 2010-02-03 15:01:39 +0200 (Wed, 03 Feb 2010) | 11 lines
      branches/zip: buf_LRU_invalidate_tablespace(): Ensure that prev_bpage
      is not relocated when freeing a compressed block.  This avoids the
      costly rescan of the LRU list.  (Bug #35077, Issue #449)
      
      At most one buffer-fix will be active at a time, affecting two blocks:
      the buf_page_t and the compressed page frame. This should not block
      the memory defragmentation in buf0buddy.c too much.  In fact, it may
      avoid unnecessary copying if also prev_bpage belongs to the tablespace
      that is being invalidated.
      
      rb://240
      1222f0a6
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 82f3117e
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6547 | marko | 2010-02-03 14:43:38 +0200 (Wed, 03 Feb 2010) | 14 lines
      branches/zip: Clean up CHECK TABLE error handling. (Issue #220)
      
      ha_innobase::change_active_index(): Clean up code formatting.
      
      ha_innobase::check(): Incorporate the code from
      row_check_table_for_mysql().  Report errors to the client connection
      instead of writing them to the error log.
      
      row_check_table_for_mysql(): Remove.
      
      row_check_index_for_mysql(): Renamed from row_scan_and_check_index().
      Let the caller initialize prebuilt, and assume that the index is usable.
      
      rb://178 approved by Sunny Bains
      82f3117e
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 4cba299e
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6546 | jyang | 2010-02-03 11:05:24 +0200 (Wed, 03 Feb 2010) | 9 lines
      branches/zip: Relax assertion on the number of index defined
      in InnoDB must be comparable with that of MySQL to tolerate
      possible dictionary inconsistency. Fix Mantis issue #455,
      "UNIV_DEBUG+ assert ha_innodb.cc:3152 ib_num_index >= 
      mysql_num_index".
      
      rb://248 Approved by Marko.
      4cba299e
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 1e1f4beb
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6540 | marko | 2010-02-01 11:35:13 +0200 (Mon, 01 Feb 2010) | 1 line
      branches/zip: ChangeLog: Document the merge of 6471:6538 from branches/5.1.
      1e1f4beb
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 19448219
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6539 | marko | 2010-02-01 11:31:12 +0200 (Mon, 01 Feb 2010) | 75 lines
      branches/zip: Merge revisions 6471:6538 from branches/5.1:
      
        ------------------------------------------------------------------------
        r6488 | sunny | 2010-01-21 02:55:08 +0200 (Thu, 21 Jan 2010) | 2 lines
        Changed paths:
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
      
        branches/5.1: Factor out test for bug#44030 from innodb-autoinc.test
        into a separate test/result files.
        ------------------------------------------------------------------------
        r6489 | sunny | 2010-01-21 02:57:50 +0200 (Thu, 21 Jan 2010) | 2 lines
        Changed paths:
           A /branches/5.1/mysql-test/innodb-autoinc-44030.result
           A /branches/5.1/mysql-test/innodb-autoinc-44030.test
      
        branches/5.1: Factor out test for bug#44030 from innodb-autoinc.test
        into a separate test/result files.
        ------------------------------------------------------------------------
        r6492 | sunny | 2010-01-21 09:38:35 +0200 (Thu, 21 Jan 2010) | 1 line
        Changed paths:
           M /branches/5.1/mysql-test/innodb-autoinc-44030.test
      
        branches/5.1: Add reference to bug#47621 in the comment.
        ------------------------------------------------------------------------
        r6535 | sunny | 2010-01-30 00:08:40 +0200 (Sat, 30 Jan 2010) | 11 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
      
        branches/5.1: Undo the change from r6424. We need to return DB_SUCCESS even
        if we were unable to initialize the tabe autoinc value. This is required for
        the open to succeed. The only condition we currently treat as a hard error
        is if the autoinc field instance passed in by MySQL is NULL.
      
        Previously if the table autoinc value was 0 and the next value was requested
        we had an assertion that would fail. Change that assertion and treat a value
        of 0 to mean that the autoinc system is unavailable. Generation of next
        value will now return failure.
      
        rb://237
        ------------------------------------------------------------------------
        r6536 | sunny | 2010-01-30 00:13:42 +0200 (Sat, 30 Jan 2010) | 6 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
      
        branches/5.1: Check *first_value everytime against the column max
        value and  set *first_value to next autoinc if it's > col max value.
        ie.  not rely on what is passed in from MySQL.
      
        [49497] Error 1467 (ER_AUTOINC_READ_FAILED) on inserting a negative value
        rb://236
        ------------------------------------------------------------------------
        r6537 | sunny | 2010-01-30 00:35:00 +0200 (Sat, 30 Jan 2010) | 2 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
      
        branches/5.1: Undo r6536.
        ------------------------------------------------------------------------
        r6538 | sunny | 2010-01-30 00:43:06 +0200 (Sat, 30 Jan 2010) | 6 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
      
        branches/5.1: Check *first_value every time against the column max
        value and  set *first_value to next autoinc if it's > col max value.
        ie.  not rely on what is passed in from MySQL.
      
        [49497] Error 1467 (ER_AUTOINC_READ_FAILED) on inserting a negative value
        rb://236
        ------------------------------------------------------------------------
      19448219
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#49047. · 03f0003f
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6534 | sunny | 2010-01-29 23:42:49 +0200 (Fri, 29 Jan 2010) | 15 lines
      branches/zip: Two changes to fix the problem:
      
      1. First scan the joining transaction's locks and check if no other
      transaction is waiting for a lock held by the joining transaction.
      If no other transaction is waiting then  no deadlock an occur and
      we avoid doing an exhaustive search.
      
      2. Change the direction of the lock traversal from backward to forward.
      Previously we traversed backward from the lock that has to wait, the function
      to that fetched the previous node was very inefficient resulting in O(n^2)
      access to the rec lock list.
      
      Fix Bug #49047 InnoDB deadlock detection is CPU intensive with many locks on a single row.
      
      rb://218
      03f0003f
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · be24a9ea
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6533 | calvin | 2010-01-29 23:31:59 +0200 (Fri, 29 Jan 2010) | 4 lines
      branches/zip: remove duplicated copyright and license info.
      be24a9ea
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · eb6f014f
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6527 | vasil | 2010-01-29 14:39:48 +0200 (Fri, 29 Jan 2010) | 6 lines
      branches/zip:
      
      Extend the comment about row_mysql_handle_errors().
      
      Suggested by:	Heikki
      eb6f014f
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#47622. · 84d09ccc
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6526 | jyang | 2010-01-28 18:12:40 +0200 (Thu, 28 Jan 2010) | 8 lines
      branches/zip: Add index translation table to map mysql index
      number to InnoDB index structure directly. Fix Bug #47622:
      "the new index is added before the existing ones in MySQL,
      but after one in SE".
      
      rb://215, approved by Marko
      84d09ccc
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#35077. · 4c8b5358
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6525 | marko | 2010-01-28 16:23:15 +0200 (Thu, 28 Jan 2010) | 11 lines
      branches/zip: buf_LRU_invalidate_tablespace(): Do not unnecessarily
      acquire the block_mutex for every block in the LRU list. Only acquire
      it when holding buf_pool_mutex is not sufficient. This should speed up
      the function and considerably reduce traffic on the memory bus and
      caches.
      
      I noticed this deficiency when working on Issue #157.
      This deficiency popped up again in Issue #449 (Bug #35077),
      which this fix does not fully address.
      
      rb://78 revision 1 approved by Heikki Tuuri.
      4c8b5358
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#41609. · 0ce70c05
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6521 | marko | 2010-01-27 10:49:01 +0200 (Wed, 27 Jan 2010) | 17 lines
      branches/zip: Drop temporary tables at startup.
      This addresses the third aspect of Bug #41609.
      
      row_mysql_drop_temp_tables(): New function, to drop all temporary
      tables. These can be distinguished by the least significant bit of
      MIX_LEN. However, we will skip ROW_FORMAT=REDUNDANT tables, because in
      the records for those tables, that bit may be garbage.
      
      recv_recovery_from_checkpoint_finish(): Invoke
      row_mysql_drop_temp_tables().  Normally, if the .frm files for the
      temporary tables exist at startup, MySQL will ask InnoDB to drop the
      temporary tables.  However, if the files are deleted, for instance, by
      the boot scripts of the operating system, the tables would remain in
      the InnoDB data dictionary unless someone digs them up by
      innodb_table_monitor and creates .frm files for dropping the tables.
      
      rb://221 approved by Sunny Bains.
      0ce70c05
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 84c85a04
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6498 | marko | 2010-01-21 11:22:52 +0200 (Thu, 21 Jan 2010) | 15 lines
      branches/zip: buf_page_get_gen(): Obey recv_no_ibuf_operations
      and do not call ibuf_merge_or_delete_for_page() in crash recovery,
      before the redo log has been applied.
      This could cure some hard-to-repeat, hard-to-explain bugs
      related to secondary indexes.
      
      A possible recipe to repeat the bug:
      
      1. update a secondary index leaf page on a compressed table
      2. evict the page from the buffer pool while it is still dirty
      3. ibuf_insert() something for the page
      4. crash
      5. crash recovery; ibuf merge would be done too early,
      before applying redo log to the sec index page or the ibuf pages
      84c85a04
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 60e905a9
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6472 | calvin | 2010-01-16 01:53:47 +0200 (Sat, 16 Jan 2010) | 12 lines
      branches/zip: Merge revisions 6425:6471 from branches/5.1
      to pick up the first part fix of bug49396.
      
          ------------------------------------------------------------------------
          r6471 | calvin | 2010-01-15 17:43:27 -0600 (Fri, 15 Jan 2010) | 4 lines
      
          branches/5.1: fix bug#49396: main.innodb test fails in embedded mode
      
          Change replace_result by using $MYSQLD_DATADIR. Tested in both embedded
          mode and normal server mode.
          ------------------------------------------------------------------------
      
      r6473 | calvin | 2010-01-16 01:58:16 +0200 (Sat, 16 Jan 2010) | 6 lines
      branches/zip: fix bug#49396: innodb.innodb-index test fails in
      embedded mode
      
      This is 2nd part of the fix for bug#49396. The 1st part is
      innodb.test. Tested in both embedded mode and normal server mode.
      60e905a9