1. 16 Sep, 2009 1 commit
    • marko's avatar
      branches/zip: Introduce UNIV_LOG_LSN_DEBUG and MLOG_LSN for redo log · 09c2196b
      marko authored
      diagnostics.  This was written in order to better track down
      Issue #313 in InnoDB Hot Backup.
      
      MLOG_LSN: A new redo log entry type, for recording the current log
      sequence number (LSN).  This will be checked in an assertion in
      recv_parse_log_rec().
      
      rb://161, discussed with Sunny and Vasil.
      09c2196b
  2. 15 Sep, 2009 3 commits
  3. 14 Sep, 2009 3 commits
    • inaam's avatar
      branches/zip rb://159 · 75a00e01
      inaam authored
      In case of pages that are not made young the counter is incremented
      only when the page in question is 'old'. In case of pages that are
      made young the counter is incremented in case of all pages. For apple
      to apple comparison this patch changes the 'young-making' counter to
      consider only 'old' blocks.
      
      Approved by: Marko
      75a00e01
    • vasil's avatar
      branches/zip: · 164b1f86
      vasil authored
      Add missing return statement in the test program that could have
      caused a warning.
      164b1f86
    • vasil's avatar
      branches/zip: · 21051b21
      vasil authored
      Back-merge c5880 and c5881 from branches/embedded-1.0:
      
        ------------------------------------------------------------------------
        r5880 | vasil | 2009-09-12 17:28:44 +0300 (Sat, 12 Sep 2009) | 18 lines
        Changed paths:
           M /branches/embedded-1.0/configure.in
           M /branches/embedded-1.0/include/os0sync.h
           M /branches/embedded-1.0/srv/srv0start.c
        
        branches/embedded-1.0:
        
        Clean up and simplify the code that surrounds the atomic ops:
        
        * Simplify the code that prints what atomics are used:
        Instead of repeating the same conditions on which each atomics are used
        use just one printf that prints a variable defined by the code which
        chooses what atomics to use.
        
        * In os0sync.h pick up each atomic variant only if it has been selected
        by autoconf (based on IB_ATOMIC_MODE_* macros). Define the startup message
        to be printed.
        
        * In configure.in: check what user has chosen and if he has chosen
        something that is not available, emit an error. If nothing has been chosen
        explicitly by the user, auto select an option according to the described
        logic in configure.in.
        
        ------------------------------------------------------------------------
        r5881 | vasil | 2009-09-12 20:08:27 +0300 (Sat, 12 Sep 2009) | 4 lines
        Changed paths:
           M /branches/embedded-1.0/configure.in
        
        branches/embedded-1.0:
        
        Fix syntax error in test program.
        
        ------------------------------------------------------------------------
      21051b21
  4. 12 Sep, 2009 11 commits
    • vasil's avatar
      branches/zip: · 824f2231
      vasil authored
      Remove unnecessary macro.
      824f2231
    • vasil's avatar
      branches/zip: · b31926f4
      vasil authored
      Explicitly include os0sync.h to the places where HAVE_ATOMIC_BUILTINS and
      INNODB_RW_LOCKS_USE_ATOMICS are used to avoid potential problems.
      b31926f4
    • vasil's avatar
      branches/zip: · 7a191dc3
      vasil authored
      Rename HAVE_SOLARIS_ATOMICS to HAVE_IB_SOLARIS_ATOMICS and 
      IB_HAVE_PAUSE_INSTRUCTION to HAVE_IB_PAUSE_INSTRUCTION so they
      all follow the same HAVE_IB_* convention.
      7a191dc3
    • vasil's avatar
      branches/zip: · 48bbbf1f
      vasil authored
      Define HAVE_ATOMIC_BUILTINS and INNODB_RW_LOCKS_USE_ATOMICS in os0sync.h
      instead of in univ.i. The code expects os_*() macros to be present if
      HAVE_ATOMIC_BUILTINS and INNODB_RW_LOCKS_USE_ATOMICS are defined. So define
      them next to defining the os_*() macros.
      48bbbf1f
    • vasil's avatar
      branches/zip: · c548ef1b
      vasil authored
      Include ut0auxconf.h only if none of the macros it would define is defined.
      The check when to include this header was outdated from the time when there
      was only one macro involved.
      
      Move the atomics checks that are in univ.i outside of
      #if windows ... #else ... #endif
      This simplifies the code and removes some duplicates like defining
      HAVE_ATOMIC_BUILTINS if HAVE_WINDOWS_ATOMICS is defined in both branches.
      
      Do not define the same macro HAVE_ATOMIC_PTHREAD_T for different events.
      Instead define HAVE_IB_ATOMIC_PTHREAD_T_GCC and
      HAVE_IB_ATOMIC_PTHREAD_T_SOLARIS.
      c548ef1b
    • vasil's avatar
      branches/zip: · 7f153330
      vasil authored
      Move the check whether to include ut0auxconf.h before everything because
      we are now even checking for GCC atomics, we relied on MySQL to define
      this macro before.
      7f153330
    • vasil's avatar
      branches/zip: · 104e3853
      vasil authored
      Update comment to reflect reality.
      104e3853
    • vasil's avatar
      branches/zip: · 115d580f
      vasil authored
      Add the check for GCC atomics to ut0auxconf* (copied from plug.in) because
      we no longer rely on MySQL's HAVE_GCC_ATOMIC_BUILTINS.
      115d580f
    • vasil's avatar
      branches/zip: · e599d1ed
      vasil authored
      Simplify the compile time checks by splittig them into 5 independent checks:
      
      * Whether GCC atomics are available
      * Whether pthread_t can be used by GCC atomics
      * Whether Solaris libc atomics are available
      * Whether pthread_t can be used by Solaris libs atomics
      * Checking the size of pthread_t
      e599d1ed
    • vasil's avatar
      branches/zip: · 881c6ef4
      vasil authored
      Include string.h which is needed for memset().
      881c6ef4
    • vasil's avatar
      branches/zip: · 4407a642
      vasil authored
      Check that pthread_t can indeed be passed to Solaris atomic functions, instead
      of assuming that it can be passed if 0 can be assigned to it. It could be that:
      * 0 can be assigned, but pthread_t cannot be passed and
      * 0 cannot be assigned but pthread_t can be passed
      
      Better to check what we are interested in, not something else and make
      assumptions.
      4407a642
  5. 11 Sep, 2009 1 commit
    • vasil's avatar
      branches/zip: · f4303a98
      vasil authored
      Fix the indentation of the closing bracket.
      f4303a98
  6. 10 Sep, 2009 4 commits
    • marko's avatar
      branches/zip: Roll back recovered dictionary transactions before · 0425e482
      marko authored
      dropping incomplete indexes (Issue #337).
      
      trx_rollback_or_clean_recovered(ibool all): New function, split from
      trx_rollback_or_clean_all_recovered().  all==FALSE will only roll back
      dictionary transactions.
      
      recv_recovery_from_checkpoint_finish(): Call
      trx_rollback_or_clean_recovered(FALSE) before
      row_merge_drop_temp_indexes().
      
      rb://158 approved by Sunny Bains
      0425e482
    • marko's avatar
      branches/zip: Reduce mutex contention that was introduced when · 5f161630
      marko authored
      addressing Bug #45015 (Issue #316), in r5703.
      
      buf_page_set_accessed_make_young(): New auxiliary function, called by
      buf_page_get_zip(), buf_page_get_gen(),
      buf_page_optimistic_get_func(). Call ut_time_ms() outside of
      buf_pool_mutex. Use cached access_time.
      
      buf_page_set_accessed(): Add the parameter time_ms, so that
      ut_time_ms() need not be called while holding buf_pool_mutex.
      
      buf_page_optimistic_get_func(), buf_page_get_known_nowait(): Read
      buf_page_t::access_time without holding buf_pool_mutex. This should be
      OK, because the field is only used for heuristic purposes.
      
      buf_page_peek_if_too_old(): If buf_pool->freed_page_clock == 0, return
      FALSE, so that we will not waste time moving blocks in the LRU list in
      the warm-up phase or when the workload fits in the buffer pool.
      
      rb://156 approved by Sunny Bains
      5f161630
    • marko's avatar
    • marko's avatar
  7. 09 Sep, 2009 6 commits
    • calvin's avatar
      branches/zip: · 5dbaccb3
      calvin authored
      HA_ERR_TOO_MANY_CONCURRENT_TRXS is added in 5.1.38.
      But the plugin should still work with previous versions
      of MySQL.
      5dbaccb3
    • vasil's avatar
      branches/zip: · 534560bf
      vasil authored
      Fix a bug in manipulating the variable innodb_old_blocks_pct:
      
      for any value assigned it got that value -1, except for 75. When
      assigned 75, it got 75.
      
        mysql> set global innodb_old_blocks_pct=15;
        Query OK, 0 rows affected (0.00 sec)
        
        mysql> show variables like 'innodb_old_blocks_pct';
        +-----------------------+-------+
        | Variable_name         | Value |
        +-----------------------+-------+
        | innodb_old_blocks_pct | 14    | 
        +-----------------------+-------+
        1 row in set (0.00 sec)
        
        mysql> set global innodb_old_blocks_pct=75;
        Query OK, 0 rows affected (0.00 sec)
        
        mysql> show variables like 'innodb_old_blocks_pct';
        +-----------------------+-------+
        | Variable_name         | Value |
        +-----------------------+-------+
        | innodb_old_blocks_pct | 75    | 
        +-----------------------+-------+
      
      After the fix it gets exactly what was assigned.
      
      Approved by:	Marko (via IM)
      534560bf
    • marko's avatar
    • marko's avatar
      branches/zip: buf_page_peek_if_too_old(): Silence a compiler warning · 17792f8e
      marko authored
      that was introduced in r5779 on 32-bit systems.
      17792f8e
    • marko's avatar
      d9a57383
    • marko's avatar
      branches/zip: buf_page_peek_if_too_old(): Make the bitmasking work when · 54a450f6
      marko authored
      buf_pool->freed_page_clock is wider than 32 bits.
      54a450f6
  8. 08 Sep, 2009 1 commit
  9. 07 Sep, 2009 1 commit
    • calvin's avatar
      branches/zip: Build InnoDB on Windows with UNIV_HOTBACKUP · 1e3d04fa
      calvin authored
      The changes are non-functional changes for normal InnoDB,
      but needed for building the Hot Backup on Windows (with
      UNIV_HOTBACKUP defined).
      
      - Define os_aio_use_native_aio for HB.
      - Do not acquire seek mutexes for backup since HB is single threaded.
      - Do not use srv_flush_log_at_trx_commit for HB build
      
      rb://155
      
      Approved by: Marko
      1e3d04fa
  10. 03 Sep, 2009 8 commits
  11. 02 Sep, 2009 1 commit