1. 12 Mar, 2004 1 commit
    • unknown's avatar
      Force mysqlbinlog to require an argument if --local-load is used · 0f164389
      unknown authored
      (--local-load alone means "I want files to be prepared for LOAD 
      DATA INFILE, in the default temp directory", and mysqlbinlog already
      does this without --local-load).
      
      
      client/mysqlbinlog.cc:
        --local-load always needs an argument; --local-load alone is of no use.
      0f164389
  2. 11 Mar, 2004 13 commits
    • unknown's avatar
      Fix for BUG#2983 "If statement was killed on master, slave errors despite replicate-wild-ignore-t" · bd6c4ef4
      unknown authored
      We introduce a new function mysql_test_parse_for_slave().
      If the slave sees that the query got a really bad error on master
      (killed e.g.), then it calls this function to know if this query
      can be ignored because of replicate-*-table rules (do not worry
      about replicate-*-db rules: they are checked so early that they have
      no bug). If the answer is yes, it skips the query and continues. If
      it's no, then it stops and say "fix your slave data manually" (like it
      did before this change).
      
      
      mysql-test/r/rpl_error_ignored_table.result:
        result update
      mysql-test/t/rpl_error_ignored_table-slave.opt:
        ignore more tables
      mysql-test/t/rpl_error_ignored_table.test:
        we test if a killed query on the master, is ignored on the slave
        if the tables it involves should be excluded because of replicate-*-table
        rules.
      sql/log_event.cc:
        If the query got a really bad error on the master (thread killed etc),
        parse it to test the table names: if the replicate-*-do|ignore-table
        rules say "this query must be ignored" then we exit gracefully;
        otherwise we warn about the bad error and tell DBA to check/fix it.
        Before this change, we always warned and stopped.
      sql/mysql_priv.h:
        new function
      sql/slave.cc:
        don't print error immediately as we need to do one more test to
        be sure.
      sql/sql_parse.cc:
        we add a function mysql_test_parse_for_slave(), to be used only
        by the slave if it wants to know if the query should be ignored or not;
        so this function only parses the query, does not execute it.
      bd6c4ef4
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · b1e0a38f
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      sql/set_var.cc:
        Auto merged
      b1e0a38f
    • unknown's avatar
      Fix for BUG#2921 "Replication problem on mutex lock in mySQL-4.0.18": · f8080302
      unknown authored
      re-using unused LOCK_active_mi to serialize all administrative
      commands related to replication:
      START SLAVE, STOP SLAVE, RESET SLAVE, CHANGE MASTER, init_slave()
      (replication autostart at server startup), end_slave() (replication
      autostop at server shutdown), LOAD DATA FROM MASTER.
      This protects us against a handful of deadlocks (like BUG#2921
      when two START SLAVE, but when two STOP SLAVE too).
      Removing unused variables.
      
      
      sql/item_func.cc:
        We don't need LOCK_active_mi just to MASTER_POS_WAIT().
      sql/repl_failsafe.cc:
        no need for macro
      sql/set_var.cc:
        no need for macro
      sql/slave.cc:
        Re-using unused LOCK_active_mi to serialize all administrative
        commands related to replication:
        START SLAVE, STOP SLAVE, RESET SLAVE, CHANGE MASTER, init_slave()
        (replication autostart at server startup), end_slave() (replication
        autostop at server shutdown), LOAD DATA FROM MASTER.
        This protects us against a handful of deadlocks.
        Removing unused variables.
      sql/slave.h:
        Re-using LOCK_active_mi to serialize administrative replication commands.
        Macros unneeded. Removing unneeded variables.
      sql/sql_parse.cc:
        found unused variable.
        Replacing macros.
      sql/sql_show.cc:
        replacing macros
      f8080302
    • unknown's avatar
      Merge marko@build.mysql.com:/home/bk/mysql-4.0 · cb9f3048
      unknown authored
      into hundin.mysql.fi:/home/marko/l/mysql-4.0
      
      
      cb9f3048
    • unknown's avatar
      Remove remaining references to the built-in ODBC driver of InnoDB · 713ca805
      unknown authored
      
      BitKeeper/deleted/.del-ib_odbc.h~6882a6fe66f9b3e:
        Delete: innobase/include/ib_odbc.h
      BitKeeper/deleted/.del-odbc0odbc.h~6cdf5ecedbf3b3f0:
        Delete: innobase/include/odbc0odbc.h
      innobase/include/Makefile.am:
        Remove odbc0odbc.h and ib_odbc.h
      innobase/srv/srv0srv.c:
        Remove reference to odbc0odbc.h
      innobase/include/pars0pars.h:
        Remove unused functions related to ODBC and stored procedures
        Made pars_print_lexed conditional [UNIV_SQL_DEBUG]
      innobase/pars/pars0pars.c:
        Remove unused functions related to ODBC and stored procedures
        Made pars_print_lexed conditional [UNIV_SQL_DEBUG]
        Output to stderr instead of stdout
      713ca805
    • unknown's avatar
      Remove libcom.a from acinclude.m4 (should have been done in ChangeSet 1.1741) · 89cdc136
      unknown authored
      
      acinclude.m4:
        innodb_libs: Remove libcom.a
      89cdc136
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-4.0 · 233c422f
      unknown authored
      into ua72d24.elisa.omakaista.fi:/home/my/bk/mysql-4.0
      
      
      233c422f
    • unknown's avatar
      Merge marko@build.mysql.com:/home/bk/mysql-4.0 · 46e4f598
      unknown authored
      into hundin.mysql.fi:/home/marko/l/mysql-4.0
      
      
      46e4f598
    • unknown's avatar
      Small fixes. · 24f85213
      unknown authored
      
      client/mysqlbinlog.cc:
        Patched patch for Bug#2491.
      sql/set_var.cc:
        Added max_insert_delayed_threads into 'SHOW VARIABLES'.
      24f85213
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.0 · 37678666
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2874/mysql-4.0
      
      
      37678666
    • unknown's avatar
      Remove unneeded module "com" · 3fbf812f
      unknown authored
      
      BitKeeper/deleted/.del-Makefile.am~2b013aa835a140c4:
        Delete: innobase/com/Makefile.am
      BitKeeper/deleted/.del-com0com.c~473a1f0f440ce91b:
        Delete: innobase/com/com0com.c
      BitKeeper/deleted/.del-com0shm.c~6a16f0c3d81de1f:
        Delete: innobase/com/com0shm.c
      BitKeeper/deleted/.del-makefilewin~3e26f0df100887f2:
        Delete: innobase/com/makefilewin
      BitKeeper/deleted/.del-com0com.h~533a7eaa16ec585a:
        Delete: innobase/include/com0com.h
      BitKeeper/deleted/.del-com0com.ic~671e309916e285b:
        Delete: innobase/include/com0com.ic
      BitKeeper/deleted/.del-com0shm.h~5f3df7c04221b0fe:
        Delete: innobase/include/com0shm.h
      BitKeeper/deleted/.del-com0shm.ic~f827cfca1603fa6b:
        Delete: innobase/include/com0shm.ic
      innobase/configure.in:
        Remove com/Makefile
      innobase/include/Makefile.am:
        Remove com*.h
      innobase/include/usr0sess.h:
        Remove unused communication functions
      innobase/include/usr0sess.ic:
        Remove unused communication functions
      innobase/include/usr0types.h:
        Remove sess_sys_t and sess_sig_t
      innobase/usr/usr0sess.c:
        Remove unused functions
      innobase/dict/dict0crea.c:
        Remove unneeded params of que_fork_start_command()
      innobase/include/que0que.h:
        Remove unneeded params of que_fork_start_command()
      innobase/row/row0mysql.c:
        Remove unneeded params of que_fork_start_command()
      innobase/include/srv0srv.h:
        Remove references to the com module
      innobase/srv/srv0srv.c:
        Remove references to the com module
        Remove unused vars srv_n_{com,worker}_threads
        Make some global vars static
      innobase/que/que0que.c:
        Remove references to odbc
        Add #ifdef UNIV_SYNC_DEBUG around some ut_ad()
        Remove unneeded params of que_fork_start_command()
        Remove unreachable code
        Output diagnostics to stderr, not stdout
      innobase/include/trx0trx.h:
        Remove unneeded params of trx_sig_send() and trx_sig_reply()
      innobase/trx/trx0trx.c:
        Remove unneeded params of trx_sig_send() and trx_sig_reply()
        Remove params of sess_open()
      innobase/srv/srv0start.c:
        Remove reference to com0com.h
        Remove call to sess_sys_init_at_db_start()
      innobase/trx/trx0purge.c:
        Remove references to the com module
        Remove params of sess_open()
        Remove unneeded params of que_fork_start_command()
      innobase/trx/trx0roll.c:
        Remove params of sess_open()
        Remove unneeded params of que_fork_start_command()
        Remove unneeded params of trx_sig_send() and trx_sig_reply()
      3fbf812f
    • unknown's avatar
      sync0arr.c, os0file.h: · 4d47802f
      unknown authored
        Print always the count of pending pread() and pwrite() calls if there is a long semaphore wait
      
      
      innobase/include/os0file.h:
        Print always the count of pending pread() and pwrite() calls if there is a long semaphore wait
      innobase/sync/sync0arr.c:
        Print always the count of pending pread() and pwrite() calls if there is a long semaphore wait
      4d47802f
    • unknown's avatar
      data0data.c: · 06b776f9
      unknown authored
        Do not test a magic number with =, use == instead :)
      
      
      innobase/data/data0data.c:
        Do not test a magic number with =, use == instead :)
      06b776f9
  3. 10 Mar, 2004 8 commits
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.0 · 8dcefa6f
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2874/mysql-4.0
      
      
      mysql-test/install_test_db.sh:
        Auto merged
      mysql-test/mysql-test-run.sh:
        Auto merged
      8dcefa6f
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.0 · 12f5e3eb
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2874/mysql-4.0
      
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      12f5e3eb
    • unknown's avatar
      fixed BUG #2874 "Grant table bug" and · 2053f8f8
      unknown authored
      added tests for testing structure of mysql db
      
      
      client/mysqltest.c:
        extend "replace" to column names
        extend "disable_result_log" to output of --exec commad
      mysql-test/install_test_db.sh:
        corrected wrong column definitions (as a result of tests)
      mysql-test/mysql-test-run.sh:
        export MYSQL and MYSQL_FIX_SYSTEM_TABLES + 
        added option --result-file for *.opt files
      scripts/mysql_fix_privilege_tables.sh:
        added new options to using in tests + 
        added new alters (as a result of new tests)
      scripts/mysql_fix_privilege_tables.sql:
        added new alters (as a result of new tests)
      scripts/mysql_install_db.sh:
        corrected definition of tables_priv.Table_name
      2053f8f8
    • unknown's avatar
      Backporting parts of · c6d91e00
      unknown authored
      ChangeSet 1.1620.12.1 and ChangeSet 1.1625.2.1
      from 4.1. This makes the slave I/O thread flush the relay log 
      after every event, which provides additional safety in case
      of brutal crash (reduces chances to lose a part of the relay log).
      
      
      sql/repl_failsafe.cc:
        update for new prototype
      sql/slave.cc:
        The slave I/O thread now flushes the relay log after writing
        every event to it, like we already do in 4.1.
      sql/slave.h:
        new prototype
      sql/sql_repl.cc:
        update for new prototype
      c6d91e00
    • unknown's avatar
      Undoing 2 parts of changeset 1.1730.1.1 : · 843d6df5
      unknown authored
      - the one about BUG#2921
      - the one about relay log flushing
      Both will be rewritten in a next changeset
      (this one will not be pushed before the next changeset).
      
      
      sql/log.cc:
        undo
      sql/log_event.cc:
        undo
      sql/repl_failsafe.cc:
        undo
      sql/slave.cc:
        undo
      sql/slave.h:
        undo
      sql/sql_repl.cc:
        undo
      843d6df5
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · b2147e25
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      
      sql/log_event.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      b2147e25
    • unknown's avatar
      Fixed memory leak in DROP DATABASE when using RAID tables (Bug #2882) · 221397cd
      unknown authored
      
      BUILD/compile-pentium-debug-max:
        Added --with-raid
      configure.in:
        Removed -DFN_NO_CASE_SENCE for Mac OS X as this is not always true
      mysql-test/install_test_db.sh:
        Added --skip-warnings
      mysql-test/mysql-test-run.sh:
        Fixes to get --gdb and --ddd to work
      mysql-test/r/lowercase_table2.result:
        Test for lower_case_table_names=2 and temporary tables
      mysql-test/r/lowercase_table3.result:
        Fixed error message
      mysql-test/r/multi_update.result:
        Test of behaviour of multi-table-delete and alias
      mysql-test/t/lowercase_table2.test:
        Test for lower_case_table_names=2 and temporary tables
      mysql-test/t/lowercase_table3.test:
        Fixed error
      mysql-test/t/multi_update.test:
        Test of behaviour of multi-table-delete and alias (Bug #2940)
      mysys/mf_iocache.c:
        Renamed _flush_io_cache to my_b_flush_io_cache
      sql/ha_myisam.cc:
        Added comment
      sql/lock.cc:
        Extra debugging
      sql/log.cc:
        New parameter to flush_relay_log_info
      sql/log_event.cc:
        New parameter to flush_relay_log_info
      sql/mf_iocache.cc:
        Removed not used header files
      sql/mysqld.cc:
        More debugging info
        Less warnings when run with --skip-warnings
      sql/opt_range.cc:
        More debug information
      sql/repl_failsafe.cc:
        New parameter to flush_relay_log_info
      sql/slave.cc:
        First start SQL thread, then start IO thread. This fixed a raze condition in SLAVE START (Bug #2921)
        Ensure that we have a lock on the IO thread before flushing a relay log file that. The original code could core dump when a relay log rotated.
      sql/slave.h:
        New parameter to flush_relay_log_info
      sql/sql_base.cc:
        Added warning
      sql/sql_handler.cc:
        Indentation fix
      sql/sql_repl.cc:
        New parameter to flush_relay_log_info
      sql/sql_select.cc:
        Fixed problem with deleting temporary tables when using lower_case_table_names=2. (Bug #2858)
      sql/sql_table.cc:
        Fixed comment
      sql/sql_yacc.yy:
        Removed compiler warning
      include/my_sys.h:
        Fixed usage of unpack_filename
      mysys/mf_pack.c:
        Changed unpack_filename() to return length of result string.
      mysys/test_fn.c:
        Fixed usage of unpack_filename
      sql/sql_db.cc:
        Fixed memory leak with raid tables
      sql/table.cc:
        Fixed usage of unpack_filename
      221397cd
    • unknown's avatar
      buf0lru.c: · 0f4c30de
      unknown authored
        Add typecasts to ulong because ulint is __int64 in Win 64-bits
        Better error message to the .err log if we have to crash the server because the buffer pool is exhausted by the lock table or the adaptive hash index
      
      
      innobase/buf/buf0lru.c:
        Add typecasts to ulong because ulint is __int64 in Win 64-bits
      0f4c30de
  4. 09 Mar, 2004 2 commits
  5. 08 Mar, 2004 4 commits
  6. 06 Mar, 2004 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 5bc89a96
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      5bc89a96
    • unknown's avatar
      Ensure that one can't from the command line set a variable too small. (Bug #2710) · aa20bd9e
      unknown authored
      Allow one to force lower_case_table_names to 0, even if the file system is case insensitive. This fixes some issues on Mac OS X (Bug #2994)
      Added variables "lower_case_file_system", "version_compile_os" and "license"
      
      
      mysql-test/t/lowercase_table3-master.opt:
        Rename: mysql-test/t/lowercase_table2-master.opt -> mysql-test/t/lowercase_table3-master.opt
      mysys/my_getopt.c:
        Ensure that one can't from the command line set a variable too small (could happen when sub_size was set)
      sql/mysql_priv.h:
        Added lower_case_file_system
      sql/mysqld.cc:
        Allow one to force lower_case_table_names to 0, even if the file system is case insensitive
      sql/set_var.cc:
        Added variable "lower_case_file_system"
        Added variable "version_compile_os"
        Added variable "license"
      sql/set_var.h:
        Added support for read only strings
      sql/sql_select.cc:
        Make join optimizer killable
      aa20bd9e
  7. 04 Mar, 2004 10 commits
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.0 · c0422729
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-4.0
      
      
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      c0422729
    • unknown's avatar
      Added option chroot to mysqlhotcopy. · 21918cf7
      unknown authored
      Useful in case mysqld was started with chroot.
      
      
      21918cf7
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-4.0 · c890c312
      unknown authored
      into ua72d24.elisa.omakaista.fi:/home/my/bk/mysql-4.0
      
      
      c890c312
    • unknown's avatar
      Fixed Bug#2491, INSERT DELAYED causes binary log unusable by mysqlbinlog (replication is ok) · 52236ae1
      unknown authored
      Setting insert delayed threads = 0 at mysql_init_command.
      
      
      sql/mysql_priv.h:
        New session variable, max_insert_delayed_threads
      sql/mysqld.cc:
        New session variable, max_insert_delayed_threads
      sql/set_var.cc:
        New session variable, max_insert_delayed_threads
      sql/sql_class.h:
        New session variable, max_insert_delayed_threads
      sql/sql_insert.cc:
        New session variable, max_insert_delayed_threads
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      52236ae1
    • unknown's avatar
      invalidation of locking for write tables (BUG#2693) · d4f43e51
      unknown authored
      fixed linking query_prealloc_size to query cache presence
      
      
      mysql-test/r/query_cache.result:
        test of QC invalidation by LOCK command
      mysql-test/t/query_cache.test:
        test of QC invalidation by LOCK command
      sql/mysqld.cc:
        new variable query_cache_wlock_invalidate
        fixed query_prealloc_size with QC absence
      sql/set_var.cc:
        new variable query_cache_wlock_invalidate
      sql/sql_cache.cc:
        new method for table invalidation
      sql/sql_cache.h:
        new method for table invalidation
      sql/sql_class.h:
        new variable query_cache_wlock_invalidate
      sql/sql_parse.cc:
        layout fixed
      d4f43e51
    • unknown's avatar
      Rollback UPDATE/DELETE statements on kill · 0b751edc
      unknown authored
      nsure that rows in a multi-row INSERT DELAYED are inserted atomicly
      
      
      mysql-test/mysql-test-run.sh:
        Make test case safe for openserver/unixware (Bug #2700)
      sql/sql_delete.cc:
        Rollback statement on kill
      sql/sql_insert.cc:
        Ensure that rows in a multi-row INSERT DELAYED are inserted atomicly (without releasing logs).
        This is needed to ensure that the mysqlbinlog is consistent.
        Bug #2491
      sql/sql_list.h:
        Ensure that rows in a multi-row INSERT DELAYED is inserted atomicly (without releasing logs).
        This is needed to ensure that the mysqlbinlog is consistent.
        Bug #2491
      sql/sql_update.cc:
        Rollback statement on kill
      0b751edc
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · eadfe4dd
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      eadfe4dd
    • unknown's avatar
      Fix for BUG#3063 "Don't mark an auto DROP TEMP TABLE as 'killed' in the binlog"; · c1f9f3b6
      unknown authored
      even if the thread was killed, we write the DROP with error_code=0.
      This will remove unneeded stops on slave, and will lose nothing:
      if a real update was killed, this real update will be logged with the
      nonzero error code and will cause the stop on slave.
      
      
      c1f9f3b6
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · 53368efe
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      53368efe
    • unknown's avatar
      drop tables in windows-compatible order · 4924f276
      unknown authored
      4924f276