1. 23 Feb, 2007 4 commits
    • unknown's avatar
      Merge alik.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt-build · 1264c582
      unknown authored
      into  alik.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-build
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      1264c582
    • unknown's avatar
      Fix test for views with national characters, · 49b66418
      unknown authored
      which accidentally got broken during the merge
      on 16-Feb-2007.
      
      
      mysql-test/r/view.result:
        Updated result file.
      mysql-test/t/view.test:
        Fix test for views with national characters,
        which accidentally got broken during the merge
        on 16-Feb-2007.
        
        Now view.test is in UTF8 character set,
        so SET NAMES is required.
      49b66418
    • unknown's avatar
      Merge alik.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt · 2894e817
      unknown authored
      into  alik.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/t/im_daemon_life_cycle.imtest:
        Merged.
      2894e817
    • unknown's avatar
      BUG#24415: im_daemon_life_cycle.imtest fails · df1104ff
      unknown authored
      Fix timeouts. Only test suite is changed.
      
      
      mysql-test/mysql-test-run.pl:
        Decrease MySQL server shutdown delay.
        Trasactional storage engines are not used here,
        so it should be enough.
      mysql-test/t/im_daemon_life_cycle.imtest:
        Increase wait-timeout.
      df1104ff
  2. 22 Feb, 2007 4 commits
    • unknown's avatar
      Merge fix. · d65f1c92
      unknown authored
      d65f1c92
    • unknown's avatar
      Merge alik.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt · 1b0a3baa
      unknown authored
      into  alik.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-merge
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/t/disabled.def:
        Merge: enabled im_daemon_life_cycle.imtest
      mysql-test/t/view.test:
        Manual merge.
      server-tools/instance-manager/listener.cc:
        Manual merge.
      server-tools/instance-manager/manager.cc:
        Manual merge.
      server-tools/instance-manager/manager.h:
        Manual merge.
      server-tools/instance-manager/mysqlmanager.cc:
        Manual merge.
      server-tools/instance-manager/thread_registry.cc:
        Manual merge.
      server-tools/instance-manager/thread_registry.h:
        Manual merge.
      1b0a3baa
    • unknown's avatar
      Fix powermacg5 build failure. · ce00eac6
      unknown authored
      
      server-tools/instance-manager/angel.cc:
        Include my_dir.h because MacOS defines mode constants
        (S_IRUSR, S_IWUSR, ...) in sys/stat.h.
      ce00eac6
    • unknown's avatar
      efead7f3
  3. 21 Feb, 2007 1 commit
  4. 20 Feb, 2007 5 commits
    • unknown's avatar
      Fix for BUG#24415: Instance manager test im_daemon_life_cycle fails randomly. · 4bb9efa6
      unknown authored
      The cause of im_daemon_life_cycle.imtest random failures was the following
      behaviour of some implementations of LINUX threads: let's suppose that a
      process has several threads (in LINUX threads, there is a separate process for
      each thread). When the main process gets killed, the parent receives SIGCHLD
      before all threads (child processes) die. In other words, the parent receives
      SIGCHLD, when its child is not completely dead.
      
      In terms of IM, that means that IM-angel receives SIGCHLD when IM-main is not dead
      and still holds some resources. After receiving SIGCHLD, IM-angel restarts
      IM-main, but IM-main failed to initialize, because previous instance (copy) of
      IM-main still holds server socket (TCP-port).
      
      Another problem here was that IM-angel restarted IM-main only if it was killed
      by signal. If it exited with error, IM-angel thought it's intended / graceful
      shutdown and exited itself.
      
      So, when the second instance of IM-main failed to initialize, IM-angel thought
      it's intended shutdown and quit.
      
      The fix is
        1. to change IM-angel so that it restarts IM-main if it exited with error code;
        2. to change IM-main so that it returns proper exit code in case of failure.
      
      
      mysql-test/t/disabled.def:
        Enable im_daemon_life_cycle.
      server-tools/instance-manager/listener.cc:
        Set error status if Listener failed to initialize.
      server-tools/instance-manager/manager.cc:
        Return exit code from the manager.
      server-tools/instance-manager/manager.h:
        Return exit code from the manager.
      server-tools/instance-manager/mysqlmanager.cc:
        1. Restart IM-main if exit code is not EXIT_SUCCESS (0).
        2. Log IM-main exit code in case of failure.
      server-tools/instance-manager/thread_registry.cc:
        Add support for exit code.
      server-tools/instance-manager/thread_registry.h:
        Add support for exit code.
      4bb9efa6
    • unknown's avatar
      Polishing: · ad9cd3a5
      unknown authored
        1. use MySQL headers instead of system ones;
        2. move logical part of code into a separate function.
      
      
      server-tools/instance-manager/angel.cc:
        Polishing: try not to use system headers.
        Use headers from include/ directory when it is possible.
      server-tools/instance-manager/manager.cc:
        Polishing: move logical part of code into a separate function.
      server-tools/instance-manager/manager.h:
        Polishing: move logical part of code into a separate function.
      server-tools/instance-manager/mysqlmanager.cc:
        Polishing: rollback rename.
      ad9cd3a5
    • unknown's avatar
      Fix Windows build. · bae98cc8
      unknown authored
      bae98cc8
    • unknown's avatar
      Fix build failures on Windows and Mac. · 2194a89e
      unknown authored
      
      server-tools/instance-manager/WindowsService.cpp:
        Include my_global.h for DBUG_ASSERT.
      server-tools/instance-manager/mysqlmanager.cc:
        Include my_dir.h for umask().
      2194a89e
    • unknown's avatar
      Merge kpettersson@bk-internal:/home/bk/mysql-5.1-runtime · cfad743d
      unknown authored
      into  kpdesk.mysql.com:/home/thek/dev/mysql-5.1-runtime
      
      
      sql/sql_parse.cc:
        SCCS merged
      cfad743d
  5. 19 Feb, 2007 8 commits
  6. 18 Feb, 2007 1 commit
    • unknown's avatar
      Patch for IM in scope of working on BUG#24415: Instance manager test · f2f1e4d8
      unknown authored
      im_daemon_life_cycle fails randomly.
      
      1. Move IM-angel functionality into a separate file, create Angel class.
      2. Be more verbose;
      3. Fix typo in FLUSH INSTANCES implementation;
      4. Polishing.
      
      
      mysql-test/r/im_options.result:
        Updated result file.
      mysql-test/t/im_cmd_line.imtest:
        Updated test.
      server-tools/instance-manager/IMService.cpp:
        Move HandleServiceOptions() into IMService::main().
      server-tools/instance-manager/IMService.h:
        Move HandleServiceOptions() into IMService::main().
      server-tools/instance-manager/Makefile.am:
        Added angel.cc and angel.h.
      server-tools/instance-manager/WindowsService.cpp:
        Initialize class-members in constructor.
      server-tools/instance-manager/WindowsService.h:
        Initialize class-members in constructor.
      server-tools/instance-manager/commands.cc:
        Return actual error code (ER_OUT_OF_RESOURCES or ER_THERE_IS_ACTIVE_INSTANCE)
        from FLUSH INSTANCES.
      server-tools/instance-manager/manager.cc:
        1. Return actual error code from Manager::flush_instances().
        2. Be more verbose.
      server-tools/instance-manager/manager.h:
        Return actual error code from Manager::flush_instances().
      server-tools/instance-manager/mysqlmanager.cc:
        Move IM-angel functionality into separate file (angel.cc).
      server-tools/instance-manager/priv.cc:
        Use return bool datatype instead int{ 0, 1 }.
      server-tools/instance-manager/priv.h:
        Use return bool datatype instead int{ 0, 1 }.
      server-tools/instance-manager/angel.cc:
        IM-angel functionality.
      server-tools/instance-manager/angel.h:
        IM-angel functionality.
      f2f1e4d8
  7. 16 Feb, 2007 3 commits
    • unknown's avatar
      Manual merge · 4386278e
      unknown authored
      4386278e
    • unknown's avatar
      Merge weblab.(none):/home/marcsql/TREE/mysql-5.0-base · a858d8e8
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.0-rt-merge
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      a858d8e8
    • unknown's avatar
      Manual merge · 64a60185
      unknown authored
      64a60185
  8. 15 Feb, 2007 2 commits
    • unknown's avatar
      Merge weblab.(none):/home/marcsql/TREE/mysql-5.1-base · 25bf1eae
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.1-rt-merge
      
      
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/ps_1general.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql/event_data_objects.cc:
        Auto merged
      sql/event_queue.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      25bf1eae
    • unknown's avatar
      Bug#25042 OPTIMIZE TABLE cause race condition in IO CACHE SHARE · 448f6003
      unknown authored
      - The condition variable implementation "lost" a signal to
        WaitOnSingleObject when a semaphore was released.
      - The signal could be consumed by a new call to pthread_cond_wait
        before all waiting threads had awoken.
      - The new implementation of pthread_cond_* uses events
        instead of semaphores. It also uses an extra lock to protect entry
        into new cond wait before the broadcast has finished.
      
      
      include/my_pthread.h:
        - New implementatin of pthread_cond_init. This version uses events
          instead of semaphores
      mysys/my_wincond.c:
        - New implementatin of pthread_cond_init. This version uses events
          instead of semaphores
      448f6003
  9. 14 Feb, 2007 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 4f12094f
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.1-maint
      
      
      sql/mysql_priv.h:
        Auto merged
      4f12094f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 9d66be72
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
      
      
      sql/mysql_priv.h:
        Auto merged
      9d66be72
    • unknown's avatar
      Post-merge fix · 59b0e145
      unknown authored
      59b0e145
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 86267e67
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      BitKeeper/etc/gone:
        auto-union
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      mysys/my_getopt.c:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      86267e67
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · d311c188
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      BitKeeper/etc/gone:
        auto-union
      mysys/my_getopt.c:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      mysql-test/r/select.result:
        SCCS merged
      mysql-test/t/select.test:
        SCCS merged
      d311c188
  10. 13 Feb, 2007 7 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 1e9a3773
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      sql/item.cc:
        Auto merged
      1e9a3773
    • unknown's avatar
      Post-merge fix · c039eed8
      unknown authored
      c039eed8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 8ed41572
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.1-maint
      
      
      8ed41572
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 579c926d
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
      
      
      BitKeeper/etc/gone:
        auto-union
      mysys/my_getopt.c:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      mysql-test/r/select.result:
        Manual merge
      mysql-test/t/select.test:
        Manual merge
      579c926d
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug25807/my50-bug25807 · cbed7766
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/bug25807/my51-bug25807
      
      
      BitKeeper/etc/collapsed:
        auto-union
      mysys/mf_iocache.c:
        Auto merged
      cbed7766
    • unknown's avatar
      Bug#25807: LOAD DATA INFILE does not work with Pipes · 035062b2
      unknown authored
      Showstopper and regression against 5.0.24.
      
      Previously, we ignored seek() errors (see Bug#22828) and let seek()s
      against pipes fail.  Now, since we check that a seek didn't fail,
      and return without reading, this bug popped up.
      
      This restores the behavior for file-ish objects that could never be 
      seek()ed.
      
      
      mysys/mf_iocache.c:
        If we detect early that the file is not tell()able, then we should
        assume that it's also not seek()able and therefore we should never
        set the (poorly named) "seek_not_done" flag so that we don't immedi-
        ately try to seek() when reading later.
        
        The problem was that tell() was returning -1, so when we read later, 
        we needlessly tried to seek to position  (unsigned long) -1 . 
        
        Also, if we think we're supposed to seek to a position in a file and 
        the file is un-tell()able, then abort.
      035062b2
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 7a498bbf
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/t/view.test:
        Manual merge
      7a498bbf