1. 10 Oct, 2006 10 commits
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · 14ecf6d0
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21354
      
      
      14ecf6d0
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 14cf209a
      unknown authored
      into  example.com:/work/mysql-5.1-runtime
      
      
      14cf209a
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · acbc2baf
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21354
      
      
      acbc2baf
    • unknown's avatar
      Remove direct mapping of enum interval_type to mysql.event.interval_field · 92b3a32b
      unknown authored
        This decoupling allows in further versions of MySQL enum interval_type to
        be reordered without this affecting any backward compatibility in the
        events code.
        This changeset doesn't change any exposed behavior but makes events' code
        more durable to changes outside of their code base.
        
        To the reviewer: There is no regression test included as it is impossible
        to construct one with the current infrastructure which can test it. To test
        the code one has create and event, then change the order of
        enum interval_type in my_time.h, update sql/time.cc, recompile the server
        and run it with scheduler running.
      
      
      include/my_time.h:
        Add a reminder to keep enum interval_type and
        interval_type_to_name in sync
      sql/event_data_objects.cc:
        When loading from disk don't use the integer value of
        mysql.event.interval_field because it could be different of the
        values of enum interval_type, if the latter is reordered in a later
        version of MySQL. Loaded from disk is the string value which is then
        resolved against interval_type_to_name to get the exact enum value we
        need for Event_queue_element::interval.
      sql/event_db_repository.cc:
        Use interval_type_to_name from sql/time.cc during storage thus
        decoupling the value stored on disk (the enum) from the integer
        representation in memory. interval_type can be changed and as
        long as interval_type_to_name is kept in sync correct values will
        be saved to disk.
      sql/mysql_priv.h:
        add proto of find_string_in_array
      sql/strfunc.cc:
        Add a function for searching a LEX_STRING in an array of LEX_STRINGs
      92b3a32b
    • unknown's avatar
      Fix after manual merge. · 0540c6ad
      unknown authored
      0540c6ad
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug21354 · c370208a
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21354
      
      
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      c370208a
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug21354 · e32f277c
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug21354
      
      
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      sql/item_sum.h:
        Manual merge.
      e32f277c
    • unknown's avatar
      BUG#21354: (COUNT(*) = 1) not working in SELECT inside prepared · 3177e8eb
      unknown authored
                 statement.
      
      The problem was that during statement re-execution if the result was
      empty the old result could be returned for group functions.
      
      The solution is to implement proper cleanup() method in group
      functions.
      
      
      mysql-test/r/ps.result:
        Add result for bug#21354: (COUNT(*) = 1) not working in SELECT inside
        prepared statement.
      mysql-test/t/func_gconcat.test:
        Add a comment that the test case is from bug#836.
      mysql-test/t/ps.test:
        Add test case for bug#21354: (COUNT(*) = 1) not working in SELECT inside
        prepared statement.
      sql/item_sum.cc:
        Call clear() in Item_sum_count::cleanup().
      sql/item_sum.h:
        Add comments.
        Add proper cleanup() methods.
        Change Item_sum::no_rows_in_result() to call clear() instead of reset(),
        as the latter also issues add(), and there is nothing to add when there
        are no rows in result.
      3177e8eb
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug19111 · c4e977ce
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug19111
      
      
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      c4e977ce
    • unknown's avatar
      Bug#19111: TRIGGERs selecting from a VIEW on the firing base table fail. · 469ff92d
      unknown authored
      In a trigger or a function used in a statement it is possible to do
      SELECT from a table being modified by the statement.  However,
      encapsulation of such SELECT into a view and selecting from a view
      instead of direct SELECT was not possible.
      
      This happened because tables used by views (which in their turn
      were used from functions/triggers) were not excluded from checks
      in unique_table() routine as it happens for the rest of tables
      added to the statement table list for prelocking.
      
      With this fix we ignore all such tables in unique_table(), thus
      providing consistency: inside a trigger or a functions SELECT from
      a view may be used where plain SELECT is allowed.  Modification of
      the same table from function or trigger is still disallowed.  Also,
      this patch doesn't affect the case where SELECT from the table being
      modified is done outside of function of trigger, such SELECTs are
      still disallowed (this limitation and visibility problem when function
      select from a table being modified are subjects of bug 21326).  See
      also bug 22427.
      
      
      mysql-test/r/view.result:
        Add result for bug#19111: TRIGGERs selecting from a VIEW on the
        firing base table fail.
      mysql-test/t/view.test:
        Add test case for bug#19111: TRIGGERs selecting from a VIEW on the
        firing base table fail.
      sql/sql_base.cc:
        In unique_table() do not check tables that are used in a stored
        function or a trigger ('prelocking_placeholder' is set).  If such
        function or a trigger will attempt to modify a table, the error will
        be given, however select is allowed there.
      469ff92d
  2. 08 Oct, 2006 3 commits
  3. 06 Oct, 2006 12 commits
  4. 05 Oct, 2006 6 commits
    • unknown's avatar
      After merge fix. · 45c91e43
      unknown authored
      45c91e43
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG21381/mysql-5.0-engines · 09d77144
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG21381/mysql-5.1-engines
      
      
      mysql-test/r/ndb_update.result:
        Auto merged
      sql/sql_update.cc:
        Manual merge.
      09d77144
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG21381/mysql-4.1-engines · d4b77025
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG21381/mysql-5.0-engines
      
      
      mysql-test/r/ndb_update.result:
        Auto merged
      mysql-test/t/ndb_update.test:
        Auto merged
      sql/sql_update.cc:
        Manual merge.
      d4b77025
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1-engines · 9387a593
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG21381/mysql-4.1-engines
      
      
      9387a593
    • unknown's avatar
      BUG#21381 - Engine not notified about multi-table UPDATE IGNORE · 2268afed
      unknown authored
      Though this is not storage engine specific problem, I was able to
      repeat this problem with BDB and NDB engines only. That was the
      reason to add a test case into ndb_update.test. As a result
      different bad things could happen.
      
      BDB has removed duplicate rows which is not expected.
      NDB returns an error.
      
      For multi table update notify storage engine about UPDATE IGNORE
      as it is done in single table UPDATE.
      
      
      mysql-test/r/ndb_update.result:
        A test case for bug#21381.
      mysql-test/t/ndb_update.test:
        A test case for bug#21381.
      sql/sql_update.cc:
        For multi table update notify storage engine about UPDATE IGNORE
        as it is done in single table UPDATE.
      2268afed
    • unknown's avatar
      Added license information display to output of plugins schema, and tagged all... · 76cdfbbd
      unknown authored
      Added license information display to output of plugins schema, and tagged all plugins with GPL flag. 
      
      
      include/mysql/plugin.h:
        Adding license information.
      plugin/fulltext/plugin_example.c:
        License
      sql/ha_ndbcluster.cc:
        License
      sql/ha_partition.cc:
        License
      sql/handler.h:
        License
      sql/log.cc:
        License
      sql/sql_show.cc:
        Additional PLUIN display information
      storage/archive/ha_archive.cc:
        License information added
      storage/blackhole/ha_blackhole.cc:
        License information added
      storage/csv/ha_tina.cc:
        License Information
      storage/example/ha_example.cc:
        License information
      storage/federated/ha_federated.cc:
        License Information
      storage/heap/ha_heap.cc:
        License Information
      storage/innobase/handler/ha_innodb.cc:
        License Information
      storage/myisam/ha_myisam.cc:
        License Information
      storage/myisammrg/ha_myisammrg.cc:
        License Information
      76cdfbbd
  5. 03 Oct, 2006 9 commits
    • unknown's avatar
      Merge xiphis.org:/home/antony/work2/p2-bug22080.2 · 831924f1
      unknown authored
      into  xiphis.org:/home/antony/work2/p2-bug22080.3
      
      
      storage/csv/ha_tina.cc:
        Auto merged
      831924f1
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · c8b64ea1
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      sql/item_func.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      c8b64ea1
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-new-rpl · c9970c5b
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      client/mysql.cc:
        Auto merged
      include/m_ctype.h:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/strict.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/r/warnings.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      c9970c5b
    • unknown's avatar
    • unknown's avatar
      After merge fix. · 0416b69d
      unknown authored
      
      mysql-test/extra/rpl_tests/rpl_insert_id.test:
        Enhance test for bug#21726 to cover statement-based replication of
        function calls.
      sql/sql_class.cc:
        Fix typo and whitespace.
      0416b69d
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-real-bug21726-fix · af9e2eb1
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-real-bug21726
      
      
      sql/item_func.cc:
        Use local.
      sql/log.cc:
        Use local.
      sql/set_var.cc:
        Use local.
      sql/sql_class.cc:
        Use local.
      sql/sql_class.h:
        Use local.
      sql/sql_parse.cc:
        Use local.
      sql/sql_select.cc:
        Use local.
      mysql-test/r/rpl_insert_id.result:
        Use local.
      mysql-test/t/rpl_insert_id.test:
        Add result for updated test.
      af9e2eb1
    • unknown's avatar
      sql_yacc.yy: · fd5ea175
      unknown authored
        After merge fix.
      field.cc:
        After merge fix
      
      
      sql/field.cc:
        After merge fix
      sql/sql_yacc.yy:
        After merge fix.
      fd5ea175
    • unknown's avatar
      BUG#22924 - windows test fails with wrong errno · c0acb5d5
      unknown authored
      Fixed a test case according to fix for bug10974.
      
      
      mysql-test/r/windows.result:
        Fixed a test case according to fix for bug10974.
      mysql-test/t/windows.test:
        Fixed a test case according to fix for bug10974.
      c0acb5d5
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.1 · e6340946
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      BitKeeper/etc/collapsed:
        auto-union
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/lib/mtr_process.pl:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      e6340946