- 20 Mar, 2007 1 commit
-
-
unknown authored
into chilla.local:/home/mydev/mysql-5.1-bug17332 sql/handler.cc: Auto merged sql/sql_table.cc: Auto merged storage/myisam/ha_myisam.cc: Auto merged mysys/mf_keycache.c: Bug#17332 - changing key_buffer_size on a running server can crash under load Manual merge
-
- 16 Mar, 2007 1 commit
-
-
unknown authored
into blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25289 storage/myisam/ha_myisam.cc: Auto merged
-
- 15 Mar, 2007 8 commits
-
-
unknown authored
into xiphis.org:/home/antony/work2/p1-bug25671.4 sql/sql_parse.cc: Auto merged
-
unknown authored
into chilla.local:/home/mydev/mysql-5.1-bug25289 storage/myisam/ha_myisam.cc: Bug#25289 - repair table causes "my_seek.c:56: my_seek: Assertion `fd != -1' failed" Manual merge from 5.0
-
unknown authored
into chilla.local:/home/mydev/mysql-5.0-bug25289 sql/ha_myisam.cc: Bug#25289 - repair table causes "my_seek.c:56: my_seek: Assertion `fd != -1' failed" Manual merge from 4.1
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.1-bg25966 sql/mysqld.cc: Auto merged sql/sp_head.cc: Auto merged sql/sql_parse.cc: Auto merged
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.0-bg25966-2 sql/mysqld.cc: Auto merged
-
unknown authored
TABLE ... WRITE". Memory and CPU hogging occured when connection which had to wait for table lock was serviced by thread which previously serviced connection that was killed (note that connections can reuse threads if thread cache is enabled). One possible scenario which exposed this problem was when thread which provided binlog dump to replication slave was implicitly/automatically killed when the same slave reconnected and started pulling data through different thread/connection. The problem also occured when one killed particular query in connection (using KILL QUERY) and later this connection had to wait for some table lock. This problem was caused by the fact that thread-specific mysys_var::abort variable, which indicates that waiting operations on mysys layer should be aborted (this includes waiting for table locks), was set by kill operation but was never reset back. So this value was "inherited" by the following statements or even other connections (which reused the same physical thread). Such discrepancy between this variable and THD::killed flag broke logic on SQL-layer and caused CPU and memory hogging. This patch tries to fix this problem by properly resetting this member. There is no test-case associated with this patch since it is hard to test for memory/CPU hogging conditions in our test-suite. sql/mysqld.cc: We should not forget to reset THD::mysys_var::abort after kill operation if we are going to use thread to which this operation was applied for handling of other connections. sql/sp_head.cc: We should not forget to reset THD::mysys_var::abort after kill operation if we are going to use thread to which this operation was applied for handling of further statements. sql/sql_parse.cc: We should not forget to reset THD::mysys_var::abort after kill operation if we are going to use thread to which this operation was applied for handling of further statements.
-
unknown authored
TABLE ... WRITE". CPU hogging occured when connection which had to wait for table lock was serviced by thread which previously serviced connection that was killed (note that connections can reuse threads if thread cache is enabled). One possible scenario which exposed this problem was when thread which provided binlog dump to replication slave was implicitly/automatically killed when the same slave reconnected and started pulling data through different thread/connection. In 5.* versions memory hogging was added to CPU hogging. Moreover in those versions the problem also occured when one killed particular query in connection (using KILL QUERY) and later this connection had to wait for some table lock. This problem was caused by the fact that thread-specific mysys_var::abort variable, which indicates that waiting operations on mysys layer should be aborted (this includes waiting for table locks), was set by kill operation but was never reset back. So this value was "inherited" by the following statements or even other connections (which reused the same physical thread). Such discrepancy between this variable and THD::killed flag broke logic on SQL-layer and caused CPU and memory hogging. This patch tries to fix this problem by properly resetting this member. There is no test-case associated with this patch since it is hard to test for memory/CPU hogging conditions in our test-suite. sql/mysqld.cc: We should not forget to reset THD::mysys_var::abort after kill operation if we are going to use thread to which this operation was applied for handling of other connections.
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.1-bg25966
-
- 14 Mar, 2007 14 commits
-
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.1-build
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.0-build
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-4.1-build
-
unknown authored
Updated to version 0.6 of the text EXCEPTIONS-CLIENT: Updated to version 0.6 of the text
-
unknown authored
my_seek: Assertion `fd != -1' failed" In difficult optimize/repair situations the server could crash. Under some circumstances the server retries an optimize/repair with more elaborate options. But it did not check if the first attempt failed so badly that a second one must not be tried. This could happen when a new data file has been created but it was not possible to open it. In this case the repair leaves behind a table with closed data file. This must not be used for another repair attempt. We do now detect the closed data file and do not try another repair attempt in this situation. No test case. The required table corruption can not be repeated easily. There is a test program attached to bug 25433. sql/ha_myisam.cc: Bug#25289 - repair table causes "my_seek.c:56: my_seek: Assertion `fd != -1' failed" Added code to detect a closed data file. It could be closed by a preceeding repair attempt. We must not try another repair then.
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.1-build configure.in: Auto merged storage/ndb/src/ndbapi/NdbBlob.cpp: Auto merged storage/ndb/test/ndbapi/testBlobs.cpp: Auto merged
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.1-build
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.0-build configure.in: Auto merged
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.0-build
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-4.1-build
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-4.1-build configure.in: SCCS merged
-
unknown authored
Added test for sched_yield() possibly in -lposix4 on Solaris configure.in: Added test for sched_yield() possibly in -lposix4 on Solaris
-
unknown authored
into blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25460
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines storage/myisam/mi_open.c: Auto merged
-
- 13 Mar, 2007 12 commits
-
-
unknown authored
-
unknown authored
"CREATE/DROP/ALTER SERVER should require privileges" Add check for SUPER privilege when executing CREATE/DROP/ALTER SERVER. Previously, any user even with only USAGE priv can execute those commands. mysql-test/r/federated_server.result: Bug25671 - CREATE/DROP/ALTER SERVER should require privileges mysql-test/t/federated_server.test: Bug25671 - CREATE/DROP/ALTER SERVER should require privileges sql/sql_parse.cc: Bug25671 - CREATE/DROP/ALTER SERVER should require privileges Add check for SUPER privilege when executing CREATE/DROP/ALTER SERVER
-
unknown authored
into blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25460
-
unknown authored
The previous two patches for this bug worked together so that no permanent table was memory mapped. The first patch tried to avoid mapping while a table is in use. It allowed mapping only if there was exactly one lock on the table, assuming that the calling thread owned it. During mi_open(), a different call to memory mapping was coded, which did not have this limitation. The second patch tried to remove the code duplication and just called mi_extra() from mi_open() an thus inherited the limitation. But on open, a thread does not have a lock on the table... A possible solution would be to check for zero or one lock. But since I learned that it is safe to memory map a file while normal file I/O is done on it, I removed the restriction altogether and allow to memory map while a table is in use. No test case. I do not see a chance to verify with the test suite which kind of I/O is used on a table. storage/myisam/mi_extra.c: Bug#25460 - High concurrency MyISAM access causes severe mysqld crash. Allow to memory map while table is in use.
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines mysql-test/r/merge.result: Auto merged mysql-test/t/merge.test: Auto merged sql/sql_parse.cc: Auto merged storage/myisam/ha_myisam.cc: Auto merged storage/myisam/mi_create.c: Auto merged
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines myisam/mi_create.c: Auto merged mysql-test/t/merge.test: Auto merged sql/ha_myisam.cc: Auto merged sql/sql_parse.cc: Use local. mysql-test/r/merge.result: SCCS merged
-
unknown authored
differences in tables Certain merge tables were wrongly reported as having incorrect definition: - Some fields that are 1 byte long (e.g. TINYINT, CHAR(1)), might be internally casted (in certain cases) to a different type on a storage engine layer. (affects 4.1 and up) - If tables in a merge (and a MERGE table itself) had short VARCHAR column (less than 4 bytes) and at least one (but not all) tables were ALTER'ed (even to an identical table: ALTER TABLE xxx ENGINE=yyy), table definitions went ouf of sync. (affects 4.1 only) This is fixed by relaxing a check for underlying conformance and setting field type to FIELD_TYPE_STRING in case varchar is shorter than 4 when a table is created. myisam/mi_create.c: Added a comment. mysql-test/r/merge.result: A test case for bug#26881. mysql-test/t/merge.test: A test case for bug#26881. sql/ha_myisam.cc: Relaxed some checks performed by check_definition(): As comparing of fulltext keys (and key segments) is not yet implemented, only return an error in case one of keys is fulltext and other is not. Otherwise, if both keys are fulltext, accept them as is. As comparing of spatial keys (and key segments) is not yet implemented, only return an error in case one of keys is spatial and other is not. Otherwise, if both keys are spatial, accept them as is. A workaround to handle situation when field is casted from FIELD_SKIP_ZERO to FIELD_NORMAL. This could happen only in case field length is 1 and row format is fixed. sql/sql_parse.cc: When a table that has varchar field shorter than 4 is created, field type is set to FIELD_TYPE_VAR_STRING. Later, when a table is modified using alter table, field type is changed to FIELD_TYPE_STRING (see Field_string::type). That means HA_OPTION_PACK_RECORD flag might be lost and thus null_bit might be shifted by alter table, in other words alter table doesn't create 100% equal table definition. This is usually not a problem, since when a table is created/altered, definition on a storage engine layer is based on one that is passed from sql layer. But it is a problem for merge engine - null_bit is shifted when a table (merge or underlying) is altered. Set field type to FIELD_TYPE_STRING in case FIELD_TYPE_VAR_STRING is shorter than 4 when a table is created as it is done in Field::type.
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines sql/field.h: Auto merged storage/myisam/rt_index.c: Auto merged
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines storage/myisam/mi_open.c: Use local.
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines myisam/rt_index.c: Auto merged sql/field.h: Auto merged
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-4.1-engines
-
- 12 Mar, 2007 4 commits
-
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.0-build
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.1-build configure.in: Auto merged
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-5.0-build configure.in: SCCS merged
-
unknown authored
Restored accidently removed line to check for zlib configure.in: Restored accidently removed line to check for zlib
-