1. 26 Mar, 2008 2 commits
  2. 25 Mar, 2008 1 commit
    • unknown's avatar
      Bug#33275 Server crash when creating temporary table mysql.user · a3126bfc
      unknown authored
      When creating a temporary table that uses the same name as the mysql
      privs table the server would crash on FLUSH PRIVILEGES.
      
      This patches corrects the problem by setting a flag to ignore any
      temporary table when trying to reload the privileges.
      
      
      mysql-test/r/grant.result:
        Test for checking shadowing of privilege tables
      mysql-test/t/grant.test:
        Test for checking shadowing of privilege tables
      sql/sql_acl.cc:
        Set flag for ignoring temporary tables when trying to reload privileges.
      a3126bfc
  3. 18 Mar, 2008 1 commit
    • unknown's avatar
      Bug#25175 Too much memory used by MySQL grant system · 00182991
      unknown authored
      Each time the server reloads privileges containing table grants, the 
      system will allocate too much memory than needed because of badly
      chosen growth prediction in the underlying dynamic arrays.
      
      This patch introduces a new signature to the hash container initializer
      which enables a much more pessimistic approach in favour for more
      efficient memory useage.
      
      This patch was supplied by Google Inc.
      
      
      include/hash.h:
        * New signature for _hash_init.
        * Defined new function hash_init2 which takes growth_size argument.
      mysys/hash.c:
        * New signature for _hash_init.
      sql/sql_acl.cc:
        * Changed hash_init signature so that it takes a 'growth_size' smaller
        than the default. Each time a GRANT_TABLE is allocated a pre-allocated
        dynamic array is instantiated. A large growth size can result in too
        many unused hash-entries per table-entry and thus be a waste of free
        memory.
      00182991
  4. 10 Mar, 2008 1 commit
  5. 06 Mar, 2008 1 commit
    • unknown's avatar
      Bug#25132 disabled query cache: Qcache_free_blocks = 1 · c184cd63
      unknown authored
      The initial value of free memory blocks in 0. When the query cache is enabled 
      a new memory block gets allocated and is assigned number 1. The free memory
      block is later split each time query cache memory is allocated for new blocks.
      This means that the free memory block counter won't be reduced to zero when
      the number of allocated blocks are zero, but rather one. To avoid confusion
      this patch changes this behavior so that the free memory block counter is
      reset to zero when the query cache is disabled.
      Note that when the query cache is enabled and resized the free memory block
      counter was still calculated correctly.
      
      
      mysql-test/r/query_cache.result:
        test case
      mysql-test/t/query_cache.test:
        test case
      sql/sql_cache.cc:
        Restore the memory block count to 0 for consistency.
      c184cd63
  6. 05 Mar, 2008 1 commit
  7. 04 Mar, 2008 5 commits
  8. 03 Mar, 2008 1 commit
  9. 29 Feb, 2008 2 commits
  10. 28 Feb, 2008 6 commits
    • unknown's avatar
      Merge buzz.(none):/home/davi/mysql-5.0-runtime · 05480a88
      unknown authored
      into  buzz.(none):/home/davi/mysql-5.1-runtime
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/limit.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/item.cc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_user_variables.result:
        Manual merge
      mysql-test/suite/rpl/t/rpl_user_variables.test:
        Manual merge
      sql/sql_yacc.yy:
        Manual merge
      05480a88
    • unknown's avatar
      Post-merge fix for Bug 33851. The initialization order of members · 8b779456
      unknown authored
      must match the order which they were declared in the class definition. 
      
      
      sql/item.cc:
        Fix initialization order, parameter was the last one declared.
      8b779456
    • unknown's avatar
      Bug#34655 Compile error · 33a4e760
      unknown authored
      Rename client_last_error to last_error and client_last_errno to last_errno
      to not break connectors which use the internal net structure for error handling.
      
      
      include/mysql_com.h:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      include/mysql_h.ic:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysql/libmysql.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysql/manager.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysqld/lib_sql.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      libmysqld/libmysqld.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      server-tools/instance-manager/mysql_connection.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/log_event.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql-common/client.c:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/log_event_old.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/net_serv.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      sql/repl_failsafe.cc:
        Rename client_last_error to last_error, client_last_errno to last_errno.
      33a4e760
    • unknown's avatar
      Bug#33851 Passing UNSIGNED param to EXECUTE returns ERROR 1210 · 1164e2bc
      unknown authored
      The problem is that passing anything other than a integer to a limit
      clause in a prepared statement would fail. This limitation was introduced
      to avoid replication problems (e.g: replicating the statement with a
      string argument would cause a parse failure in the slave).
      
      The solution is to convert arguments to the limit clause to a integer
      value and use this converted value when persisting the query to the log.
      
      
      mysql-test/r/limit.result:
        Update test case result.
      mysql-test/r/ps.result:
        Add test case result for Bug#33851
      mysql-test/r/rpl_user_variables.result:
        Test case result for replication of prepared statement with
        limit clause.
      mysql-test/t/limit.test:
        Test parameters to limit clause.
      mysql-test/t/ps.test:
        Add test case for Bug#33851
      mysql-test/t/rpl_user_variables.test:
        Test replication of a parameter which value is converted.
      sql/item.cc:
        Convert value to integer if it's a parameter to a limit clause.
      sql/item.h:
        Flag signal that item is a parameter to a limit clause.
      sql/item_func.cc:
        Const member functions, object is not mutated.
      sql/sql_class.h:
        Const member functions, object is not mutated.
      sql/sql_yacc.yy:
        Flag that item is a parameter to a limit clause.
      1164e2bc
    • unknown's avatar
      Disable test case due to Bug#34891: sp_notembedded.test fails · 944f2599
      unknown authored
      sporadically.
      
      
      mysql-test/r/sp_notembedded.result:
        Disable test case.
      mysql-test/t/sp_notembedded.test:
        Disable test case.
      944f2599
    • unknown's avatar
      Fix for Bug#34852: SHOW OPEN TABLES output is not repeatable · ce7b8e12
      unknown authored
      (show_check.test fails sporadically).
      
      Fix test case for Bug#12183 to make it stable.
      
      
      mysql-test/r/show_check.result:
        Fix result file.
      mysql-test/t/show_check.test:
        Make test case for Bug#12183 stable.
      ce7b8e12
  11. 27 Feb, 2008 7 commits
  12. 26 Feb, 2008 12 commits
    • unknown's avatar
      Merge quad.:/mnt/raid/alik/MySQL/devel/5.0-rt · fe7035a7
      unknown authored
      into  quad.:/mnt/raid/alik/MySQL/devel/5.1-rt
      
      
      mysql-test/r/view.result:
        Auto merged
      fe7035a7
    • unknown's avatar
      Merge quad.:/mnt/raid/alik/MySQL/devel/5.1 · 336f2c7e
      unknown authored
      into  quad.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Manually merged.
      mysql-test/t/disabled.def:
        Manually merged.
      336f2c7e
    • unknown's avatar
      Merge quad.:/mnt/raid/alik/MySQL/devel/5.0 · a86e504f
      unknown authored
      into  quad.:/mnt/raid/alik/MySQL/devel/5.0-rt-merged
      
      
      mysql-test/r/view.result:
        Auto merged
      a86e504f
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/34424-5.1 · fb3f8bdb
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      fb3f8bdb
    • unknown's avatar
      Fix the remaining memory leaks (mysql_client_test). · 2aa0927d
      unknown authored
      
      tests/mysql_client_test.c:
        Fix the remaining memory leaks.
      2aa0927d
    • unknown's avatar
      Bug#34424 query_cache_debug.test leads to valgrind warnings · bf9bb656
      unknown authored
      Bug#34678 @@debug variable's incremental mode
      
      The problem is that the per-thread debugging settings stack wasn't
      being deallocated before the thread termination, leaking the stack
      memory. The chosen solution is to push a new state if the current
      is set to the initial settings and pop it (free) once the thread
      finishes.
      
      
      dbug/dbug.c:
        Move dbug parser out of _db_set_ to a separate function and
        make _db_set_ push a new stack if the corrent one is set to
        the initial settings.
      dbug/user.r:
        Update DBUG_SET description.
      mysql-test/t/disabled.def:
        Re-enable test case which triggered the leak.
      mysys/my_thr_init.c:
        Pop a pushed state, nop if stack is empty.
      sql/set_var.cc:
        Handle incremental debug settings.
      mysql-test/r/variables_debug.result:
        Add new test case result for Bug#34678
      mysql-test/t/variables_debug.test:
        Add new test case for Bug#34678
      bf9bb656
    • unknown's avatar
      Valgrind errors in mysql_client_test. · 6b9db6d2
      unknown authored
      
      tests/mysql_client_test.c:
        Fix a memory leak.
        Run the test for Bug#28386 only if logging to tables is enabled.
      6b9db6d2
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 0a1c0059
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      0a1c0059
    • unknown's avatar
      We never check the return value of mysql_frm_type for an error. Do · 226e6821
      unknown authored
      not try to push an error into the error stack as it will be ignored anyway.
      
      
      226e6821
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · fd317533
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      tests/mysql_client_test.c:
        Auto merged
      fd317533
    • unknown's avatar
      Merge dipika.(none):/opt/local/work/mysql-5.0-runtime · 1f3c1706
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      tests/mysql_client_test.c:
        Manual merge.
      1f3c1706
    • unknown's avatar
      Fix memory leaks (valgrind) · 24039016
      unknown authored
      24039016