1. 06 Apr, 2011 1 commit
  2. 05 Apr, 2011 8 commits
    • Marko Mäkelä's avatar
      2d4d5f25
    • Marko Mäkelä's avatar
      Remove unused functions. · 0edf090a
      Marko Mäkelä authored
      os_thread_get_curr(), os_thread_get_priority(), os_thread_set_priority(),
      os_thread_get_last_error(): Remove.
      0edf090a
    • Vasil Dimov's avatar
      Merge mysql-5.1-innodb -> mysql-5.5-innodb · abbdd3b6
      Vasil Dimov authored
      abbdd3b6
    • Vasil Dimov's avatar
      7930eb2b
    • Vasil Dimov's avatar
      Add the testcase for Bug#59410 to 5.1/InnoDB Plugin · b93cc426
      Vasil Dimov authored
      Bug#59410 read uncommitted: unlock row could not find a 3 mode lock
      on the record
      
      This bug is present only in 5.6 but I am adding the test case to earlier
      versions to ensure it never appears in earlier versions too.
      b93cc426
    • Vasil Dimov's avatar
      Add the testcase for Bug#59410 to 5.1/builtin · 40221754
      Vasil Dimov authored
      Bug#59410 read uncommitted: unlock row could not find a 3 mode lock
      on the record
      
      This bug is present only in 5.6 but I am adding the test case to earlier
      versions to ensure it never appears in earlier versions too.
      40221754
    • Marko Mäkelä's avatar
      Bug 12323643 - CLEAN UP THE INNODB THREAD SHUTDOWN AND ASSERTIONS (WL#5136) · 67496884
      Marko Mäkelä authored
      On shutdown, do not exit threads in os_event_wait(). This method of
      exiting was only used by the I/O handler threads. Exit them on a
      higher level.
      
      os_event_wait_low(), os_event_wait_time_low(): Do not exit on shutdown.
      
      os_thread_exit(), ut_dbg_assertion_failed(), ut_print_timestamp(): Add
      attribute cold, so that GCC knows that these functions are rarely
      invoked and can be optimized for size.
      
      os_aio_linux_collect(): Return on shutdown.
      
      os_aio_linux_handle(), os_aio_simulated_handle(), os_aio_windows_handle():
      Set *message1 = *message2 = NULL and return TRUE on shutdown.
      
      fil_aio_wait(): Return on shutdown.
      
      logs_empty_and_mark_files_at_shutdown(): Even in very fast shutdown
      (innodb_fast_shutdown=2), allow the background threads to exit, but
      skip the flushing and log checkpointing.
      
      innobase_shutdown_for_mysql(): Always wait for all the threads to exit.
      
      rb:633 approved by Sunny Bains
      67496884
    • Marko Mäkelä's avatar
      Bug 12323643 - CLEAN UP THE INNODB THREAD SHUTDOWN AND ASSERTIONS (WL#5136) · 6fe99e2d
      Marko Mäkelä authored
      Remove most references to thread id in InnoDB. Three references
      remain: the current holder of a mutex, and the current x-lock holder
      of a rw-lock, and some references in UNIV_SYNC_DEBUG checks. This
      allows MySQL to change the thread associated to a client connection.
      
      Tighten the UNIV_SYNC_DEBUG checks, trying to ensure that no InnoDB
      mutex or x-lock is being held when returning control to MySQL. The
      only semaphore that may be held is the btr_search_latch in shared mode.
      
      sync_thread_levels_empty_except_dict(): A wrapper for
      sync_thread_levels_empty_gen(TRUE).
      
      sync_thread_levels_nonempty_trx(): Check that the current thread is
      not holding any InnoDB semaphores, except btr_search_latch if
      trx->has_search_latch.
      
      sync_thread_levels_empty(): Unused function; remove.
      
      trx_t: Remove mysql_thread_id and mysql_process_no.
      
      srv_slot_t: Remove id and handle.
      
      row_search_for_mysql(), srv_conc_enter_innodb(),
      srv_conc_force_enter_innodb(), srv_conc_force_exit_innodb(),
      srv_conc_exit_innodb(), srv_suspend_mysql_thread: Assert
      !sync_thread_levels_nonempty_trx().
      
      rb:634 approved by Sunny Bains
      6fe99e2d
  3. 04 Apr, 2011 6 commits
  4. 02 Apr, 2011 1 commit
  5. 31 Mar, 2011 3 commits
    • Gleb Shchepa's avatar
      Bug #11766094 - 59132: MIN() AND MAX() REMOVE UNSIGNEDNESS · 7aa81e2a
      Gleb Shchepa authored
      In the string context the MIN() and MAX() functions don't take
      into account the unsignedness of the UNSIGNED BIGINT argument
      column.
      
      I.e.:
              CREATE TABLE t1 (a BIGINT UNSIGNED);
              INSERT INTO t1 VALUES (18446668621106209655);
              SELECT CONCAT(MAX(a)) FROM t1;
      
      returns -75452603341961.
      
      
      mysql-test/r/func_group.result:
        Test case for bug #11766094.
      mysql-test/t/func_group.test:
        Test case for bug #11766094.
      sql/item.cc:
        Bug #11766094 - 59132: MIN() AND MAX() REMOVE UNSIGNEDNESS
        
        The Item_cache_int::val_str() method has been modified to
        take into account the unsigned_flag value when converting
        data to string.
      7aa81e2a
    • Mattias Jonsson's avatar
      merge · 8e2b0dc6
      Mattias Jonsson authored
      8e2b0dc6
    • Mattias Jonsson's avatar
      92c6bc5e
  6. 30 Mar, 2011 7 commits
    • Magne Mahre's avatar
      Null merge 5.1->5.5 · d9a3c073
      Magne Mahre authored
      d9a3c073
    • Magne Mahre's avatar
      Fix-up after commit of Bug#11900714 · b8faa8f2
      Magne Mahre authored
      The patch fixes a build problem on MacOSX, where
      the compiler complains about unused parameters.
      b8faa8f2
    • Marko Mäkelä's avatar
      e2f14878
    • Marko Mäkelä's avatar
      Bug#11877216 InnoDB too eager to commit suicide on a busy server · ddec6ecd
      Marko Mäkelä authored
      sync_array_print_long_waits(): Return the longest waiting thread ID
      and the longest waited-for lock. Only if those remain unchanged
      between calls in srv_error_monitor_thread(), increment
      fatal_cnt. Otherwise, reset fatal_cnt.
      
      Background: There is a built-in watchdog in InnoDB whose purpose is to
      kill the server when some thread is stuck waiting for a mutex or
      rw-lock. Before this fix, the logic was flawed.
      
      The function sync_array_print_long_waits() returns TRUE if it finds a
      lock wait that exceeds 10 minutes (srv_fatal_semaphore_wait_threshold).
      The function srv_error_monitor_thread() will kill the server if this
      happens 10 times in a row (fatal_cnt reaches 10), checked every 30
      seconds. This is wrong, because this situation does not mean that the
      server is hung. If the server is very busy for a little over 15
      minutes, it will be killed.
      
      Consider this example. Thread T1 is waiting for mutex M. Some time
      later, threads T2..Tn start waiting for the same mutex M. If T1 keeps
      waiting for 600 seconds, fatal_cnt will be incremented to 1. So far,
      so good. Now, if M is granted to T1, the server was obviously not
      stuck. But, T2..Tn keeps waiting, and their wait time will be longer
      than 600 seconds. If 5 minutes later, some Tn has still been waiting
      for more than 10 minutes for the mutex M, the server can be killed,
      even though it is not stuck.
      
      rb:622 approved by Jimmy Yang
      ddec6ecd
    • Sergey Glukhov's avatar
      5.1 -> 5.5 merge · abbe33eb
      Sergey Glukhov authored
      abbe33eb
    • Sergey Glukhov's avatar
      Bug#11766124 59164: VALGRIND: UNINITIALIZED VALUE IN NUMBER_TO_DATETIME · a7d383cb
      Sergey Glukhov authored
      Valgrind warning happens due to missing NULL value check in
      Item::get_date. The fix is to add this check.
      
      
      mysql-test/r/func_time.result:
        test case
      mysql-test/t/func_time.test:
        test case
      sql/item.cc:
        added check for NULL value
      a7d383cb
    • Sergey Glukhov's avatar
      Bug#11766126 59166: ANOTHER DATETIME VALGRIND UNINITIALIZED WARNING · 3b7f0445
      Sergey Glukhov authored
      Valgrind warning happens because null values check happens too late
      in Item_func_month::val_str(after result string calculation).The fix
      is to check null value before result string calculation.
      
      
      mysql-test/r/func_time.result:
        test case
      mysql-test/t/func_time.test:
        test case
      sql/item_timefunc.h:
        check null value before result string calculation.
      3b7f0445
  7. 29 Mar, 2011 3 commits
    • Magne Mahre's avatar
      Bug#11933945 REMOVE LGPL LICENSED FILES IN MYSQL 5.5 · 517c5c24
      Magne Mahre authored
      The LGPL license is used in some legacy code, and to
      adhere to current licensing polity, we remove those
      files that are no longer used, and reorganize the
      remaining LGPL code so it will be GPL licensed from
      now on.
                  
      Note:  This patch only removed LGPL licensed files
             in MySQL 5.5 and later, and is the third of a 
             set of patches to remove LGPL from all trees.
             (See Bug# 11840513 for details) 
      517c5c24
    • Jon Olav Hauglid's avatar
      Null merge from mysql-5.1 to mysql-5.5 · f239fa30
      Jon Olav Hauglid authored
      f239fa30
    • Jon Olav Hauglid's avatar
      Bug# 11763784 (former 56541) · 4e26a41f
      Jon Olav Hauglid authored
      ASSERTION TABLE->DB_STAT FAILED IN
      SQL_BASE.CC::OPEN_TABLE() DURING I_S Q
      
      This assert could be triggered if a statement requiring a name
      lock on a table (e.g. DROP TRIGGER) executed concurrently
      with an I_S query which also used the table.
      
      One connection first started an I_S query that opened a given table.
      Then another connection started a statement requiring a name lock
      on the same table. This statement was blocked since the table was
      in use by the I_S query. When the I_S query resumed and tried to
      open the table again as part of get_all_tables(), it would encounter
      a table instance with an old version number representing the pending
      name lock. Since I_S queries ignore version checks and thus pending
      name locks, it would try to continue. This caused it to encounter
      the assert. The assert checked that the TABLE instance found with a
      different version, was a real, open table. However, since this TABLE
      instance instead represented a pending name lock, the check would
      fail and trigger the assert.
      
      This patch fixes the problem by removing the assert. It is ok for
      TABLE::db_stat to be 0 in this case since the TABLE instance can
      represent a pending name lock.
      
      Test case added to lock_sync.test.
      4e26a41f
  8. 28 Mar, 2011 11 commits