An error occurred fetching the project authors.
  1. 26 Nov, 2007 1 commit
    • unknown's avatar
      Bug#25146 Some warnings/errors not shown when using --show-warnings · 53cf1921
      unknown authored
       - Additional patch to fix compiler warnings
      
      
      client/mysql.cc:
        Initialize warnings to 0 to avid compiler warning
        Call 'print_warnings' also when error occured
      mysql-test/r/mysql.result:
        Change test to make is possible to see that second set of warnings
        are from second invocation of mysql
      mysql-test/t/mysql.test:
        Change test to make is possible to see that second set of warnings
        are from second invocation of mysql
      53cf1921
  2. 21 Nov, 2007 1 commit
    • unknown's avatar
      Bug #25146: Some warnings/errors not shown when using --show-warnings · 49b527ab
      unknown authored
      In several cases, an error when processing the query would cause mysql to
      return to the top level without printing warnings.  Fix is to always
      print any available warnings before returning to the top level.
      
      
      client/mysql.cc:
        In com_go(), ensure that warnings are printed even if an error
        occurred when processing the query.  Before this patch, an error
        in several places would return to the top level without printing
        associated warnings.
        
        Attempt to avoid printing the warning, though, if it's a duplicate
        of mysql_error() for the connection handle.
      mysql-test/r/mysql.result:
        Add test for bug 25146
      mysql-test/t/mysql.test:
        Add test for bug 25146
      49b527ab
  3. 04 Oct, 2007 1 commit
  4. 30 Aug, 2007 2 commits
    • unknown's avatar
      Use double quotes instead of single ones which make the test fail on Windows.... · aef135da
      unknown authored
      Use double quotes instead of single ones which make the test fail on Windows. This is for bug #30164.
      
      
      mysql-test/t/mysql.test:
        Use double quotes instead of single ones which make the test fail on Windows.
      aef135da
    • unknown's avatar
      Bug #30164: Using client side macro inside server side comments generates broken queries · bb986a24
      unknown authored
        
      Problem:
        
      In cases when a client-side macro appears inside a server-side comment, the add_line() function in mysql.cc discarded all characters until the next delimiter to remove macro arguments from the query string. This resulted in broken queries being sent to the server when the next delimiter character appeared past the comment's boundaries, because the comment closing sequence ('*/') was discarded.
        
      Fix:
        
      If a client-side macro appears inside a server-side comment, discard all characters in the comment after the macro (that is, until the end of the comment rather than the next delimiter).
      This is a minimal fix to allow only simple cases used by the mysqlbinlog utility. Limitations that are worth documenting:
        
      - Nested server-side and/or client-side comments are not supported by mysql.cc
      - Using client-side macros in multi-line server-side comments is not supported
      - All characters after a client-side macro in a server-side comment will be omitted from the query string (and thus, will not be sent to server).
      
      
      client/mysql.cc:
        If a client-side macro appears inside a server-side comment, discard all characters in the comment after the macro.
      mysql-test/r/mysql.result:
        Added a test case for bug #30164.
      mysql-test/t/mysql.test:
        Added a test case for bug #30164.
      bb986a24
  5. 07 Aug, 2007 1 commit
    • unknown's avatar
      Bug#20037 mysqltest requires cygwin on windows(part 1, new mysqltest commands) · 04e8c93c
      unknown authored
       - Update comments
       - Make "write_file" fail if file already exist
       - Remove temporary files created by test cases
      
      
      client/mysqltest.c:
        Improve function comments
        Make write_file fail if file already exist
      mysql-test/r/mysqltest.result:
        Update test result after adding new test and updating description
        of argumements to chmod
      mysql-test/t/bootstrap.test:
        Remove temporary file created by testcase
      mysql-test/t/mysql.test:
        Remove temporary file created by testcase
      mysql-test/t/mysqladmin.test:
        Remove temporary file created by testcase
      mysql-test/t/mysqltest.test:
        Remove temporary file created by testcase 
        Add test to show that "write_file" fails if file already exist
      mysql-test/t/sp-destruct.test:
        Remove temporary file created by testcase
      04e8c93c
  6. 04 Aug, 2007 1 commit
  7. 01 Jun, 2007 1 commit
    • unknown's avatar
      Fix some mysqltest warnings. · d8cd88cd
      unknown authored
      mysql-test/r/sp.result:
        Update results.
      mysql-test/t/mysql.test:
        Fix a typo.
      mysql-test/t/mysqltest.test:
        Fix a typo.
      mysql-test/t/order_by.test:
        Fix a typo.
      mysql-test/t/row.test:
        Remove an unsupported command.
      mysql-test/t/sp.test:
        Fix a typo.
      mysql-test/t/subselect3.test:
        Fix  mysqltest warnings - now it warns when sees some suspicious --
        comment
      d8cd88cd
  8. 23 Apr, 2007 1 commit
  9. 16 Apr, 2007 1 commit
    • unknown's avatar
      Fix for · be90800c
      unknown authored
      bug #27715: mysqld --character-sets-dir buffer overflow
      bug ##26851: Mysql Client --pager Buffer Overflow
      
      Using strmov() to copy an argument may cause overflow 
      if the argument's length is bigger than the buffer:
      use strmake instead.
      Also, we have to encrease the error message buffer size to fit 
      the longest message.
      
      
      client/mysql.cc:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
          - use strmake() instead of strmov() to avoid buffer overflow.
      mysql-test/r/mysql.result:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
        
          - test result.
      mysql-test/t/mysql.test:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
        
          - test case.
      mysys/charset.c:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
        
          - encrease error message buffer size to fit the (possible) longest message.
      be90800c
  10. 21 Feb, 2007 1 commit
    • unknown's avatar
      Moved the test requiring cp932 to a separate unit. · a1338e05
      unknown authored
      This is for bug #18743.
      
      
      mysql-test/t/mysql.test:
        Moved the test requiring cp932 to a separate unit
      mysql-test/r/mysql_cp932.result:
        Moved the test requiring cp932 to a separate unit
      mysql-test/t/mysql_cp932.test:
        Moved the test requiring cp932 to a separate unit
      a1338e05
  11. 20 Feb, 2007 2 commits
  12. 19 Feb, 2007 1 commit
    • unknown's avatar
      Bug#18743: Several test cases fails if "classic" configuration in 5.0 · db36a2aa
      unknown authored
      The problem happened because those tests were using "cp932" and "ucs2" without checking whether these character sets are available. This fix moves test parts to make character set specific parts be tested only if they are:
      - some parts were moved to "ctype_ucs.test" and "ctype_cp932.test"
      - some parts were moved to the newly added tests "innodb-ucs2.test", "mysqlbinglog-cp932.test" and "sp-ucs2.test"
      
      
      mysql-test/r/ctype_cp932.result:
        Moved cp932-specific test case from mysql.test
      mysql-test/r/innodb.result:
        Moved ucs2-specific test cases to innodb-ucs2.test
      mysql-test/r/mysql.result:
        Move cp932-specific test cases to ctype_cp932.test
      mysql-test/r/mysqlbinlog.result:
        Moved cp932-specific test case to mysqlbinlog-cp932.test
      mysql-test/r/sp.result:
        Moved ucs2-specific test case to sp-ucs2.test
      mysql-test/t/ctype_cp932.test:
        Moved cp932-specific test case from mysql.test
      mysql-test/t/ctype_ucs2_def-master.opt:
        Use the comma-separated list of character sets to avoid mysql-test errors when ucs2 is not available in the server
      mysql-test/t/ctype_ucs2_def.test:
        Added requirement for ucs2 in the server
      mysql-test/t/innodb.test:
        Moved ucs2-specific test cases to innodb-ucs2.test
      mysql-test/t/mysql.test:
        Move cp932-specific test cases to ctype_cp932.test
      mysql-test/t/mysqlbinlog.test:
        Moved cp932-specific test case to mysqlbinlog-cp932.test
      mysql-test/t/sp.test:
        Moved ucs2-specific test case to sp-ucs2.test
      sql/mysqld.cc:
        Allow specifying several character sets for test purposes, to make "mysqld" start even if the character set being tested is not compiled:
        mysqld --default-character-set=ucs2,latin1
        The first available character set will be chosen.
      mysql-test/r/innodb-ucs2.result:
        New BitKeeper file ``mysql-test/r/innodb-ucs2.result''
      mysql-test/r/mysqlbinlog-cp932.result:
        New BitKeeper file ``mysql-test/r/mysqlbinlog-cp932.result''
      mysql-test/r/sp-ucs2.result:
        New BitKeeper file ``mysql-test/r/sp-ucs2.result''
      mysql-test/t/innodb-ucs2.test:
        New BitKeeper file ``mysql-test/t/innodb-ucs2.test''
      mysql-test/t/mysqlbinlog-cp932.test:
        New BitKeeper file ``mysql-test/t/mysqlbinlog-cp932.test''
      mysql-test/t/sp-ucs2.test:
        New BitKeeper file ``mysql-test/t/sp-ucs2.test''
      db36a2aa
  13. 16 Feb, 2007 1 commit
  14. 17 Jan, 2007 1 commit
  15. 14 Dec, 2006 1 commit
    • unknown's avatar
      Fixed compiler warnings detected by option -Wshadow and -Wunused: · f00257dd
      unknown authored
      - Removed not used variables and functions
      - Added #ifdef around code that is not used
      - Renamed variables and functions to avoid conflicts
      - Removed some not used arguments
      
      Fixed some class/struct warnings in ndb
      Added define IS_LONGDATA() to simplify code in libmysql.c
      
      I did run gcov on the changes and added 'purecov' comments on almost all lines that was not just variable name changes
      
      
      BUILD/SETUP.sh:
        Added printing of unused functions and variables.
        Made it easy to test compiling with -Wshadow
      BUILD/compile-pentium-gcov:
        Added warnings
        Mark binary with -gcov
      client/mysql.cc:
        Fixed warnings found with gcc -Wshadow
      client/mysql_upgrade.c:
        Fixed warnings found with gcc -Wshadow
      client/mysqlbinlog.cc:
        Fixed warnings found with gcc -Wshadow
      client/mysqldump.c:
        Fixed warnings found with gcc -Wshadow
      client/mysqltest.c:
        Fixed warnings found with gcc -Wshadow
      client/sql_string.cc:
        Fixed warnings found with gcc -Wshadow
        Merged with sql/sql_string.cc
      client/sql_string.h:
        Fixed warnings found with gcc -Wshadow
        Merged with sql/sql_string.h
      cmd-line-utils/readline/display.c:
        Fixed compiler warning
      cmd-line-utils/readline/histexpand.c:
        Fixed warnings found with gcc -Wshadow
      cmd-line-utils/readline/input.c:
        Fixed warnings found with gcc -Wshadow
      cmd-line-utils/readline/text.c:
        Fixed warnings found with gcc -Wshadow
      cmd-line-utils/readline/vi_mode.c:
        Fixed warnings found with gcc -Wshadow
      dbug/dbug_analyze.c:
        Fixed warnings found with gcc -Wshadow
      extra/my_print_defaults.c:
        Prefixed defaults_extra_file and defaults_group_suffix with 'my' to avoid conflicts with similar named local variables
      extra/yassl/include/buffer.hpp:
        Fixed compiler warnings
      extra/yassl/include/crypto_wrapper.hpp:
        Fixed compiler warnings
      extra/yassl/include/yassl_imp.hpp:
        Fixed compiler warnings
      extra/yassl/include/yassl_int.hpp:
        Fixed compiler warnings
      extra/yassl/src/crypto_wrapper.cpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/benchmark/benchmark.cpp:
        Fixed warnings found with gcc -Wshadow
      extra/yassl/taocrypt/include/algebra.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/include/des.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/include/hash.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/include/hmac.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/include/modarith.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/include/modes.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/include/rsa.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/mySTL/list.hpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/src/aes.cpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/src/algebra.cpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/src/asn.cpp:
        Fixed compiler warnings
      extra/yassl/taocrypt/test/test.cpp:
        Fixed compiler warnings
      extra/yassl/testsuite/testsuite.cpp:
        Fixed compiler warnings
      include/m_ctype.h:
        Fixed warnings found with gcc -Wshadow
      include/my_pthread.h:
        Fixed warnings found with gcc -Wshadow
      include/my_sys.h:
        Fixed warnings found with gcc -Wshadow
      include/my_time.h:
        Fixed warnings found with gcc -Wshadow
      include/mysql.h:
        Fixed warnings found with gcc -Wshadow
        Added define IS_LONGDATA() to simplify code in libmysql.c
      libmysql/libmysql.c:
        Fixed warnings found with gcc -Wshadow
        (Mostly replaced bind -> my_bind and time -> my_time)
      libmysqld/lib_sql.cc:
        Removed not used variables and labels
      myisam/ft_boolean_search.c:
        Fixed warnings found with gcc -Wshadow
      myisam/mi_open.c:
        Fixed warnings found with gcc -Wshadow
      myisam/mi_search.c:
        Fixed warnings found with gcc -Wshadow
      myisam/mi_unique.c:
        Fixed compiler warning
      myisam/myisampack.c:
        Fixed warnings found with gcc -Wshadow
      myisam/rt_index.c:
        Remove not used variables
      myisam/sort.c:
        Fixed warnings found with gcc -Wshadow
      mysql-test/r/mysqlcheck.result:
        Remove databases and tables possible left by previous test
      mysql-test/r/mysqltest.result:
        New test results
      mysql-test/t/mysql.test:
        Coverage tests
      mysql-test/t/mysqlbinlog.test:
        Coverage tests
      mysql-test/t/mysqlcheck.test:
        Remove databases and tables possible left by previous test
      mysql-test/t/mysqltest.test:
        Coverage tests
      mysys/default.c:
        Prefixed defaults_file, defaults_group_suffix and defaults_extra_file with 'my' to avoid conflicts with local variables in some functions
      mysys/mf_iocache2.c:
        Fixed warnings found with gcc -Wshadow
      mysys/mf_keycache.c:
        Fixed warnings found with gcc -Wshadow
      mysys/my_bitmap.c:
        Fixed warnings found with gcc -Wshadow
      mysys/sha1.c:
        Fixed warnings found with gcc -Wshadow
      ndb/include/kernel/signaldata/ArbitSignalData.hpp:
        Fixed compiler warning
      ndb/include/kernel/signaldata/DictTabInfo.hpp:
        Fixed compiler warnings
      ndb/include/ndbapi/NdbReceiver.hpp:
        Fixed warnings found with gcc -Wshadow
      ndb/include/transporter/TransporterDefinitions.hpp:
        Fixed compiler warning
      ndb/include/util/InputStream.hpp:
        Fixed compiler warning
      ndb/include/util/OutputStream.hpp:
        Fixed compiler warning
      ndb/include/util/SimpleProperties.hpp:
        Fixed compiler warning
      ndb/include/util/SocketAuthenticator.hpp:
        Fixed compiler warning
      ndb/include/util/SocketServer.hpp:
        Fixed compiler warning
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/portlib/NdbTick.c:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/transporter/SHM_Transporter.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/transporter/TCP_Transporter.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/transporter/TCP_Transporter.hpp:
        Fixed compiler warning
      ndb/src/common/transporter/Transporter.cpp:
        Removed not used variable
      ndb/src/common/transporter/TransporterRegistry.cpp:
        Removed not used variable
      ndb/src/common/util/Bitmask.cpp:
        Moved function to avoid warnings of not used function
      ndb/src/common/util/ConfigValues.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/util/File.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/util/Properties.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/util/SocketClient.cpp:
        Fixed wrong return value
      ndb/src/common/util/random.c:
        Fixed warnings found with gcc -Wshadow
      ndb/src/common/util/socket_io.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/cw/cpcd/APIService.cpp:
        Removed not used variable
      ndb/src/cw/cpcd/main.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/dblqh/Dblqh.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/dbtup/DbtupScan.cpp:
        Removed not used variable
      ndb/src/kernel/blocks/dbtux/DbtuxNode.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/dbtux/DbtuxScan.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/dbtux/DbtuxTree.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/ndbcntr/Ndbcntr.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/ndbfs/AsyncFile.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/qmgr/Qmgr.hpp:
        Fixed compiler warnings
      ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/suma/Suma.cpp:
        Removed not used variables
      ndb/src/kernel/blocks/suma/Suma.hpp:
        Fixed compiler warnings
      ndb/src/kernel/vm/MetaData.hpp:
        Fixed compiler warnings
      ndb/src/mgmapi/LocalConfig.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/mgmapi/mgmapi.cpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Removed not used variables
      ndb/src/mgmsrv/ConfigInfo.cpp:
        Fixed warnings found with gcc -Wshadow
        Removed not used variables
      ndb/src/mgmsrv/ConfigInfo.hpp:
        Fixed warnings found with gcc -Wshadow
      ndb/src/mgmsrv/InitConfigFileParser.cpp:
        Prefixed defaults_file, defaults_group_suffix and defaults_extra_file with 'my' to avoid conflicts with local variables in some functions
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Removed not used variables and functions
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Fixed compiler warnings
      ndb/src/mgmsrv/Services.cpp:
        Removed not used variables and functions
      ndb/src/mgmsrv/main.cpp:
        Removed not used variable
      ndb/src/ndbapi/ClusterMgr.hpp:
        Fixed compiler warnings
      ndb/src/ndbapi/Ndb.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbBlob.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbIndexOperation.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbOperationDefine.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbOperationExec.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbOperationSearch.cpp:
        Removed not used variables
      ndb/src/ndbapi/NdbScanFilter.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/NdbScanOperation.cpp:
        Removed not used variables
      ndb/src/ndbapi/SignalSender.cpp:
        Removed not used variables
      ndb/src/ndbapi/ndb_cluster_connection.cpp:
        Removed not used variable
      ndb/tools/delete_all.cpp:
        Removed not used variable
      ndb/tools/desc.cpp:
        Removed not used variable
      ndb/tools/drop_index.cpp:
        Removed not used variable
      ndb/tools/drop_tab.cpp:
        Removed not used variable
      ndb/tools/listTables.cpp:
        Removed not used variable
      ndb/tools/ndb_config.cpp:
        Fixed warnings found with gcc -Wshadow
        Added missing puts(desc)
      ndb/tools/restore/Restore.hpp:
        Changed delimiter to define instead of static variable, as the static variable caused a LOT of compiler warnings
        Fixed compiler warning
      ndb/tools/restore/consumer.hpp:
        Fixed compiler warning
      ndb/tools/restore/restore_main.cpp:
        Fixed compiler warnings
      ndb/tools/select_all.cpp:
        Removed not used variables
      ndb/tools/select_count.cpp:
        Removed not used variable
      server-tools/instance-manager/commands.h:
        Fixed compiler warnings
      server-tools/instance-manager/guardian.cc:
        Fixed compiler warnings
      server-tools/instance-manager/instance_options.cc:
        Removed not used variables
      server-tools/instance-manager/mysql_connection.cc:
        Fixed compiler warnings
      server-tools/instance-manager/options.cc:
        Fixed compiler warnings
      server-tools/instance-manager/options.h:
        Fixed compiler warnings
      server-tools/instance-manager/parse.cc:
        Removed not used variable
      server-tools/instance-manager/user_map.cc:
        Fixed compiler warnings
      server-tools/instance-manager/user_map.h:
        Fixed compiler warnings
      sql/field.cc:
        Fixed compiler warnings
      sql/field.h:
        Fixed compiler warnings
      sql/filesort.cc:
        Fixed compiler warnings
      sql/ha_archive.cc:
        Removed table and share arguments from get_share() / free_share() to get rid of compiler warnings
      sql/ha_archive.h:
        Removed table and share arguments from get_share() / free_share() to get rid of compiler warnings
      sql/ha_federated.cc:
        Fixed compiler warnings
      sql/ha_heap.cc:
        Fixed compiler warnings
      sql/ha_myisam.cc:
        Fixed compiler warnings
      sql/ha_myisammrg.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/handler.cc:
        Fixed compiler warnings
      sql/item.cc:
        Fixed compiler warnings
      sql/item.h:
        Fixed compiler warnings
        new_item() -> clone_item(), to avoid a lot of warnings with variable 'new_item'
        el() -> element_index()
      sql/item_cmpfunc.cc:
        Fixed compiler warnings
      sql/item_cmpfunc.h:
        Fixed compiler warnings
      sql/item_func.cc:
        Fixed compiler warnings
      sql/item_geofunc.cc:
        Fixed compiler warnings
      sql/item_row.h:
        Fixed compiler warnings
      sql/item_strfunc.cc:
        Fixed compiler warnings
      sql/item_subselect.cc:
        Fixed compiler warnings
      sql/item_subselect.h:
        Fixed compiler warnings
      sql/item_sum.cc:
        Fixed compiler warnings
      sql/item_timefunc.cc:
        Fixed compiler warnings
      sql/log.cc:
        Fixed compiler warnings
        More comments
        Added #ifdef HAVE_REPLICATION
      sql/log_event.cc:
        Fixed compiler warnings
      sql/log_event.h:
        Fixed compiler warnings
      sql/mysql_priv.h:
        query_id -> global_query_id, to avoid a lot of clashes with function and class variables
        start_time -> server_start_time
      sql/mysqld.cc:
        Fixed compiler warnings:
        - Removed not used variables
        - Added #ifndef EMBEDDED_LIBRARY
        - Fixed shadow warnings
      sql/net_serv.cc:
        Fixed compiler warnings
      sql/opt_range.cc:
        range -> last_range to avoid shadow warnings
        Removed not used function print_rowid()
      sql/opt_range.h:
        range -> last_range to avoid shadow warnings
      sql/password.c:
        Fixed compiler warnings
      sql/protocol.cc:
        Fixed compiler warnings
      sql/repl_failsafe.cc:
        Fixed compiler warnings
      sql/set_var.cc:
        Fixed compiler warnings
      sql/set_var.h:
        type() -> show_type()
        Fixed compiler warnings
      sql/slave.cc:
        Fixed compiler warnings
      sql/sp_head.cc:
        Fixed compiler warnings
      sql/sp_head.h:
        Fixed compiler warnings
      sql/spatial.cc:
        Fixed compiler warnings
      sql/spatial.h:
        length() -> geom_length() to avoid compiler warnings
        wkb_end -> wkb_last to avoid compiler warnings with local variables named 'wkb_end'
      sql/sql_cache.h:
        Fixed compiler warnings
      sql/sql_class.cc:
        Fixed compiler warnings
      sql/sql_class.h:
        log -> log_xid() to avoid compiler warnings
        Fixed shadow compiler warnings
      sql/sql_derived.cc:
        Removed not used variable
      sql/sql_insert.cc:
        Fixed compiler warnings
      sql/sql_lex.cc:
        Fixed compiler warnings
      sql/sql_lex.h:
        res -> saved_error to make the meaning of the variable clear and avoid shadow warnings
      sql/sql_load.cc:
        Fixed compiler warnings
      sql/sql_parse.cc:
        Fixed compiler warnings
      sql/sql_prepare.cc:
        Fixed compiler warnings
      sql/sql_select.cc:
        Fixed compiler warnings
      sql/sql_show.cc:
        Fixed compiler warnings
      sql/sql_string.cc:
        Fixed compiler warnings
      sql/sql_string.h:
        Fixed compiler warnings
      sql/sql_table.cc:
        Fixed compiler warnings
      sql/sql_trigger.cc:
        Fixed compiler warnings
      sql/sql_trigger.h:
        table -> trigger_table to avoid warnings from local variables
      sql/sql_union.cc:
        Fixed compiler warnings
        (mainly res -> saved_error)
      sql-common/client.c:
        Removed not used variable
      sql-common/my_time.c:
        Removed not used variable
        time -> my_time
      sql/sql_update.cc:
        Removed not used variable
      sql/sql_view.cc:
        Removed not used variable
      sql/sql_yacc.yy:
        Removed not used variable
      sql/table.cc:
        Removed not used variable
      sql/tztime.cc:
        Removed not used variable
      sql/unireg.cc:
        Removed not used variable
      strings/ctype-bin.c:
        mblen -> mb_len to avoid compiler warnings with local variable mblen
      strings/ctype-cp932.c:
        Fixed compiler warnings
      strings/ctype-eucjpms.c:
        Fixed compiler warnings
      strings/ctype-mb.c:
        mblen -> mb_len to avoid compiler warnings with local variable mblen
      strings/ctype-simple.c:
        mblen -> mb_len to avoid compiler warnings with local variable mblen
        exp -> exponent
      strings/ctype-sjis.c:
        Fixed compiler warnings
      strings/ctype-uca.c:
        mblen -> mb_len to avoid compiler warnings with local variable mblen
      strings/ctype-ujis.c:
        Fixed compiler warnings
      strings/ctype-utf8.c:
        Fixed compiler warnings
      strings/decimal.c:
        Fixed compiler warnings
      strings/my_vsnprintf.c:
        Added comment
      strings/strtod.c:
        Fixed compiler warnings
      tests/mysql_client_test.c:
        Fixed compiler warnings
        (Biggest part of patch is to not get a conflict with global function 'bind')
      f00257dd
  16. 29 Nov, 2006 1 commit
    • unknown's avatar
      Fix merges. · 724e06e7
      unknown authored
      mysql-test/r/func_misc.result:
        case change in SHOW CREATE keywords.
      mysql-test/r/mysql.result:
        Revert clobber of charset special chars.
      mysql-test/t/mysql.test:
        Revert clobber of charset special chars.
      724e06e7
  17. 28 Nov, 2006 1 commit
  18. 13 Nov, 2006 1 commit
  19. 03 Nov, 2006 2 commits
  20. 26 Oct, 2006 1 commit
    • unknown's avatar
      Bug#20894 Reproducible MySQL client segmentation fault · 08d43705
      unknown authored
       - Add two null bytes in  "buff" variable allowing us to call
         get_arg two times also for strings longer than sizeof(buff) 
      
      
      client/mysql.cc:
        Make sure there are _two_ zero bytes at the end of buff, to allow 'get_arg' to be
        called twice on long strings. The first time it will mark end of string with a
        zero and the second time it will "skip ahead" to the first zero, and the find the
        second one indicating end of buff.
      mysql-test/r/mysql.result:
        Update test results
      mysql-test/t/mysql.test:
        Add tests for "com_connect" function in mysql
        Add test reported in bug
      08d43705
  21. 09 Oct, 2006 1 commit
  22. 02 Oct, 2006 1 commit
    • unknown's avatar
      Fix for Bug #21412 (client allows DELIMITER with backslash character) · 89220d07
      unknown authored
      BitKeeper/etc/ignore:
        Added mysql-test/t/tmp.test mysql-test/r/tmp.result client/tmp.diff to the ignore list
      client/mysql.cc:
        Fix for Bug #21412 (client allows DELIMITER with backslash)
      mysql-test/r/mysql.result:
        Added test case for Bug #21412
      mysql-test/t/mysql.test:
        Added test case for Bug #21412
      89220d07
  23. 13 Sep, 2006 1 commit
    • unknown's avatar
      Bug #21618: NULL shown as empty string in client · 306827a5
      unknown authored
      The column's NOT NULL flag doesn't affect what we should print.  Remove the
      wrong logic that does check it.
      
      Also, verify that this and the previous two tests print the same data as 
      other output formats.
      
      
      client/mysql.cc:
        Don't check the column's NOT NULL flag when determining whether to print 
        "NULL" or not.
      mysql-test/r/mysql.result:
        Add results and confirm that the other output forms give the same results
        for other similar tests.
      mysql-test/t/mysql.test:
        Add regression tests for this bug and two similar bugs.
      306827a5
  24. 06 Sep, 2006 1 commit
  25. 24 Aug, 2006 1 commit
    • unknown's avatar
      Bug #11972: client uses wrong character set after reconnect. · 689fae64
      unknown authored
      The mysql client uses the default character set on reconnect.  The default character set is now controled by the client charset command while the client is running.  The charset command now also issues a SET NAMES command to the server to make sure that the client's charset settings are in sync with the server's.
      
      
      client/mysql.cc:
        Client charset command now changes the default character set and issues a SET NAMES command to the server.
      mysql-test/r/mysql.result:
        Corrected results for new behaviour.
      mysql-test/t/mysql.test:
        Removed redundant commands from test.
      689fae64
  26. 16 Aug, 2006 1 commit
    • unknown's avatar
      Bug#20328 mysql client: dumb about trailing spaces on 'help' command · a707d490
      unknown authored
       Fix testcase to also work on windows
      
      
      BitKeeper/deleted/.del-mysql_client.test:
        Delete: mysql-test/t/mysql_client.test
      BitKeeper/deleted/.del-mysql_client.result:
        Delete: mysql-test/r/mysql_client.result
      mysql-test/r/mysql.result:
        Update test result
      mysql-test/t/mysql.test:
        Move tests from mysql_client to mysql
        Fix test case for bug#20328 to work on windows by comparing the output from "help" and "help "
      a707d490
  27. 02 Aug, 2006 1 commit
  28. 31 Jul, 2006 1 commit
    • unknown's avatar
      Bug#21042 mysql client segfaults on importing a mysqldump export · 71c896c2
      unknown authored
       - Use strmake, that will both protect the buffer and make sure it's terminated by a zero
       - Add test case
      
      
      client/mysql.cc:
        Use strmake instead of strxnmov as that function will make sure the string is terminated by 0
      mysql-test/r/mysql.result:
        Update test result
      mysql-test/t/mysql.test:
        Add test case
      71c896c2
  29. 24 Jul, 2006 1 commit
  30. 17 Jul, 2006 1 commit
    • unknown's avatar
      mysql.test, mysql.result: · 9a5daa60
      unknown authored
        Corrected the test case after fixing bug#10977
      
      
      mysql-test/t/mysql.test:
        Corrected the test case after fixing bug#10977
      mysql-test/r/mysql.result:
        Corrected the test case after fixing bug#10977
      9a5daa60
  31. 10 May, 2006 1 commit
    • unknown's avatar
      Bug#19564: mysql displays NULL instead of space · 2e72ae3d
      unknown authored
      Correct a bug (that I introduced, after using Oracle's database software for 
      too many years) where the length of the database-sent data is incorrectly 
      used to infer NULLness.
      
      
      client/mysql.cc:
        No longer use the length of the data to infer whether it is NULL or not.
      mysql-test/r/mysql.result:
        Add result and version marker, and correct previous result.
      mysql-test/t/mysql.test:
        Add test and version marker
      2e72ae3d
  32. 16 Apr, 2006 1 commit
    • unknown's avatar
      Only expand the empty string to the letters "NULL" if the column · 1e2bde0d
      unknown authored
      does not have "NOT NULL" attribute set.  Also, calculate the padding
      characters more safely, so that a negative number doesn't cause it to 
      print MAXINT-n spaces.
      
      
      mysql-test/r/mysql.result:
        Add test result.
      mysql-test/t/mysql.test:
        Add test.
      1e2bde0d
  33. 04 Apr, 2006 1 commit
    • unknown's avatar
      Bug#18265: mysql client: No longer right-justifies numeric columns · 0fae7e3b
      unknown authored
      Also fixes a new bug for which "NULL" wasn't printed (because the 
      data it represents has length zero).  (Discovered my Paul DuBois.)
      
      
      client/mysql.cc:
        Cleaned up the interactive-session table-printing function.
        
        - No longer rely on the length of the data to pad column boundries.
        - Be smarter about how we detect if the column is NULL.
        - Document how multibyte characters affect the output printing.
        - Use more descriptive variable names.
        
        More importantly, (re-)add these features that were crippled in an
        earlier change:
        - Print "NULL".
        - Right-justify numbers.
      mysql-test/r/mysql.result:
        Updated old result and added new case.
      mysql-test/t/mysql.test:
        Added new test case.
      0fae7e3b
  34. 03 Mar, 2006 1 commit
    • unknown's avatar
      Bug#16859 involves truncating column data at NUL characters. Instead, the · 21d6e172
      unknown authored
      client will now substitute spaces for NULs, so that the grid isn't messed up
      due to silently consumed NULs and that the full field is shown.
      
      
      client/mysql.cc:
        For non-numbers, print each character at a time, instead of using the 
        fprintf() facility, which interprets an array of chars as a C string, which 
        is necessarily NUL terminated.  We mustn't terminate on NULs, and since we 
        know the length of the data, we needn't.
      mysql-test/r/mysql.result:
        Add a test.
      mysql-test/t/mysql.test:
        Add a test.
      21d6e172
  35. 24 Feb, 2006 1 commit
    • unknown's avatar
      Fixes to embedded server to be able to run tests with it · 0afb6ff6
      unknown authored
      (Needed for "list of pushes" web page and autopush)
      
      
      include/mysql.h:
        Fix to embedded server to be able to run tests on it
      libmysql/libmysql.c:
        Fix to embedded server to be able to run tests on it
      libmysqld/emb_qcache.cc:
        Fix to embedded server to be able to run tests on it
      libmysqld/embedded_priv.h:
        Fix to embedded server to be able to run tests on it
      libmysqld/lib_sql.cc:
        Fix to embedded server to be able to run tests on it
      libmysqld/libmysqld.c:
        Fix to embedded server to be able to run tests on it
      mysql-test/mysql-test-run.sh:
        Fix to embedded server to be able to run tests on it
      mysql-test/r/binlog.result:
        Updated test for embedded server
      mysql-test/r/ctype_cp932.result:
        Updated test for embedded server
      mysql-test/r/innodb.result:
        Updated test for embedded server
      mysql-test/r/mysqltest.result:
        Updated test for embedded server
      mysql-test/r/query_cache.result:
        Updated test for embedded server
      mysql-test/r/query_cache_notembedded.result:
        Updated test for embedded server
      mysql-test/r/sp-error.result:
        Updated test for embedded server
      mysql-test/r/sp.result:
        Updated test for embedded server
      mysql-test/r/subselect.result:
        Updated test for embedded server
      mysql-test/r/view.result:
        Updated test for embedded server
      mysql-test/r/view_grant.result:
        Updated test for embedded server
      mysql-test/t/backup.test:
        Updated test for embedded server
      mysql-test/t/binlog.test:
        Updated test for embedded server
      mysql-test/t/blackhole.test:
        Updated test for embedded server
      mysql-test/t/compress.test:
        Updated test for embedded server
      mysql-test/t/ctype_cp932.test:
        Updated test for embedded server
      mysql-test/t/delayed.test:
        Updated test for embedded server
      mysql-test/t/handler.test:
        Updated test for embedded server
      mysql-test/t/innodb.test:
        Updated test for embedded server
      mysql-test/t/mysql.test:
        Updated test for embedded server
      mysql-test/t/mysql_client_test.test:
        Updated test for embedded server
      mysql-test/t/mysqltest.test:
        Updated test for embedded server
      mysql-test/t/query_cache.test:
        Updated test for embedded server
      mysql-test/t/query_cache_notembedded.test:
        Updated test for embedded server
      mysql-test/t/read_only.test:
        Updated test for embedded server
      mysql-test/t/skip_grants.test:
        Updated test for embedded server
      mysql-test/t/sp-destruct.test:
        Updated test for embedded server
      mysql-test/t/sp-error.test:
        Updated test for embedded server
      mysql-test/t/sp-threads.test:
        Updated test for embedded server
      mysql-test/t/sp.test:
        Updated test for embedded server
      mysql-test/t/subselect.test:
        Updated test for embedded server
      mysql-test/t/temp_table.test:
        Updated test for embedded server
      mysql-test/t/view.test:
        Updated test for embedded server
      mysql-test/t/view_grant.test:
        Updated test for embedded server
      mysql-test/t/wait_timeout.test:
        Updated test for embedded server
      mysys/mf_dirname.c:
        Review fix: Don't access data outside of array
      mysys/my_bitmap.c:
        Remove compiler warnings
      scripts/mysql_fix_privilege_tables.sql:
        Add flush privileges to .sql script so that one doesn't have to reboot mysqld when one runs the mysql_fix_privilege_script
      sql-common/client.c:
        Updated test for embedded server
      sql/item.cc:
        Remove DBUG_PRINT statement that can cause crashes when running with --debug
      sql/mysqld.cc:
        Fix to embedded server to be able to run tests on it
      sql/protocol.cc:
        Fix to embedded server to be able to run tests on it
        (Trivial reconstruction of code)
      sql/protocol.h:
        Fix to embedded server to be able to run tests on it
      sql/sql_base.cc:
        Better comment
      sql/sql_class.cc:
        Fix to embedded server to be able to run tests on it
      sql/sql_class.h:
        Fix to embedded server to be able to run tests on it
      sql/sql_cursor.cc:
        Fix to embedded server to be able to run tests on it
      sql/sql_parse.cc:
        Fix to embedded server to be able to run tests on it
        Don't crash for disabled commands when using embedded server
      sql/sql_prepare.cc:
        Fix to embedded server to be able to run tests on it
      mysql-test/r/ctype_cp932_notembedded.result:
        New BitKeeper file ``mysql-test/r/ctype_cp932_notembedded.result''
      mysql-test/r/innodb_notembedded.result:
        New BitKeeper file ``mysql-test/r/innodb_notembedded.result''
      mysql-test/r/sp.result.orig:
        New BitKeeper file ``mysql-test/r/sp.result.orig''
      mysql-test/r/sp_notembedded.result:
        New BitKeeper file ``mysql-test/r/sp_notembedded.result''
      mysql-test/r/subselect_notembedded.result:
        New BitKeeper file ``mysql-test/r/subselect_notembedded.result''
      mysql-test/t/ctype_cp932_notembedded.test:
        New BitKeeper file ``mysql-test/t/ctype_cp932_notembedded.test''
      mysql-test/t/innodb_notembedded.test:
        New BitKeeper file ``mysql-test/t/innodb_notembedded.test''
      mysql-test/t/sp.test.orig:
        New BitKeeper file ``mysql-test/t/sp.test.orig''
      mysql-test/t/sp_notembedded.test:
        New BitKeeper file ``mysql-test/t/sp_notembedded.test''
      mysql-test/t/subselect_notembedded.test:
        New BitKeeper file ``mysql-test/t/subselect_notembedded.test''
      0afb6ff6
  36. 09 Feb, 2006 1 commit
    • unknown's avatar
      BUG#16217 forced to introduce a separate mysql client command to adopt its · e025e47a
      unknown authored
      internal charset to one associated with currently being handled query. 
      To note such a query can come from interactive client either.
      
      There was a discussion within replication team and Monty who's suggestion won.
      It avoids straightforward parsing of all `set' queries that could affect client side 
      character set. 
      According to the idea, mysql client does not parse `set' queries but rather cares of
      `charset new_cs_name' command.
      This command is generated by mysqlbinlog in form of exclaiming comment (Lars' suggestion)
      so that enlightened clients like `mysql' knows what to do with it.
      
      Interactive human can switch between many multi-byte charsets during the session 
      providing the command explicitly. 
      To note that setting new internal mysql's charset does not
      trigger sending any `SET' sql statement to the server. 
      
      
      client/mysql.cc:
        BUG#16217 revealed the problem of switching between charsets in mysql client.
        Such switching is necessary in a case when being scanned query consists of 
        multi-byte chars and internal charset was initialized differently. mysql finds 
        `/' escape and misiterprete it 
        while in fact one could be a part of a multi-byte symbol like the bug page reported. 
        
        This patch extends mysql `charset' command, '\C' shortcut.
      mysql-test/r/ctype_ucs_binlog.result:
        comment line generated by mysqlbinlog for processing of logs with multi-byte chars.
      mysql-test/r/mysql.result:
        results are altered due to #16217
      mysql-test/r/mysqlbinlog.result:
        Results are altered due to #16217
      mysql-test/r/mysqlbinlog2.result:
        commeted command for mysql client due to multi-byte binlog
      mysql-test/r/rpl_charset.result:
        commented command for mysql due to multi-byte binlogs
      mysql-test/r/rpl_timezone.result:
        commented command for mysql client due to multi-byte binlogs
      mysql-test/r/user_var-binlog.result:
        commented command for mysql client due to multi-byte binlogs
      mysql-test/t/mysql.test:
        Main test for mysql client is extended to check `charset' command.
      mysql-test/t/mysqlbinlog.test:
        Checking how /*! \C cs_name */ are added to the output of mysqlbinlog.
        The exclaiming comment is for further processing by mysql client.
        The added part mimics the failure to recover tables from binlog - see BUG#16217.
      sql/log_event.cc:
        Sending into output instructions for mysql client to switch internally 
        to appropriate charset.
        mysql client is supposed to be invoked with --default-character-set=
        "to default character set of the server created the binlog".
      e025e47a
  37. 04 Jan, 2006 1 commit
    • unknown's avatar
      Big patch to make embedded-server working in 5.x · 6b27acbd
      unknown authored
      Now it supports queries returning several results
      (particularly important with the SP)
      
      
      include/mysql.h:
        embedded_query_result structure added
      libmysql/libmysql.c:
        embedded-server related fixes
      libmysqld/emb_qcache.cc:
        multiple-result support added
      libmysqld/embedded_priv.h:
        embedded_query_result struct implemented
      libmysqld/lib_sql.cc:
        multiple-result support added
      libmysqld/libmysqld.c:
        small fixes
      mysql-test/t/backup.test:
        test fixed
      mysql-test/t/binlog_stm_binlog.test:
        test fixed
      mysql-test/t/binlog_stm_blackhole.test:
        test fixed
      mysql-test/t/binlog_stm_ctype_cp932.test:
        test fixed
      mysql-test/t/compress.test:
        test fixed
      mysql-test/t/delayed.test:
        test fixed
      mysql-test/t/federated.test:
        test fixed
      mysql-test/t/federated_archive.test:
        test fixed
      mysql-test/t/federated_bug_13118.test:
        test fixed
      mysql-test/t/federated_transactions.test:
        test fixed
      mysql-test/t/flush_table.test:
        test fixed
      mysql-test/t/handler.test:
        test fixed
      mysql-test/t/init_connect.test:
        test fixed
      mysql-test/t/innodb.test:
        test fixed
      mysql-test/t/mysql.test:
        test fixed
      mysql-test/t/mysql_client_test.test:
        test fixed
      mysql-test/t/mysqltest.test:
        test fixed
      mysql-test/t/query_cache.test:
        test fixed
      mysql-test/t/query_cache_notembedded.test:
        test fixed
      mysql-test/t/read_only.test:
        test fixed
      mysql-test/t/skip_grants.test:
        test fixed
      mysql-test/t/sp-destruct.test:
        test fixed
      mysql-test/t/sp-error.test:
        test fixed
      mysql-test/t/sp-threads.test:
        test fixed
      mysql-test/t/sp.test:
        test fixed
      mysql-test/t/view.test:
        test fixed
      mysql-test/t/wait_timeout.test:
        test fixed
      sql-common/client.c:
        small fixes
      sql/mysqld.cc:
        embedded-server related fix
      sql/protocol.cc:
        embedded-server related fix
      sql/protocol.h:
        embedded-server related fix
      sql/sql_class.cc:
        embedded-server related fix
      sql/sql_class.h:
        embedded-server related fix
      sql/sql_cursor.cc:
        embedded-server related fix
      sql/sql_parse.cc:
        embedded-server related fix
      sql/sql_prepare.cc:
        embedded-server related fix
      6b27acbd