An error occurred fetching the project authors.
  1. 12 Apr, 2005 2 commits
  2. 09 Apr, 2005 1 commit
  3. 06 Apr, 2005 2 commits
  4. 03 Apr, 2005 1 commit
    • unknown's avatar
      XID SQL syntax · 2fc4270b
      unknown authored
      minor cleanups
      XA tests
      
      
      include/m_ctype.h:
        minor cleanup
      sql/field.cc:
        minor cleanup
      sql/handler.cc:
        XID SQL syntax
      sql/handler.h:
        XID SQL syntax
      sql/item_sum.h:
        minor cleanup
      sql/lock.cc:
        comments
      sql/sql_class.cc:
        minor cleanup
      sql/sql_lex.h:
        XID SQL syntax
      sql/sql_parse.cc:
        XID SQL syntax
      sql/sql_yacc.yy:
        XID SQL syntax
        cleanups
      2fc4270b
  5. 01 Apr, 2005 1 commit
    • unknown's avatar
      Invalid DEFAULT values for CREATE TABLE now generates errors. (Bug #5902) · db7561ec
      unknown authored
      CAST() now produces warnings when casting a wrong INTEGER or CHAR values. This also applies to implicite string to number casts. (Bug #5912)
      ALTER TABLE now fails in STRICT mode if it generates warnings.
      Inserting a zero date in a DATE, DATETIME or TIMESTAMP column during TRADITIONAL mode now produces an error. (Bug #5933)
      
      
      mysql-test/r/bigint.result:
        New warning added
      mysql-test/r/cast.result:
        Added testing of wrong CAST's of strings to numbers and numbers to strings
      mysql-test/r/create.result:
        Added test for wrong default values (#5902)
      mysql-test/r/func_if.result:
        Changed tests to produce less warnings
      mysql-test/r/func_misc.result:
        New warning
      mysql-test/r/func_str.result:
        Added missing drop table
        Changed test to produce less warnings
        New warnings
      mysql-test/r/ndb_index_unique.result:
        Removed wrong default usage
      mysql-test/r/ps_1general.result:
        Changed tests to produce less warnings
      mysql-test/r/row.result:
        New warnings
      mysql-test/r/rpl_session_var.result:
        Changed tests to produce less warnings
      mysql-test/r/strict.result:
        New tests for CAST() and zero date handling
      mysql-test/r/subselect.result:
        Changed tests to produce less warnings
      mysql-test/r/type_ranges.result:
        Changed tests to produce less warnings
      mysql-test/t/cast.test:
        Added testing of wrong CAST's of strings to numbers and numbers to strings
      mysql-test/t/create.test:
        Added test for wrong default values (#5902)
      mysql-test/t/func_if.test:
        Changed tests to produce less warnings
      mysql-test/t/func_str.test:
        Added missing drop table
        Changed test to produce less warnings
        New warnings
      mysql-test/t/ndb_index_unique.test:
        Removed wrong default usage
      mysql-test/t/ps_1general.test:
        Changed tests to produce less warnings
      mysql-test/t/rpl_session_var.test:
        Changed tests to produce less warnings
      mysql-test/t/strict.test:
        New tests for CAST() and zero date handling
      mysql-test/t/subselect.test:
        Changed tests to produce less warnings
      mysql-test/t/type_ranges.test:
        Changed tests to produce less warnings
      sql/Makefile.am:
        Added new include file
      sql/field.cc:
        Added warnings for zero dates for DATE, DATETIME and TIMESTAMP
        Moved Field_blob::max_length() to a more appropriate position
        Changed type for 'level' in set_warning() to avoid casts
      sql/field.h:
        Changed type for 'level' in set_warning() to avoid casts
      sql/field_conv.cc:
        Copy date and datetime fields through string in 'traditional' mode to detect zero dates
      sql/item.cc:
        Removed compiler warnings
        Give warnings for wrong CAST of strings -> number
      sql/item.h:
        Moved Item_string::val_real() and ::val_int() to item.cc
      sql/item_row.cc:
        Better detection of null values (which doesn't produce warnings)
      sql/item_sum.cc:
        Better detection of null values (which doesn't produce warnings)
      sql/item_timefunc.cc:
        Give warnings for wrong CAST of number -> string
      sql/my_decimal.cc:
        Fixed typo in comment
      sql/mysql_priv.h:
        Removed prototype for static function
        Moved defines for error handling to sql_error.h (to be able to use these in field.h)
      sql/mysqld.cc:
        Simplify code
      sql/sql_class.h:
        Moved to sql_error.h
      sql/sql_load.cc:
        Removed wrong cast
      sql/sql_parse.cc:
        Fixed wrong printf()
      sql/sql_table.cc:
        Made mysql_prepare_table() static
        Changed references to pointers to make code more readable
        ALTER TABLE now aborts if one gets warnings in STRICT mode
      sql/time.cc:
        Fixed possible wrong call
      sql/unireg.cc:
        Removed one call to current_thd
        Give errors if one uses a wrong DEFAULT value
      db7561ec
  6. 31 Mar, 2005 1 commit
    • unknown's avatar
      postmerge 4.1->5.0 fixes · c831a156
      unknown authored
      mysql-test/r/group_by.result:
        result change
      mysql-test/r/union.result:
        result change
      mysql-test/r/view.result:
        result change
      mysql-test/t/subselect.test:
        fixed mistake of merge
      sql/field.cc:
        new 5.0 types support
        temporary table/db names detection in field fixed
      sql/field.h:
        removed non-existent methods
        added wrongly deleted during manual merge string
      sql/item.cc:
        support of new types added to merge of union types routines
      sql/item.h:
        fixed method definition
      sql/item_cmpfunc.cc:
        fixed type
      sql/item_func.h:
        item type name fixed
      sql/item_subselect.cc:
        added forgoten methods
      sql/item_subselect.h:
        fixed type
      sql/sql_derived.cc:
        fixed typo of manual merge
      sql/sql_view.cc:
        added new parameter
      c831a156
  7. 30 Mar, 2005 2 commits
    • unknown's avatar
      Enabled more tests of STR_TO_DATE() · a593a0a7
      unknown authored
      Fixed that datetime gives warning for zero dates in traditional mode
      
      
      mysql-test/r/strict.result:
        Enabled more tests of STR_TO_DATE()
      mysql-test/t/strict.test:
        Enabled more tests of STR_TO_DATE()
      sql/field.cc:
        Fixed that datetime gives warning for zero dates in traditional mode
      sql/log_event.h:
        Fix wrong ifdef from last push
      a593a0a7
    • unknown's avatar
      Give warnings if wrong date/time/datetime argument for STR_TO_DATE · a5b1b9d9
      unknown authored
      Small fixes while doing review of new pushed code
      More test cases for decimal
      
      
      mysql-test/r/date_formats.result:
        Warnings added for STR_TO_DATE()
      mysql-test/r/ps_1general.result:
        Better description for BLACKHOLE
      mysql-test/r/strict.result:
        Added tests for STR_TO_DATE
      mysql-test/r/type_decimal.result:
        Test to test ranges of DECIMAL
      mysql-test/t/date_formats.test:
        More tests
      mysql-test/t/strict.test:
        Added tests for STR_TO_DATE
      mysql-test/t/type_decimal.test:
        Test to test ranges of DECIMAL
      sql/field.cc:
        Simple optimization
      sql/handler.cc:
        Better description for BLACKHOLE
      sql/item_timefunc.cc:
        Give warnings if wrong date/time/datetime argument for STR_TO_DATE
      sql/log_event.cc:
        Indentation fixes
      sql/log_event.h:
        #ifdef-ed not used code
      sql/share/errmsg.txt:
        New error message
      sql/sql_show.cc:
        Ensure that we do a proper restore in case of error
      a5b1b9d9
  8. 28 Mar, 2005 1 commit
    • unknown's avatar
      Fix for bug #8894 "TIMESTAMP values scrambled/misaligned when using --new". · 22f6c58b
      unknown authored
      Fixed Field_timestamp::val_int() so now it works correctly in --new mode
      (or for TIMESTAMP(19) columns). 
      Also removed unused Field_timestamp::fill_and_store() method.
      
      
      mysql-test/r/type_timestamp.result:
        Added test for bug #8894 "TIMESTAMP values scrambled/misaligned when 
        using --new".
      mysql-test/t/type_timestamp.test:
        Added test for bug #8894 "TIMESTAMP values scrambled/misaligned when 
        using --new".
      sql/field.cc:
        Field_timestamp::fill_and_store() 
          Removed unused method.
        Field_timestamp::val_int()
          Even in --new mode integer representation of TIMESTAMP value should
          not exceed 14 digits.
      sql/field.h:
        Removed unused Field_timestamp::fill_and_store() method.
      22f6c58b
  9. 23 Mar, 2005 1 commit
    • unknown's avatar
      fixed union types merging and table related metadata (BUG#8824) · 5a425250
      unknown authored
      mysql-test/r/func_group.result:
        new result
      mysql-test/r/metadata.result:
        new result
        test of metadata of variables, unions and derived tables
      mysql-test/r/union.result:
        new results
        test of union of enum
      mysql-test/t/metadata.test:
        test of metadata of variables, unions and derived tables
      mysql-test/t/union.test:
        test of union of enum
      sql/field.cc:
        Field type merging rules added
        Fixed table name/alias returting for field made from temporary tables
      sql/field.h:
        removed unned field type reporting
      sql/item.cc:
        fixed bug in NEW_DATE type field creartion
        replaced mechanism of merging types of UNION
      sql/item.h:
        replaced mechanism of merging types of UNION
      sql/item_func.h:
        new item type to make correct field type detection possible
      sql/item_subselect.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_derived.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_lex.h:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_parse.cc:
        made function for enum/set pack length calculation
      sql/sql_prepare.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_select.cc:
        new temporary table field creation by Item_type_holder
        fixed table alias for temporary table
      sql/sql_union.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      5a425250
  10. 22 Mar, 2005 1 commit
  11. 19 Mar, 2005 1 commit
    • unknown's avatar
      Eliminate warnings noticed by VC7. This includes fixing my_mmap() on · 892a6138
      unknown authored
      Windows to call CreateFileMapping() with correct arguments, and
      propogating the introduction of query_id_t to everywhere query ids are
      passed around. (Bug #8826)
      
      
      libmysql/libmysql.c:
        Make implicit cast explicit
      myisam/mi_open.c:
        Make cast of value to smaller data size explicit
      myisam/mi_packrec.c:
        Cast file size (my_off_t) to size_t for mmap
      mysys/my_mmap.c:
        Fix Windows version of my_mmap() to use the right parameters
        for call to CreateFileMapping()
      sql/field.cc:
        Use temporary value of correct type
      sql/field.h:
        Use query_id_t for query_id value
      sql/ha_berkeley.cc:
        Fix flag check
      sql/ha_innodb.h:
        Use query_id_t for query_id value
      sql/handler.cc:
        Explain opt_using_transactions calculation, and add cast
      sql/handler.h:
        Fix forward declaration of COND
      sql/item.cc:
        Fix val_bool() tests of val_int() to avoid implicit cast
      sql/item_cmpfunc.cc:
        Fix typo in switch label
      sql/item_func.cc:
        Make implicit cast explicit
      sql/item_strfunc.cc:
        Now that query_id is a query_id_t, need to cast it to a ulong here
      sql/item_subselect.cc:
        Fix test of value
      sql/log.cc:
        Cast my_off_t used for file size to size_t for memory allocation
        Also cast my_off_t when using it to calculate the number of pages for TC log
        Cast total_ha_2pc to uchar when saving it
      sql/mysql_priv.h:
        Move up query_id definition so it can be used more widely
      sql/opt_range.cc:
        Add unused delete operator to prevent compiler warning
      sql/set_var.cc:
        Cast value for max_user_connections
      sql/sql_cache.cc:
        Remove unused label
      sql/sql_class.h:
        Fix query id values to be of type query_id_t
      sql/sql_db.cc:
        Move variable only used inside #ifdef within the #ifdef
      sql/sql_help.cc:
        Remove unused label
      sql/sql_insert.cc:
        Use query_id_t for query id values
      sql/sql_lex.h:
        Add unused delete operator to prevent compiler warning
      sql/sql_select.cc:
        Remove unused variable
        Make cast of value explicit
      sql/sql_select.h:
        Use query_id_t for query id values
      sql/sql_table.cc:
        Make comparison to function pointer explicit
      sql/sql_update.cc:
        Use query_id_t for query id values
      sql/table.h:
        Use query_id_t for query id values
      strings/ctype-simple.c:
        Add cast of long value to (char) in expression
      strings/ctype-ucs2.c:
        Add cast of long value to (char) in expression
      strings/ctype-utf8.c:
        Make cast to smaller size explicit
      892a6138
  12. 17 Mar, 2005 1 commit
    • unknown's avatar
      Field::quote_data(): · b6e29d09
      unknown authored
        don't call escape_string_for_mysql() unnecesary
        don't overwrite local buffer
      escape_string_for_mysql():
        take a length of the destination buffer as an argument
      
      
      include/my_sys.h:
        prototype changed
      libmysql/libmysql.c:
        prototype changed
      mysys/charset.c:
        escape_string_for_mysql():
          take a length of the destination buffer as an argument
      sql/field.cc:
        Field::quote_data():
          don't call escape_string_for_mysql() unnecesary
          don't overwrite local buffer
      sql/item.cc:
        prototype changed
      sql/sql_prepare.cc:
        prototype changed
      b6e29d09
  13. 16 Mar, 2005 1 commit
    • unknown's avatar
      Cleanup during reviews · 284b8b8b
      unknown authored
      Removed some optional arguments
      Fixed portability problem in federated tests
      
      
      client/sql_string.cc:
        update from sql/sql_string.cc
      client/sql_string.h:
        update from sql/sql_string.h
      mysql-test/r/federated.result:
        Fixed error message
      sql/field.cc:
        Cleanup during review
        Remove const in 'const unsigned int'
      sql/field.h:
        Remove const in 'const unsigned int'
      sql/ha_federated.cc:
        Better error string.  Add missing argument to error (before 'errno' was picked up from stack)
      sql/handler.cc:
        Removed compiler warning
      sql/item_func.cc:
        Cleanup during review
      sql/item_sum.cc:
        Cleanup during review
      sql/lock.cc:
        Remove optional arguments
      sql/log_event.cc:
        Remove optional arguments
      sql/mysql_priv.h:
        Remove optional arguments
        cahnge preapre_create_fields to use pointers instead of references
      sql/opt_range.cc:
        Fix arguments so that return value is last
      sql/sql_base.cc:
        Remove optional arguments
      sql/sql_delete.cc:
        Remove optional arguments
      sql/sql_error.cc:
        Remove optional arguments
      sql/sql_help.cc:
        Remove optional arguments
      sql/sql_parse.cc:
        Remove optional arguments
      sql/sql_prepare.cc:
        Remove optional arguments
      sql/sql_rename.cc:
        Remove optional arguments
      sql/sql_select.cc:
        Remove optional arguments
      sql/sql_show.cc:
        Cleanup during review
      sql/sql_string.cc:
        Simple optimization
      sql/sql_table.cc:
        Remove optional arguments
        Fixed indentation
      sql/sql_update.cc:
        Remove optional arguments
      sql/sql_yacc.yy:
        Change references to pointers
      284b8b8b
  14. 13 Mar, 2005 1 commit
    • unknown's avatar
      WL#926 "SUM(DISTINCT) and AVG(DISTINCT)": improvement of SUM(DISTINCT) and · 1534ed8e
      unknown authored
       implementation of AVG(DISTINCT) which utilizes the approach with Fields.
      The patch implemented in October is portede to the up-to-date tree 
      containing DECIMAL type.
      Tests for AVG(DISTINCT) (although there is not much to test provided
      that SUM(DISTINCT) works), cleanups for COUNT(DISTINCT) and GROUP_CONCAT()
      will follow in another changeset.
      
      
      sql/field.cc:
        A handy way to init create_field used for use with virtual tmp tables.
        Feel free to extend it for your own needs.
      sql/field.h:
        Declaration for create_field::init_for_tmp_table()
      sql/item.cc:
        Implementation for a framework used to easily handle different result
        types of SQL expressions. Instead of having instances of each possible 
        result type (integer, decimal, double) in every item, variables
        of all used types are moved to struct Hybrid_type.
        Hybrid_type can change its dynamic type in runtime, and become,
        for instance, DECIMAL from INTEGER.
        All type-specific Item operations are moved to the class hierarchy
        Hybrid_type_traits. Item::decimals and Item::max_length can
        be moved to Hybrid_type as well.
      sql/item.h:
        Declaration for Hybrid_type framework. See also comments for item.cc
        in this changeset.
      sql/item_sum.cc:
        Rewritten implementation for Item_sum_sum_distinct (SUM(DISTINCT))
        and added implementation for Item_sum_avg_distinct (AVG(DISTINCT)).
        The classes utilize Hybrid_type class hierarchy and Fields to
        convert SUM/AVG arguments to binary representation and store in a RB-tree.
      sql/item_sum.h:
        Declarations for Item_sum_distinct (the new intermediate class used
        for SUM and AVG distinct), Item_sum_sum_distinct, Item_sum_avg_distinct.
      sql/sql_select.cc:
        Implementatio of create_virtual_tmp_table().
      sql/sql_select.h:
        Declaration for create_virtual_tmp_table.
      sql/sql_yacc.yy:
        Grammar support for Item_sum_avg_distinct.
      1534ed8e
  15. 10 Mar, 2005 1 commit
  16. 07 Mar, 2005 1 commit
  17. 25 Feb, 2005 1 commit
    • unknown's avatar
      Remove compiler warnings and remove not used variables · 248e4494
      unknown authored
      (Found during build process)
      
      
      extra/comp_err.c:
        Remove compiler warnings
      extra/perror.c:
        Remove compiler warnings
      innobase/dict/dict0dict.c:
        Remove compiler warnings
      innobase/dict/dict0load.c:
        Remove compiler warnings
      innobase/pars/pars0sym.c:
        Remove compiler warnings
      innobase/row/row0row.c:
        Remove compiler warnings
      innobase/row/row0sel.c:
        Remove compiler warnings
      libmysqld/lib_sql.cc:
        Remove not used variables
      myisam/mi_key.c:
        Remove compiler warnings
      regex/engine.c:
        Added comment
      sql/derror.cc:
        Remove not used variables
      sql/examples/ha_archive.cc:
        Fixed bug in blob handling
        Removed not used variable
      sql/field.cc:
        Remove compiler warnings
        Remove not used variables
      sql/filesort.cc:
        Remove compiler warnings
      sql/ha_heap.cc:
        Remove not used variable
      sql/ha_innodb.cc:
        Remove not used variables
        Remove compiler warnings
      sql/handler.cc:
        Remove compiler warnings and remove not used variables
      sql/item.cc:
        Remove compiler warnings and remove not used variables
      sql/item_subselect.cc:
        Remove compiler warnings
      sql/item_sum.cc:
        Remove compiler warnings
      sql/item_sum.h:
        Remove compiler warnings and remove not used variables
      sql/log.cc:
        Remove compiler warnings and remove not used variables
      sql/log_event.cc:
        Remove compiler warnings
      sql/mysqld.cc:
        Remove compiler warnings and remove not used variables
      sql/opt_range.cc:
        Remove compiler warnings and remove not used variables
      sql/slave.cc:
        Remove compiler warnings and remove not used variables
      sql/sp_pcontext.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_acl.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_analyse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_base.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_db.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_help.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_insert.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_load.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_parse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_prepare.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_select.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_show.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_table.cc:
        Remove compiler warnings
      sql/sql_union.cc:
        Remove compiler warnings
      sql/sql_update.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_yacc.yy:
        Remove compiler warnings and remove not used variables
      sql/strfunc.cc:
        Remove compiler warnings and remove not used variables
      strings/ctype-ucs2.c:
        Remove compiler warnings
      tests/mysql_client_test.c:
        Remove compiler warnings and remove not used variables
      tools/mysqlmanager.c:
        Remove compiler warnings and remove not used variables
      248e4494
  18. 22 Feb, 2005 2 commits
    • unknown's avatar
      Backport my_strntod() from 5.0 · cb8d9c3a
      unknown authored
      Change string->float conversion to delay division as long as possible.
      This gives us more exact integer->float conversion for numbers of type '123.45E+02' (Bug #7740)
      
      
      
      
      client/mysql.cc:
        Fix wront usage of charset (found during review of pushed code)
      include/m_string.h:
        Backported my_strtod() from 5.0
      mysql-test/mysql-test-run.sh:
        Run also mysql_client_test with --debug
      mysql-test/r/ps_1general.result:
        Safety fix (if mysql_client_test.test fails)
      mysql-test/r/type_float.result:
        More test
      mysql-test/t/mysql_client_test.test:
        Comments for what to do if this test fails
      mysql-test/t/ps_1general.test:
        Safety fix (if mysql_client_test.test fails)
      mysql-test/t/type_float.test:
        More test to better test new strtod() function
        Test also bug #7740 (wrong comparsion between integer and float-in-integer-range)
      sql/field.cc:
        Backport my_strntod() from 5.0
      sql/item.cc:
        Backport my_strntod() from 5.0
      sql/item.h:
        Backport my_strntod() from 5.0
      sql/item_func.h:
        Backport my_strntod() from 5.0
      sql/item_strfunc.cc:
        Backport my_strntod() from 5.0
      sql/item_sum.cc:
        Backport my_strntod() from 5.0
      sql/item_sum.h:
        Backport my_strntod() from 5.0
      sql/procedure.h:
        Backport my_strntod() from 5.0
      strings/ctype-simple.c:
        Backport my_strntod() from 5.0
      strings/ctype-ucs2.c:
        Backport my_strntod() from 5.0
      strings/strtod.c:
        Backport my_strntod() from 5.0
        Change conversion to delay division as long as possible.
        This gives us more exact integer-> float conversion for numbers of type '123.45E+02'
      cb8d9c3a
    • unknown's avatar
      field.cc: · 1329f063
      unknown authored
        optimize test_if_minus() when not UCS2 support is compiled.
      
      
      sql/field.cc:
        optimize test_if_minus() when not UCS2 support is compiled.
      1329f063
  19. 19 Feb, 2005 1 commit
    • unknown's avatar
      use dbug_print_decimal instead of DBUG_EXECUTE · 3805001f
      unknown authored
      Portability fix
      Note: rpl_trunc_binlog fails, but Sergei has promised to fix it, so I will ignore it for now
      
      
      sql/field.cc:
        use dbug_print_decimal instead of DBUG_EXECUTE
      sql/item.h:
        Portability fix
      sql/my_decimal.cc:
        Fix error in last changeset (not pushed)
      3805001f
  20. 18 Feb, 2005 1 commit
    • unknown's avatar
      Changes and fixes for windows compilation · af4b5c89
      unknown authored
      VC++Files/libmysqld/libmysqld.dsp:
        added sql/my_decimal.cc
      VC++Files/sql/mysqld.dsp:
        added my_decimal.cpp
      VC++Files/strings/strings.dsp:
        added decimal.c
      sql/field.cc:
        conversion fixes for windows compilation
      sql/item.h:
        fix for windows compilation
      sql/item_func.cc:
        fixed conversion for windows (cast from ulonglong to double 
        is not supported)
      sql/item_sum.cc:
        typecast fix for windows compilation
      sql/sp_head.cc:
        typecast fix fo windows compilation
      sql/sql_cache.cc:
        typecast fix for windows compilation
      af4b5c89
  21. 15 Feb, 2005 2 commits
    • unknown's avatar
      After merge fixes · 6992c010
      unknown authored
      mysql-test/r/ctype_ucs.result:
        Fixed warning after merge
      sql/field.cc:
        After merge fix
      sql/item_cmpfunc.cc:
        Style & comment changes
      sql/sql_yacc.yy:
        After merge fix
      6992c010
    • unknown's avatar
      Fixed failing test cases 'row.test' when running with --ps-protocol · 67b16d20
      unknown authored
      Simple optimzations done while reviewing code
      
      
      client/mysqltest.c:
        Added options --enable-ps-warnings and --disable-ps-warnings
        (to fix failing test case)
      mysql-test/t/row.test:
        Disable warnings that comes from 'parse' parth
      sql/field.cc:
        Removed calls to is_null() in field functions.
        (Not needed as NULL handling is done on the level above fields)
        Indentation fixes
        Removed calls to alloca() as buffer needed was quite small.
      sql/field.h:
        Indentation changes and comment fixes
      sql/filesort.cc:
        Simple optimization during code review
      sql/item.cc:
        Indentation fixes
        Removed some unnecessary tests (added DBUG_ASSERTS() instead)
      sql/item_buff.cc:
        Indentation fixes
      sql/my_decimal.cc:
        Indentation fixes
        Simple optimization
        Fixed compiler warning
      sql/sql_update.cc:
        Removed unnessessary assignment
      67b16d20
  22. 12 Feb, 2005 1 commit
  23. 10 Feb, 2005 1 commit
    • unknown's avatar
      Things missing in last changset · 4adab48b
      unknown authored
      After merge fixes
      Don't give duplicate warnings for some ::store() functions
      
      
      mysql-test/mysql-test-run.sh:
        Added back missing line
      mysql-test/r/ps_2myisam.result:
        Update results after removing duplicate warnings from ::store()
      mysql-test/r/ps_3innodb.result:
        Update results after removing duplicate warnings from ::store()
      mysql-test/r/ps_4heap.result:
        Update results after removing duplicate warnings from ::store()
      mysql-test/r/ps_5merge.result:
        Update results after removing duplicate warnings from ::store()
      sql/field.cc:
        Don't give duplicate warnings for some ::store() functions
        Before we could get different number of warnings in the test suite for different platforms
      sql/field.h:
        Update results after removing duplicate warnings from ::store()
      sql/sql_class.h:
        Update results after removing duplicate warnings from ::store()
      sql/sql_error.cc:
        Update results after removing duplicate warnings from ::store()
      sql/sql_list.h:
        After merge fix
      4adab48b
  24. 08 Feb, 2005 1 commit
    • unknown's avatar
      Precision Math implementation · 91db48e3
      unknown authored
      BitKeeper/etc/ignore:
        Added client/decimal.c client/my_decimal.cc client/my_decimal.h to the ignore list
      91db48e3
  25. 04 Feb, 2005 1 commit
    • unknown's avatar
      A fix: bug#6931: Date Type column problem when using UNION-Table · 66eb71f3
      unknown authored
             bug#7833:  Wrong datatype of aggregate column is returned
      
      
      mysql-test/r/func_group.result:
        Test case for bug 7833:  Wrong datatype of aggregate column is returned
      mysql-test/r/union.result:
        Test case for bug 6931: Date Type column problem when using UNION-Table.
      mysql-test/t/func_group.test:
        Test case for bug 7833:  Wrong datatype of aggregate column is returned
      mysql-test/t/union.test:
        Test case for bug 6931: Date Type column problem when using UNION-Table.
      66eb71f3
  26. 01 Feb, 2005 1 commit
  27. 21 Jan, 2005 1 commit
    • unknown's avatar
      -Added quote_data and needs_quotes (moved from federated handler. · 66b62e05
      unknown authored
      -New tests and results
      
      logging_ok:
        Logging to logging@openlogging.org accepted
      ha_federated.h:
        removed quote_data and type_quote (now in the Field class)
      ha_federated.cc:
        moved quote_data and type_quote to field class
      field.h:
        new methods quote_data and needs_quotes declared
      field.cc:
        new field class methods quote_data and needs_quotes (per Monty's request)
      federated.test:
        more tests, joins, index tests
      have_federated_db.require:
        new name of federated system var
      federated.result:
        new test results for federated handler
      have_federated_db.inc:
        changed name of variable in test due to change in vars
      sql_analyse.cc:
        over-ridden append_escaped to take (String *, char *, uint) per requirements of 'create_where_from_key' method in federated handler.
      mysql_priv.h:
        define over-ridden append_escaped to take arguments from 'create_where_from_key' method in federated handler 
      ha_federated.cc:
        implemented "create_where_from_key" to deal properly with two-byte prefix and multi keys. Initial testing shows it works, but I still need to move quoting to field class and also look at changes per Segei's suggestions.
      
      
      sql/mysql_priv.h:
        define over-ridden append_escaped to take arguments from 'create_where_from_key' method in federated handler
      sql/sql_analyse.cc:
        over-ridden append_escaped to take (String *, char *, uint) per requirements of 'create_where_from_key' method in federated handler.
      mysql-test/include/have_federated_db.inc:
        changed name of variable in test due to change in vars
      mysql-test/r/federated.result:
        new test results for federated handler
      mysql-test/r/have_federated_db.require:
        new name of federated system var
      mysql-test/t/federated.test:
        more tests, joins, index tests
      sql/field.cc:
        new field class methods quote_data and needs_quotes (per Monty's request)
      sql/field.h:
        new methods quote_data and needs_quotes declared
      sql/ha_federated.cc:
        moved quote_data and type_quote to field class
      sql/ha_federated.h:
        removed quote_data and type_quote (now in the Field class)
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      66b62e05
  28. 19 Jan, 2005 2 commits
  29. 15 Jan, 2005 2 commits
    • unknown's avatar
      After merge fixes · 6ead8600
      unknown authored
      Fix for BIT(X) field as string
      
      
      mysql-test/r/func_gconcat.result:
        Fix wrong merge
      mysql-test/r/func_sapdb.result:
        Use results so that dimitry can fix them properly
      mysql-test/r/innodb.result:
        Update test after fast TRUNCATE in InnoDB
      mysql-test/r/ps_1general.result:
        After megre fixes
      mysql-test/r/type_bit.result:
        New test to verify patch for Bit fields
      mysql-test/t/ps_1general.test:
        After merge fixes
      mysql-test/t/type_bit.test:
        New test to verify patch for Bit fields
      sql/field.cc:
        Fix for new my_strntod()
        Fix for BIT(X) field as string
      sql/item.h:
        Fix for new my_strntod()
      sql/item_func.h:
        Fix for new my_strntod()
      sql/item_sum.h:
        Fix for new my_strntod()
      sql/procedure.h:
        Fix for new my_strntod()
      sql/sql_base.cc:
        Port fix for INSERT DELAYED with prepared statements to 5.0
      6ead8600
    • unknown's avatar
      Changed interface for my_strntod() to make it more general and more portable · 5437a90d
      unknown authored
      BUILD/compile-solaris-sparc-purify:
        Cleanup (Changes from Kent)
      include/m_string.h:
        New interface for my_strtod()
      mysql-test/mysql-test-run.sh:
        Added option --use-old-data to allow one to run a test case on an existing table
        (Good for debugging)
      mysql-test/r/strict.result:
        Updated results
      mysql-test/r/type_float.result:
        More tests
      mysql-test/t/strict.test:
        Safety fix
      mysql-test/t/type_float.test:
        More tests
      mysys/mf_iocache.c:
        Change flush_io_cache() to my_b_flush_io_cache()
        More debugging
      mysys/thr_lock.c:
        Added comment
      sql/field.cc:
        Use new my_strntod()
      sql/filesort.cc:
        Indentation fixes
      sql/item.cc:
        Use new my_strntod()
      sql/item_strfunc.cc:
        Use new my_strntod()
      sql/item_sum.cc:
        Use new my_strntod()
      strings/ctype-cp932.c:
        strnncollsp was missing one argument
      strings/ctype-simple.c:
        Use new my_strntod()
      strings/ctype-ucs2.c:
        Use new my_strntod()
      strings/strtod.c:
        Changed interface:
        - Force user to supply pointer to end of string (eliminates the need for an end \0)
        - More strict error checking (depend less off if INF is set), which makes this more portable
        - Better handling of numbers of type 0.000000....E+...
        - Return pointer to + in case of '+.'
        
        The above should fix a that strict.test failed on Solaris-sparc.
      5437a90d
  30. 13 Jan, 2005 1 commit
  31. 12 Jan, 2005 2 commits
    • unknown's avatar
      Small fix for Field_str::store() to avoid trying to read past beginning · 7682d6c9
      unknown authored
      of log_10 array.
      
      
      sql/field.cc:
        Avoid pointless calculation for really short fields, and what could be
        an attempt to access outside the bounds of the log_10 array.
      7682d6c9
    • unknown's avatar
      Fix conversion of floating point values to character fields when the · 8b077c2b
      unknown authored
      absolute value of the float is less than 1, and also fix calculation of
      length for negative values. (Bug #7774)
      
      
      sql/field.cc:
        Fix handling of negative values and fabs(values> < 1 in Field_str::store
      mysql-test/r/type_float.result:
        Add results
      mysql-test/r/type_float.result.es:
        Add results
      mysql-test/t/type_float.test:
        Add test for conversion of floats to character field
      8b077c2b
  32. 11 Jan, 2005 1 commit