An error occurred fetching the project authors.
  1. 13 Dec, 2007 1 commit
    • unknown's avatar
      Fix broken embedded build (broken by the patch for Bug#12713, first part). · 37a2c459
      unknown authored
      client/mysqltest.c:
        Remove a call to my_message() (server call) in case of a client error.
        It asserts in the embedded build now, since is called after send_ok().
      libmysqld/emb_qcache.cc:
        Use net_send_eof (embedded implementation) in embedded query cache/
        send result to client, since send_eof currently does not
        send anything.
      libmysqld/emb_qcache.h:
        Declare net_send_eof.
      libmysqld/lib_sql.cc:
        Fix the main loop of the embedded server to use the new Diagnostics_area
        API.
      sql/log.cc:
        Silence errors of open_performance_schema_table. This function
        is called for general logging, and it happens after the error
        has been sent to the client, and thus triggers an assert.
      storage/myisam/ha_myisam.cc:
        Remove an old hack that broke repair.test in embedded build:
        unless we clear an error here, the server attempts to send OK after
        ERROR. This currently asserts.
      37a2c459
  2. 01 Nov, 2007 1 commit
  3. 17 Oct, 2007 1 commit
    • unknown's avatar
      Bug#31608 missing mysqltest change_user command · e5125728
      unknown authored
      Post merge fixes: close any open statement before
      the change user command and fix test case output.
      
      
      client/mysqltest.c:
        Close an open statement since it won't work after a change_user command.
      mysql-test/r/change_user.result:
        Fixed test case output.
      mysql-test/t/change_user.test:
        Fix test case output to return 1 or 0.
      e5125728
  4. 16 Oct, 2007 1 commit
    • unknown's avatar
      Bug#31608 missing mysqltest change_user command · 88e5aa69
      unknown authored
      The problem is that currently there is no way to test the behavior
      of the mysql_change_user() function using the mysqltest suite because
      there is no internal command for it.
      
      The solution is to introduce a change_user command that can be used
      to test aspects of the MySQL client function mysql_change_user().
      
      
      client/mysqltest.c:
        Add change_user command to mysqltest.
      mysql-test/r/mysqltest.result:
        Add test case result for change_user command
      mysql-test/t/mysqltest.test:
        Add test case for change_user command
      mysql-test/r/change_user.result:
        Add new file with test case results for bugs 20023 and 31418.
      mysql-test/t/change_user.test:
        Add new file with test cases for bugs 20023 and 31418.
      88e5aa69
  5. 10 Oct, 2007 1 commit
  6. 05 Oct, 2007 2 commits
  7. 30 Sep, 2007 1 commit
  8. 29 Sep, 2007 1 commit
  9. 13 Sep, 2007 1 commit
    • unknown's avatar
      Bug #15327: configure: --with-tcp-port option being partially ignored · ee7f125d
      unknown authored
      make sure that if builder configured with a non-standard (!= 3306)
      default TCP port that value actually gets used throughout. if they
      didn't configure a value, assume "use a sensible default", which
      will be read from /etc/services or, failing that, from the factory
      default. That makes the order of preference
      - command-line option
      - my.cnf, where applicable
      - $MYSQL_TCP_PORT environment variable
      - /etc/services (unless configured --with-tcp-port)
      - default port (--with-tcp-port=... or factory default)
      
      
      client/mysql.cc:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysql_upgrade.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqladmin.cc:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqlbinlog.cc:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqlcheck.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqldump.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqlimport.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqlmanagerc.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      configure.in:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        If MYSQL_TCP_PORT defaulted in configure (factory default 3306
        at the time of this writing), set MYSQL_TCP_PORT to factory
        default, then clear factory default after. That way, we lose no
        information, and we can distinguish between "defaulted" and the
        pathological case "builder specifically configured a port that
        coincides with factory default." This can in theory happen if
        builder configures and builds several servers from a script
        (--with-tcp-port=3306, --with-tcp-port=3316, --with-tcp-port=3326).
        Not all that probable, but much preferable to having more "magic"
        happen in the server when we can solve this without any guesswork.
      client/mysqlshow.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      client/mysqltest.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      include/mysql_version.h.in:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make factory default for TCP port available as MYSQL_PORT_DEFAULT
        if build-time configured with a different default.  (0 if unchanged)
      libmysql/libmysql.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        initialize default tcp port for client, like so:
        - if user configured --with-tcp-port, use that value as default
        - otherwise assume "use a good default": search mysqld/tcp in
          /etc/services; if that doesn't exist, use factory default (3306)
        - environment variable MYSQL_TCP_PORT overrides this default
        - command-line option overrides all of the above
      mysql-test/Makefile.am:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make factory default for TCP port available as MYSQL_TCP_PORT_DEFAULT
        if build-time configured with a different default.  (0 if unchanged)
      mysql-test/mysql-test-run-shell.sh:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        set up MYSQL_TCP_PORT if not already set in environment:
        - if user configured --with-tcp-port, use that value as default
        - otherwise assume "use a good default": search mysqld/tcp in
          /etc/services; if that doesn't exist, use factory default (3306)
      netware/mysql_test_run.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        account for non-standard default port-no. configured at build-time
      netware/mysqld_safe.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        account for non-standard default port-no. configured at build-time
      scripts/Makefile.am:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make factory default for TCP port available as MYSQL_TCP_PORT_DEFAULT
        if build-time configured with a different default.  (0 if unchanged)
      scripts/mysql_config.sh:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        set up MYSQL_TCP_PORT if not already set in environment:
        - if user configured --with-tcp-port, use that value as default
        - otherwise assume "use a good default": search mysqld/tcp in
          /etc/services; if that doesn't exist, use factory default (3306)
      scripts/mysql_fix_privilege_tables.sh:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        clarifying notice only
      scripts/mysqld_safe-watch.sh:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        account for non-standard default port-no. configured at build-time
      server-tools/instance-manager/priv.h:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        account for non-standard default port-no. configured at build-time
      sql/mysqld.cc:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        if builder specifically requested a default port, use that
        (even if it coincides with our factory default).
        only if they didn't do we check /etc/services (and, failing
        on that, fall back to the factory default of 3306).
        either default can be overridden by the environment variable
        MYSQL_TCP_PORT, which in turn can be overridden with command
        line options.
      tests/mysql_client_test.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      tests/ssl_test.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        account for non-standard default port-no. configured at build-time
      tests/thread_test.c:
        Bug #15327: configure: --with-tcp-port option being partially ignored
        
        make help on --port a little more clear
      ee7f125d
  10. 28 Aug, 2007 3 commits
    • unknown's avatar
      Streamline "do_close_connection" and "do_send_quit" · 2bb6a44a
      unknown authored
      Fix typo, "next_con" -> "con"
      
      
      client/mysqltest.c:
        Reuse "find_connection_by_name" both from "do_close_connection" and "do_send_quit"
        Adjust alignment of comment
        Fix typo in "do_close_connection", it used the global variable "next_con" instead
        of local variable "con"
      2bb6a44a
    • unknown's avatar
      Move "analyze_testcase_failure" to mysqltest(since it knows best when · 345c18e4
      unknown authored
      to perform this analyzis)
      
      
      client/mysqltest.c:
        Add function 'show_query' and use it to output some debug queries when
        "sync_with_master" has failed.
      mysql-test/mysql-test-run.pl:
        Move "analyze_testcase_failure" to mysqltest
      345c18e4
    • unknown's avatar
      Fix warning · 3a53dbba
      unknown authored
      3a53dbba
  11. 13 Aug, 2007 2 commits
    • unknown's avatar
      Improve error messages · 65fa527a
      unknown authored
      Write test results to var/log
      Add test for "source" and variable expansion
      
      
      client/mysqltest.c:
        Improve error messages
        Write .reject file to the location specified by --logdir
      mysql-test/mysql-test-run.pl:
        Pass logdir to mysqltest, to get test results written to var/log
      mysql-test/r/mysqltest.result:
        Update test results
      mysql-test/t/mysqltest.test:
        Add test for "source" and variable expansion
        Update test after writing result in var/log
      65fa527a
    • unknown's avatar
      Fixed a lot of compiler warnings and errors detected by Forte C++ on Solaris · 09a53f28
      unknown authored
      Faster thr_alarm()
      Added 'Opened_files' status variable to track calls to my_open()
      Don't give warnings when running mysql_install_db
      Added option --source-install to mysql_install_db
      
      I had to do the following renames() as used polymorphism didn't work with Forte compiler on 64 bit systems
      index_read()      -> index_read_map()
      index_read_idx()  -> index_read_idx_map()
      index_read_last() -> index_read_last_map()
      
      
      BUILD/compile-solaris-sparc-forte:
        Updated script to current Solaris installations
        Now we compile by default for 64 bits
      client/mysql.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      client/mysql_upgrade.c:
        Fixed compiler warning (on Forte)
      client/mysqladmin.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      client/mysqlcheck.c:
        Fixed compiler warning (on Forte)
      client/mysqldump.c:
        Fixed compiler warning (on Forte)
      client/mysqlslap.c:
        Fixed compiler warning (on Forte)
      client/mysqltest.c:
        Fixed compiler warning (on Forte)
      client/sql_string.cc:
        Avoid compiler warnings when using C function pointers in C++
      configure.in:
        Added detection of mtmalloc and ieeefp.h
      extra/replace.c:
        Fixed compiler warning (on Forte)
      include/m_ctype.h:
        Added some typedef's to make it easy to use C function pointers in C++
      include/my_sys.h:
        Added my_file_total_opened (counter for calls to my_open())
      include/myisam.h:
        Fixed compiler warning (on Forte)
      libmysql/libmysql.c:
        Fixed compiler warning (on Forte) by adding casts and change types
      libmysql/manager.c:
        Fixed compiler warning (on Forte) by adding casts and change types
      mysql-test/r/ctype_cp932_binlog_stm.result:
        Updated positions
        (Needed because we didn't before correctly restore collation_database after running stored procedure
      mysys/my_fopen.c:
        Count number of opened files
      mysys/my_open.c:
        Count number of opened files
      mysys/my_static.c:
        Count number of opened files
      mysys/thr_alarm.c:
        Optimization to do less alarm() and pthread_sigmask() calls.
        Idea is to remember time for next pending alarm and not reschedule a new alarm if it's after the current one.
        Before we only did this if there was other pending alarms.
        We don't have to use pthread_sigmask() in case of 'USE_ONE_SIGNAL_HAND' as the alarm()
        signal will be blocked for the calling thread anyway and no other thread will have the alarm() signal enabled to call process_alarm()
      regex/regcomp.c:
        Fixed compiler warning (on Forte) by adding casts and change types
      scripts/mysql_install_db.sh:
        Added option --source-install to allow one to create a mysql database from the source tree without installing MySQL
        Don't give (unnecessary) warnings
      server-tools/instance-manager/angel.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      server-tools/instance-manager/thread_registry.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/event_db_repository.cc:
        index_read() -> index_read_map()
      sql/event_queue.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/field.cc:
        Fixed compiler warnings about hidden fields
      sql/ha_partition.cc:
        Fixed compiler warnings about hidden fields
        index_read() -> index_read_map()
      sql/ha_partition.h:
        index_read() -> index_read_map()
      sql/handler.cc:
        Added PAGE option to row types (to prepare for future)
        index_read() -> index_read_map()
      sql/handler.h:
        Added ROW_TYPE_PAGE (for future)
        Added flag to signal if table was to be created transactionally
        I had to do the following renames() as used polymorphism didn't work with Forte compiler on 64 bit systems
        index_read()      -> index_read_map()
        index_read_idx()  -> index_read_idx_map()
        index_read_last() -> index_read_last_map()
      sql/item.cc:
        Fixed indentation
        Renamed local variable to avoid hiding class variable
      sql/item_cmpfunc.cc:
        Renamed local variable to avoid hiding class variable
      sql/item_cmpfunc.h:
        Removed not used variable
      sql/item_func.cc:
        Renamed local variable to avoid hiding class variable
      sql/item_strfunc.cc:
        Moved functions from Item_strfunc.cc
      sql/item_strfunc.h:
        Move functions to item_strfunc.cc
        Use C function pointer type to avoid compiler warnings (with Forte)
      sql/item_subselect.cc:
        index_read() -> index_read_map()
      sql/item_xmlfunc.cc:
        Renamed local variable to avoid hiding class variable
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/key.cc:
        Fixed indentation
      sql/log.cc:
        Renamed local variable to avoid hiding class variable
      sql/log_event.cc:
        Removed call to my_time() when creating class instance of Log_event() as this may have static instances.
        (One can't call my_time() before my_init())
        index_read() -> index_read_map()
        Renamed local variable to avoid hiding class variable
      sql/log_event_old.cc:
        Renamed local variable to avoid hiding class variable
      sql/mysql_priv.h:
        Made all create_backup_ctx() declarations identical.
        This lifted up a bug where wrong create_backup_ctx() was called in some cases.
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/mysqld.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
        Fixed indentation
        Don't call end_thr_alarm() when calling unireg_abort() as unireg_abort() already calls end_thr_alarm()
        Added variable 'Opened_files' (number of calls to my_open() or my_fopen())
        Don't print 'loose' warnings when using --bootstrap (to avoid warnings when running mysql_install_db)
        Fixed compiler warnings
      sql/opt_range.cc:
        index_read() -> index_read_map()
      sql/opt_sum.cc:
        index_read() -> index_read_map()
      sql/partition_info.cc:
        Renamed local variable to avoid hiding class variable
      sql/rpl_filter.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/set_var.cc:
        Renamed local variable to avoid hiding class variable
        Added 'process_key_cache_t' type to avoid compiler warning (on Forte)
      sql/set_var.h:
        Added 'process_key_cache_t' type to avoid compiler warning (on Forte)
      sql/sp.cc:
        More debugging
        index_read() -> index_read_map()
      sql/sp_cache.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/sp_head.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
        Moved 'saved_creation_ctx' higher up to be able to free objects allocated by create_backup_ctx()
      sql/sql_acl.cc:
        index_read() -> index_read_map()
      sql/sql_class.cc:
        Renamed local variable to avoid hiding class variable
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/sql_class.h:
        Renamed local variable to avoid hiding class variable
      sql/sql_db.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      sql/sql_delete.cc:
        Renamed local variable to avoid hiding class variable
      sql/sql_handler.cc:
        index_read() -> index_read_map()
      sql/sql_help.cc:
        index_read() -> index_read_map()
      sql/sql_insert.cc:
        index_read() -> index_read_map()
        Renamed local variable to avoid hiding class variable
      sql/sql_lex.cc:
        Renamed local variable to avoid hiding class variable
      sql/sql_plugin.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
        index_read() -> index_read_map()
        Don't give warnings about not used plugins if we are using --warnings=0
      sql/sql_select.cc:
        index_read() -> index_read_map()
      sql-common/client.c:
        Fixed compiler warning (on Forte)
      sql-common/my_time.c:
        Removed never accessed code
        Fixed compiler warning (on Forte)
      sql/sql_servers.cc:
        index_read() -> index_read_map()
      sql/sql_show.cc:
        Added TRANSACTIONAL to SHOW CREATE
        Fixed ROW_TYPE_PAGE
      sql/sql_string.cc:
        Avoid compiler warnings when using C function pointers in C++
      sql/sql_table.cc:
        Set create_info->transactional if we used TRANSACTIONAL=1
      sql/sql_udf.cc:
        index_read() -> index_read_map()
      sql/sql_yacc.yy:
        Added TRANSACTIONAL=0|1 to CREATE (for future)
        Added row type PAGE (was only partionally handled before)
      sql/strfunc.cc:
        Avoid compiler warnings when using C function pointers in C++
      sql/table.cc:
        More DBUG statements
        Declare all create_backup_ctx() functions identically
        Remember if table was created with TRANSACTIONAL flag or not (future safe)
        Renamed local variable to avoid hiding class variable
      sql/table.h:
        Remember if table was created with TRANSACTIONAL=1
      sql/tztime.cc:
        index_read() -> index_read_map()
      sql-common/pack.c:
        Fixed compiler warning (on Forte)
      storage/archive/archive_reader.c:
        Fixed compiler warning (on Forte)
      storage/archive/azio.c:
        Fixed compiler warning (on Forte)
      storage/blackhole/ha_blackhole.cc:
        index_read() -> index_read_map()
      storage/blackhole/ha_blackhole.h:
        index_read() -> index_read_map()
      storage/csv/ha_tina.cc:
        Declare functions sent to C code with extern "C" to avoid compiler warnings (on Forte)
      storage/example/ha_example.cc:
        index_read() -> index_read_map()
      storage/example/ha_example.h:
        index_read() -> index_read_map()
      storage/heap/ha_heap.cc:
        index_read() -> index_read_map()
      storage/heap/ha_heap.h:
        index_read() -> index_read_map()
      storage/heap/hp_test1.c:
        Fixed compiler warning (on Forte)
      storage/heap/hp_test2.c:
        Fixed compiler warning (on Forte)
      storage/myisam/ft_boolean_search.c:
        Fixed compiler warning (on Forte)
      storage/myisam/ft_nlq_search.c:
        Fixed compiler warning (on Forte)
      storage/myisam/ft_parser.c:
        Fixed compiler warning (on Forte)
      storage/myisam/ft_stopwords.c:
        Fixed compiler warning (on Forte)
      storage/myisam/ha_myisam.cc:
        index_read() -> index_read_map()
      storage/myisam/ha_myisam.h:
        index_read() -> index_read_map()
      storage/myisam/mi_check.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_delete.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_dynrec.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_extra.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_key.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_keycache.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_locking.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_log.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_open.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_packrec.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_page.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_rkey.c:
        Added comment
      storage/myisam/mi_search.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_statrec.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_test1.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_test2.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_test3.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_update.c:
        Fixed compiler warning (on Forte)
      storage/myisam/mi_write.c:
        Fixed compiler warning (on Forte)
      storage/myisam/myisamdef.h:
        Fixed that file_read/file_write returns type size_t
        Changed some functions to use uchar * as argument/return value instead of char*
        This fixed some compiler warnings on Forte
      storage/myisam/myisamlog.c:
        Fixed compiler warning (on Forte)
      storage/myisam/myisampack.c:
        Fixed compiler warning (on Forte)
      storage/myisam/rt_test.c:
        Fixed compiler warning (on Forte)
      storage/myisam/sort.c:
        Fixed compiler warning (on Forte) by adding casts or changing variables to uchar*
      storage/myisam/sp_test.c:
        Fixed compiler warning (on Forte) by adding casts or changing variables to uchar*
      storage/myisammrg/ha_myisammrg.cc:
        index_read() -> index_read_map()
      storage/myisammrg/ha_myisammrg.h:
        index_read() -> index_read_map()
      storage/myisammrg/myrg_create.c:
        Fixed compiler warning (on Forte) by adding casts or changing variable types
      storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        Tdummy -> align  (as in other part of cluster code)
      storage/ndb/src/kernel/vm/DynArr256.cpp:
        Removed not used variable
      storage/ndb/src/ndbapi/Ndb.cpp:
        Removed not used variable
      strings/strtod.c:
        Include ieeefp.h to avoid compiler warning
      tests/bug25714.c:
        Fixed compiler warning
      tests/mysql_client_test.c:
        Remove not used variable
        Fixed indentation
        Removed never reached code
        Fixed compiler warning (on Forte) by adding casts or changing variable types
      vio/viosocket.c:
        Fixed compiler warning (on Forte) by adding casts or changing variable types
      09a53f28
  12. 08 Aug, 2007 4 commits
  13. 07 Aug, 2007 2 commits
    • unknown's avatar
      Bug#29547 mysql-test-run to retrieve warnings for failed command · c35318ce
      unknown authored
       - Run "SHOW WARNINGS" when mysqltest fails and display all but the
         last warning(since it's the same as "last error") on stderr
       - Fix typo
      
      
      client/mysqltest.c:
        - Display any warnings produced prior to the error that caused
        mysqltest to die.
        - Fix typo "cur_con" -> "con_slot"
        - Move initialization of the "cur_con" pointer to just before it's
          initialized  so it can be used to check if a connection to mysql
          exist.
      c35318ce
    • unknown's avatar
      Bug#20037 mysqltest requires cygwin on windows(part 1, new mysqltest commands) · 04e8c93c
      unknown authored
       - Update comments
       - Make "write_file" fail if file already exist
       - Remove temporary files created by test cases
      
      
      client/mysqltest.c:
        Improve function comments
        Make write_file fail if file already exist
      mysql-test/r/mysqltest.result:
        Update test result after adding new test and updating description
        of argumements to chmod
      mysql-test/t/bootstrap.test:
        Remove temporary file created by testcase
      mysql-test/t/mysql.test:
        Remove temporary file created by testcase
      mysql-test/t/mysqladmin.test:
        Remove temporary file created by testcase
      mysql-test/t/mysqltest.test:
        Remove temporary file created by testcase 
        Add test to show that "write_file" fails if file already exist
      mysql-test/t/sp-destruct.test:
        Remove temporary file created by testcase
      04e8c93c
  14. 06 Aug, 2007 3 commits
    • unknown's avatar
      Add missing ' · 275a8030
      unknown authored
      Extend buffer size to allow for longer log messages
      
      
      275a8030
    • unknown's avatar
      Remove NOT_YET code · 050256c2
      unknown authored
      Update comments
      Add more tests for "let from query"
      
      
      client/mysqltest.c:
        Remove NOT_YET code
        Update comments
      mysql-test/r/mysqltest.result:
        Add more tests for "let from query"
      mysql-test/t/mysqltest.test:
        Add more tests for "let from query"
      050256c2
    • unknown's avatar
      Fix spelling errors · 135b5863
      unknown authored
      135b5863
  15. 03 Aug, 2007 3 commits
    • unknown's avatar
      841ae673
    • unknown's avatar
    • unknown's avatar
      WL#3935 Improve mysqltest report and exitcode for diff · 2cedc54d
      unknown authored
       - Move the code to generate test report to the test tool(in this
         case mysqltest) where the best control of what failed is
      - Simplify the code in mysql-test-run.pl
      - mysqltest will now find what diff to use in a best effort attempt
        using "diff -u", "diff -c" and finally dumping the two files verbatim
        in the report.
      
      
      client/mysqltest.c:
        - Add new option --tail-lines indicating how many lines of the result to output
          when generating report for a failure
        - Remove eval_result, noone knows what it should do and it's not used.
        - Add support for best effort execution of systems builtin "diff",
          try with "diff -u" and "diff -c" and if that fails dump the whole content
           of teh two files to report
        - Use one common function when comapring two files, used when test 
          has completed and the result should be compared to the .result file
          as well as using it from myqltest's builtin diff_files command.
        - Output the last lines og the result so far  in the report that mysqltest
          generates in case of a test failure.
      mysql-test/lib/mtr_report.pl:
        - Remove code for generating diff between .reject and .result file,
          that is handled by mysqltest(or the test tool) from now on.
        - Add better comments
      mysql-test/mysql-test-run.pl:
        - Remove the --udiff flag to mysql-test-run.pl, if the systems diff supports
          unified diff it will be used automatically
        - Remove the code for "mtr_show_failed_diff", the report from mysqltest
          will know include the diff so if mysqltest(or another test tool)
          fails, just display it's report what went wrong
        - Pass --tail-lines=20 to mysqltest to it will shos the last 20 lines 
          from the result in the report in case of failure.	
      mysql-test/r/mysqltest.result:
        Update result file now when the output from mysqltest has been sent to /dev/null
      mysql-test/t/mysqltest.test:
        - Improve tests for --diff_files
        - Remove temporary files in var/tmp generated in the fly
        - Send output from test for --diff_files to /deb/null since only the error
          code it returns are of interest and tyhe outpu may vary depending
          on what builtin diff is being used.
      2cedc54d
  16. 02 Aug, 2007 1 commit
    • unknown's avatar
      Set --debug-check if one uses DBUG_PUSH in all clients · f9ea4275
      unknown authored
      Fixed bug in query cache that made it impossible to run mysqld with --debug
      Fixed memory leaks in mysqldump and mysqltest
      Memory leaks associated with wrong usage of mysqltest is not fixed. To find these, run
      mysql-test-run --debug mysqltest
      
      
      client/mysql_upgrade.c:
        Set --debug-check if one uses DBUG_PUSH
      client/mysqlcheck.c:
        Set --debug-check if one uses DBUG_PUSH
      client/mysqldump.c:
        Set --debug-check if one uses DBUG_PUSH
        Fixed several memory leaks
      client/mysqlimport.c:
        Set --debug-check if one uses DBUG_PUSH
      client/mysqlshow.c:
        Set --debug-check if one uses DBUG_PUSH
      client/mysqlslap.c:
        Set --debug-check if one uses DBUG_PUSH
      client/mysqltest.c:
        Set --debug-check if one uses DBUG_PUSH
        Fixed some memory leaks
        Removed MY_CHECK_ERROR argument to my_end() as mysqltest.test otherwise shows MANY memory leaks
      dbug/dbug.c:
        Fixed compiler warning
        Force flush of out_file on end
        Removed some wrong dbug_flush(0) commands that could cause crashes
      mysys/my_init.c:
        Don't write memory usage if MY_GIVE_INFO is not given
      sql/sql_cache.cc:
        Fixed bug in query cache that made it impossible to run mysqld with --debug
      f9ea4275
  17. 01 Aug, 2007 1 commit
    • unknown's avatar
      Fixes Bug#30127: --debug-info no longer prints memory usage in mysql · 0c9a3e59
      unknown authored
      Fixed compiler warnings, errors and link errors
      Fixed new bug on Solaris with gethrtime()
      Added --debug-check option to all mysql clients to print errors and memory leaks
      Added --debug-info to all clients. This now works as --debug-check but also prints memory and cpu usage
      
      
      BUILD/compile-solaris-sparc-debug:
        Remove old cpu options
      client/client_priv.h:
        Added OPT_DBUG_CHECK
      client/mysql.cc:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysql_upgrade.c:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqladmin.cc:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqlbinlog.cc:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqlcheck.c:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqldump.c:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqlimport.c:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqlshow.c:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqlslap.c:
        --debug-info now prints memory usage 
        Added --debug-check
      client/mysqltest.c:
        --debug-info now prints memory usage 
        Added --debug-check
      include/my_sys.h:
        Added extra option to TERMINATE to not print statistics
      libmysql/libmysql.c:
        Fixed compiler warning
      mysql-test/mysql-test-run.pl:
        --debug-info -> --debug-check to not print memory usage
      mysys/my_getsystime.c:
        Moved fast time calculation to my_micro_time_and_time()
        Fixed bug in previous push related to HAVE_GETHRTIME
      mysys/my_init.c:
        Print not freed memory in my_end() if MY_CHECK_ERROR is given
      mysys/my_static.c:
        Cleanup
      mysys/safemalloc.c:
        Added extra option to TERMINATE to not print statistics
      sql/item_xmlfunc.cc:
        Fixed compiler warning
      sql/sql_test.cc:
        Fixed TERMINATE() call
      unittest/mysys/base64-t.c:
        Fixed link error
      unittest/mysys/bitmap-t.c:
        Fixed link error
      unittest/mysys/my_atomic-t.c:
        Fixed link error
      0c9a3e59
  18. 13 Jul, 2007 2 commits
    • unknown's avatar
      When opening a new connecgtion, changed mysqltest to prefer a brand new... · d3d38d0b
      unknown authored
      When opening a new connecgtion, changed mysqltest to prefer a brand new connection slot over an existing, closed slot. Fixes a problem with reused slots that can cause tests to fail. bug#29579
      
      
      client/mysqltest.c:
        When opening a new connecgtion, changed mysqltest to prefer a brand new connection slot over an existing, closed slot. Fixes a problem with reused slots that can cause tests to fail.
      d3d38d0b
    • unknown's avatar
      Bug #29579 Clients using SSL can hang the server · b7527f6b
      unknown authored
      Added an option to yassl to allow "quiet shutdown" like openssl does. This option causes the SSL libs to NOT perform the close_notify handshake during shutdown. This fixes a hang we experience because we hold a lock during socket shutdown.
      
      
      mysql-test/t/ssl_big.test:
        BitKeeper file /Users/dkatz/50/mysql-test/t/ssl_big.test
      mysql-test/r/ssl-big.result:
        BitKeeper file /Users/dkatz/50/mysql-test/r/ssl-big.result
      client/mysqltest.c:
        Added new command to mysqltest to send a quit command to the server, but to not close the actual socket on our end.
        
        Also changed code to reuse connection slots, so that the tests can open and close sockets in a loop.
      extra/yassl/include/openssl/ssl.h:
        Added C accessors to the quietShutdown option.
      extra/yassl/include/yassl_int.hpp:
        Added quietShutdown_ member and accessor methods to the SSL class.
      extra/yassl/src/ssl.cpp:
        Added accessors to get/set the quietShutdown option and to not perform the shutdown handshake if quietShutdown is set.
      extra/yassl/src/yassl_int.cpp:
        Added quietShutdown_ member and accessor methods to the SSL class.
      vio/viossl.c:
        Added line to set the quiet_shutdown option before shutting down the socket.
      mysql-test/t/ssl-big.test:
        Added a test that causes an unpatched server to hang during SSL socket shutdown.
      b7527f6b
  19. 08 Jun, 2007 1 commit
    • unknown's avatar
      Bug #28333 Test "flush" tries to create a new thread - on only one platform · 99b4321a
      unknown authored
      on PPC/Debian Linux default stack size for a thread is too big.
      As we use default thread settings in mysqltest, the
      thread creation fails if we create lots of threads (as it
      happens in flush.test). So now stack size is explicitly specified
      for the mysqltest
      
      
      client/mysqltest.c:
        Bug #28333 Test "flush" tries to create a new thread - on only one platform
        
        specify appropriate stack size for the 'query' thread
      99b4321a
  20. 01 Jun, 2007 2 commits
  21. 31 May, 2007 1 commit
    • unknown's avatar
      Added casts to avoid compiler warnings and fixed a wrong type. · c6ff8a65
      unknown authored
      ```yaml
      Added casts and fixed wrong type.
      ```
      
      Added casts and fixed wrong type.
      ---
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.1-marvel
      into  a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-5.1-marvel
      ---
      Don't give warning that readonly variable is forced to be readonly
      mysql-test-run run now fails if we have [Warning] and [ERROR] as tags in .err file
      Fixed wrong reference to the mysql manual
      Fixed wrong prototype that caused some tests to fail on 64 bit platforms
      ---
      Disabled compiler warnings mainly for Win 64.
      ---
      Added casts to remove compiler warnings on windows
      Give warnings also for safe_mutex errors found by test system
      Added some warnings from different machines in pushbuild
      ---
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-marvel
      into  mysql.com:/home/my/mysql-5.1
      ---
      Added escapes for double quotes and parenthesis.
      ---
      Archive db fix plus added non-critical warnings
      in ignore list.
      ---
      Fixed previously added patch and added new ignored warning.
      
      
      client/mysqltest.c:
        Added casts to avoid compiler warnings.
        ---
        Added casts to avoid compiler warnings.
      mysql-test/lib/mtr_report.pl:
        Test run now fails if we have [Warning] and [ERROR] as tags in .err file
        Added list of all common 'not fatal' errors to ignore error list
        ---
        Give warnings also for safe_mutex errors
        Added some warnings from different machines in pushbuild
        ---
        Added escapes for double quotes and parenthesis.
        ---
        Added non-critical warnings to be ignored.
        ---
        Fixed a wrong regexp
        Added new non-critical warning
      mysql-test/mysql-test-run-shell.sh:
        Fixed some wrong startup options
      mysql-test/r/func_misc.result:
        Test case for archive db fix.
      mysql-test/t/disabled.def:
        Disable instance manager tests because they generate warnings (and probably don't read the option files correctly)
      mysql-test/t/func_misc.test:
        Test case for archive db fix.
      mysys/array.c:
        Added casts to avoid compiler warnings.
      mysys/hash.c:
        Added casts to avoid compiler warnings.
      mysys/my_compress.c:
        Added casts to remove compiler warnings on windows
      mysys/my_conio.c:
        To avoid a warning from compiler.
      mysys/my_pread.c:
        Archive db fix.
      mysys/my_quick.c:
        Added cast to avoid compiler warning.
        ---
        Added cast to avoid compiler warning.
      sql/ha_ndbcluster_binlog.cc:
        Ensure we log all binglog errors with the "NDB Binlog" tag
      sql/ha_partition.cc:
        result is type bool, so calculation should be forced to
        that also.
      sql/log.cc:
        Fixed compiler problem on Solaris.
      sql/slave.cc:
        Make errors uniform
      sql/sql_class.cc:
        Added cast to remove compiler warnings on windows
      sql/sql_map.cc:
        Added casts to avoid compiler warnings.
        ---
        Added casts to avoid compiler warnings.
      sql/sql_plugin.cc:
        Fixed wrong type.
        ---
        Don't give warning that readonly variable is forced to be readonly
      sql/stacktrace.c:
        Corrected manual reference
      storage/archive/azio.c:
        Archive db fix.
        ---
        Fixed previously added patch.
      storage/blackhole/ha_blackhole.cc:
        Fixed wrong prototype that caused test to fail on 64 bit platforms
      storage/example/ha_example.cc:
        Fixed wrong prototype that caused test to fail on 64 bit platforms
      strings/ctype-ucs2.c:
        Fixed wrong type.
        ---
        Fixed wrong type.
      support-files/compiler_warnings.supp:
        Added new disabled warnings for Win 64.
      c6ff8a65
  22. 29 May, 2007 2 commits
    • unknown's avatar
      Added casts and fixed wrong type. · 7a432ea4
      unknown authored
      client/mysqltest.c:
        Added casts to avoid compiler warnings.
      mysys/my_quick.c:
        Added cast to avoid compiler warning.
      sql/log.cc:
        Fixed compiler problem on Solaris.
      sql/sql_map.cc:
        Added casts to avoid compiler warnings.
      strings/ctype-ucs2.c:
        Fixed wrong type.
      7a432ea4
    • unknown's avatar
      Added casts and fixed wrong type. · 44c169f2
      unknown authored
      client/mysqltest.c:
        Added casts to avoid compiler warnings.
      mysys/my_quick.c:
        Added cast to avoid compiler warning.
      sql/sql_map.cc:
        Added casts to avoid compiler warnings.
      strings/ctype-ucs2.c:
        Fixed wrong type.
      44c169f2
  23. 28 May, 2007 1 commit
    • unknown's avatar
      Changed accidently added tabs back into spaces. · 64a82941
      unknown authored
      Fixed a bug that came in merge.
      
      
      client/mysqltest.c:
        Changed accidently added tabs back into spaces.
      mysys/array.c:
        Changed accidently added tabs back into spaces.
      sql/set_var.cc:
        Changed accidently added tabs back into spaces.
      sql/sql_insert.cc:
        Removed accidently included line in merge.
      sql/sql_yacc.yy:
        Changed accidently added tabs back into spaces.
      64a82941
  24. 18 May, 2007 1 commit
    • unknown's avatar
      WL#2247 mysqltest: add option for sorting results · 421d8ca9
      unknown authored
       - Final touchups
      
      
      client/mysqltest.c:
        Final touch ups, rename sorted_results to sorted_result
      mysql-test/r/mysqltest.result:
        Update test result
      mysql-test/t/mysqltest.test:
        Update results with additional subtests for empty result set,
        NULL values and 1024 rows
      421d8ca9
  25. 16 May, 2007 1 commit
    • unknown's avatar
      WL#2247 mysqltest: add option for sorting results · 61413522
      unknown authored
       - Change from "query_sorted <query>" to "sorted_results"
      
      
      client/mysqltest.c:
        Replace "query_sorted <query>" with the ability to turn
        on "one shot result sorting" with the command "sorted_results"
      mysql-test/r/mysqltest.result:
        Update test and result
      mysql-test/t/mysqltest.test:
        Update test and result
      61413522