An error occurred fetching the project authors.
  1. 20 Aug, 2004 2 commits
    • konstantin@mysql.com's avatar
      Fix for bug#4912 "mysqld crashs in case a statement is executed · 568c6e85
      konstantin@mysql.com authored
       a second time". The bug was caused by incompatibility of
      negations elimination algorithm and PS: during first statement 
      execute a subtree with negation was replaced with equivalent 
      subtree without NOTs.
      The problem was that although this transformation was permanent, 
      items of the new subtree were created in execute-local memory.
      The patch adds means to check if it is the first execute of a
      prepared statement, and if this is the case, to allocate items
      in memory of the prepared statement.
      The implementation:
      - backports Item_arena from 5.0
      - adds Item_arena::is_stmt_prepare(), 
        Item_arena::is_first_stmt_execute().
      - deletes THD::allocate_temporary_pool_for_ps_preparing(),
        THD::free_temporary_pool_for_ps_preparing(); they
        were redundant.
      and adds a few invariants:
      - thd->free_list never contains junk (= freed items)
      - thd->current_arena is never null. If there is no
        prepared statement, it points at the thd. 
      The rest of the patch contains mainly mechanical changes and
      cleanups.
      568c6e85
    • guilhem@mysql.com's avatar
      Making FLUSH TABLES WITH READ LOCK block COMMITs of existing transactions, · 5db56a10
      guilhem@mysql.com authored
      in a deadlock-free manner. This splits locking the global read lock in two steps.
      This fixes a consequence of this bug, known as:
      BUG#4953 'mysqldump --master-data may report incorrect binlog position if using InnoDB'
      And a test.
      5db56a10
  2. 19 Aug, 2004 2 commits
    • guilhem@mysql.com's avatar
      (manual port from 4.0 - was needed) · 0db5b4d2
      guilhem@mysql.com authored
      Fix for BUG#4971 "CREATE TABLE ... TYPE=HEAP SELECT ... stops slave (wrong DELETE in binlog)":
      replacing the no_log argument of mysql_create_table() by some safer method
      (temporarily setting OPTION_BIN_LOG to 0) which guarantees that even the automatic
      DELETE FROM heap_table does not get into the binlog when a not-yet-existing HEAP table
      is opened by mysql_create_table().
      0db5b4d2
    • rburnett@build.mysql.com's avatar
      This fixes a Windows build failure. How did this build on Linux? · d3e6b5c3
      rburnett@build.mysql.com authored
      logging_ok:
        Logging to logging@openlogging.org accepted
      mysql_priv.h, my_time.h:
        Moved declaration of days_in_month array from mysql_priv.h to my_time.h to correct Windows build issues
      d3e6b5c3
  3. 18 Aug, 2004 1 commit
  4. 13 Aug, 2004 2 commits
  5. 10 Aug, 2004 1 commit
  6. 29 Jul, 2004 1 commit
    • guilhem@mysql.com's avatar
      WL#1580: --start-datetime, --stop-datetime, --start-position (alias for... · 0f3e279a
      guilhem@mysql.com authored
      WL#1580: --start-datetime, --stop-datetime, --start-position (alias for --position) and --stop-position
      options for mysqlbinlog, with a test file.
      This enables user to say "recover my database to how it was this morning at 10:30"
      (mysqlbinlog "--stop-datetime=2003-07-29 10:30:00").
      Using time functions into client/ made me move them out of sql/ into sql-common/.
      + (small) fix for BUG#4507 "mysqlbinlog --read-from-remote-server sometimes
      cannot accept 2 binlogs" (that is, on command line).
      0f3e279a
  7. 21 Jul, 2004 1 commit
  8. 10 Jul, 2004 1 commit
  9. 09 Jul, 2004 1 commit
  10. 08 Jul, 2004 1 commit
  11. 25 Jun, 2004 1 commit
  12. 24 Jun, 2004 3 commits
    • konstantin@mysql.com's avatar
      Fix for Bug#4030 "Client side conversion string -> date type doesn't · a30fcdc6
      konstantin@mysql.com authored
      work (prepared statements)" and after-review fixes:
      - str_to_TIME renamed to str_to_datetime to pair with str_to_time
      - functions str_to_time and str_to_TIME moved to sql-common
      - send_data_str now supports MYSQL_TYPE_TIME, MYSQL_TIME_DATE,
        MYSQL_TIME_DATETIME types of user input buffers.
      - few more comments in the client library
      - a test case added.
      a30fcdc6
    • ingo@mysql.com's avatar
      bug#3565 - HANDLER and FLUSH TABLE/TABLES deadlock. · 18cd61d0
      ingo@mysql.com authored
      Redesigned the handler close functions so that they are usable
      at different places where waiting for closing tables is done.
      18cd61d0
    • guilhem@mysql.com's avatar
      Final part of WL#1717 "innodb/binlog consistency". This is to resolve · 4a82bd47
      guilhem@mysql.com authored
      a limitation of yesterday's implementation:
      if there was an unfinished transaction (COMMIT not typed), and some MyISAM tables were
      then updated, and then mysqld crashes, then at restart the server would use the too old
      binlog offset known by InnoDB to cut the binlog, thus cutting the successful MyISAM
      updates. We fix this by reporting the binlog offset into InnoDB even if InnoDB was not
      affected at all by the update.
      But the feature is still disabled until we decide if it can go into 4.1.3.
      4a82bd47
  13. 20 Jun, 2004 1 commit
    • guilhem@mysql.com's avatar
      Robustness feature. · f5d64244
      guilhem@mysql.com authored
      Won't be pushed as is - separate email sent for internal review.
      WL#1717 "binlog-innodb consistency".
      Now when mysqld starts, if InnoDB does a crash recovery, we use the binlog name
      and position retrieved from InnoDB (corresponding to the last transaction
      successfully committed by InnoDB) to cut any rolled back transaction from
      the binary log. This is triggered by the --innodb-safe-binlog option.
      Provided you configure mysqld to fsync() InnoDB at every commit (using
      flush_log_at_trx_commit) and to fsync() the binlog at every write
      (using --sync-binlog=1), this behaviour guarantees that a master always has
      consistency between binlog and InnoDB, whenever the crash happens.
      6 tests to verify that it works.
      f5d64244
  14. 18 Jun, 2004 1 commit
    • dlenev@brandersnatch.localdomain's avatar
      WL#1264 "Per-thread time zone support infrastructure". · 09ba29e5
      dlenev@brandersnatch.localdomain authored
      Added basic per-thread time zone functionality (based on public
      domain elsie-code). Now user can select current time zone
      (from the list of time zones described in system tables).
      All NOW-like functions honor this time zone, values of TIMESTAMP
      type are interpreted as values in this time zone, so now
      our TIMESTAMP type behaves similar to Oracle's TIMESTAMP WITH
      LOCAL TIME ZONE (or proper PostgresSQL type).
        
      WL#1266 "CONVERT_TZ() - basic time with time zone conversion 
      function".
        
      Fixed problems described in Bug #2336 (Different number of warnings 
      when inserting bad datetime as string or as number). This required
      reworking of datetime realted warning hadling (they now generated 
      at Field object level not in conversion functions).
        
      Optimization: Now Field class descendants use table->in_use member
      instead of current_thd macro.
      09ba29e5
  15. 10 Jun, 2004 3 commits
  16. 07 Jun, 2004 1 commit
  17. 01 Jun, 2004 1 commit
  18. 27 May, 2004 1 commit
  19. 24 May, 2004 1 commit
  20. 22 May, 2004 1 commit
  21. 21 May, 2004 2 commits
  22. 19 May, 2004 1 commit
  23. 16 May, 2004 1 commit
    • monty@mishka.local's avatar
      key_cmp -> key_cmp_if_same · 314a8bf1
      monty@mishka.local authored
      New records_in_range() interface (similar to read_range())
      Macros for faster bitmap handling
      Simplify read_range() code (#WL1786)
      New general key_cmp() function to compare keys
      
      314a8bf1
  24. 28 Apr, 2004 1 commit
    • monty@mysql.com's avatar
      Fixed http address in some scripts (Bug #3460) · f10d098f
      monty@mysql.com authored
      Output TIMESTAMP in 4.1 format for 4.1 tables (or for TIMESTAMP(19)) (portability fix)
      Fixed that INTERVAL can handle big integers. (Bug #3498)
      Fixed that hostname="" works identical as hostname="%" for table/column grants (Bug #3473)
      f10d098f
  25. 15 Apr, 2004 1 commit
  26. 13 Apr, 2004 1 commit
  27. 12 Apr, 2004 1 commit
    • sergefp@mysql.com's avatar
      WL#1622 "SQL Syntax for Prepared Statements": post-review fixes: · a314cbef
      sergefp@mysql.com authored
        Moved PS name to Statement class, Statement_map now handles name-to-statement resolution.
        Both named and unnamed statements are now executed in one function (sql_prepare.cc:execute_stmt)
        Fixed a problem: Malformed sequence of commands from client could cause server to use previously deleted objects.
        Some code cleanup and small fixes
      a314cbef
  28. 09 Apr, 2004 1 commit
  29. 08 Apr, 2004 1 commit
  30. 07 Apr, 2004 2 commits
    • bell@sanja.is.com.ua's avatar
      new error for unsupported command in PS · 5e37c41f
      bell@sanja.is.com.ua authored
      fixed IN subselect with basic constant left expression
      SQLCOM_CREATE_TABLE, SQLCOM_UPDATE_MULTI, SQLCOM_REPLACE_SELECT, SQLCOM_INSERT_SELECT, QLCOM_DELETE_MULTI fixed to be compatible with PS (BUG#3398, BUG#3406)
      fixed multiupdate privelege check (BUG#3408)
      fixed multiupdate tables check (BUG#3411)
      unchecked commands now is rejected by PS protocol to avoid serever crash
      fixed cleunup procedure to be compatible sith DO/SET (BUG#3393)
      5e37c41f
    • serg@serg.mylan's avatar
      78991587
  31. 05 Apr, 2004 1 commit
    • sergefp@mysql.com's avatar
      Many files: · a8386d01
      sergefp@mysql.com authored
        SQL Syntax for Prepared Statements (WL#1622)
      ps.test, ps.result:
        new file
      a8386d01