- 17 Mar, 2014 1 commit
-
-
Alexey Botchkov authored
Notifications about changed variables: server_audit_file_rotate_now server_audit_file_rotations server_audit_file_rotations are now handled and one doesn't need to stop/start logging to make them effective.
-
- 14 Mar, 2014 1 commit
-
-
Michael Widenius authored
Reason for the bug was an optimization for higher connect speed where we moved when global status was updated, but forgot to update states when slave thread dies. Fixed by adding thd->add_status_to_global() before deleting slave thread's thd. mysys/my_delete.c: Added missing newline sql/mysqld.cc: Use add_status_to_global() sql/slave.cc: Added missing add_status_to_global() sql/sql_class.cc: Use add_status_to_global() sql/sql_class.h: Simplify adding local status to global by adding add_status_to_global()
-
- 13 Feb, 2014 1 commit
-
-
Sergey Vojtovich authored
Pre-MDL versions had direct relationship between LOCK_open and LOCK_global_system_variables, e.g.: intern_sys_var_ptr // locks LOCK_global_system_variable mysql_sys_var_char create_options_are_valid ha_innobase::create handler::ha_create ha_create_table rea_create_table mysql_create_table_no_lock // locks LOCK_open mysql_create_table With MDL this relationship was removed, but mutex order was still recorded. In fact there is indirect relationship between LOCK_open and LOCK_global_system_variables via rwlocks in reverse order. Removed LOCK_open and LOCK_global_system_variables order recording, instead assert that LOCK_open is never held in intern_sys_var_ptr(). This solves only one of many problems detected with MDEV-5089.
-
- 11 Mar, 2014 5 commits
-
-
Sergey Petrunya authored
- There was List<N>::nth_element() but it didn't work because linker removed it. - Now, removal by linker is prevented for important values of T, and function is renamed.
-
Sergey Petrunya authored
-
Sergey Petrunya authored
(This is attempt at fix #2) (re-commit with fixed typo) - Moved the testcase from partition_test to partition_innodb.test where it can really work. - Made ordered index scans over ha_partition tables to satisfy ROR property for the case where underlying table uses extended keys.
-
Michael Widenius authored
-
Michael Widenius authored
extra/replace.c: Removed compiler warning sql/unireg.cc: Removed compiler warning storage/maria/ma_blockrec.c: Removed compiler warning storage/maria/ma_dynrec.c: Fixed compiler failure storage/maria/ma_unique.c: Removed compiler warning storage/myisam/mi_check.c: Removed compiler warning storage/myisam/mi_checksum.c: Removed compiler warning
-
- 10 Mar, 2014 1 commit
-
-
Michael Widenius authored
Fixed MDEV-5724 "Server crashes on SQL select containing more group by and left join statements using innodb tables" The problem was that a big record was allocated on the stack, which casued stack to run out. Fixed by using my_safe_alloca() instead of my_alloca() when allocating records. Now only records <= 16384 are allocated on the stack. mysql-test/r/stack-crash.result: Added test case mysql-test/t/stack-crash.test: Added test case storage/maria/ma_blockrec.c: Use my_safe_alloca() instead of my_alloca() storage/maria/ma_dynrec.c: Use my_safe_alloca() instead of my_alloca() storage/maria/maria_def.h: Added MARIA_MAX_RECORD_ON_STACK storage/maria/maria_pack.c: Use my_safe_alloca() instead of my_alloca()
-
- 04 Mar, 2014 2 commits
-
-
unknown authored
Patch from Tomas Matejicek Add missing error code to is_networ_error(), to allow slave to automatically attempt reconnection also in this case.
-
Sergey Petrunya authored
- MariaDB-5.5 part of the fix: since we can't easily fix query optimization for I_S tables, run the affected-tablespaces query with semijoin=off. It happens to have a good query plan with that setting.
-
- 27 Feb, 2014 2 commits
-
-
Alexey Botchkov authored
-
Alexey Botchkov authored
That error 'Can't open the pid file' leads to mysqld crash signal 11 in mysql_audit_general() called with the 'thd' parameter set to NULL. That wasn't checked when the thd->db and thd->db_length were accessed. Fixed by checking for the NULL thd.
-
- 26 Feb, 2014 3 commits
-
-
Elena Stepanova authored
-
Jan Lindström authored
file storage. Analysis: posix_fallocate was called using 0 as offset and len as desired size. This is not optimal for SSDs. Fix: Call posix_fallocate with correct offset i.e. current file size and extend the file from there len bytes.
-
Jan Lindström authored
on debug build when innodb_use_fallocate=1 Analysis: There was merge error that caused additional call to fil_node_complete_io. Fixed by removing incorrect call and fixed calculation of extended file size.
-
- 24 Feb, 2014 1 commit
-
-
Alexey Botchkov authored
-
- 22 Feb, 2014 1 commit
-
-
Sergei Golubchik authored
-
- 21 Feb, 2014 2 commits
-
-
Sergei Golubchik authored
-
Igor Babaev authored
update_used_tables for the the where condition to update cached indicators of constant subexpressions. It should be done before further possible simplification of the where condition. This change caused simplification of the executed where conditions in many test cases.
-
- 20 Feb, 2014 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
In ::position() federated needs to know an element before the current ("data_cursor") in the single-linked list. Replace list traversal for every ::position() call (which is O(n^2)) with remembering the current element before it's advanced by mysql_fetch_row(). storage/federatedx/federatedx_io_mysql.cc: mdev:5698
-
- 19 Feb, 2014 9 commits
-
-
Sergei Golubchik authored
Use 20-year ssl certificates for mysql-test from RedHat patch
-
Sergei Golubchik authored
On fedora: 1. provide/obsoleve mariadb-* packages 2. MariaDB-common conflicts with mariadb-libs (on filesystem level), but does not provide or obsolete it.
-
Sergei Golubchik authored
* readability fixes * CPackRPM wrapper to fix property leakage between components (cmake bug 13248)
-
Sergei Golubchik authored
might end up having the same query id
-
Sergei Golubchik authored
An attempt to introduce libmysqlclient.so symbol versioning that is compatible both with Debian and Fedora all versions: put all symbols into libmysqlclient_18 version node (as on Debian), but also put aliases of old symbols into libmysqlclient_16 version node (as on Fedora). Also use a linker script to create aliases of exported symbols, not rpm_support.cc source file.
-
Sergey Petrunya authored
MDEV-4556 Server crashes in SEL_ARG::rb_insert with index_merge+index_merge_sort_union, FORCE INDEX - merge_same_index_scans() may put the same SEL_ARG tree in multiple result plans. make it call incr_refs() on the SEL_ARG trees that it does key_or() on, because key_or(sel_arg_tree_1, sel_arg_tree_2) call may invalidate SEL_ARG trees pointed by sel_arg_tree_1 and sel_arg_tree_2.
-
Sergey Petrunya authored
In function ‘void* memset(void*, int, size_t)’, inlined from ‘void Lifo_buffer::set_buffer_space(uchar*, uchar*)’ at sql_lifo_buffer.h:70:5, inlined from ‘int DsMrr_impl::dsmrr_init(handler*, RANGE_SEQ_IF*, void*, uint, uint, HANDLER_BUFFER*)’ at multi_range_read.cc:895:62: /usr/include/i386-linux-gnu/bits/string3.h:82:32: error: call to ‘__warn_memset_zero_len’ declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror] It was intentional that the buffer is set to zero length there.
-
Sergey Petrunya authored
(gdb) p dbug_print_table_row(table) $33 = "SUBQUERY2_t1(col_int_key,col_varchar_nokey)=(7,c)"
-
Sergey Petrunya authored
- Item_direct_view_ref didn't clear its pointer to item_equal in ::cleanup. - Some Item_direct_view_ref objects have statement lifetime (i.e. they survive across multiple EXECUTE commands). Item_equal objects live only for the duration of one EXECUTE. This caused Item_direct_view_ref to have a stale pointer, which could cause all sorts of effects. (In this bug's testcase it was pointing to the wrong Item_equal, causing wrong query result) - Fixed by doing what Item_field::cleanup() does - don't keep item_equal pointer value. - There is no testcase because the only testcase I've got is highly fragile (e.g. the bug will not show up if @@datadir is of the wrong length).
-
- 18 Feb, 2014 2 commits
-
-
Alexey Botchkov authored
Fixed so the MYSQL_TYPE_GEOMETRY is treated as BLOB.
-
Alexey Botchkov authored
The result is EMPTY for a buffer(line, -1), but we still need one FALSE operation to be stored in the condition. And we actually add it but forgot to alloc memory to store it.
-
- 17 Feb, 2014 6 commits
-
-
Sergei Golubchik authored
Wait until the server starts accepting connections, not until the pid file appears
-
Sergei Golubchik authored
daemon plugin: join the thread to make sure it exits before the plugin is unloaded
-
Sergei Golubchik authored
It helps to interpret valgrind/safemalloc memory-related warnings that are printed when a plugin is unloaded (and thus cannot resolve addresses automatically)
-
Sergei Golubchik authored
Handles the case of sysctl net.ipv6.conf.all.disable_ipv6=1 net.ipv6.conf.default.disable_ipv6=1
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-