An error occurred fetching the project authors.
  1. 05 Sep, 2007 1 commit
    • unknown's avatar
      Fixed bug #29938. · 6a71b067
      unknown authored
      mysqldump --skip-events --all-databases dumped data of the mysqld.event table,
      and during the restoration from this dump events were created in spite
      of the --skip-events option.
      
      The mysqldump client has been modified to ignore mysql.event table data
      in case of --skip-events options.
      
      
      client/mysqldump.c:
        Fixed bug #29938.
        The dump_table function has been modified to skip dumping of
        the mysql.event table data in case of the --skip-event mysqldump
        client option.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #29938.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #29938.
      6a71b067
  2. 27 Jul, 2007 2 commits
    • unknown's avatar
      Fix test so that it will be environment-independent. · 818b0b84
      unknown authored
      mysql-test/r/mysqldump.result:
        Update result file.
      818b0b84
    • unknown's avatar
      Fix for BUG#30027: mysqldump does not dump views properly. · e030b5dc
      unknown authored
      mysqldump generates view defitions in two stages:
      
        - dump CREATE TABLE statements for the temporary tables.  For each view a
          temporary table, that has the same structure as the view is created.
      
        - dump DROP TABLE statements for the temporary tables and CREATE VIEW
          statements for the view.
      
      This approach is required because views can have dependencies on each other
      (a view can use other views). So, they should be created in the particular
      order. mysqldump however is not smart enough, so in order to resolve
      dependencies it creates temporary tables first of all.
      
      The problem was that mysqldump might have generated incorrect dump for the
      temporary table when a view has non-ASCII column name. That happened when
      default-character-set is not utf8.
      
      The fix is to:
      
        1. Switch character_set_client for the mysqldump's connection to binary
           before issuing SHOW FIELDS statement in order to avoid conversion.
          
        2. Dump switch character_set_client statements to UTF8 and back for
           CREATE TABLE statement that is issued to create temporary table.
      
      
      client/mysqldump.c:
        1. Switch character_set_results for mysqldump's connection to
        binary before SHOW FIELDS in order to avoid conversion to client
        character set.
        
        2. Dump switch character_set_client statements to UTF8 and back
        for CREATE TABLE statement.
      mysql-test/r/mysqldump.result:
        Update result file.
      mysql-test/t/mysqldump.test:
        Test case for BUG#30027.
      e030b5dc
  3. 20 Jul, 2007 1 commit
    • unknown's avatar
      Fixed bug #29788. · cff531ff
      unknown authored
      After dumping triggers mysqldump copied 
      the value of the OLD_SQL_MODE variable to the SQL_MODE
      variable. If the --compact option of the mysqldump was
      not set the OLD_SQL_MODE variable had the value
      of the uninitialized SQL_MODE variable. So
      usually the NO_AUTO_VALUE_ON_ZERO option of the
      SQL_MODE variable was discarded.
      
      This fix is for non-"--compact" mode of the mysqldump,
      because mysqldump --compact never set SQL_MODE to the
      value of NO_AUTO_VALUE_ON_ZERO.
      
      The dump_triggers_for_table function has been modified
      to restore previous value of the SQL_MODE variable after
      dumping triggers using the SAVE_SQL_MODE temporary
      variable.
      
      
      client/mysqldump.c:
        Fixed bug #29788.
        The dump_triggers_for_table function has been modified
        to restore previous value of the SQL_MODE variable after
        dumping triggers using the SAVE_SQL_MODE temporary
        variable.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #29788.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #29788.
      cff531ff
  4. 18 Jul, 2007 1 commit
    • unknown's avatar
      Fixed bug #28524. · 2bfe84d4
      unknown authored
      For each view the mysqldump utility creates a temporary table
      with the same name and the same columns as the view 
      in order to satisfy views that depend on this view.
      After the creation of all tables, mysqldump drops all
      temporary tables and creates actual views.
      However, --skip-add-drop-table and --compact flags disable
      DROP TABLE statements for those temporary tables. Thus, it was
      impossible to create the views because of existence of the
      temporary tables with the same names.
      
      
      client/mysqldump.c:
        Fixed bug #28524.
        The mysqldump utility has been modified to unconditionally drop
        temporary tables before the creation of views.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #28524 and updated result of previous tests.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #28524 and updated result of previous tests.
      2bfe84d4
  5. 07 Jun, 2007 1 commit
    • unknown's avatar
      Bug#28369 rpl test cases fail with binlog disabled · 33df97df
      unknown authored
       - Turn on binlog only for tests that need it
       - Skip those tests if --skip-binlog is used
      
      
      BitKeeper/deleted/.del-ctype_cp932_notembedded.result:
        Rename: mysql-test/r/ctype_cp932_notembedded.result -> BitKeeper/deleted/.del-ctype_cp932_notembedded.result
      BitKeeper/deleted/.del-ctype_cp932_notembedded.test:
        Rename: mysql-test/t/ctype_cp932_notembedded.test -> BitKeeper/deleted/.del-ctype_cp932_notembedded.test
      mysql-test/include/master-slave.inc:
        Need binlog
      mysql-test/lib/mtr_cases.pl:
        Turn on binlog only for tests that need it
        Skip those tests if --skip-binlog is used
      mysql-test/r/sp_trans.result:
        Moved to "sp_binlog"
      mysql-test/t/binlog.test:
        Need binlog
      mysql-test/t/blackhole.test:
        Need binlog
      mysql-test/t/ctype_cp932_binlog.test:
        Need binlog
      mysql-test/t/ctype_ucs_binlog.test:
        Need binlog
      mysql-test/t/drop_temp_table.test:
        Need binlog
      mysql-test/t/flush_block_commit_notembedded.test:
        Need binlog
      mysql-test/t/innodb.test:
        Need binlog
      mysql-test/t/insert_select-binlog.test:
        Need binlog
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Need binlog
      mysql-test/t/mysqlbinlog-cp932.test:
        Need binlog
      mysql-test/t/mysqlbinlog.test:
        Need binlog
      mysql-test/t/mysqlbinlog2.test:
        Need binlog
      mysql-test/t/mysqldump.test:
        Need binlog
      mysql-test/t/rpl000015.test:
        Need binlog
      mysql-test/t/rpl000017.test:
        Need binlog
      mysql-test/t/rpl_rotate_logs.test:
        Need binlog
      mysql-test/t/sp_trans.test:
        Moved to "sp_binlog"
      mysql-test/t/user_var-binlog.test:
        Need binlog
      mysql-test/r/sp_trans_log.result:
        New BitKeeper file ``mysql-test/r/sp_trans_log.result''
      mysql-test/t/sp_trans_log.test:
        New BitKeeper file ``mysql-test/t/sp_trans_log.test''
      33df97df
  6. 25 May, 2007 1 commit
    • unknown's avatar
      Fixed bug #28522: · c326457d
      unknown authored
      sometimes `mysqldump --hex-blob' overruned output buffer by '\0' byte.
      
      The dump_table() function has been fixed to reserve 1 byte more for the
      last '\0' byte of dumped string.
      
      
      client/mysqldump.c:
        Fixed bug #28522.
        The dump_table() function has been fixed to reserve 1 byte more for the
        last '\0' byte of dumped string.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #28522.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #28522.
      c326457d
  7. 15 May, 2007 1 commit
  8. 01 May, 2007 1 commit
  9. 30 Apr, 2007 2 commits
    • unknown's avatar
      Bug#27293: mysqldump crashes when dumping procedure defined by different user · 8f8244df
      unknown authored
      mysqldump didn't properly handle getting no data on
      SHOW CREATE PROCEDURE.  If S/C/P fails (due to dumping
      user's insufficient privileges on mysql.proc, say),
      mysqldump will print a comment to that effect to the
      output and return an error-code.  If the -f (force) option
      is used, the dump will continue, otherwise, it will abort
      right there and then.
      
      Also fixes Bug#22761, "mysqldump reports no errors when using
      --routines without mysql.proc privileges"
      ---
      Merge mysql.com:/home/tnurnberg/27293/50-27293
      into  mysql.com:/home/tnurnberg/27293/51-27293
      ---
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-maint
      into  mysql.com:/home/tnurnberg/27293/51-27293
      
      
      client/mysqldump.c:
        Bug#27293: mysqldump crashes when dumping procedure defined by different user
        
        handle failure of SHOW CREATE PROCEDURE, give user diagnostics,
        heed -f (force) option
        ---
        manual merge
      mysql-test/r/mysqldump.result:
        Bug#27293: mysqldump crashes when dumping procedure defined by different user
        
        show that trying to mysqldump --routines with insufficient
        privileges will no longer crash the client
        ---
        manual merge
      mysql-test/t/mysqldump.test:
        Bug#27293: mysqldump crashes when dumping procedure defined by different user
        
        show that trying to mysqldump --routines with insufficient
        privileges will no longer crash the client
        ---
        manual merge
      8f8244df
    • unknown's avatar
      Bug#27293: mysqldump crashes when dumping procedure defined by different user · 3f18c6bc
      unknown authored
      mysqldump didn't properly handle getting no data on
      SHOW CREATE PROCEDURE.  If S/C/P fails (due to dumping
      user's insufficient privileges on mysql.proc, say),
      mysqldump will print a comment to that effect to the
      output and return an error-code.  If the -f (force) option
      is used, the dump will continue, otherwise, it will abort
      right there and then.
      
      Also fixes Bug#22761, "mysqldump reports no errors when using
      --routines without mysql.proc privileges"
      ---
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint
      into  mysql.com:/home/tnurnberg/27293/50-27293
      
      
      client/mysqldump.c:
        Bug#27293: mysqldump crashes when dumping procedure defined by different user
        
        handle failure of SHOW CREATE PROCEDURE, give user diagnostics,
        heed -f (force) option
      mysql-test/r/mysqldump.result:
        Bug#27293: mysqldump crashes when dumping procedure defined by different user
        
        show that trying to mysqldump --routines with insufficient
        privileges will no longer crash the client
        ---
        manual merge
      mysql-test/t/mysqldump.test:
        Bug#27293: mysqldump crashes when dumping procedure defined by different user
        
        show that trying to mysqldump --routines with insufficient
        privileges will no longer crash the client
        ---
        manual merge
      3f18c6bc
  10. 05 Apr, 2007 1 commit
    • unknown's avatar
      Bug#26121 mysqldump includes LOCK TABLES general_log WRITE · 393e2aa9
      unknown authored
      - Giving the directive '--all-databases' to mysqldump caused 
        an attempt to lock and dump log tables which don't support this
        operation.
      - With this patch the log tables are excluded from the set of
        databases tables to dump.
      
      
      client/mysqldump.c:
        - Ignore log tables which can't be locked.
      mysql-test/t/mysqldump.test:
        Added test
      393e2aa9
  11. 02 Apr, 2007 1 commit
    • unknown's avatar
      Minor test cleanup. · f7417a29
      unknown authored
      mysql-test/t/mysqldump.test:
        Fix for failing Windows test.
      f7417a29
  12. 27 Mar, 2007 1 commit
    • unknown's avatar
      Bug#23491 MySQLDump prefix function call in a view by database name · 609277f9
      unknown authored
      - mysqldump executes a SHOW CREATE VIEW statement to generate the text
      that it outputs.  When the function name is retrieved it's database 
      name is unconditionally prepended.  This change causes the function's 
      database name to be prepended only when it was used to define the 
      function.
      
      
      mysql-test/r/information_schema.result:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Updated Results.
      mysql-test/r/mysqldump.result:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Added new results.
      mysql-test/r/sp-code.result:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Updated Results.
      mysql-test/r/udf.result:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Updated Results.
      mysql-test/t/mysqldump.test:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Added new testcase.
      sql/item_func.cc:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Use new m_explicit_name member when deciding whether or not to prepend
        the db name while building the function name.
      sql/sp.cc:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Use new sp_name constructor.
      sql/sp_head.h:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Add m_explicit_name member to sp_name object.
        - Redefined sp_name constructor to include new member.
      sql/sql_yacc.yy:
        Bug#23491 MySQLDump prefix function call in a view by database name
        - Use new sp_name constructors.
      609277f9
  13. 26 Mar, 2007 1 commit
    • unknown's avatar
      Fix for bug #25993: mysqldump crashes with merge table and -c option · 9b2e0127
      unknown authored
        
      opt_complete_insert was improperly used by accident.
      Use complete_insert flag instead.
      
      
      client/mysqldump.c:
        Fix for bug #25993: mysqldump crashes with merge table and -c option
          - use complete_insert instead of opt_complete_insert.
      mysql-test/r/mysqldump.result:
        Fix for bug #25993: mysqldump crashes with merge table and -c option
          - test result.
      mysql-test/t/mysqldump.test:
        Fix for bug #25993: mysqldump crashes with merge table and -c option
          - test case.
      9b2e0127
  14. 22 Mar, 2007 1 commit
    • unknown's avatar
      Bug#26346: stack + buffer overrun in mysqldump · 1a52767f
      unknown authored
      Fixes to buffer overlows from long command line args, and unchecked dyn_str return codes. Also light refactoring.
      
      
      client/mysqldump.c:
        Bug#26346 stack + buffer overrun in mysqldump
      mysql-test/r/mysqldump.result:
        Bug#26346 stack + buffer overrun in mysqldump
      mysql-test/t/mysqldump.test:
        Bug#26346 stack + buffer overrun in mysqldump
      1a52767f
  15. 19 Feb, 2007 2 commits
  16. 21 Nov, 2006 4 commits
    • unknown's avatar
      Added --debug-info to most clients to detect memory leaks in mysql-test-run · 85a590a2
      unknown authored
      Moved .progress files into the log directory
      Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name
      Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23
      Fixed some compiler warnings
      Fixed small memory leak in libmysql
      Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1
      
      
      client/client_priv.h:
        Added OPT_DEBUG_INFO and OPT_COLUMN_TYPES
      client/mysql.cc:
        Split --debug-info into --debug-info and --column-type-info
      client/mysql_upgrade.c:
        Give only error info at end if using --debug-info
      client/mysqladmin.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlbinlog.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlcheck.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlimport.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlshow.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqltest.c:
        Added --debug-info to detect memory leaks in mysqltest
        Added option --logdir to force .progress files in a specific directory
      libmysql/libmysql.c:
        Fixed memory leak
      mysql-test/include/ndb_setup_slave.inc:
        Moved cluster tables under 'mysql'
      mysql-test/include/query_cache.inc:
        Added more tests for query cache
      mysql-test/lib/init_db.sql:
        Move cluster.binlog_index -> mysql.binlog_index
      mysql-test/lib/mtr_report.pl:
        Find memory leaks
      mysql-test/mysql-test-run-shell.sh:
        Added --debug-info to programs to detect memory leaks
      mysql-test/mysql-test-run.pl:
        Added --debug-info to programs to detect memory leaks
        Force log files to var/log
        cluster tables moved under 'mysql'
      mysql-test/r/cache_innodb.result:
        New query cache test with innodb
      mysql-test/r/connect.result:
        binlog_index is now in mysql
      mysql-test/r/drop.result:
        Removed 'cluster' database
      mysql-test/r/information_schema.result:
        Removed 'cluster' database
      mysql-test/r/mysqlcheck.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_basic.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_ddl_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_discover.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_restore_compat.result:
        cluster -> mysql
      mysql-test/r/ps_1general.result:
        Removed cluster database
      mysql-test/r/rpl_create_database.result:
        Removed cluster database
      mysql-test/r/rpl_load_from_master.result:
        Removed cluster database
      mysql-test/r/rpl_loaddata_m.result:
        Removed cluster database
      mysql-test/r/rpl_ndb_bank.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_advance.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_basic.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_idempotent.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_log.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_multi.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_sync.result:
        cluster -> mysql
      mysql-test/r/rpl_row_basic_11bugs.result:
        Removed cluster database
      mysql-test/r/rpl_truncate_7ndb.result:
        Position have changed
      mysql-test/r/rpl_truncate_7ndb_2.result:
        cluster -> mysql
      mysql-test/r/schema.result:
        Removed cluster database
      mysql-test/r/show_check.result:
        Removed cluster database
      mysql-test/r/system_mysql_db.result:
        binlog_index moved under mysql
      mysql-test/r/upgrade.result:
        More tests
      mysql-test/t/information_schema.test:
        cluster -> mysql
      mysql-test/t/mysqldump.test:
        More test to detect memory leaks
      mysql-test/t/ndb_binlog_basic.test:
        cluster -> mysql
      mysql-test/t/ndb_binlog_multi.test:
        cluster -> mysql
      mysql-test/t/ndb_restore_compat.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_bank.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_dd_advance.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_idempotent.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_multi.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_sync.test:
        cluster -> mysql
      mysql-test/t/system_mysql_db_fix.test:
        Drop also binlog_index
      mysql-test/t/upgrade.test:
        Check that tables created with 3.23 works
      mysys/my_error.c:
        Remove all registered errors (to avoid memory leaks)
      mysys/my_init.c:
        call my_error_unregister_all() to avoid some possible memory leaks
      mysys/mysys_priv.h:
        Added prototype
      scripts/mysql_create_system_tables.sh:
        cluster -> mysql
      scripts/mysql_fix_privilege_tables.sql:
        Changed -- to #
        Create binlog_index table if it dosesn't exist
      sql/field.cc:
        Made offset() inline
      sql/field.h:
        Changed prototype of offset() to not make it depending on TABLE structure
      sql/field_conv.cc:
        Removed some usage of current_thd
      sql/ha_ndbcluster_tables.h:
        cluster -> mysql
      sql/item_sum.cc:
        Usage of new 'offset' parameters
      sql/key.cc:
        Changed 'find_ref_key' to not be dependent on field->table
        (This fixed a crash when using a table created in MySQL 3.23)
      sql/mysql_priv.h:
        Changed find_ref_key() to not use field->table
      sql/mysqld.cc:
        Fix that plugin_init() works properly on bootstrap
        (Previously we got warnings from plugin_init)
      sql/sql_class.cc:
        new 'field->offset()'
      sql/sql_select.cc:
        New field->offset()
      sql/table.cc:
        We don't need field->table to be set in find_ref_key() or find_field() anymore.
      storage/archive/ha_archive.cc:
        New field->offset()
      storage/federated/ha_federated.cc:
        New field->offset()
      storage/innobase/handler/ha_innodb.cc:
        Fixed compiler warnings
      storage/myisam/ha_myisam.cc:
        Fixed compiler warnings (Wrong paramter to sprintf())
        New field->offset()
      storage/myisam/ha_myisam.h:
        Fixed wrong type of table_flags
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warning
      mysql-test/r/1st.result:
        New BitKeeper file ``mysql-test/r/1st.result''
      mysql-test/std_data/old_table-323.frm:
        New BitKeeper file ``mysql-test/std_data/old_table-323.frm''
      mysql-test/t/1st.test:
        New BitKeeper file ``mysql-test/t/1st.test''
      85a590a2
    • unknown's avatar
      Preparing to merge "backport of bug#13926 into 5.0" · c50025a1
      unknown authored
      Moving tests to 4.1 section
      
      
      c50025a1
    • unknown's avatar
      Prepare to merge "backport of bug#13926 from 5.0 to 4.1" back into 5.0: · 654395b0
      unknown authored
      Moving tests into their new place into 4.1 tests section
      
      
      654395b0
    • unknown's avatar
      BUG#13926: --order-by-primary fails if PKEY contains quote character. · 248ab7c7
      unknown authored
      Backporting from 5.0
      
      
      mysql-test/r/mysqldump.result:
        Adding test case
      mysql-test/t/mysqldump.test:
        Adding test case
      248ab7c7
  17. 15 Nov, 2006 1 commit
    • unknown's avatar
      Cleanup after test cases · 8b8647ff
      unknown authored
      mysql-test/r/init_connect.result:
        Restore global variable to the value it's set to when server is started
      mysql-test/r/key_cache.result:
        Restore global variable values to original
      mysql-test/r/mysqldump.result:
        Drop the user that was created. Specifying "drop user myDB_user" is equal to "drop user myDB_user@%"
      mysql-test/r/rpl_deadlock.result:
        Restore global variable values to original
      mysql-test/r/rpl_drop_db.result:
        Remove the conflicting file and drop database mysqltest1 before test exits
      mysql-test/r/rpl_ignore_revoke.result:
        As changes to mysql.* are ignored - explicitly delete the user on slave
      mysql-test/r/rpl_init_slave.result:
        Restore global variable values to original
      mysql-test/r/rpl_max_relay_size.result:
        Restore global variable values to original
      mysql-test/r/rpl_sp.result:
        Restore global variable values to original
      mysql-test/r/rpl_timezone.result:
        Restore global variable values to original
      mysql-test/r/rpl_variables.result:
        Restore global variable values to original
      mysql-test/r/view_grant.result:
        Use same user in all places in the same test "readonly" is equal to "readonly@%" not "readonly@localhost"
      mysql-test/t/init_connect.test:
        Restore global variable to the value it's set to when server is started
      mysql-test/t/key_cache.test:
        Restore global variable values to original
      mysql-test/t/mysqldump.test:
        Drop the user that was created. Specifying "drop user myDB_user" is equal to "drop user myDB_user@%"
      mysql-test/t/rpl_deadlock.test:
        Restore global variable values to original
      mysql-test/t/rpl_drop_db.test:
        Remove the conflicting file and drop database mysqltest1 before test exits
      mysql-test/t/rpl_ignore_revoke.test:
        As changes to mysql.* are ignored - explicitly delete the user on slave
      mysql-test/t/rpl_init_slave.test:
        Restore global variable values to original
      mysql-test/t/rpl_max_relay_size.test:
        Restore global variable values to original
      mysql-test/t/rpl_sp.test:
        Restore global variable values to original
      mysql-test/t/rpl_timezone.test:
        Restore global variable values to original
      mysql-test/t/rpl_variables.test:
        Restore global variable values to original
      mysql-test/t/view_grant.test:
        Use same user in all places in the same test "readonly" is equal to "readonly@%" not "readonly@localhost"
      8b8647ff
  18. 18 Oct, 2006 1 commit
    • unknown's avatar
      Bug#19745: mysqldump --xml produces invalid xml · 016a7d4c
      unknown authored
      The mysqldump command with both the --xml and --hex-blob options will output blob data encoded as hexBinary.  
      The proper XML datatype is xs:hexBinary.  
      The correct XML datatype is specified be setting the xsi_type attribute equal to xs:hexBinary for each encoded element.
      
      
      client/mysqldump.c:
        Bug#19745: mysqldump --xml produces invalid xml
        - Moved hex-blob code to it's own function.
        - Rewrote print_xml_tag function to accept zero or more attribute/value
          pair(s) which are appended to a separate tag name.
        - --xml option respects the --hex-blob option by ouputting blob data in hex
          encoded format.  Each hex encoded field tag will also contain an xsi:type
          attribute with an xs:hexBinary value.
        - --extended-insert and --xml are mutually exclusive. Otherwise, the xml file
          will contain INSERT commands.
        - Minor comment cleanup.
      mysql-test/r/mysqldump.result:
        Bug#19745: mysqldump --xml produces invalid xml
        -Added results.
      mysql-test/t/mysqldump.test:
        Bug#19745: mysqldump --xml produces invalid xml
        -Added test.
      016a7d4c
  19. 21 Sep, 2006 1 commit
  20. 18 Sep, 2006 1 commit
  21. 16 Sep, 2006 1 commit
    • unknown's avatar
      Test case fixes · 7d557fbc
      unknown authored
      mysql-test/r/rpl_row_tabledefs_2myisam.result:
        Change error code of new error
      mysql-test/r/rpl_switch_stm_row_mixed.result:
        Change of result file
      mysql-test/t/mysqldump.test:
        incorrect merge
      7d557fbc
  22. 15 Sep, 2006 1 commit
  23. 14 Sep, 2006 1 commit
    • unknown's avatar
      Bug#21424 mysqldump failing to export/import views. ... · 0aa344f3
      unknown authored
      Bug#21424 mysqldump failing to export/import views.                                                                                                                                                                  
      
      Dumps are created for the tables in each specified database then for the views in each specified database. This bug occurs when any database's views depend on the mysql database's table data while being restored. 
      Added command line option --flush-privileges to the mysqldump utility which causes a FLUSH PRIVILIGES statement to be written to the dump after the mysql database.
      
      
      client/mysqldump.c:
        When the flush-privileges command line option is specified, make sure to FLUSH PRIVILEGES after only the mysql database's tables' data is restored so that grant tables are current.
      mysql-test/r/mysqldump.result:
        Added Results.
      mysql-test/t/mysqldump.test:
        Expanded existing test case for bug 21527 to also test for bug 21424. 
        Exercises new --flush-priviliges command line option.
        Test ignores log tables.
      0aa344f3
  24. 01 Sep, 2006 1 commit
    • unknown's avatar
      Restore bug fix lost in merge of client/mysqldump.c, and clean up mysqldump.test · 55c61a6e
      unknown authored
      so that 4.1 and 5.0 tests are all in the right place and no tests are duplicated.
      
      
      client/mysqldump.c:
        Restore fix for bug 21215 accidently removed during merge
      mysql-test/r/mysqldump.result:
        Update results
      mysql-test/t/mysqldump.test:
        Fix order of tests so that all the tests new to the 5.0 tree come after
        "End of 4.1 tests", and so that each leaves things in the state it found
        them (particularly by returning to the 'test' database. Also remove some
        tests that were duplicated.
      55c61a6e
  25. 29 Aug, 2006 1 commit
    • unknown's avatar
      Post merge changes. · a9a675a8
      unknown authored
      mysql-test/r/mysqldump.result:
        post-merge fix.
      mysql-test/t/mysqldump.test:
        post-merge fix.
      a9a675a8
  26. 28 Aug, 2006 1 commit
    • unknown's avatar
      Bug #21527 mysqldump incorrectly tries to LOCK TABLES on the information_schema database. · e88121ea
      unknown authored
          
      init_dumping now accepts a function pointer to the table or view specific init_dumping function.  This allows both tables and views to use the init_dumping function.
      
      
      client/mysqldump.c:
        Added functions for table and view specific dumping initalization.
      mysql-test/r/mysqldump.result:
        Added Result.
      mysql-test/t/mysqldump.test:
        Added test case.
      e88121ea
  27. 17 Aug, 2006 1 commit
    • unknown's avatar
      Bug #21288: mysqldump segmentation fault when using --where · 8d8fa0e3
      unknown authored
        The problem was that the error handling was using a too-small buffer to
        print the error message generated. We fix this by not using a buffer at
        all, but by using fprintf() directly. There were also some problems with
        the error handling in table dumping that was exposed by this fix that were
        also corrected.
      
      
      client/mysqldump.c:
        Use fprintf() instead of my_printf_error() to avoid buffer overflow issues.
        Since ME_BELL wasn't specified, calling my_printf_error() offered no advantage
        except for adding my_progname, which we just go ahead and do manually. Also,
        fix the error handling in dumpTable() when queries to get data fail and --force
        was specified.
      mysql-test/r/mysqldump.result:
        Add new results
      mysql-test/t/mysqldump.test:
        Add new regression test
      8d8fa0e3
  28. 14 Aug, 2006 3 commits
    • unknown's avatar
      Merge fixes · 7260fd70
      unknown authored
      mysql-test/r/mysqldump.result:
        Merge result fix
      mysql-test/r/repair.result:
        Merge Result Fix
      mysql-test/t/mysqldump.test:
        Fix of test
      7260fd70
    • unknown's avatar
      Fix a test case (proper clean up). · 492e7b08
      unknown authored
      mysql-test/r/mysqldump.result:
        Update results.
      mysql-test/t/mysqldump.test:
        Fix a bug in the test case that left user mysqltest_1@localhost 
        around (this broke furhter tests).
      492e7b08
    • unknown's avatar
      Manual merge 5.0->5.1. Post-merge fixes. · 21e75cb0
      unknown authored
      client/mysqldump.c:
        A post-merge fix - 'sock' was renamed to 'mysql'
      mysql-test/r/events_bugs.result:
        A post merge fix: now we strip rear comments from the query before
        it gets into the log.
      mysql-test/r/func_group.result:
        A post merge fix: default clause is now printed uppercase.
      mysql-test/r/im_life_cycle.result:
        Fix my mistake in manual resolve.
      mysql-test/r/mysqlcheck.result:
        use test; - after we drop client_test_db there is no current database.
        This cleanup is present in 5.1 only, but the test that was added in 
        5.0 assumes there is a current database, test.
      mysql-test/r/mysqldump.result:
        Ignore results of execution of mysqldump: we can't rely on 
        MASTER_LOG_POS in test results, it's different for statement
        and row level logging.
      mysql-test/r/mysqlshow.result:
        A post-merge fix: information schema contains a few more tables
        in 5.1
      mysql-test/r/mysqltest.result:
        A post merge fix: add 5.1 test end separator.
      mysql-test/r/ndb_basic.result:
        A post-merge fix: add test end separators.
      mysql-test/r/rpl_switch_stm_row_mixed.result:
        A post merge fix: length of varbinary column is now 3 times less.
        Assuming a side effect of some other change. Length of any
        field is not relevant in this test.
      mysql-test/r/rpl_view.result:
        Add an end of test marker.
      mysql-test/r/show_check.result:
        Remove duplicate results. Add results from a merged test case.
      mysql-test/r/sp-error.result:
        Add test end separators.
      mysql-test/r/sp-security.result:
        Post-merge fix: use test after the current database is dropped.
      mysql-test/r/sp.result:
        Remove a duplicate result (bad merge that left a copy of
        the test case for Bug#19862 in the test suite).
      mysql-test/r/strict.result:
        An after-merge fix for a new test case: in 5.1 we issue a more accurate
        error message: "Incorrect value" instead of "Truncated value". I reason
        it so that in case of an error nothing is truncated, really.
        Also found similar changes in other test cases.
      mysql-test/r/type_datetime.result:
        Fix the text of an error.
      mysql-test/r/union.result:
        A post-merge fix: CHARACTER SET is now uppercase.
      mysql-test/t/mysqlcheck.test:
        A post-merge fix: use test, after current database is dropped, there
        is no current database.
      mysql-test/t/mysqldump.test:
        Disable result log: it's dependent on binlog position.
      mysql-test/t/sp-security.test:
        use test
      sql/item_sum.cc:
        Adjust the call to the constructor after the merge.
      sql/sp_head.cc:
        Add a missing DBUG_VOID_RETURN, move security checks out of
        execute_trigger to Table_triggers_list: in 5.1 we check for
        TRIGGER privilege, not SUPER privilege to execute triggers, so these
        checks lack table context inside execute_trigger and have to be
        performed when we have table object on hand.
      sql/sql_db.cc:
        A post-merge fix: adjust load_db_opt_by_name and check_db_dir_existence
        (new functions added in 5.0) to be tablename-to-filename encoding 
        friendly.
      sql/sql_lex.cc:
        A post-merge fix: make skip_rear_comments operate on const uchar *s.
      sql/sql_lex.h:
        A post-merge fix.
      sql/sql_show.cc:
        A post-merge fix: fix a bad merge, rename orig_sql_command -> sql_command.
      sql/sql_trigger.cc:
        A post-merge fix: move security checks to process_triggers
        from execute_trigger.
      sql/sql_view.cc:
        Adjust to the new signature of skip_rear_comments.
      sql/sql_yacc.yy:
        Adjust to the new signature of init_strings.
      21e75cb0
  29. 10 Aug, 2006 1 commit
    • unknown's avatar
      after merge update · 2834469c
      unknown authored
      mysql-test/r/mysqldump.result:
        update result
      mysql-test/t/mysqldump.test:
        update test
      2834469c
  30. 03 Aug, 2006 2 commits
  31. 02 Aug, 2006 1 commit
    • unknown's avatar
      BUG#13926: --order-by-primary fails if PKEY contains quote character. · 7fd78b84
      unknown authored
      Quote PKEY.
      
      
      mysql-test/t/mysqldump.test:
        Test for BUG#13926: --order-by-primary fails if PKEY contains quote character
      mysql-test/r/mysqldump.result:
        Test results for BUG#13926: --order-by-primary fails if PKEY contains quote character
      client/mysqldump.c:
        Fix for BUG#13926: --order-by-primary fails if PKEY contains quote character.
        Quote PKEY.
      7fd78b84