1. 19 Nov, 2010 12 commits
    • Vladislav Vaintroub's avatar
      4180ba3d
    • Vladislav Vaintroub's avatar
      merge · 8c2462f9
      Vladislav Vaintroub authored
      8c2462f9
    • Vladislav Vaintroub's avatar
      Bug#58313: CMake stops with VS Express if -DBUILD_CONFIG=mysql_release.cmake · 86197142
      Vladislav Vaintroub authored
      Bug : -DBUILD_CONFIG=mysql_release sets SIGNCODE parameter which requires 
      singtool.exe (part of Windows SDK)  in order to be able to sign the binaries (
      only if valid certificate is found). However singtool is not a part of the SDK shipped
      with Visual Studio Express, so the build fails claiming missing singtools.exe
      
      Fix: Do not  use SIGNCODE  wiith VC Express.
      
      Also, fix broken nmake build (*.rc files could not be compiled due to ADD_DEFINITIONS
      contaning C/C++ compiler specific flags)
      86197142
    • Alexander Barkov's avatar
      Bug#58190 BETWEEN no longer uses indexes for date or datetime fields · ba68b26a
      Alexander Barkov authored
      Regression introduced by WL#2649.
      
      Problem: queries with date/datetime columns did not use indexes:
      set names non_latin1_charset;
      select * from date_index_test
      where date_column between '2010-09-01' and '2010-10-01';
      
      before WL#2649 indexes worked fine because charset of 
      date/datetime
      columns was BINARY which always won.
      
      Fix: testing that collation of the operation matches collation 
      of the field is only needed in case of "real" string data types.
      For DATE, DATETIME it's not needed.
      
      
        @ mysql-test/include/ctype_numconv.inc
        @ mysql-test/r/ctype_binary.result
        @ mysql-test/r/ctype_cp1251.result
        @ mysql-test/r/ctype_latin1.result
        @ mysql-test/r/ctype_ucs.result
        @ mysql-test/r/ctype_utf8.result
        Adding tests
      
        @ sql/field.h
        Adding new method Field_str::match_collation_to_optimize_range()
        for use in opt_range.cc to distinguish between
        "real string" types like CHAR, VARCHAR, TEXT
        (Field_string, Field_varstring, Field_blob)
      
        and "almost string" types DATE, TIME, DATETIME
        (Field_newdate, Field_datetime, Field_time, Field_timestamp)
      
        @ sql/opt_range.cc
        Using new method instead of checking result_type() against STRING result.
      
      Note:
      
        Another part of this problem (which is not regression) 
        is submitted separately (see bug##58329).
      ba68b26a
    • Alexander Barkov's avatar
      Bug#58175 xml functions read initialized bytes when conversions happen · 76ce2feb
      Alexander Barkov authored
      Problem:
      
       nr_of_decimals could read behind the end of the buffer
       in case of a non-null-terminated string, which caused
       valgring warnings.
      
      Fix:
      
        fixing nr_of_decimals not to read behind the "end" pointer.
      
      modified:
      
        @ mysql-test/r/xml.result
        @ mysql-test/t/xml.test
        @ sql/item.cc
      76ce2feb
    • Georgi Kodinov's avatar
      Bug #58119: Typo in warning on log: [Warning] 'proxes_priv' entry · e4361481
      Georgi Kodinov authored
      Fixed a typo in an error message.
      e4361481
    • Vladislav Vaintroub's avatar
      merge · be0ff408
      Vladislav Vaintroub authored
      be0ff408
    • Dmitry Lenev's avatar
      Fix tree name which was accidentally changed · 86da427a
      Dmitry Lenev authored
      during the merge.
      86da427a
    • Dmitry Lenev's avatar
      Merged recent change from mysql-5.5-bugteam into · df2c54f2
      Dmitry Lenev authored
      mysql-5.5-runtime tree.
      df2c54f2
    • Dmitry Lenev's avatar
      Suppress false-positive uninitialized variable use · ce16c4fb
      Dmitry Lenev authored
      warnings in Event_queue::get_top_for_execution_if_time()
      method which has caused -Werror build to fail.
      ce16c4fb
    • Dmitry Lenev's avatar
      Fix for bug #57985 "ONLINE/FAST ALTER PARTITION can fail and · 602a2225
      Dmitry Lenev authored
      leave the table unusable".
       
      Failing ALTER statement on partitioned table could have left
      this table in an unusable state. This has happened in cases
      when ALTER was executed using "fast" algorithm, which doesn't 
      involve copying of data between old and new versions of table, 
      and the resulting new table was incompatible with partitioning
      function in some way.
       
      The problem stems from the fact that discrepancies between new 
      table definition and partitioning function are discovered only 
      when the table is opened. In case of "fast" algorithm this has
      happened too late during ALTER's execution, at the moment when
      all changes were already done and couldn't have been reverted.
       
      In the cases when "slow" algorithm, which copies data, is used 
      such discrepancies are detected at the moment new table
      definition is opened implicitly when new version of table is
      created in storage engine. As result ALTER is aborted before 
      any changes to table were done.
       
      This fix tries to address this issue by ensuring that "fast"
      algorithm behaves similarly to "slow" algorithm and checks
      compatibility between new definition and partitioning function 
      by trying to open new definition after .FRM file for it has 
      been created.
       
      Long term we probably should implement some way to check
      compatibility between partitioning function and new table
      definition which won't involve opening it, as this should
      allow much cleaner fix for this problem.
      
      mysql-test/r/partition_innodb.result:
        Added test for bug #57985 "ONLINE/FAST ALTER PARTITION can
        fail and leave the table unusable".
      mysql-test/t/partition_innodb.test:
        Added test for bug #57985 "ONLINE/FAST ALTER PARTITION can
        fail and leave the table unusable".
      sql/sql_table.cc:
        Ensure that in cases when .FRM for partitioned table is
        created without creating table in storage engine (e.g.
        during "fast" ALTER TABLE) we still open table definition. 
        This allows to check that definition of created table/.FRM 
        is compatible with its partitioning function.
      602a2225
    • Alexander Barkov's avatar
      Bug#57306 SHOW PROCESSLIST does not display string literals well. · ee66d905
      Alexander Barkov authored
      A post-patch fixing test failures on Windows.
      
      Host name in "SHOW PROCESSLIST" is displayed with port number
      for some reasons.
      ee66d905
  2. 18 Nov, 2010 14 commits
  3. 17 Nov, 2010 4 commits
  4. 19 Nov, 2010 8 commits
  5. 18 Nov, 2010 2 commits
    • Georgi Kodinov's avatar
      Bug #50021: Windows standard configuration files are showing Linux · 05c9acaa
      Georgi Kodinov authored
       options/settings
       
       1. Changed the default value for socket on Windows to the windows
       default
       2. Removed hard-coded trailing slashes from innodb_data_home_dir
       and innodb_log_group_name_dir.
       3. Added extra backslashes to the innodb directory example
       4. Made the tempdir platform "dependent"
       5. Fixed the comments in the .ini files
       6. Removed the tmpdir from the templates and the scripts
      05c9acaa
    • Bjorn Munch's avatar
      upmerge 58257 · 5da7193a
      Bjorn Munch authored
      5da7193a