- 08 Aug, 2015 4 commits
-
-
Jan Lindström authored
Analysis: Handler used table flag HA_REQUIRE_PRIMARY_KEY but a bug on sql_table.cc function mysql_prepare_create_table internally marked secondary key with NOT NULL colums as unique key and did not then fail on requirement that table should have primary key or unique key.
-
Jan Lindström authored
Analysis: Handler table flag HA_REQUIRE_PRIMARY_KEY alone is not enough to force primary or unique key, if table has at least one NOT NULL column and secondary key for that column. Fix: Add additional check that table really has primary key or unique key for InnoDB terms.
-
Jan Lindström authored
Removed extra line break.
-
Jan Lindström authored
MDEV-8409: Changing file-key-management-encryption-algorithm causes crash and no real info why Analysis: Both bugs has two different error cases. Firstly, at startup when server reads latest checkpoint but requested key_version, key management plugin or encryption algorithm or method is not found leading corrupted log entry. Secondly, similarly when reading system tablespace if requested key_version, key management plugin or encryption algorithm or method is not found leading buffer pool page corruption. Fix: Firsly, when reading checkpoint at startup check if the log record may be encrypted and if we find that it could be encrypted, print error message and do not start server. Secondly, if page is buffer pool seems corrupted but we find out that there is crypt_info, print additional error message before asserting.
-
- 07 Aug, 2015 1 commit
-
-
Sergei Petrunia authored
-
- 04 Aug, 2015 4 commits
-
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
This bug is essentially another variant of MDEV-7458. If a transaction conflict caused a deadlock kill of T2 in record_gtid() during commit, the code would do a rollback _before_ running rgi->unmark_start_commit(). This creates a race where following transactions could start too early (before T2 has completed its transaction retry). This in turn could lead to replication failure, if there was a conflict that caused eg. duplicate key error or similar. The fix is to remove these rollbacks (in Query_log_event::do_apply_event() and Xid_log_event::do_apply_event(). They seem out-of-place; code in log_event.cc generally does not roll back on error, this is handled higher up. In addition, because of the extreme difficulty of reproducing bugs like MDEV-7458 and MDEV-8302, this patch adds some extra precations to try to detect (in debug builds) or prevent (in release builds) similar bugs. ha_rollback_trans() will now call unmark_start_commit() if needed (and assert in debug build when a caller does rollback without unmark first). We also add an extra check for thd->killed() so that we avoid doing mark_start_commit() if we already have a pending deadlock kill. And we add a missing unmark_start_commit() call in the error case, found by the above assertion.
-
- 24 Jul, 2015 1 commit
-
-
Sergey Vojtovich authored
Attempting to kill query owned by different user now returns better error: "You are not owner of query N" instead of "You are not owner of thread N".
-
- 23 Jul, 2015 2 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 22 Jul, 2015 2 commits
-
-
Sergei Golubchik authored
-
Jan Lindström authored
Analysis: In fil_crypt_space_needs_rotation we first make sure that tablespace is found and then separately that it is normal tablespace. Thus, tablespace could be dropped between these two functions calls. Fix: If space is not found from fil_system return tablespace type ULINT_UNDEFINED and naturally do not continue rotating space.
-
- 21 Jul, 2015 1 commit
-
-
Jan Lindström authored
Analysis: There is race between drop table and encryption threads that could cause encryption thread to enter mutex that has been already released. Fix: When destroying crypt_data first enter the mutex and set crypt data unavailable, then release the memory and clean up the data. This should make the race more unprobable. Additionally, added big_test for create_or_replace as it could fail testcase timeout if you have slow I/O (tested that testcase passes with --mem).
-
- 20 Jul, 2015 5 commits
-
-
Sergei Golubchik authored
as a workaround until the bug is fixed don't run mroonga tests in --embedded mode by default
-
Sergei Golubchik authored
WARN_DEPRECATED_NO_REPLACEMENT(NULL, ...) was causing a warning, because it expanded into NULL->variables.errmsgs[...]
-
-
Sergei Golubchik authored
because the actual merge was already done in dced5146 as a patch
-
Nirbhay Choubey authored
In non-wsrep builds, wsrep_running_threads should be defined to (0).
-
- 19 Jul, 2015 4 commits
-
-
Elena Stepanova authored
The version in sysvars_innodb,32bit,xtradb.rdiff was not updated
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
--gtid-ignore-duplicates was comparing sequence numbers as 32-bit, so after 2**32 transactions things would start to fail.
-
- 17 Jul, 2015 1 commit
-
-
Elena Stepanova authored
The test did not wait until the server shuts down
-
- 16 Jul, 2015 2 commits
-
-
Monty authored
Problem was that for queries of type: select rand() r, rand() p, rand() = rand() from a having r = p The optimizer thought that r = p was same as rand() = rand() and this would always be true. The problem was that when testing if two expressions are equal, we didn't take into account no determinstic functions. The fix is to not compare non deterministic functions as equal.
-
Monty authored
Other things: - Avoid calling init_and_set_log_file_name() when opening binary log. - Remove newlines early when reading from index file. - Ensure that reset_logs() will work even if thd is 0 (Can happen on startup) - Added thd to sart_slave_threads() for better error handling.
-
- 15 Jul, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 14 Jul, 2015 6 commits
-
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Alexander Barkov authored
-
- 13 Jul, 2015 1 commit
-
-
Alexander Barkov authored
-
- 10 Jul, 2015 3 commits
-
-
Nirbhay Choubey authored
Enable replication of GRANT/REVOKE ROLE commands across galera nodes.
-
Monty authored
Cleanups, fixed warnings from valgrind, fixed failing tests (because on changes in WSREP initialization)
-
Monty authored
This should not have caused any notable errors in most cases. After fix, we are not using keys to solve MIN/MAX if the string used for comparision is longer thant the column-
-
- 09 Jul, 2015 2 commits
-
-
Monty authored
Conflicts: sql/item_subselect.cc Fixed also typo in comment
-
Monty authored
- Cache variables.lc_messages->errmsgs->errmsgs in variables.errmsgs This gives us 15 byte less code space and 2 memory references for any access to language dependent message, of which there are 500 in the server..
-