1. 20 Jul, 2005 9 commits
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 46c627f3
      unknown authored
      into  mysql.com:/home/jonas/src/mysql-4.1-push
      
      
      46c627f3
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-4.1 · 21038e65
      unknown authored
      into lmy002.wdf.sap.corp:/home/georg/work/mysql/prod/mysql-4.1
      
      
      tests/mysql_client_test.c:
        Auto merged
      21038e65
    • unknown's avatar
      Merge mysql.com:/home/jonas/src/mysql-4.1 · 5aac38c0
      unknown authored
      into  mysql.com:/home/jonas/src/mysql-4.1-push
      
      
      5aac38c0
    • unknown's avatar
      cs fixes from last commit · 6147be6e
      unknown authored
      6147be6e
    • unknown's avatar
      bug#11942 - ndb backup · fe073647
      unknown authored
        fix error code to avoid clash with 5.0/5.1
      
      
      ndb/include/kernel/signaldata/AlterTable.hpp:
        Change error codes to remove clash from 5.0
      ndb/include/kernel/signaldata/DropTable.hpp:
        Change error codes to remove clash from 5.0
      ndb/src/ndbapi/ndberror.c:
        Change error codes to remove clash from 5.0
      fe073647
    • unknown's avatar
      bug#11942 - ndb backup with parallell DDL · e071abac
      unknown authored
        add testcase to autotest
      
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        remove ;
      ndb/test/run-test/daily-basic-tests.txt:
        add test case
      e071abac
    • unknown's avatar
      Added some missing casts and changed a define for alloca(). · 44589256
      unknown authored
      
      client/mysqldump.c:
        Added casts.
      include/my_sys.h:
        Define for alloca() changed for Metrowerks compiler.
      myisam/rt_split.c:
        Added cast.
      44589256
    • unknown's avatar
      bug#11942 · 783dbfc3
      unknown authored
      
      ndb/include/kernel/signaldata/AlterTable.hpp:
        Add error code for backup in progress
      ndb/include/kernel/signaldata/DictTabInfo.hpp:
        Add backup state
      ndb/include/kernel/signaldata/DropTable.hpp:
        Add error code for backup in progress
      ndb/include/ndbapi/NdbDictionary.hpp:
        Add backup state
      ndb/src/kernel/blocks/backup/Backup.cpp:
        1) remove invalid require (util_sequence_ref) crash
        2) Don't backup objects dropping/creating
        3) set correct error code on backup fragment ref (crash)
        4) save TrigAttrInfo header when getting log full (crash)
        5) lock/unlock tables during backup
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        1) add mutex lock/unlock as part of drop/alter table
        2) add lock/unlock for backup
        3) remove TC from backup trigger loop
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Add BACKUP_ONGOING state
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Add backup state
      ndb/src/ndbapi/ndberror.c:
        Add error code for backup in progress
      ndb/test/ndbapi/testBackup.cpp:
        Add testcase for testBackup -n BackupDDL
      ndb/tools/drop_index.cpp:
        Fix ndb_drop_index
      ndb/tools/listTables.cpp:
        Print of backup state
      783dbfc3
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 5dd49439
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1.innolike
      
      
      5dd49439
  2. 19 Jul, 2005 10 commits
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-7249 · abcd8b03
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      abcd8b03
    • unknown's avatar
      Fixed some test cases that was not forgotten in a recent patch · 3d5be633
      unknown authored
      
      sql/sql_show.cc:
        Cleanup comment
        Removed extra end space
      3d5be633
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · a4ceba69
      unknown authored
      into  mishka.local:/home/my/mysql-4.1
      
      
      a4ceba69
    • unknown's avatar
      Simple fixes during review of new code · 3a31f7b9
      unknown authored
      
      include/my_global.h:
        Added floatget() to read unaligned flaot
      mysql-test/r/select.result:
        Added test for found_rows()
      mysql-test/t/select.test:
        Added test for found_rows()
      sql/des_key_file.cc:
        Moved initalization of LOCK_des_key_file to mysqld to make simpler code and avoid theoretical race condition
      sql/field_conv.cc:
        Added optimizzed varsion of do_cut_string (for simple character sets)
      sql/item_func.cc:
        Simplify code (and ensure DBUG_ENTER is excuted before main code)
      sql/item_strfunc.cc:
        Safe calculation of max_length
        This was needed as max_length can now be 1<<32-1 (after konstantins recent patch to fix BLOB_LENGTH)
        Remove init_des_key_file() as this is not initialized in mysqld.cc
      sql/item_timefunc.cc:
        Safe calculation of max_length
        This was needed as max_length can now be 1<<32-1 (after konstantins recent patch to fix BLOB_LENGTH)
      sql/log_event.cc:
        Simplify code
      sql/mysql_priv.h:
        Moved initalization of LOCK_des_key_file to mysqld to make simpler code and avoid theoretical race condition
      sql/mysqld.cc:
        Moved initalization of LOCK_des_key_file to mysqld to make simpler code and avoid theoretical race condition
        Revert wrong patch of calling close_connection() in first close_connections() loop. (Bug #7403)
        Instead we now print a warning for closed connections only if mysqld is sarted with --warnings
        Added comments to make the close_connections() logic clearer
      sql/sql_prepare.cc:
        Use floatget() and doubleget() to protect against unaligned data
      sql/sql_select.cc:
        Fixed some cases unlikely cases where found_rows() would return wrong for queries that would return 0 or 1 rows
      3a31f7b9
    • unknown's avatar
      fix for bug#12001 · 1dccfdac
      unknown authored
      
      sql-common/client.c:
        fixed wrong offset
      tests/mysql_client_test.c:
        testcase for bug #12001
      1dccfdac
    • unknown's avatar
    • unknown's avatar
      43a550ae
    • unknown's avatar
      ConfigInfo.cpp: · ac2209a1
      unknown authored
        BUG#12028, cannot use default section for hostname in cluster config
        made clearer error message
      
      
      ndb/src/mgmsrv/ConfigInfo.cpp:
        BUG#12028, cannot use default section for hostname in cluster config
        made clearer error message
      ac2209a1
    • unknown's avatar
      BUG#12028, cannot use default value for HostName in cluster config · 09f19d3b
      unknown authored
      + added switch --print-full-config
      + removed unused REP configuration
      
      
      09f19d3b
    • unknown's avatar
      perror.c: · a3a9d00b
      unknown authored
        BUG#11999, incorrect --help on perror with ndb
      
      
      extra/perror.c:
        BUG#11999, incorrect --help on perror with ndb
      a3a9d00b
  3. 18 Jul, 2005 6 commits
  4. 17 Jul, 2005 2 commits
    • unknown's avatar
      select.result, select.test: · 6a88fa48
      unknown authored
        Added a test case for bug #11745.
      sql_select.cc:
        Fixed bug # 11745.
        Added support of where clause for queries with FROM DUAL.
      sql_yacc.yy:
        Fixed bug # 11745.
        Added optional where clause for queries with FROM DUAL.
      
      
      sql/sql_yacc.yy:
        Fixed bug # 11745.
        Added optional where clause for queries with FROM DUAL.
      sql/sql_select.cc:
        Fixed bug # 11745.
        Added support of where clause for queries with FROM DUAL.
      mysql-test/t/select.test:
        Added a test case for bug #11745.
      mysql-test/r/select.result:
        Added a test case for bug #11745.
      6a88fa48
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1 · 89519b67
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-4.1
      
      
      sql/sql_select.cc:
        Auto merged
      89519b67
  5. 16 Jul, 2005 4 commits
    • unknown's avatar
      Added test for Bug #11521 · 7adfe96d
      unknown authored
      "Negative integer keys incorrectly substituted for 0 during range analysis."
      
      The problem is that the range optimizer incorrectly replaces any negative
      constant with '0' for all types except BIGINT because the method save_in_field()
      casts negative integers to non-negative. This causes incorrect query
      results where (0 = any_negative_number).
      
      The problem caused by this bug is fixed by the patch for BUG#11185.
      That patch constitutes an optimization due to which the problem code is
      never called with negative constants. This patch adds a test so we are sure
      that the problem does not reappear.
      
      
      mysql-test/r/select.result:
        Test for BUG#11521.
      mysql-test/t/select.test:
        Test for BUG#11521.
      7adfe96d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · b6f3a373
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      b6f3a373
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · cc57265b
      unknown authored
      into moonbone.local:/work/mysql-4.1-bug-11868
      
      
      cc57265b
    • unknown's avatar
      Fix bug#11868 NOT NULL ref optimization in subquery used in update must be · 560ff1a2
      unknown authored
      disabled if ref is built with a key from the updated table
      
      Problem was in add_not_null_conds() optimization function.
      It contains following code:
      JOIN_TAB *referred_tab= not_null_item->field->table->reginfo.join_tab;
      ...
      add_cond_and_fix(&referred_tab->select_cond, notnull);
      For UPDATE described in bug report referred_tab is 0 and dereferencing it
      crashes the server.
      
      
      
      sql/sql_select.cc:
        Fix bug #11868 NOT NULL ref optimization in subquery used in update must be
        disabled if ref is built with a key from the updated table
      mysql-test/r/update.result:
        Test case for bug#11868 Update with subquery with ref built with a key from
        the updated table crashes server.
      mysql-test/t/update.test:
        Test case for bug#11868 Update with subquery with ref built with a key from the updated table crashes server
      560ff1a2
  6. 15 Jul, 2005 9 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 7768acb6
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      7768acb6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · d5b80a78
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-root
      
      
      d5b80a78
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · bbe80645
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      bbe80645
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · e81337d8
      unknown authored
      into  linux.site:/home/reggie/bk/bug7403
      
      
      e81337d8
    • unknown's avatar
      A fix and a test case for Bug#9359 "Prepared statements take snapshot · e83e1053
      unknown authored
       of system vars at PREPARE time": implement a special Item
      to handle system variables. This item substitutes itself with 
      a basic constant containing variable value at fix_fields.
      
      
      mysql-test/r/ps.result:
        - test results fixed (Bug#9359).
      mysql-test/t/ps.test:
        - add a test case for Bug#9359 "Prepared statements take snapshot
         of system vars at PREPARE time"
      sql/item_func.cc:
        - implement Item_func_get_system_var: we should not evaluate system
        variables in the parser, but instead should create an item which 
        is evaluated to a constant at execute.
        - remove an unused function
      sql/item_func.h:
        Add a new item, Item_func_get_system_var
      sql/mysql_priv.h:
        Move necessary declarations to make set_var.h objects visible in 
        item_func.h
      sql/set_var.cc:
        - we should not print to network from get_system_var: if it's called
        from prepared statement prepare, we get packets out of order when using
        the binary protocol. Instead report the error to be sent to the user later.
        This is a backport from 5.0.
      sql/set_var.h:
        - declaration of enum_var_type moved to mysql_priv.h
      e83e1053
    • unknown's avatar
      Fix bug#11482 4.1.12 produces different resultset for a complex query · 0f41fb42
      unknown authored
        than in previous 4.1.x
      
      Wrongly applied optimization were adding NOT NULL constraint which results in
      rejecting valid rows and reduced result set.
      
      The problem was that add_notnull_conds() while checking subquery were adding
      NOT NULL constraint to left joined table, to which, normally, optimization 
      don't have to be applied.
      
      
      sql/sql_select.cc:
        Fix bug #11482 Wrongly applied optimization was erroneously rejecting valid rows
        Constraint were added to optimization appliance test.
      mysql-test/t/select.test:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      mysql-test/r/select.result:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      0f41fb42
    • unknown's avatar
      Fix error in formatting metadata in mysqltest. · 085653b9
      unknown authored
      
      client/mysqltest.c:
        Fix reporting of length and max_length when displaying metadata
        -- they are unsigned int.
      085653b9
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-9979 · 2013d566
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      sql/sql_parse.cc:
        Auto merged
      2013d566
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0589559e
      unknown authored
      into  linux.site:/home/reggie/bk/bug7403
      
      
      0589559e