1. 24 Jan, 2007 13 commits
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 53491b18
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.1-21029
      
      
      Makefile.am:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      53491b18
    • unknown's avatar
      Bug#21029 (Dependencies between sql_yacc.cc and dependent headers not detected) · 39cc6d11
      unknown authored
      The build scripts in general, using automake, autoconf, etc, contain several
      special commands and work around all related to the way the bison code in the
      parser is built, for sql/sql_yacc.yy. These work arounds, accumulated over
      time during development, ultimately cause the build scripts to be unstable
      and cause build defects by not enforcing dependencies.
      
      This fix simplifies the build process and aligns it with the automake tooling,
      which provides native support for bison and *.yy files.
      
      In particular, the following problem have been fixed:
      - dependencies with sql_yacc.cc were not honored (Bug 21029), leading to
        corrupted builds,
      - the work around introduced by Bug 24557, to cleanup the generated files
        sql_yacc.h and sql_yacc.cc, has been removed,
      - the generated makefile, in a source distribution, used to destroy the files
        sql_yacc.h and sql_yacc.cc on a 'make clean' target. This has been fixed:
        these files are now removed by make maintainer-clean.
      - The root cause of the problem found with gcc 4.1 (see Bug 24619) has been
        clearly documented, and the "sed" hack has been replaced by a cleaner
        work around, when building the code with bison 1.875.
      - Removed the file sql/sql_yacc.yy.bak, added by WL 3031 by accident.
      - Removed the unnecessary AM_YFLAG= --debug introduced by WL 3432, since
        the compiling option DBUG_OFF takes precedence when setting YYDEBUG.
      
      
      BitKeeper/deleted/.del-sql_yacc.yy.bak:
        Rename: sql/sql_yacc.yy.bak -> BitKeeper/deleted/.del-sql_yacc.yy.bak
      Makefile.am:
        General cleanup of the build process for sql_yacc.yy
      sql/Makefile.am:
        General cleanup of the build process for sql_yacc.yy
      sql/sql_yacc.yy:
        General cleanup of the build process for sql_yacc.yy
      39cc6d11
    • unknown's avatar
      Merge mockturtle.local:/home/dlenev/src/mysql-5.0-merge · 5c0216c5
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-merge
      
      
      mysql-test/t/ps.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      mysql-test/t/disabled.def:
        Manual merge.
      5c0216c5
    • unknown's avatar
      Disabling back im_daemon_life_cycle.test, which was temporarily enabled in · 259a4658
      unknown authored
      the team tree for additional investigation.
      
      
      259a4658
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 7b109de6
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-merge
      
      
      mysql-test/t/disabled.def:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      7b109de6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 491ef6af
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-merge
      
      
      mysql-test/t/disabled.def:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      491ef6af
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-5.1 · e57ef96a
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build-work
      
      
      e57ef96a
    • unknown's avatar
      Fixed test case after merging fix for bug#24491 "using alias from source · 07b6b2f8
      unknown authored
      table in insert ... on duplicate key" in 5.1 tree.
      
      
      mysql-test/t/sp-error.test:
        After merge fix.
      07b6b2f8
    • unknown's avatar
      Merge mockturtle.local:/home/dlenev/src/mysql-5.0-bg24491 · a45938bf
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-bg24491
      
      
      mysql-test/t/sp-error.test:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/ps.result:
        SCCS merged
      mysql-test/r/sp-error.result:
        SCCS merged
      mysql-test/t/disabled.def:
        SCCS merged
      mysql-test/t/ps.test:
        SCCS merged
      a45938bf
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 3f064efb
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.0/ndb-work
      
      
      3f064efb
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.0/ndb-work · 1b71102f
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.1/ndb-work
      
      
      storage/ndb/src/common/util/SocketClient.cpp:
        Auto merged
      1b71102f
    • unknown's avatar
      fix hpux build problem and some ndb connect errors being missed · 71f60680
      unknown authored
      
      ndb/src/common/util/SocketClient.cpp:
        fix two problems recently introduced:
        - HPUX build problem
        - some connect errors not being detected properly
      71f60680
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 02a9f2f7
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.0-ndb
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      02a9f2f7
  2. 23 Jan, 2007 22 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · ffb51e15
      unknown authored
      into  production.mysql.com:/usersnfs/mjorgensen/bktrees/mysql-5.1-build
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      ffb51e15
    • unknown's avatar
      Merge xiphis.org:/home/antony/work2/p1-bug25396.4 · dd5523d9
      unknown authored
      into  xiphis.org:/home/antony/work2/p1-bug25396.5
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      dd5523d9
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 964f502c
      unknown authored
      into  clam.ndb.mysql.com:/export/space/pekka/ndb/version/my50-ndb
      
      
      964f502c
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.1-ndb · f80084bf
      unknown authored
      into  clam.ndb.mysql.com:/export/space/pekka/ndb/version/my51-ndb
      
      
      f80084bf
    • unknown's avatar
      Merge mysql.com:/data0/mysqldev/users/tomas/mysql-5.0-build · c64b504a
      unknown authored
      into  mysql.com:/data0/mysqldev/users/tomas/mysql-5.1-build
      
      
      configure.in:
        Auto merged
      cmd-line-utils/readline/undo.c:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      storage/myisam/mi_packrec.c:
        Auto merged
      c64b504a
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.0/ndb · a7174850
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.0/bug25487
      
      
      a7174850
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.1/ndb · b9077693
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.1/bug25567
      
      
      mysql-test/r/ndb_basic.result:
        Auto merged
      b9077693
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.0/bug25487 · a36dffb1
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.1/bug25567
      
      
      storage/ndb/include/mgmapi/mgmapi.h:
        Auto merged
      storage/ndb/include/util/SocketClient.hpp:
        Auto merged
      storage/ndb/src/common/transporter/Transporter.cpp:
        Auto merged
      storage/ndb/src/common/util/SocketClient.cpp:
        Auto merged
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Auto merged
      a36dffb1
    • unknown's avatar
      Bug#25567 records() call performs scan in NDB, performance bug · 8b54310b
      unknown authored
      
      mysql-test/r/ndb_basic.result:
        from spaces, to tabs. what fun!
      sql/ha_ndbcluster.h:
        fix estimate_rows_upper_bound() to be correct for NDB
      sql/sql_select.cc:
        use non-exact records information
      8b54310b
    • unknown's avatar
      Bug#25396 · d48e864f
      unknown authored
        "Valgrind leak in closecon_handlerton"
        plugin_shutdown() calls plugin_deinitialize() which calls ha_finalize_handlerton().
        ndbcluster_end() fails to wait for the ndb utility thread to exit which results in
        the handlerton struct being freed before the ndb utility thread has destroyed it's THD
        but before the plugin has been marked as UNINITIALIZED
      
      Bug is caused by misuse of abort_loops variable and not locking mutex during calls to
      pthread condition variable functions causing a race in valgrind's pthread_cond_wait
      implementation.
      
      
      sql/ha_ndbcluster.cc:
        Bug25396
        Valgrind requires that mutex be held during call to pthread_cond_signal.
        Change pthread_cond_timedwait() to pthread_cond_wait() where the timeout is not needed.
        Ensure that appropiate variables are protected by mutex.
        Remove use of abort_loop global variable.
        Ensure that ndbcluster_end waits for util thread to exit.
        Add an extra cond_var as insurance against non-conforming pthreads implementations.
      sql/mysqld.cc:
        Bug25386
        Valgrind requires that mutex be held during call to pthread_cond_signal.
      BUILD/compile-amd64-valgrind-max:
        New BitKeeper file ``BUILD/compile-amd64-valgrind-max''
      d48e864f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · 5f544ed0
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-bg24491
      
      
      sql/item.h:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      5f544ed0
    • unknown's avatar
      Merge clam.ndb.mysql.com:/export/space/pekka/ndb/version/my50-ndb · 29a9f743
      unknown authored
      into  clam.ndb.mysql.com:/export/space/pekka/ndb/version/my51-ndb
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      29a9f743
    • unknown's avatar
      Proposed fix for bug#24491 "using alias from source table in insert ... · 1dead07d
      unknown authored
      on duplicate key".
      
      INSERT ... SELECT ... ON DUPLICATE KEY UPDATE which was used in
      stored routine or as prepared statement and which in its ON DUPLICATE
      KEY clause erroneously tried to assign value to a column mentioned only
      in its SELECT part was properly emitting error on the first execution
      but succeeded on the second and following executions.
      
      Code which is responsible for name resolution of fields mentioned in
      UPDATE clause (e.g. see select_insert::prepare()) modifies table list
      and Name_resolution_context used in this process. It uses
      Name_resolution_context_state::save_state/restore_state() to revert
      these modifications. Unfortunately those two methods failed to revert
      properly modifications to TABLE_LIST::next_name_resolution_table
      and this broke name resolution process for successive executions.
      
      This patch fixes Name_resolution_context_state::save_state/restore_state()
      in such way that it properly handles TABLE_LIST::next_name_resolution_table.
      
      
      mysql-test/r/ps.result:
        Added test case for bug#24491 "using alias from source table in insert ...
        on duplicate key"
      mysql-test/r/sp-error.result:
        Added test case for bug#24491 "using alias from source table in insert ...
        on duplicate key"
      mysql-test/t/ps.test:
        Added test case for bug#24491 "using alias from source table in insert ...
        on duplicate key"
      mysql-test/t/sp-error.test:
        Added test case for bug#24491 "using alias from source table in insert ...
        on duplicate key"
      sql/item.h:
        Name_resolution_context::save_state/restore_state():
          At the moment these methods are used only by code implementing
          INSERT and INSERT ... SELECT statements. This code doesn't modify
         'next_name_resolution_table' member of table list element
          corresponding to the first table of SELECT clause (pointed by
          'first_name_resolution_table'). But it modifies table list element
          corresponding to the target table of INSERT (pointed by 'table_list')
          So these methods were changed to reflect this.
      1dead07d
    • unknown's avatar
      ndb - bug#25562 use byte-size max_data_length() when setting blob part size · 25fb32ef
      unknown authored
      
      sql/ha_ndbcluster.cc:
        bug#25562 use byte-size max_data_length() when setting blob part size
      25fb32ef
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 7f7d0c34
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      7f7d0c34
    • unknown's avatar
      round up Transporter connect timeout · 68ab0996
      unknown authored
      
      ndb/src/common/transporter/Transporter.cpp:
        change so timeout is rounded up to nearest second
      68ab0996
    • unknown's avatar
      Bug #25487 deleting ndb_cluster_connection object takes long time · 8deeb2f9
      unknown authored
        
        aim is to:
        a) if set_connect_timeout called, timeout connect attempt (for retry on
        next call) after timeout period
        b) preserve existing blocking behaviour otherwise (for, e.g. mgmapi)
        
        Related to customer issue with long time deleting ndb_cluster_connection
        object. believe we're hanging on the connect(2) call until timeout (when
        we then realise we should exit the thread).
      
      
      ndb/include/mgmapi/mgmapi.h:
        add ndb_mgm_set_connect_timeout
      ndb/include/util/SocketClient.hpp:
        add timeout (seconds) for max time to wait for connection
      ndb/src/common/transporter/Transporter.cpp:
        set limit on amount of time we'll wait for tcp connect
      ndb/src/common/util/SocketClient.cpp:
        only try to connect for a maximum of timeout time
      ndb/src/mgmapi/mgmapi.cpp:
        add ndb_mgm_set_connect_timeout
      8deeb2f9
    • unknown's avatar
      Merge poseidon.mysql.com:/home/tomas/mysql-5.0-ndb · ea9eb022
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/ndbapi/ClusterMgr.cpp:
        Auto merged
      storage/ndb/src/ndbapi/ClusterMgr.hpp:
        Auto merged
      storage/ndb/src/ndbapi/SignalSender.cpp:
        Auto merged
      ea9eb022
    • unknown's avatar
      ndb - bug#22013 · ab8355fa
      unknown authored
          Fix bug in event handling wrt early node shutdown
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Fix bug in event handling wrt early node shutdown
      ndb/src/ndbapi/ClusterMgr.cpp:
        Fix reportNodeFailed if only connected wo/ having received any API_REGCONF
      ndb/src/ndbapi/ClusterMgr.hpp:
        Fix reportNodeFailed if only connected wo/ having received any API_REGCONF
      ndb/src/ndbapi/SignalSender.cpp:
        Fix memleak
      ab8355fa
    • unknown's avatar
      correct manual merge · e7b4e509
      unknown authored
      e7b4e509
    • unknown's avatar
      Merge poseidon.mysql.com:/home/tomas/mysql-5.0-ndb · 8f9198ca
      unknown authored
      into  poseidon.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      storage/ndb/include/kernel/signaldata/DumpStateOrd.hpp:
        Auto merged
      storage/ndb/include/portlib/NdbMem.h:
        Auto merged
      storage/ndb/src/common/debugger/EventLogger.cpp:
        Auto merged
      storage/ndb/src/common/portlib/NdbMem.c:
        Auto merged
      storage/ndb/src/common/util/ConfigValues.cpp:
        Auto merged
      storage/ndb/src/common/util/File.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/qmgr/Qmgr.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Auto merged
      storage/ndb/src/kernel/vm/Configuration.cpp:
        Auto merged
      storage/ndb/src/kernel/vm/Configuration.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      storage/ndb/test/ndbapi/testNodeRestart.cpp:
        Auto merged
      storage/ndb/test/run-test/daily-basic-tests.txt:
        Auto merged
      mysql-test/r/ndb_basic.result:
        manual merge
      mysql-test/t/ndb_basic.test:
        manual merge
      storage/ndb/src/ndbapi/ndberror.c:
        manual merge
      8f9198ca
    • unknown's avatar
      bug#25746 ndb: 4209 error with 2 VARCHAR primary keys · 188899cd
      unknown authored
      - post review changes
      
      
      188899cd
  3. 22 Jan, 2007 5 commits