1. 23 Mar, 2007 1 commit
    • unknown's avatar
      Trivial cleanups and whitespace change in Event Scheduler code. · 57dc1256
      unknown authored
      A larger patch is to come, this is to exclude rudimentary changes
      from it.
      
      
      sql/event_data_objects.cc:
        Whitespace change.
      sql/event_data_objects.h:
        Remove debug allocators - we have safemalloc.
      sql/event_db_repository.cc:
        Whitespace change.
      sql/event_db_repository.h:
        Whitespace change.
      sql/event_queue.cc:
        Remove an unused structure. Whitespace change.
      sql/event_queue.h:
        Whitespace.
      sql/event_scheduler.cc:
        Whitespace change.
      sql/event_scheduler.h:
        Add comments. Whitespace change.
      sql/events.cc:
        Whitespace change.
      sql/events.h:
        Trivial cleanups.
      57dc1256
  2. 21 Mar, 2007 7 commits
  3. 20 Mar, 2007 1 commit
  4. 19 Mar, 2007 6 commits
    • unknown's avatar
      sql_insert.cc: · c71bff6d
      unknown authored
        After merge fix.
      
      
      sql/sql_insert.cc:
        After merge fix.
      c71bff6d
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/27006-bug-5.0-opt-mysql · ca16e703
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/sql_insert.cc:
        Manually merged.
      ca16e703
    • unknown's avatar
      sql_insert.cc: · 3798a7d5
      unknown authored
        Removed wrong fix for the bug#27006.
        The bug was added by the fix for the bug#19978 and fixed by Monty on 2007/02/21.
      trigger.test, trigger.result:
        Corrected test case for the bug#27006.
      
      
      sql/sql_insert.cc:
        Removed wrong fix for the bug#27006.
        The bug was added by the fix for the bug#19978 and fixed by Monty on 2007/02/21.
      mysql-test/t/trigger.test:
        Corrected test case for the bug#27006.
      mysql-test/r/trigger.result:
        Corrected test case for the bug#27006.
      3798a7d5
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/mysql-5.0-runtime · f81e917a
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      f81e917a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · e9bb08ac
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      include/my_global.h:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/events_scheduling.result:
        Auto merged
      BitKeeper/deleted/.del-init_db.sql~a77d572c39d5a1f8:
        Auto merged
      BitKeeper/deleted/.del-mysql_create_system_tables.sh:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/events_scheduling.test:
        Auto merged
      mysql-test/t/grant_cache.test:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      scripts/mysql_system_tables_fix.sql:
        Auto merged
      sql/event_db_repository.cc:
        Auto merged
      sql/event_queue.cc:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_help.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/tztime.cc:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/ha_myisam.h:
        Auto merged
      mysql-test/r/skip_grants.result:
        Manualmerge.
      mysql-test/r/sp.result:
        Manualmerge.
      mysql-test/t/skip_grants.test:
        Manualmerge.
      mysql-test/t/sp.test:
        Manualmerge.
      sql/event_data_objects.cc:
        Manualmerge.
      e9bb08ac
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 14ab9bef
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/sp.result:
        SCCS merged
      mysql-test/t/sp.test:
        SCCS merged
      14ab9bef
  5. 17 Mar, 2007 2 commits
    • unknown's avatar
      dbug/dbug.c: unused variable removed · 6bb42080
      unknown authored
      include/config-win.h: SIZEOF_INT
      include/my_global.h: win64 fix
      support-files/Makefile.am: automake magic
      
      
      dbug/dbug.c:
        unused variable removed
      include/config-win.h:
        SIZEOF_INT
      include/my_global.h:
        win64 fix
      support-files/Makefile.am:
        automake magic
      6bb42080
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 9128a807
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      sql/sql_insert.cc:
        Auto merged
      9128a807
  6. 16 Mar, 2007 23 commits
    • unknown's avatar
      wl#3700 - post-review fixes: · 7d383909
      unknown authored
      s/ulonglong/key_part_map/, comments
      
      
      include/heap.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      include/my_base.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      include/myisam.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      include/myisammrg.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/event_db_repository.cc:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/ha_partition.cc:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/ha_partition.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/sql_select.h:
        wl#3700 - post-review fixes:
        remove tab_to_keypart_map()
      7d383909
    • unknown's avatar
      sql_insert.cc: · 84d24679
      unknown authored
        Post-merge fix.
      
      
      sql/sql_insert.cc:
        Post-merge fix.
      84d24679
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 929b7b1b
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_help.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/table.h:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      929b7b1b
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/27006-bug-5.0-opt-mysql · f5ca9468
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/sql_insert.cc:
        Manually merged
      f5ca9468
    • unknown's avatar
      remove unnecessary line · a2630174
      unknown authored
      a2630174
    • unknown's avatar
      merging · 68f09e77
      unknown authored
      68f09e77
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 793c3061
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      mysql-test/t/skip_grants.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_insert.cc:
        merging
      793c3061
    • unknown's avatar
      Fix compilation on Windows broken with the push of bug#16420. · 998260ae
      unknown authored
      Fix three compilation warnings.
      
      
      sql/event_data_objects.cc:
        Fix compilation warnings.
      sql/event_queue.cc:
        Fix compilation warning: reimplement event_queue_element_compare_q()
        properly.
        
        Use set_timespec() to initialize struct timespec.
      998260ae
    • unknown's avatar
      Merge moonlight.home:/home/tomash/src/mysql_ab/mysql-5.1 · 354e15f0
      unknown authored
      into  moonlight.home:/home/tomash/src/mysql_ab/mysql-5.1-wl3698
      
      
      354e15f0
    • unknown's avatar
      BUG#16420: Events: timestamps become UTC · 086fba76
      unknown authored
      BUG#26429: SHOW CREATE EVENT is incorrect for an event that
                 STARTS NOW()
      BUG#26431: Impossible to re-create an event from backup if its
                 STARTS clause is in the past
      WL#3698: Events: execution in local time zone
      
      The problem was that local times specified by the user in AT, STARTS
      and ENDS of CREATE EVENT/ALTER EVENT statement were converted to UTC,
      and the original time zone was forgotten.  This way, event scheduler
      couldn't honor Daylight Saving Time shifts, and times shown to the
      user were also in UTC.  Additionally, CREATE EVENT didn't allow times
      in the past, thus preventing straightforward event restoration from
      old backups.
      
      This patch reworks event scheduler time computations, performing them
      in the time zone associated with the event.  Also it allows times to
      be in the past.
      
      The patch adds time_zone column to mysql.event table.
      
      NOTE: The patch is almost final, but the bug#9953 should be pushed
      first.
      
      
      client/mysqldump.c:
        Before every CREATE EVENT, output its time zone.
      mysql-test/include/wait_condition.inc:
        Add optional $wait_timeout parameter.
      mysql-test/lib/init_db.sql:
        Add time_zone column.
      mysql-test/r/events.result:
        Update result.
      mysql-test/r/events_bugs.result:
        Update result.
      mysql-test/r/events_grant.result:
        Update result.
      mysql-test/r/events_restart_phase1.result:
        Update result.
      mysql-test/r/events_scheduling.result:
        Update result.
      mysql-test/r/mysqldump.result:
        Update result.
      mysql-test/r/ps.result:
        Update result.
      mysql-test/r/system_mysql_db.result:
        Update result.
      mysql-test/t/events.test:
        Remove STARTS from the result, as it depends on current time.
      mysql-test/t/events_bugs.test:
        Time in the past is no longer an error.
      mysql-test/t/events_restart_phase1.test:
        Fill new column 'time_zone' in mysql.event.
      mysql-test/t/events_scheduling.test:
        Cleanup: disable event scheduler.
      scripts/mysql_create_system_tables.sh:
        Add new column 'time_zone' to mysql.event.
      scripts/mysql_fix_privilege_tables.sql:
        Add new column 'time_zone' to mysql.event.
      sql/event_data_objects.cc:
        The essence of the change is the following:
         - for internal times use my_time_t instead of TIME.  Assignment and
           comparison is done now on plain numbers.
         - in init_execute_at(), init_starts(), init_ends() convert given time
           to number of seconds since Epoch (aka Unix time, in UTC).
         - handle time_zone field loading and storing.
         - in get_next_time(), Unix time is converted back to event time zone,
           interval is added, and the result is converted to UTC again.
         - fix Event_timed::get_create_event() to report STARTS and ENDS.
         - before executing the event body we set thread time zone to the
           event time zone.
      sql/event_data_objects.h:
        Add time_zone member to Event_basic class.
        
        Store internal times in my_time_t (number of seconds since Epoch),
        rather than in broken down TIME structure.
      sql/event_db_repository.cc:
        Add time_zone column handling.
        
        Give a warning and do not create an event if its execution time is in
        the past, and ON COMPLETION NOT PRESERVE is set, because such an event
        should be dropped by that time.  Also, do not allow ALTER EVENT to
        set execution time in the past when ON COMPLETION NOT PRESERVE is set.
      sql/event_db_repository.h:
        Add enum member for new time zone column.
      sql/event_queue.cc:
        Replace handling of broken down times with simple handling of
        my_time_t.
      sql/event_queue.h:
        Store internal times in my_time_t (number of seconds since Epoch),
        rather than in broken down TIME structure.
      sql/event_scheduler.cc:
        Add TODO comment.
      sql/events.cc:
        Send time_zone column for SHOW CREATE EVENT.
      sql/share/errmsg.txt:
        Update error message, and add two more errors.
      sql/sql_show.cc:
        Add TIME_ZONE column to the output of SHOW EVENTS.
      mysql-test/r/events_time_zone.result:
        BitKeeper file /home/tomash/src/mysql_ab/mysql-5.1-wl3698/mysql-test/r/events_time_zone.result
      mysql-test/t/events_time_zone.test:
        BitKeeper file /home/tomash/src/mysql_ab/mysql-5.1-wl3698/mysql-test/t/events_time_zone.test
      086fba76
    • unknown's avatar
      Bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY · 6d93f150
      unknown authored
      UPDATE if the row wasn't actually changed.
      
      This bug was caused by fix for bug#19978. It causes AFTER UPDATE triggers
      not firing if a row wasn't actually changed by the update part of the
      INSERT .. ON DUPLICATE KEY UPDATE.
      
      Now triggers are always fired if a row is touched by the INSERT ... ON
      DUPLICATE KEY UPDATE.
      
      
      sql/sql_insert.cc:
        Bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY
        UPDATE if the row wasn't actually changed.
        Now triggers are always fired if a row is touched by the INSERT ... ON
        DUPLICATE KEY UPDATE.
      mysql-test/r/trigger.result:
        Added a test case for the bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY
        UPDATE if the row wasn't actually changed.
      mysql-test/t/trigger.test:
        Added a test case for the bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY
        UPDATE if the row wasn't actually changed.
      6d93f150
    • unknown's avatar
      Merge kpdesk.mysql.com:/home/thek/dev/bug26807/my51-bug26807 · c259b576
      unknown authored
      into  kpdesk.mysql.com:/home/thek/dev/mysql-5.1-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      c259b576
    • unknown's avatar
      Bug#26807 "set global event_scheduler=1" and --skip-grant-tables crashes server · 2b2fb674
      unknown authored
      - Crash occured because Event engine is only initialized if
        ACLs are used but not properly marked as disabled.
      - The patch is to mark the Event engine as DISABLED if no ACLs
        are used to avoid access of uninitialized variables.
      
      
      mysql-test/r/skip_grants.result:
        Added test case
      mysql-test/t/skip_grants.test:
        Added test case
      2b2fb674
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 8b110160
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      include/my_global.h:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_partition.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_servers.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/table.h:
        Auto merged
      sql/tztime.cc:
        Auto merged
      storage/heap/ha_heap.cc:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisammrg/ha_myisammrg.h:
        Auto merged
      8b110160
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 43b9ff1b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26261-5.0-opt
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      mysql-test/r/insert_update.result:
        SCCS merged
      mysql-test/t/insert_update.test:
        SCCS merged
      43b9ff1b
    • unknown's avatar
      Bug #26261: · 2e8e78a4
      unknown authored
       INSERT uses query_id to verify what fields are
       mentioned in the fields list of the INSERT command.
       However the check for that is made after the 
       ON DUPLICATE KEY is processed. This causes all
       the fields mentioned in ON DUPLICATE KEY to be 
       considered as mentioned in the fields list of 
       INSERT.
       Moved the check up, right after processing the
       fields list.
      
      
      mysql-test/r/insert_update.result:
        Bug #26261: test case
      mysql-test/t/insert_update.test:
        Bug #26261: test case
      sql/mysql_priv.h:
        Bug #26261: moved the check inside mysql_prepare_insert
      sql/sql_insert.cc:
        Bug #26261: move the check inside mysql_prepare_insert
        before setting up the ON DUPLICATE KEY part
      sql/sql_prepare.cc:
        Bug #26261: moved the check inside mysql_prepare_insert
      2e8e78a4
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 1a259b88
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      1a259b88
    • unknown's avatar
      Bug#26285 selecting information_schema crahes server · a51b7686
      unknown authored
      The crash happens when 'skip-grant-tables' is enabled.
      We skip the filling of I_S privilege tables 
      if acl_cache is not initialized.
      
      
      mysql-test/r/skip_grants.result:
        test result
      mysql-test/t/skip_grants.test:
        test case
      sql/sql_acl.cc:
        skip filling of I_S privilege tables
        if acl_cache is not initialized
      a51b7686
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 0270e811
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      0270e811
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 6b428e85
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      6b428e85
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 68197e53
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      68197e53
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · eac4c7ee
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/sql_parse.cc:
        Auto merged
      eac4c7ee
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 173dc70d
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/sql_parse.cc:
        Auto merged
      173dc70d