1. 12 Nov, 2007 7 commits
  2. 11 Nov, 2007 4 commits
    • unknown's avatar
      Bug#31210 - INSERT DELAYED crashes server when used on · 076f2f73
      unknown authored
                    partitioned table
        
      Post-pushbuild fix
        
      Pushbuild detected a new need for lex initialization in
      embedded server.
      
      Fixed test for INSERT DELAYED in partitions_hash.test so that
      it works with embedded server.
      
      
      libmysqld/lib_sql.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                        partitioned table
        Initialized lex for later use in open_table().
      mysql-test/r/partition_hash.result:
        Bug#31210 - INSERT DELAYED crashes server when used on
                        partitioned table
        Fixed test result for embedded server.
      mysql-test/t/partition_hash.test:
        Bug#31210 - INSERT DELAYED crashes server when used on
                        partitioned table
        Fixed test for embedded server.
      076f2f73
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · dfc9edd2
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      dfc9edd2
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · f5afaa04
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      sql/event_scheduler.cc:
        Auto merged
      sql/events.cc:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      f5afaa04
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 47e43632
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      47e43632
  3. 10 Nov, 2007 2 commits
    • unknown's avatar
      Bug#31210 - INSERT DELAYED crashes server when used on · bb532df5
      unknown authored
                  partitioned table
      
      Post-merge fix
      
      A new need for lex initialization arose.
      
      
      sql/ha_ndbcluster.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      bb532df5
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-engines · 4b1e7b75
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-bug31210
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_servers.cc:
        Auto merged
      sql/sql_udf.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      4b1e7b75
  4. 09 Nov, 2007 1 commit
  5. 08 Nov, 2007 1 commit
  6. 07 Nov, 2007 2 commits
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/p1-bug30671.3 · 15a5881c
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/p1-bug30671.3.merge-5.1
      
      
      15a5881c
    • unknown's avatar
      Bug#22351 - handler::index_next_same() call to key_cmp_if_same() uses · 9e081bd2
      unknown authored
                  the wrong buffer
      
      handler::index_next_same() did not take into account that the
      internally called function key_cmp_if_same() uses the fixed
      buffer table->record[0] for key comparison instead of the
      buffer provided by the caller of handler::index_next_same().
      
      Added code to temporarily redirect table->record[0] and the fields
      used for the key to the record buffer provided by the caller of
      handler::index_next_same().
      
      The test case is in partition.test already.
      
      
      sql/handler.cc:
        Bug#22351 - handler::index_next_same() call to key_cmp_if_same() uses
                    the wrong buffer
        Added code to temporarily redirect table->record[0] and the fields
        used for the key to the record buffer provided by the caller of
        handler::index_next_same().
      9e081bd2
  7. 06 Nov, 2007 12 commits
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · af48b26e
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-runtime
      
      
      af48b26e
    • unknown's avatar
      BUG#32111 - Security Breach via DATA/INDEX DIRECORY and RENAME TABLE · ff4b438b
      unknown authored
      RENAME TABLE against a table with DATA/INDEX DIRECTORY overwrites
      the file to which the symlink points.
      
      This is security issue, because it is possible to create a table with
      some name in some non-system database and set DATA/INDEX DIRECTORY
      to mysql system database. Renaming this table to one of mysql system
      tables (e.g. user, host) would overwrite the system table.
      
      Return an error when the file to which the symlink points exist.
      
      
      mysql-test/r/symlink.result:
        A test case for BUG#32111.
      mysql-test/t/symlink.test:
        A test case for BUG#32111.
      mysys/my_symlink2.c:
        Return an error when the file to which the symlink points exist.
      ff4b438b
    • unknown's avatar
      Bug#4692 - DISABLE/ENABLE KEYS waste a space · a26201f8
      unknown authored
      Post-merge fix. Moved test into 5.0 section.
      
      
      a26201f8
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 9860fd24
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/ctype_uca.test:
        Auto merged
      mysql-test/r/myisam.result:
        Manual merge from 5.0.
      mysql-test/t/myisam.test:
        Manual merge from 5.0.
      mysql-test/t/subselect.test:
        Manual merge from 5.0.
      storage/myisam/mi_check.c:
        Manual merge from 5.0.
      9860fd24
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · c33d42eb
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31974-5.1-runtime
      
      
      c33d42eb
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 31d6d018
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      31d6d018
    • unknown's avatar
      Bug #31974: additional commit (test case updates) · 17698ca0
      unknown authored
       loose index scan enabled for subqueries
      
      
      mysql-test/r/group_min_max.result:
        Bug #31974: test case updates
         loose index scan enabled for subqueries
      mysql-test/r/index_merge_myisam.result:
        Bug #31974: test case updates
         loose index scan enabled for subqueries
      17698ca0
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 85425773
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      85425773
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 1a359e14
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      1a359e14
    • unknown's avatar
      Bug#4692 - DISABLE/ENABLE KEYS waste a space · 42829c61
      unknown authored
      Disabling and enabling indexes on a non-empty table grows the
      index file.
      
      Disabling indexes just sets a flag per non-unique index and does not
      free the index blocks of the affected indexes. Re-enabling indexes
      creates new indexes with new blocks. The old blocks remain unused
      in the index file.
      
      Fixed by dropping and re-creating all indexes if non-empty disabled
      indexes exist when enabling indexes. Dropping all indexes resets
      the internal end-of-file marker to the end of the index file header.
      It also clears the root block pointers of every index and clears the
      deleted blocks chains. This way all blocks are declared as free.
      
      
      myisam/mi_check.c:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added function mi_drop_all_indexes() to support drop of all indexes
        in case we want to re-enable non-empty disabled indexes.
        Changed mi_repair(), mi_repair_by_sort(), and mi_repair_parallel()
        to use the new function instead of duplicate drop index code.
      mysql-test/r/myisam.result:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added test result.
      mysql-test/t/myisam.test:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added test.
      42829c61
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.0-engines · 490591a5
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.1-engines
      
      
      storage/myisam/ft_parser.c:
        Use local.
      490591a5
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 0c185254
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.0-engines
      
      
      0c185254
  8. 05 Nov, 2007 11 commits
    • unknown's avatar
      fixed coding style · cecc2702
      unknown authored
      
      sql/sql_yacc.yy:
        Fixed coding style (tabs)
      cecc2702
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-runtime · b5bf2f73
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
      
      
      sql/sql_acl.cc:
        Auto merged
      b5bf2f73
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-base · 56d00051
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
      
      
      sql/handler.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      56d00051
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-base · 441b8608
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
      
      
      441b8608
    • unknown's avatar
      Bug#31210 - INSERT DELAYED crashes server when used on · e5b2745e
      unknown authored
                  partitioned table
      
      Trying INSERT DELAYED on a partitioned table, that has not been
      used right before, crashes the server. When a table is used for
      select or update, it is kept open for some time. This period I
      mean with "right before".
      
      Information about partitioning of a table is stored in form of
      a string in the .frm file. Parsing of this string requires a
      correctly set up lexical analyzer (lex). The partitioning code
      uses a new temporary instance of a lex. But it does still refer
      to the previously active lex. The delayd insert thread does not
      initialize its lex though...
      
      Added initialization for thd->lex before open table in the delayed
      thread and at all other places where it is necessary to call
      lex_start() if all tables would be partitioned and need to parse
      the .frm file.
      
      
      mysql-test/r/partition_hash.result:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Added test result
      mysql-test/t/partition_hash.test:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Added test
      sql/event_scheduler.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/events.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/ha_ndbcluster_binlog.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/slave.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/sql_acl.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/sql_base.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Asserted that lex is initialized in open_table().
      sql/sql_connect.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/sql_insert.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Added initialization for thd->lex before open table.
      sql/sql_lex.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Added 'is_lex_started' to test if lex is initialized.
      sql/sql_lex.h:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Added 'is_lex_started' to test if lex is initialized.
      sql/sql_plugin.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/sql_servers.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/sql_udf.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      sql/table.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Asserted that lex is initialized in open_table_from_share().
      sql/tztime.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      e5b2745e
    • unknown's avatar
      Bug#32108 - subselect.test produces warnings files · 6f12c924
      unknown authored
      Comment sign of -- at line begin in test files lead to warnings
      from mysqltest.
        
      Changed -- to #.
      
      
      mysql-test/t/subselect.test:
        Bug#32108 - subselect.test produces warnings files
        Changed -- to # at comment begin to avoid warnings files.
      6f12c924
    • unknown's avatar
      Bug#32107 - ctype_uca.test produces warnings files · abd6ff86
      unknown authored
      Comment sign of -- at line begin in test files lead to warnings
      from mysqltest.
        
      Changed -- to #.
      
      
      mysql-test/t/ctype_uca.test:
        Bug#32107 - ctype_uca.test produces warnings files
        Changed -- to # at comment begin to avoid warnings files.
      abd6ff86
    • unknown's avatar
      BUG#31611 (Security risk with BINLOG statement): · cda4afc2
      unknown authored
      Incremental patch to remove redundant, but benign, my_error() call.
      
      
      sql/sql_binlog.cc:
        Removing redundant error reporting.
      cda4afc2
    • unknown's avatar
      Merge mysqldev@production:/data0/mysqldev/my/mysql-5.1-release · 5d8ade4b
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b31611-mysql-5.1-target-5.1.22
      
      
      5d8ade4b
    • unknown's avatar
      workaround for case insensitive filesystems · 8a1ede49
      unknown authored
      8a1ede49
    • unknown's avatar
      Bug #31974: Wrong EXPLAIN output · 860f7db3
      unknown authored
      The fix for bug 31148 is not correct. It does not
      have a relation to the problem described in this bug.
      And removing the fix will not make the bug to re-appear.
      Fixed the bug #31974 by removing the fix for bug 31148
      and adding a test case.
      
      
      mysql-test/r/key.result:
        Bug #31974: test case
      mysql-test/t/key.test:
        Bug #31974: test case
      sql/sql_select.cc:
        Bug #31974: revert the fix for bug 31148
      860f7db3