1. 31 Mar, 2008 1 commit
    • unknown's avatar
      Updating commit.inc since the number of commits done for non-transactional · 600a664a
      unknown authored
      tables is not zero any more. For row-based logging, there is an extra commit
      for sending rows changed by the statement to the binary log.
      
      
      mysql-test/include/commit.inc:
        For row-based logging, an extra commit is done for each statement to commit
        non-transactional changes to the binary log.
      mysql-test/r/commit_1innodb.result:
        Result change.
      600a664a
  2. 28 Mar, 2008 23 commits
    • unknown's avatar
      Fixes to eliminate compiler warnings. · e44403fe
      unknown authored
      
      sql/log.cc:
        Reordering initialalizer list to eliminate compiler warnings.
      e44403fe
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 74c2a019
      unknown authored
      into  mats-laptop.(none):/home/bk/b29020-mysql-5.1-rpl
      
      
      sql/sql_insert.cc:
        Auto merged
      74c2a019
    • unknown's avatar
      Post-merge fixes to remove test failures resulting from merge. · 313947b1
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_row_ctype_ucs.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraCol_myisam.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_switch_stm_row_mixed.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_switch_stm_row_mixed.test:
        Removing rows causing tests to be non-deterministic.
      313947b1
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 0bb5e6de
      unknown authored
      into  moonbone.local:/work/27219-bug-5.1
      
      
      0bb5e6de
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 85063c08
      unknown authored
      into  mysql.com:/home/ram/work/mysql-5.1-bugteam
      
      
      85063c08
    • unknown's avatar
      Fix for bug #35392: Delete all statement does not execute properly · 0795e14c
      unknown authored
      after few delete statements
      
      Problem: changing a file size might require that it must be 
      unmapped beforehand.
        
      Fix: unmap the file before changing its size.
      
      
      mysql-test/r/temp_table.result:
        Fix for bug #35392: Delete all statement does not execute properly 
        after few delete statements
          - test result.
      mysql-test/t/temp_table.test:
        Fix for bug #35392: Delete all statement does not execute properly 
        after few delete statements
          - test case.
      storage/myisam/mi_delete_all.c:
        Fix for bug #35392: Delete all statement does not execute properly 
        after few delete statements
          - unmap file before changing its size as it's required 
            by SetEndOfFile() function (see my_chsize()).
          - as no other threads allowed to perform concurrent inserts 
            when delete_all is called, mmap_lock locking removed.
      0795e14c
    • unknown's avatar
      Merge moonbone.local:/work/27219-5.0-opt-mysql · fbbb60ce
      unknown authored
      into  moonbone.local:/work/27219-bug-5.1
      
      
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/group_by.result:
        SCCS merged
      mysql-test/t/group_by.test:
        SCCS merged
      sql/item.cc:
        SCCS merged
      sql/sql_lex.h:
        SCCS merged
      fbbb60ce
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-51-engines · 8c5eebfc
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-51-bugteam
      
      
      8c5eebfc
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 2e12a17d
      unknown authored
      into  mats-laptop.(none):/home/bk/b29020-mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_base64_flag.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      2e12a17d
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-50-engines · d0b5b3fa
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-51-engines
      
      
      sql/sql_insert.cc:
        Auto merged
      d0b5b3fa
    • unknown's avatar
      Merge witty.:/Users/mattiasj/Public/shared-vms/bug21413-41-engines · 32d232ff
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-engines
      
      
      sql/sql_insert.cc:
        Manual merge
      32d232ff
    • unknown's avatar
      Bug#21413 - Engine table handler used by multiple threads · fe22ff56
      unknown authored
                  in REPLACE DELAYED
          
      post push patch, removing the optimization for
      copying delayed_insert variables.
      
      
      sql/sql_insert.cc:
        Bug#21413 - Engine table handler used by multiple threads
                    in REPLACE DELAYED
        
        post push patch, removing the optimization for
        copying delayed_insert variables.
        (restored some parts which caused errors)
      fe22ff56
    • unknown's avatar
      BUG#29020 (Event results not correctly replicated to slave in RBR): · f56d77da
      unknown authored
      The bug allow multiple executing transactions working with non-transactional
      to interfere with each others by interleaving the events of different trans-
      actions.
      
      Bug is fixed by writing non-transactional events to the transaction cache and
      flushing the cache to the binary log at statement commit. To mimic the behavior
      of normal statement-based replication, we flush the transaction cache in row-
      based mode when there is no committed statements in the transaction cache,
      which means we are committing the first one. This means that it will be written
      to the binary log as a "mini-transaction" with just the rows for the statement.
      
      Note that the changes here does not take effect when building the server with
      HAVE_TRANSACTIONS set to false, but it is not clear if this was possible before
      this patch either.
      
      For row-based logging, we also have that when AUTOCOMMIT=1, the code now always
      generates a BEGIN/COMMIT pair for single statements, or BEGIN/ROLLBACK pair in the
      case of non-transactional changes in a statement that was rolled back. Note that
      for the case where changes to a non-transactional table causes a rollback due
      to error, the statement will now be logged with a BEGIN/ROLLBACK pair, even
      though some changes has been committed to the non-transactional table.
      
      
      mysql-test/extra/rpl_tests/rpl_row_delayed_ins.test:
        Removing SHOW BINLOG EVENTS causing test to be non-deterministic.
      mysql-test/r/ctype_cp932_binlog_row.result:
        Result change.
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Result change.
      mysql-test/suite/binlog/r/binlog_multi_engine.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_binlog.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_ctype_ucs.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_insert_select.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        Result file change.
      mysql-test/suite/binlog/r/binlog_stm_binlog.result:
        Result file change.
      mysql-test/suite/binlog/t/binlog_base64_flag.test:
        Removing table that will be used in test to prevent failing if preceeding
        tests forgot to drop the table.
      mysql-test/suite/rpl/r/rpl_rbr_to_sbr.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_basic_11bugs.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_delayed_ins.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_flsh_tbls.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_inexist_tbl.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_log.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_log_innodb.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_row_until.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_slave_skip.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_switch_stm_row_mixed.result:
        Result file change.
      mysql-test/suite/rpl/r/rpl_truncate_2myisam.result:
        Result file change.
      mysql-test/suite/rpl/t/rpl_row_create_table.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_row_flsh_tbls.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test:
        Binlog position change. Added stop position to mysqlbinlog argments to prevent
        extreneous output.
      mysql-test/suite/rpl/t/rpl_row_until.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_slave_skip.test:
        Binlog position change.
      mysql-test/suite/rpl/t/rpl_switch_stm_row_mixed.test:
        Removing extreneous SHOW BINLOG EVENTS causing test to be non-deterministic.
      mysql-test/suite/rpl_ndb/r/rpl_ndb_log.result:
        Result change.
      sql/log.cc:
        Adding variable at_least_one_stmt to denote that there is at least one
        statement committed to the transaction cache (but there might be more).
        
        Removing duplicate checks from binlog_end_trans(). The transaction cache
        should always be committed or rolled back when this function is called.
        
        Correcting conditions for binlog_rollback() and binlog_commit() and removing
        the previous "invisible commit" in favor of always using explicit commits
        in the binary log.
      sql/log_event.cc:
        Marking table map event to be cached. Removing Muted_query_log_event from code.
      sql/log_event.h:
        Removing unused class Muted_query_log_event.
      sql/sql_insert.cc:
        Adding missing call to ha_autocommit_or_rollback() for delayed thread. Marking
        CREATE-SELECT statements as transactional, since they don't need to be logged.
      f56d77da
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam · 7c156537
      unknown authored
      into  moonbone.local:/work/27219-5.0-opt-mysql
      
      
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7c156537
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam · 9d0385d6
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      9d0385d6
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 347972bc
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      347972bc
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · ab82016a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      ab82016a
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam · 183ded7a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      183ded7a
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 1c734848
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      1c734848
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · c1af64e0
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      c1af64e0
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · b6b4202b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      
      b6b4202b
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam · 8e5c29fa
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/grant.result:
        merge 5.0-bugteam to 5.1-bugteam
      8e5c29fa
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 5cae19a8
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B35206-5.1-bugteam
      
      
      sql/sql_select.cc:
        Auto merged
      5cae19a8
  3. 27 Mar, 2008 16 commits
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.0-opt · 0cf83bbf
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.1-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      0cf83bbf
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.0 · ed1d366a
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.0-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      ed1d366a
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.1 · ea4c84ea
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.1-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      ea4c84ea
    • unknown's avatar
      Bug #35206: select query result different if the key is indexed or not · 77fbeeab
      unknown authored
      The code for executing indexed ORDER BY was not setting all the 
      internal fields correctly when selecting to execute ORDER BY over
      and index.
      Fixed by change the access method to one that will use the 
      quick indexed access if one is selected while selecting indexed
      ORDER BY.
      
      
      mysql-test/r/order_by.result:
        Bug #35206: test case
      mysql-test/t/order_by.test:
        Bug #35206: test case
      sql/sql_select.cc:
        Bug #35206: Change the access method when selecting a 
        quick indexed access.
      77fbeeab
    • unknown's avatar
      Bug#27219: Aggregate functions in ORDER BY. · 9d661efd
      unknown authored
      Mixing aggregate functions and non-grouping columns is not allowed in the
      ONLY_FULL_GROUP_BY mode. However in some cases the error wasn't thrown because
      of insufficient check.
      
      In order to check more thoroughly the new algorithm employs a list of outer
      fields used in a sum function and a SELECT_LEX::full_group_by_flag.
      Each non-outer field checked to find out whether it's aggregated or not and
      the current select is marked accordingly.
      All outer fields that are used under an aggregate function are added to the
      Item_sum::outer_fields list and later checked by the Item_sum::check_sum_func
      function.
      
      
      mysql-test/t/group_by.test:
        Added a test case for the bug#27219: Aggregate functions in ORDER BY.
      mysql-test/r/group_by.result:
        Added a test case for the bug#27219: Aggregate functions in ORDER BY.
      sql/sql_select.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Implementation of new check for mixing non aggregated fields and aggregation
        function in the ONLY_FULL_GROUP_BY mode.
      sql/sql_lex.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Initialization of the full_group_by_flag bitmap.
        SELECT_LEX::test_limit function doesn't reset ORDER BY
        clause anymore.
      sql/sql_lex.h:
        Bug#27219: Aggregate functions in ORDER BY.
        The full_group_by_flag is added to the SELECT_LEX class.
      sql/item_sum.h:
        Bug#27219: Aggregate functions in ORDER BY.
        The outer_fields list is added to the Item_sum class.
      sql/mysql_priv.h:
        Bug#27219: Aggregate functions in ORDER BY.
        Defined a set of constants used in the new check for mixing non aggregated
        fields and sum functions in the ONLY_FULL_GROUP_BY_MODE.
      sql/item_subselect.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        The Item_in_subselect::select_in_like_transformer function now drops
        ORDER BY clause in all selects in a subquery.
      sql/item_sum.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Now the Item_sum::check_sum_func function now checks whether fields in the
        outer_fields list are aggregated or not and marks selects accordingly.
      sql/item.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Now the Item_field::fix_fields function checks whether the field is aggregated
        or not and marks its select_lex accordingly.
      9d661efd
    • unknown's avatar
      Bug#35272: @@global.key_buffer_size = 4294967295 let the server crash · f6013e63
      unknown authored
      reverting test that has been obsoleted by changes to the code
      
      
      mysql-test/r/key_cache.result:
        reverting test that has been obsoleted by changes to the code
      mysql-test/t/key_cache.test:
        reverting test that has been obsoleted by changes to the code
      f6013e63
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt · 1561ee5c
      unknown authored
      into  host.loc:/home/uchum/work/5.1-opt
      
      
      configure.in:
        Auto merged
      sql/item.cc:
        Auto merged
      1561ee5c
    • unknown's avatar
      Merge host.loc:/home/uchum/work/mysql-5.0 · 8e473edd
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      configure.in:
        Auto merged
      sql/item.cc:
        Auto merged
      8e473edd
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-50-engines · 0fa61bb8
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-51-engines
      
      
      sql/sql_insert.cc:
        manual merge
      0fa61bb8
    • unknown's avatar
      Merge witty.:/Users/mattiasj/Public/shared-vms/bug21413-41-engines · da9db4ed
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-engines
      
      
      sql/sql_insert.cc:
        Manual merge
      da9db4ed
    • unknown's avatar
      Patch clean up. · f8653a79
      unknown authored
      Fixed interference between tests: Users were added but not properly removed.
      This caused later tests to fail.
      
      
      mysql-test/r/grant.result:
        Fixed interference between tests: Users were added but not properly removed.
        This caused later tests to fail.
      mysql-test/t/grant.test:
        Fixed interference between tests: Users were added but not properly removed.
        This caused later tests to fail.
      f8653a79
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 099c8889
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      099c8889
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 0c2b6330
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      0c2b6330
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 0db1f520
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      0db1f520
    • unknown's avatar
      Merge trift2.:/MySQL/M51/ndb-decl-5.1 · a0cf1fa1
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      a0cf1fa1
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/mysql-5.1-bug33201 · 861434c3
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.0-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      861434c3