1. 21 Mar, 2012 3 commits
  2. 20 Mar, 2012 6 commits
  3. 16 Mar, 2012 3 commits
  4. 15 Mar, 2012 9 commits
  5. 14 Mar, 2012 5 commits
    • Mattias Jonsson's avatar
      merge of bug#1364811 into mysql-5.5 · aaf0e5d6
      Mattias Jonsson authored
      aaf0e5d6
    • Mattias Jonsson's avatar
      bug#13694811 · f8eb6262
      Mattias Jonsson authored
      Updated code comments according to reviewers requests.
      f8eb6262
    • Tor Didriksen's avatar
      Bug#13832772 ASSERTION `THD->IS_ERROR() || KILL_ERRNO' · cfea7c7d
      Tor Didriksen authored
      We are trying to sort a lot of text/blob fields, 
      so the buffer is indeed too small.
      Memory available = thd->variables.sortbuff_size = 262144
      min_sort_memory = param.sort_length*MERGEBUFF2 = 292245
      So the decision to abort the query is correct.
      
      filesort() calls my_error(), the error is reported.
      But, since we have DELETE IGNORE ... the error is converted to a warning by
      THD::raise_condition
      
      filesort currently expects an error to be recorded in the THD diagnostics
      area.
      If we lift this restriction (remove the assert) we end up in the familiar
      void Protocol::end_statement()
        default:
          DBUG_ASSERT(0);
      
      The solution seems to be to call my_error(ME_FATALERROR) in filesort,
      so that the error is propagated as an error rather than a warning.
      cfea7c7d
    • sayantan.dutta@oracle.com's avatar
    • Chaithra Gopalareddy's avatar
      Bug#12626844 : WE ARE NOT CHECKING VIEW TABLE NAMES · d93559f9
      Chaithra Gopalareddy authored
                     ENOUGH - CONCAT() HACKS. ALSO WRONG
                     ERROR MESSAGE WHILE TRYING TO CREATE
                     A VIEW ON A NON EXISTING DATABASE
      
      PROBLEM:
      The first part of the problem is concluded as not a
      bug, as 'concat' is not a reserved word and it is
      completely valid to create a view with the name
      'concat'.
      
      The second issue is, while trying to create a view on
      a non existing database, we are not giving a proper error
      message.
      
      FIX:
      We have added a check for the database existence while
      trying to create a view. This check would give an error
      as 'unknown database' when the database does not exist.
      
      This patch is a backport of the patch for Bug#13601606
      d93559f9
  6. 12 Mar, 2012 10 commits
    • Luis Soares's avatar
      BUG#12400313 · 08006055
      Luis Soares authored
      Automerging from mysql-5.1.
      08006055
    • Luis Soares's avatar
      BUG#12400313 · 975e6708
      Luis Soares authored
      Adding missing sync_slave_with_master to the test case.
      975e6708
    • Luis Soares's avatar
      BUG#12400313 · 03ffa2e5
      Luis Soares authored
      Fixing waiting condition. "enter_cond" text changed in 5.5+ (when the SQL thread
      is waiting for more events).
      03ffa2e5
    • Luis Soares's avatar
      BUG#12400313 · 574aace5
      Luis Soares authored
      Automerge changes to the test case from mysql-5.1.
      574aace5
    • Luis Soares's avatar
      Automerge merge with latest mysql-5.1. · deb49a26
      Luis Soares authored
      deb49a26
    • Luis Soares's avatar
      BUG#12400313 · ab03c5ba
      Luis Soares authored
      Hardening the test case:
        - including a diff_tables at the end.
        - increasing the tolerance on the relay limit size.
      ab03c5ba
    • Luis Soares's avatar
      BUG#12400313 · b06a48e4
      Luis Soares authored
      Manual merge from mysql-5.1 into mysql-5.5.
      
      CONFLICTS
      =========
        Text conflict in sql/log.cc
        Text conflict in sql/slave.cc
      b06a48e4
    • Luis Soares's avatar
      BUG#12400313 · c41a6fec
      Luis Soares authored
      Automerge with mysql-5.1.
      c41a6fec
    • Inaam Rana's avatar
      Bug#13789853 SHOW ENGINE INNODB STATUS HANGS DUE TO EXCESSIVE WORK · 273c6262
      Inaam Rana authored
      IN LOCK_VALIDATE()
      
      rb://917
      approved by: Marko Makela
      
      In lock_validate() the limit is used to release the kernel_mutex during
      the validation, to obey the latching order.
      If we do the limit++ then we are rechecking the same lock most times on
      each iteration because limit is being incremented by one and
      <space, page_no> will nearly always be > limit. If we set the limit
      correctly to (space, page+1) then we are actually making progress
      during the iteration.
      273c6262
    • Luis Soares's avatar
      BUG#12400313 RELAY_LOG_SPACE_LIMIT IS NOT WORKING IN MANY CASES · 5360c4e5
      Luis Soares authored
      BUG#64503: mysql frequently ignores --relay-log-space-limit
      
      When the SQL thread goes to sleep, waiting for more events, it sets
      the flag ignore_log_space_limit to true. This gives the IO thread a
      chance to queue some more events and ultimately the SQL thread will be
      able to purge the log once it is rotated. By then the SQL thread
      resets the ignore_log_space_limit to false. However, between the time
      the SQL thread has set the ignore flag and the time it resets it, the
      IO thread will be queuing events in the relay log, possibly going way
      over the limit.
      
      This patch makes the IO and SQL thread to synchronize when they reach
      the space limit and only ask for one event at a time. Thus the SQL
      thread sets ignore_log_space_limit flag and the IO thread resets it to
      false everytime it processes one more event. In addition, everytime
      the SQL thread processes the next event, and the limit has been
      reached, it checks if the IO thread should rotate. If it should, it
      instructs the IO thread to rotate, giving the SQL thread a chance to
      purge the logs (freeing space). Finally, this patch removes the
      resetting of the ignore_log_space_limit flag from purge_first_log,
      because this is now reset by the IO thread every time it processes the
      next event when the limit has been reached.
      
      If the SQL thread is in a transaction, it cannot purge so, there is no
      point in asking the IO thread to rotate. The only thing it can do is
      to ask for more events until the transaction is over (then it can ask
      the IO to rotate and purge the log right away). Otherwise, there would
      be a deadlock (SQL would not be able to purge and IO thread would not
      be able to queue events so that the SQL would finish the transaction).
      5360c4e5
  7. 09 Mar, 2012 3 commits
  8. 08 Mar, 2012 1 commit