1. 22 Feb, 2007 1 commit
    • unknown's avatar
      Prevent bugs by making DBUG_* expressions syntactically equivalent · 607c2249
      unknown authored
      to a single statement.
      ---
      Bug#24795: SHOW PROFILE
      
      Profiling is only partially functional on some architectures.  Where 
      there is no getrusage() system call, presently Null values are 
      returned where it would be required.  Notably, Windows needs some love 
      applied to make it as useful.
      
        Syntax this adds:
        
        SHOW PROFILES
        
        SHOW PROFILE [types] [FOR QUERY n] [OFFSET n] [LIMIT n]
         where "n" is an integer
         and "types" is zero or many (comma-separated) of
            "CPU"
            "MEMORY" (not presently supported)
            "BLOCK IO"
            "CONTEXT SWITCHES"
            "PAGE FAULTS"
            "IPC"
            "SWAPS"
            "SOURCE"
            "ALL"
      
      It also adds a session variable (boolean) "profiling", set to "no"
      by default, and (integer) profiling_history_size, set to 15 by 
      default.
      
      This patch abstracts setting THDs' "proc_info" behind a macro that 
      can be used as a hook into the profiling code when profiling 
      support is compiled in.  All future code in this line should use
      that mechanism for setting thd->proc_info.
      
      ---
      
      Tests are now set to omit the statistics.
      
      ---
      
      Adds an Information_schema table, "profiling" for access to 
      "show profile" data.
      ---
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-community-3--bug24795
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-community
      ---
      Fix merge problems.
      ---
      Fixed one bug in the query_source being NULL.  
      
      Updated test results.
      ---
      Include more thorough profiling tests.
      
      Improve support for prepared statements.
      
      Use session-specific query IDs, starting at zero.
      ---
      Selecting from I_S.profiling is no longer quashed in profiling, as
      requested by Giuseppe.
      
      Limit the size of captured query text.
      
      No longer log queries that are zero length.
      
      
      BitKeeper/deleted/.del-profile.result:
        Rename: mysql-test/r/profile.result -> BitKeeper/deleted/.del-profile.result
      BitKeeper/deleted/.del-profile.test:
        Rename: mysql-test/t/profile.test -> BitKeeper/deleted/.del-profile.test
      BitKeeper/deleted/.del-sql_profile.cc:
        Rename: sql/sql_profile.cc -> BitKeeper/deleted/.del-sql_profile.cc
      BitKeeper/deleted/.del-sql_profile.h:
        Rename: sql/sql_profile.h -> BitKeeper/deleted/.del-sql_profile.h
      configure.in:
        Add a configure-time option to enable/disable query profiling.  The
        default is enabled.
      include/my_dbug.h:
        
        
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
      myisam/mi_open.c:
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
      mysql-test/r/information_schema.result:
        Updated (re-recorded) tests that I missed somehow.  I verified these
        for correctness.
      mysql-test/r/information_schema_db.result:
        Updated test results I missed.
      mysql-test/r/mysqlshow.result:
        Fix merge problems.
      ndb/src/ndbapi/DictCache.cpp:
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
      sql/ha_archive.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/ha_berkeley.cc:
        Include patch backported to 5.0-global.
        
        THD::options is a ulonglong, not ulong.
      sql/ha_myisam.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/ha_myisammrg.cc:
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
      sql/ha_ndbcluster.cc:
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
      sql/item_cmpfunc.cc:
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
      sql/item_func.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/lock.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/log_event.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/mysql_priv.h:
        Use 64-bit constants for the 64-bit bit field.
        
        Add a new option bit for whether profiling is active or not.
      sql/mysqld.cc:
        Add semicolon to DBUG statement.
        
        Add a new system variable and set it.
        ---
        Set the minimum, which is zero and not 50.
      sql/repl_failsafe.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/set_var.cc:
        Make a new system global variable and session variable, to determine
        behavior of profiling.	
        ---
        Include patch backported to 5.0-global.
        
        THD::options is a ulonglong, not ulong.
      sql/set_var.h:
        The THD::options bit field is ulonglong, not ulong.
      sql/slave.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
        ---
        Include patch backported to 5.0-global.
        
        THD::options is a ulonglong, not ulong.
      sql/sp_head.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/sql_base.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
        ---
        Include patch backported to 5.0-global.
        
        THD::options is a ulonglong, not ulong.
      sql/sql_cache.cc:
        DBUG_* statements should be syntactically equivalent to a single 
        statement.
        ---
        Fix merge problems.
      sql/sql_class.cc:
        Insert a pointer to the current thread in the profiling code.
        ---
        Manual merge, undoing first patch.
        ---
        Fix merge problems.
      sql/sql_class.h:
        Create a new system variable, profiling_history_size, and add a 
        member to THD to hold profiling information about this thread's 
        execution.
        ---
        Manual merge, undoing first patch.
      sql/sql_delete.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
        ---
        Include patch backported to 5.0-global.
        
        THD::options is a ulonglong, not ulong.
      sql/sql_insert.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
        ---
        Fix merge problems.
      sql/sql_lex.cc:
        Initialize profiling options to empty.
        ---
        Manual merge, undoing first patch.
      sql/sql_lex.h:
        Add info to the lexer object so that we can hold data that comes from
        parsing statements.
        
        Reuse memory addresses of uints that can't occur in the same state-
        ment.
        
        This is dangerous because it involves knowledge of what symbols are 
        never used together, which is information stored obliquely in another
        file.
        ---
        Manual merge, undoing first patch.
      sql/sql_parse.cc:
        Add hooks to the parser to jump to profiling code.
        
        If profiling is not present, then return an error message upon being
        used.
        ---
        Manual merge, undoing first patch.
        ---
        Fix merge problems.
        ---
        Include patch backported to 5.0-global.
        
        THD::options is a ulonglong, not ulong.
      sql/sql_prepare.cc:
        From prepared statement execution, set the query source in the 
        profiler, as we can't get it from  thd .
        ---
        Make it less expensive to limit the size of the queries.
      sql/sql_repl.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/sql_select.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
        ---
        Fix merge problems.
      sql/sql_show.cc:
        Abstract setting thread-info into a function or macro.
        
        Also, remove "static" qualification on schema_table_store_record()
        so that external functions may use it.
        ---
        Manual merge, undoing first patch.
      sql/sql_table.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/sql_update.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/sql_view.cc:
        Abstract setting thread-info into a function or macro.
        ---
        Manual merge, undoing first patch.
      sql/sql_yacc.yy:
        Add new lexer symbols and insert new grammatical rules necessary to 
        retreive profiling information.
        ---
        Manual merge, undoing first patch.
        ---
        Fix merge problems.
      sql/table.h:
        Add enum item for query profiling.
      BitKeeper/deleted/.del-profiling-master.opt:
        New BitKeeper file ``mysql-test/t/profiling-master.opt''
      mysql-test/r/profiling.result:
        New BitKeeper file ``mysql-test/r/profiling.result''
        ---
        Include more verbose that describes the queries so far.
        
        Include Giuseppe's tests.
        ---
        Selecting from I_S.profiling is no longer quashed in profiling, as
        requested by Giuseppe.
      mysql-test/t/profiling.test:
        New BitKeeper file ``mysql-test/t/profiling.test''
        ---
        Include more verbose that describes the queries so far.
        
        Include Giuseppe's tests.
        ---
        Selecting from I_S.profiling is no longer quashed in profiling, as
        requested by Giuseppe.
      sql/sql_profile.cc:
        New BitKeeper file ``sql/sql_profile.cc''
        ---
        If query_source is NULL, as can sometimes happen, then don't try
        to copy that memory.
        ---
        Make each new session use its own numbering of query_ids, and not
        show the global-pool numbers to the user.
        
        Provide a way for prepared statements to set the query_source.
        ---
        Selecting from I_S.profiling is no longer quashed in profiling, as
        requested by Giuseppe.
        
        Limit the size of captured query text.
        
        No longer log queries that are zero length.
      sql/sql_profile.h:
        New BitKeeper file ``sql/sql_profile.h''
        ---
        Make each new session use its own numbering of query_ids, and not
        show the global-pool numbers to the user.
        
        Provide a way for prepared statements to set the query_source.
        ---
        Make it less expensive to limit the size of the queries.
      607c2249
  2. 18 Jan, 2007 3 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-community · 98d31c69
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-community
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      98d31c69
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-community--bug24822 · 83d06868
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-community
      
      
      83d06868
    • unknown's avatar
      Bug#24822: Patch: uptime_since_flush_status · 351b9664
      unknown authored
      Provide the number of seconds since flush as a new status variable
      named "Uptime_since_flush_status".
      ---
      Override the post-flush value, as a second could pass between the two
      statements.
      
      
      mysql-test/r/information_schema.result:
        Test new status variable.
        ---
        Override the post-flush value, as a second could pass between the two
        statements.
      mysql-test/t/information_schema.test:
        Test new status variable.
        ---
        Override the post-flush value, as a second could pass between the two
        statements.
      sql/mysql_priv.h:
        Add variable to hold previous flush time.
      sql/mysqld.cc:
        Add variable to hold previous flush time.  Insert name for 
        referring to it, and initialize the value.
      sql/sql_show.cc:
        Yield value of elapsed time since flush when asked.
      sql/structs.h:
        Add new show-flush-time to SHOW types enumeration.
      351b9664
  3. 14 Jan, 2007 1 commit
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 384b2121
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-community
      
      
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      384b2121
  4. 12 Jan, 2007 7 commits
  5. 11 Jan, 2007 9 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 46169fdc
      unknown authored
      into  production.mysql.com:/usersnfs/mjorgensen/bktrees/mysql-5.0-community
      
      
      configure.in:
        Auto merged
      sql/item_func.cc:
        Auto merged
      46169fdc
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/mysql-4.1-runtime · 4a819ce1
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      sql/item_func.cc:
        Auto merged
      4a819ce1
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 6ab5bdf3
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      heap/hp_block.c:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      server-tools/instance-manager/listener.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      heap/hp_write.c:
        SCCS merged
      6ab5bdf3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · fcbe66a3
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-4.1-runtime
      
      
      sql/item_func.cc:
        Auto merged
      fcbe66a3
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 7f9da471
      unknown authored
      into  rakia.gmz:/home/kgeorge/mysql/autopush/B25106-5.0-opt
      
      
      sql/sql_base.cc:
        Auto merged
      7f9da471
    • unknown's avatar
      BUG#25106: A USING clause in combination with a VIEW results in column · 6c41a043
      unknown authored
                 aliases ignored
      When a column reference to a column in JOIN USING is resolved and a new 
      Item is created for this column the user defined name was lost.
      This fix preserves the alias by setting the name of the new Item to the
      original alias.
      
      
      mysql-test/r/join.result:
        BUG#25106: A USING clause in combination with a VIEW results in column
                   aliases ignored
         - test case
      mysql-test/t/join.test:
        BUG#25106: A USING clause in combination with a VIEW results in column
                   aliases ignored
         - test case
      sql/sql_base.cc:
        BUG#25106: A USING clause in combination with a VIEW results in column
                   aliases ignored
         - take the alias of the Item to be replaced and set it into the newly
           allocated Item.
      6c41a043
    • unknown's avatar
      Many files: · a1566a09
      unknown authored
        Reverted change for bug#13859, applied smaller patch from Marko
      
      
      innobase/buf/buf0buf.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/dict/dict0dict.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/fil/fil0fil.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/ha/ha0ha.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/ha/hash0hash.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/include/hash0hash.h:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/lock/lock0lock.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/log/log0recv.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      innobase/thr/thr0loc.c:
        Reverted change for bug#13859, applied smaller patch from Marko
      a1566a09
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · ce3a76a4
      unknown authored
      into  mysql.com:/d2/hf/mr10/my50-mr10
      
      
      sql/mysqld.cc:
        Auto merged
      ce3a76a4
    • unknown's avatar
      Merge mjorgensen@bk-internal.mysql.com:/home/bk/mysql-5.0-sage · 50361d9a
      unknown authored
      into  tiger.mmj.dk:/Users/mmj/bktrees/mysql-5.0
      
      
      configure.in:
        Auto merged
      mysql-test/install_test_db.sh:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      sql/CMakeLists.txt:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      win/configure.js:
        Auto merged
      50361d9a
  6. 10 Jan, 2007 14 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M40/clone-4.0 · 34d5b84b
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      
      VC++Files/mysql.dsw:
        Null-merge: Removal of BerkeleyDB is limited to 4.0
      VC++Files/libmysqld/libmysqld.dsp:
        Null-merge: Removal of BerkeleyDB is limited to 4.0
      VC++Files/mysqldemb/mysqldemb.dsp:
        Null-merge: Removal of BerkeleyDB is limited to 4.0
      VC++Files/mysqlserver/mysqlserver.dsp:
        Null-merge: Removal of BerkeleyDB is limited to 4.0
      VC++Files/sql/mysqld.dsp:
        Null-merge: Removal of BerkeleyDB is limited to 4.0
      VC++Files/sql/mysqldmax.dsp:
        Null-merge: Removal of BerkeleyDB is limited to 4.0
      34d5b84b
    • unknown's avatar
      Merge trift2.:/MySQL/M40/upward-4.0 · 6ee56e41
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      
      mysys/my_read.c:
        Auto merged
      scripts/make_binary_distribution.sh:
        Null merge, because "--platform" is already a real argument in 4.1
      support-files/MySQL-shared-compat.spec.sh:
        Null merge, because the 4.1 version already uses two digits
        for "version40" and "version41".
      6ee56e41
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 10698df6
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-4.1-opt
      
      
      10698df6
    • unknown's avatar
      configure.in: · a4817ace
      unknown authored
        Corrected default for --disable-grant-options
      
      
      configure.in:
        Corrected default for --disable-grant-options
      a4817ace
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 6943153e
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/order_by.result:
        Manual merge
      mysql-test/t/order_by.test:
        Manual merge
      6943153e
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · c11c3b08
      unknown authored
      into  mysql.com:/d2/hf/mr10/my50-mr10
      
      
      c11c3b08
    • unknown's avatar
      configure.in: · 4ffd49d3
      unknown authored
        Removed line accidently inserted when correcting bug#18526
      
      
      configure.in:
        Removed line accidently inserted when correcting bug#18526
      4ffd49d3
    • unknown's avatar
      Merge mysql.com:/d2/hf/common/my50-common · 380ad35c
      unknown authored
      into  mysql.com:/d2/hf/mr10/my50-mr10
      
      
      380ad35c
    • unknown's avatar
      after merge fix · 53c9b0d0
      unknown authored
      53c9b0d0
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/4.1-opt · f5005095
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/mysql_priv.h:
        manual merge
      f5005095
    • unknown's avatar
      Fix for bug#20867 InnoDB Bug - create temporary table+crash => mysqld needs to clean up · ac71a8fa
      unknown authored
      2nd version
      During tmp tables cleanup we get the handler for temporary table
      and delete table using handler method.
      
      
      sql/mysql_priv.h:
        added function prototype
      sql/mysqld.cc:
        added call of mysql_rm_tmp_tables() function
      sql/sql_base.cc:
        mysql_rm_tmp_tables()
        -removed from table_cache_init
        -During tmp tables cleanup we get the handler for temporary table
         and delete table using handler method. 
         it allows to remove orphan records from data dictionary(InnoDB)
      ac71a8fa
    • unknown's avatar
      Fixed bug #25427. · 6fc17dab
      unknown authored
      In the method Item_field::fix_fields we try to resolve the name of
      the field against the names of the aliases that occur in the select
      list. This is done by a call of the function find_item_in_list.
      When this function finds several occurrences of the field name
      it sends an error message to the error queue and returns 0.
      Yet the code did not take into account that find_item_in_list
      could return 0 and tried to dereference the returned value.
      
      
      mysql-test/r/order_by.result:
        Added a test case for bug #25427.
      mysql-test/t/order_by.test:
        Added a test case for bug #25427.
      sql/item.cc:
        Fixed bug #25427.
        In the method Item_field::fix_fields we try to resolve the name of
        the field against the names of the aliases that occur in the select
        list. This is done by a call of the function find_item_in_list.
        When this function finds several occurrences of the field name 
        it sends an error message to the error queue and returns 0.
        Yet the code did not take into account that find_item_in_list
        could return 0 and tried to dereference the returned value.
      6fc17dab
    • unknown's avatar
      WL #3670: Compile-time option to remove GRANT-related startup options · c2e9a4af
      unknown authored
      - configure --disable-grant-options defines DISABLE_GRANT_OPTIONS
      - configure.js/cmake also updated
      - if DISABLE_GRANT_OPTIONS is defined, mysqld no longer recognizes:
        --bootstrap
        --init-file
        --skip-grant-tables
      
      Scripts which rely on those three options are modified to check the environment for MYSQLD_BOOTSTRAP; it should be set to the full path of a mysqld which does handle those options.
      
      For example:
      
      $ export MYSQLD_BOOTSTRAP
      $ MYSQLD_BOOTSTRAP=/path/to/full/MySQL/bin/mysqld
      $ mysql_install_db
      $ make test
      
      
      configure.in:
        WL#3670
        
        Add --disable-grant-options
      mysql-test/install_test_db.sh:
        Add MYSQLD_BOOTSTRAP env variable, to enable test suite to work even if mysqld does not accept --bootstrap or --skip-grant-tables.
      mysql-test/mysql-test-run.pl:
        Add MYSQLD_BOOTSTRAP env variable, to enable test suite to work even if mysqld does not accept --bootstrap or --skip-grant-tables.
      mysql-test/mysql_test_run_new.c:
        Mention need for MYSQLD_BOOTSTRAP in a comment, in case this needs to be used with a mysqld which does not accept the --bootstrap option.
      scripts/mysql_install_db.sh:
        Add MYSQLD_BOOTSTRAP env variable, to enable mysqld_install_db to work even if mysqld does not accept --bootstrap or --skip-grant-tables.
      sql/CMakeLists.txt:
        Add DISABLE_GRANT_OPTIONS define
      sql/mysqld.cc:
        Add DISABLE_GRANT_OPTIONS define, which removes the --bootstrap, --init-file, and --skip-grant-tables options
      win/README:
        Document the DISABLE_GRANT_OPTIONS define
      win/configure.js:
        Handle DISABLE_GRANT_OPTIONS
      c2e9a4af
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b04652e2
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      b04652e2
  7. 09 Jan, 2007 5 commits
    • unknown's avatar
      support-files/MySQL-shared-compat.spec.sh : Dummy, irrelevant change -... · 4374848c
      unknown authored
      support-files/MySQL-shared-compat.spec.sh  :    Dummy, irrelevant change - just trigger a new build.
      
      
      support-files/MySQL-shared-compat.spec.sh:
        Dummy, irrelevant change - just trigger a new build.
      4374848c
    • unknown's avatar
      Fixed bug#16861: User defined variable can have a wrong value if a tmp table was · f094fe55
      unknown authored
      used.
      
      The Item::save_in_field() function is called from fill_record() to fill the 
      new row with data while execution of the CREATE TABLE ... SELECT statement.
      Item::save_in_field() calls val_xxx() methods in order to get values.
      val_xxx() methods do not take into account the result field. Due to this
      Item_func_set_user_var::val_xxx() methods returns values from the original
      table, not from the temporary one.
      
      The save_in_field() member function is added to the Item_func_set_user_var
      class. It detects whether the result field should be used and properly updates
      the value of the user variable.
      
      
      sql/item_func.cc:
        Bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Added the save_in_field() member function to the Item_func_set_user_var class.
      sql/item_func.h:
        Bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Added the save_in_field() member function to the Item_func_set_user_var class.
      mysql-test/r/user_var.result:
        Extended the test case for bug#18681: User defined variable can have a wrong value if
        a tmp table was used.
      mysql-test/t/user_var.test:
        Extended the test case for bug#18681: User defined variable can have a wrong value if
        a tmp table was used.
      f094fe55
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 15bb22c0
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      15bb22c0
    • unknown's avatar
      Bug#14171: Wrong internal default value for a BINARY field. · 78dff026
      unknown authored
      A BINARY field is represented by the Field_string class. The space character
      is used as the filler for unused characters in such a field. But a BINARY field 
      should use \x00 instead.
      
      Field_string:reset() now detects whether the current field is a BINARY one
      and if so uses the \x00 character as a default value filler.
      
      
      sql/field.h:
        Bug#14171: Wrong internal default value for a BINARY field.
        Field_string:reset() now detects whether the current field is a BINARY one
        and if so uses the \x00 character as a default value filler.
      mysql-test/r/type_binary.result:
        Added a test case for the bug#14171: Wrong internal default value for a BINARY field.
      mysql-test/t/type_binary.test:
        Added a test case for the bug#14171: Wrong internal default value for a BINARY field.
      78dff026
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f831f46a
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-5.0-opt
      
      
      f831f46a