1. 03 Jul, 2007 1 commit
  2. 02 Jul, 2007 3 commits
  3. 01 Jul, 2007 5 commits
    • unknown's avatar
      Corrected a test case. · de0ba5c8
      unknown authored
      de0ba5c8
    • unknown's avatar
      Post.merge fixes · 1cd1f7d0
      unknown authored
      Fixed warnings
      Fixed error numbers
      
      
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        Fixed warnings
      mysql-test/r/ndb_single_user.result:
        Post-merge fixes
        Changed error numbers
      mysql-test/t/bigint.test:
        Fixed warnings
      mysql-test/t/ndb_single_user.test:
        Post-merge fixes
        Changed error numbers
      1cd1f7d0
    • unknown's avatar
      Made test case platform independent. · e63f6f32
      unknown authored
      e63f6f32
    • unknown's avatar
      Post-merge fix. · f9d36194
      unknown authored
      f9d36194
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 26a2b004
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt
      
      
      mysql-test/r/binary.result:
        Auto merged
      mysql-test/r/ctype_collate.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/binary.test:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/field_conv.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/myisam/mi_open.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      mysql-test/r/create.result:
        Manual merge.
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/r/type_enum.result:
        Manual merge.
      mysql-test/t/type_enum.test:
        Manual merge.
      mysql-test/include/mix1.inc:
        Manual merge.
      mysql-test/r/innodb_mysql.result:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      storage/myisam/mi_key.c:
        Manual merge.
      26a2b004
  4. 30 Jun, 2007 5 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 8dcd5fca
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/type_enum.result:
        Auto merged
      mysql-test/t/type_enum.test:
        Auto merged
      sql/field_conv.cc:
        SCCS merged
      8dcd5fca
    • unknown's avatar
      Post-merge fixes. · b83c28b2
      unknown authored
      
      sql/ha_partition.cc:
        Post-merge fixes.
        The new function HA_EXTRA_INSERT_WITH_UPDATE needs to be handled in
        ha_partition::extra().
      storage/federated/ha_federated.cc:
        Post-merge fixes.
        Removed leftover characters.
        Added a missing brace.
        Fixed and improved parenthesis handling in ha_federated::append_stmt_insert().
        Moved code from HA_EXTRA_RESET to ha_federated::reset().
      storage/federated/ha_federated.h:
        Post-merge fixes.
        Changed byte to uchar.
        Added declaration for ha_federated::reset().
      b83c28b2
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 2ca2b232
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29157-5.1-opt
      
      
      2ca2b232
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-axmrg · 6b125058
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      include/my_base.h:
        Manual merge
      sql/sql_insert.cc:
        Manual merge
      storage/federated/ha_federated.cc:
        Manual merge
      storage/federated/ha_federated.h:
        Manual merge
      6b125058
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · ffe19f62
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      ffe19f62
  5. 29 Jun, 2007 21 commits
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-axmrg · 241088c5
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      241088c5
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.1-amain · ca731030
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      configure.in:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      ca731030
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.1-ateam · a9e5e4c5
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      a9e5e4c5
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5 · 97139ca5
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      
      97139ca5
    • unknown's avatar
      fix Visual Studio build - strictness of compiler could not cast · c268fd77
      unknown authored
      pointer into a BOOL type.
      
      
      c268fd77
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29205 · a89259fa
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      a89259fa
    • unknown's avatar
      Fixed bug #29205. · db397d16
      unknown authored
      When a UNION statement forced conversion of an UTF8
      charset value to a binary charset value, the byte
      length of the result values was truncated to the
      CHAR_LENGTH of the original UTF8 value.
      
      
      sql/item.cc:
        Fixed bug #29205.
        The calculation of data length was modified in
        the Item_type_holder::join_types method to take into
        account possible conversion of a multibyte charset
        value to a binary charset value, when each
        multibyte character is converted into a sequence
        of bytes (not to a single byte of binary charset).
      mysql-test/t/ctype_utf8.test:
        Updated test case for bug #29205.
      mysql-test/r/ctype_utf8.result:
        Updated test case for bug #29205.
      db397d16
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/mysql-5.0-engines · eda9c97e
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      
      eda9c97e
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25511.5 · 495dfde5
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5
      
      
      sql/ha_federated.cc:
        Auto merged
      495dfde5
    • unknown's avatar
      add and amend comments for clarity · b4fe5e44
      unknown authored
      
      include/my_base.h:
        amend comment for clarity
      sql/ha_federated.cc:
        add comment
      b4fe5e44
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-amain · 29d2edfa
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      29d2edfa
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · b6fbbc9b
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      b6fbbc9b
    • unknown's avatar
      Merge mysqldev@production:/data0/mysqldev/my/mysql-5.1-release · 15575443
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      15575443
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6a00ce71
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29261-bug-5.0-opt-mysql
      
      
      6a00ce71
    • unknown's avatar
      Bug#29261: Sort order of the collation wasn't used when comparing trailing · 4772a012
      unknown authored
      spaces.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      strings/ctype-simple.c:
        Bug#29261: Sort order of the collation wasn't used when comparing trailing
        spaces.
        Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      4772a012
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 33eb22a3
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27333-gcov-5.0-opt
      
      
      33eb22a3
    • unknown's avatar
      Bug#27333: subquery grouped for aggregate of outer · c2e961cf
      unknown authored
      query / no aggregate of subquery
       The optimizer counts the aggregate functions that 
       appear as top level expressions (in all_fields) in 
       the current subquery. Later it makes a list of these
       that it uses to actually execute the aggregates in
       end_send_group().
       That count is used in several places as a flag whether
       there are aggregates functions.
       While collecting the above info it must not consider
       aggregates that are not aggregated in the current 
       context. It must treat them as normal expressions 
       instead. Not doing that leads to incorrect data about
       the query, e.g. running a query that actually has no
       aggregate functions as if it has some (and hence is
       expected to return only one row).
       Fixed by ignoring the aggregates that are not aggregated
       in the current context. 
       One other smaller omission discovered and fixed in the 
       process : the place of aggregation was not calculated for
       user defined functions. Fixed by calling 
       Item_sum::init_sum_func_check() and 
       Item_sum::check_sum_func() as it's done for the rest of 
       the aggregate functions.
      
      
      mysql-test/r/subselect.result:
        Bug #27333: test case
      mysql-test/t/subselect.test:
        Bug #27333: test case
      sql/item_subselect.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.h:
        Bug#27333: calculate the place of 
         aggregation for user defined functions.
      sql/sql_select.cc:
        Bug#27333: When counting the aggregated functions
         and collecting a list of them we must not consider
         the aggregates that are not aggregated in the local
         context as "local" : i.e. we must treat them as 
         normal functions and not add them to the aggregate
         functions list.
      sql/sql_select.h:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      c2e961cf
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · b70c486e
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      sql-common/client.c:
        Auto merged
      sql/handler.h:
        Auto merged
      b70c486e
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 73023608
      unknown authored
      into  mysql.com:/home/hf/work/29247/my50-29247
      
      
      sql-common/client.c:
        Auto merged
      73023608
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29252/my51-29252 · 3e7f28ed
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      3e7f28ed
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29247/my50-29247 · 09e78f80
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      sql-common/client.c:
        Auto merged
      09e78f80
  6. 28 Jun, 2007 5 commits
    • unknown's avatar
      Bug#25513 · dba70720
      unknown authored
        "Federared Transactions Failure"
        Bug occurs when the user performs an operation which inserts more than 
        one row into the federated table and the federated table references a 
        remote table stored within a transactional storage engine. When the
        insert operation for any one row in the statement fails due to 
        constraint violation, the federated engine is unable to perform 
        statement rollback and so the remote table contains a partial commit. 
        The user would expect a statement to perform the same so a statement 
        rollback is expected.
        This bug was fixed by implementing  bulk-insert handling into the
        federated storage engine. This will relieve the bug for most common
        situations by enabling the generation of a multi-row insert into the
        remote table and thus permitting the remote table to perform 
        statement rollback when neccessary.
        The multi-row insert is limited to the maximum packet size between 
        servers and should the size overflow, more than one insert statement 
        will be sent and this bug will reappear. Multi-row insert is disabled
        when an "INSERT...ON DUPLICATE KEY UPDATE" is being performed.
        The bulk-insert handling will offer a significant performance boost 
        when inserting a large number of small rows.
      This patch builds on Bug29019 and Bug25511
      
      
      sql/ha_federated.cc:
        bug25513
          new member methods:
            start_bulk_insert() - initializes memory for bulk insert
            end_bulk_insert() - sends any remaining bulk insert and frees memory
            append_stmt_insert() - create the INSERT statement
      sql/ha_federated.h:
        bug25513
          new member value:
            bulk_insert
          new member methods:
            start_bulk_insert(), end_bulk_insert(), append_stmt_insert()
          make member methods private:
            read_next(), index_read_idx_with_result_set()
      mysql-test/r/federated_innodb.result:
        New BitKeeper file ``mysql-test/r/federated_innodb.result''
      mysql-test/t/federated_innodb-slave.opt:
        New BitKeeper file ``mysql-test/t/federated_innodb-slave.opt''
      mysql-test/t/federated_innodb.test:
        New BitKeeper file ``mysql-test/t/federated_innodb.test''
      dba70720
    • unknown's avatar
      Bug#25511 · 94beb7cd
      unknown authored
        "Federated INSERT failures"
        Federated does not correctly handle "INSERT...ON DUPLICATE KEY UPDATE"
        However, implementing such support is not reasonably possible without
        increasing complexity of the storage engine: checking that constraints
        on remote server match local server and parsing error messages.
        This patch causes 'ON DUPLICATE KEY' to fail with ER_DUP_KEY message
        if a conflict occurs and not to fail silently.
      
      
      include/my_base.h:
        bug25511
          new storage engine hint: HA_EXTRA_INSERT_WITH_UPDATE
      mysql-test/r/federated.result:
        test for bug25511
      mysql-test/t/federated.test:
        test for bug25511
      sql/ha_federated.cc:
        bug25511
          implement support for handling HA_EXTRA_INSERT_WITH_UPDATE hint
      sql/ha_federated.h:
        bug25511
          new property: insert_dup_update
      sql/sql_insert.cc:
        bug25511
          implement support for HA_EXTRA_INSERT_WITH_UPDATE
          When checking duplicates flag, if it is DUP_UPDATE, send hint
          to the storage engine.
      94beb7cd
    • unknown's avatar
      Bug #29157: UPDATE, changed rows incorrect · ba4682ae
      unknown authored
      Sometimes the number of really updated rows (with changed
      column values) cannot be determined at the server level
      alone (e.g. if the storage engine does not return enough
      column values to verify that). So the only dependable way
      in such cases is to let the storage engine return that
      information if possible.
      Fixed the bug at server level by providing a way for the 
      storage engine to return information about wether it 
      actually updated the row or the old and the new column 
      values are the same. It can do that by returning 
      HA_ERR_RECORD_IS_THE_SAME in ha_update_row().
      Note that each storage engine may choose not to try to
      return this status code, so this behaviour remains 
      storage engine specific.
      
      
      include/my_base.h:
        Bug #29157: handle the row not updated special return value
      sql/log_event.cc:
        Bug #29157: handle the row not updated special return value
      sql/sp.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_acl.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_insert.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_servers.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_update.cc:
        Bug #29157: handle the row not updated special return value
      ba4682ae
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 26bed2a6
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26564-5.1-opt
      
      
      26bed2a6
    • unknown's avatar
      BUG#29207 - archive table reported as corrupt by check table · c69012d3
      unknown authored
      After merge fix.
      
      
      mysql-test/r/archive.result:
        After merge fix.
      c69012d3