- 11 Aug, 2009 1 commit
-
-
Guilhem Bichot authored
sql/sql_insert.cc: fix wrong merge
-
- 10 Aug, 2009 1 commit
-
-
Guilhem Bichot authored
to fix test failures on OS X PPC and Sparc64
-
- 07 Aug, 2009 4 commits
-
-
Guilhem Bichot authored
storage/innobase/CMakeLists.txt: ${WIN64} fails if variable is undefined
-
Guilhem Bichot authored
-
Guilhem Bichot authored
Fixes to tests and their results, to account for differences between InnoDB 1.0.4 and the old builtin. All committed result differences have either been verified by me or copied from Oracle's provided results (storage/innodb_plugin/mysql-test/*.result, storage/innodb_plugin/mysql-test/patches). mysql-test/r/information_schema.result: queries changed a bit mysql-test/r/information_schema_db.result: queries changed a bit mysql-test/r/innodb-autoinc.result: importing piece from storage/innodb_plugin/mysql-test/innodb-autoinc.result mysql-test/r/innodb.result: result close to storage/innodb_plugin/innodb.result, except 4095 pages instead of 8191, which makes sense as Summit runs with a buffer pool of 64M, whereas the mentioned result file was made with a buffer pool of 128M. mysql-test/r/mysqlshow.result: InnoDB I_S tables have arrived mysql-test/suite/funcs_1/r/is_columns_is.result: queries changed a bit mysql-test/suite/funcs_1/r/is_columns_is_embedded.result: queries changed a bit mysql-test/suite/funcs_1/r/is_tables_is.result: queries changed a bit mysql-test/suite/funcs_1/t/is_columns_is.test: making I_S queries ignore InnoDB I_S tables mysql-test/suite/funcs_1/t/is_columns_is_embedded.test: making I_S queries ignore InnoDB I_S tables mysql-test/suite/funcs_1/t/is_tables_is.test: making I_S queries ignore InnoDB I_S tables mysql-test/suite/innodb/r/innodb-zip.result: result update mysql-test/suite/innodb/t/innodb-zip.test: 439, as size of prefix key, throws error with certain system zlib (ubuntu "intrepid") but not with zlib bundled with MySQL, because zlib's compressBound() are different (and used by InnoDB's page_zip_empty_size()). mysql-test/suite/sys_vars/r/innodb_file_per_table_basic.result: result update mysql-test/suite/sys_vars/r/innodb_lock_wait_timeout_basic.result: result update mysql-test/suite/sys_vars/r/innodb_sync_spin_loops_basic_32.result: result update (default value is 30 in the plugin, 20 in the builtin) mysql-test/suite/sys_vars/r/innodb_sync_spin_loops_basic_64.result: result update (default value is 30 in the plugin, 20 in the builtin) mysql-test/suite/sys_vars/r/table_definition_cache_basic.result: result update (default value is 400 in Summit) mysql-test/suite/sys_vars/t/innodb_file_per_table_basic.test: variable is writable in the plugin (patch from Oracle) mysql-test/suite/sys_vars/t/innodb_lock_wait_timeout_basic.test: variable is per-session in the plugin (patch from Oracle) mysql-test/t/information_schema.test: making I_S queries ignore InnoDB I_S tables mysql-test/t/information_schema_db.test: making I_S queries ignore InnoDB I_S tables mysql-test/t/innodb-autoinc.test: importing piece from storage/innodb_plugin/mysql-test/innodb-autoinc.test mysql-test/t/innodb.test: importing most of storage/innodb_plugin/t/innodb.test. Most replace_result were not needed (no path printed), some where (for --embedded). mysql-test/t/mysqlshow.test: output of test now depends on InnoDB or not InnoDB. As there is no way to make mysqlshow produce a single output in those two cases (no way to make it exclude InnoDB I_S tables), let the test depend on InnoDB, it isn't a very selective condition, and the test is simple enough. storage/innobase/CMakeLists.txt: thanks Vlad for the noticing () vs {}
-
Guilhem Bichot authored
layout as we always had in trees containing only the builtin 2) win\configure.js WITH_INNOBASE_STORAGE_ENGINE still works. storage/innobase/CMakeLists.txt: fix to new directory name (and like 5.1) storage/innobase/Makefile.am: fix to new directory name (and like 5.1) storage/innobase/handler/ha_innodb.cc: fix to new directory name (and like 5.1) storage/innobase/plug.in: fix to new directory name (and like 5.1)
-
- 05 Aug, 2009 1 commit
-
-
Guilhem Bichot authored
mysql-test/lib/mtr_cases.pm: there is only one InnoDB in this tree, no need to run an InnoDB test twice mysql-test/suite/innodb/include/have_innodb_plugin.inc: plugin is now the builtin mysql-test/suite/innodb/t/innodb-analyze.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb-timeout.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb-use-sys-malloc.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb-zip.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb_bug36169.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb_bug36172.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb_file_format.test: plugin is now the builtin mysql-test/suite/innodb/t/innodb_information_schema.test: plugin is now the builtin storage/innodb_plugin/plug.in: build libinnobase.a, to have it built-in
-
- 04 Aug, 2009 3 commits
-
-
Guilhem Bichot authored
"Patch to fix bug 38551": it was a manual backport (2008-10-15) of http://lists.mysql.com/commits/56418. But that was an early, non-final patch from the fixer of this bug (TheK): after that backport was made by Mikael, TheK decided to do a different fix, which was finally pushed into 6.0. Then 5.1's code was changed for some other reasons, so now we have a conflict between the old never-approved TheK patch backported to Summit and the latest 5.1. The backport cannot stay, it has to be removed due to the conflict, and then rewritten if desired.
-
Guilhem Bichot authored
bzr branch mysql-5.1-performance-version mysql-trunk # Summit cd mysql-trunk bzr merge mysql-5.1-innodb_plugin # which is 5.1 + Innodb plugin bzr rm innobase # remove the builtin Next step: build, test fixes.
-
Sergey Vojtovich authored
Reverted lost in the merge line.
-
- 31 Jul, 2009 1 commit
-
-
Sergey Vojtovich authored
-
- 30 Jul, 2009 1 commit
-
-
Sergey Vojtovich authored
-
- 21 Jul, 2009 1 commit
-
-
Kelly Long authored
Part of the 'show status' code was erronously removed when the google patch was applied. This patch puts it back.
-
- 14 Jul, 2009 1 commit
-
-
Sergey Vojtovich authored
-
- 13 Jul, 2009 4 commits
-
-
Jim Winstead authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
- 12 Jul, 2009 1 commit
-
-
Alexey Kopytov authored
-
- 11 Jul, 2009 1 commit
-
-
Gleb Shchepa authored
mutually-nested subqueries Queries of the form SELECT * FROM (SELECT 1) AS t1, (SELECT 2) AS t2,... (SELECT 32) AS t32 caused the "Too high level of nesting for select" error as if the query has a form SELECT * FROM (SELECT 1 FROM (SELECT 2 FROM (SELECT 3 FROM... The table_factor parser rule has been modified to adjust the LEX::nest_level variable value after every derived table. mysql-test/r/derived.result: Added test case for bug #41156. mysql-test/t/derived.test: Added test case for bug #41156. sql/sql_yacc.yy: Bug #41156: List of derived tables acts like a chain of mutually-nested subqueries The select_derived2 parser rule calls mysql_new_select() calls push_context() and nest_level++, however only the pop_context() was called at the end of derived table parsing at the table_factor rule. The table_factor parser rule has been modified to adjust the LEX::nest_level variable value after every derived table.
-
- 10 Jul, 2009 16 commits
-
-
MySQL Build Team authored
-
Staale Smedseng authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Davi Arnaut authored
Remove commented-out test case. It has been moved to innodb_bug21704.test
-
Georgi Kodinov authored
sort_buffer_size cannot allocate The NULL return from tree_insert() (on low memory) was not checked for in Item_func_group_concat::add(). As a result on low memory conditions a crash happens. Fixed by properly checking the return code.
-
Satya B authored
1. BUG#21704 - Renaming column does not update FK definition 2. Changes in mysql-test/include/mtr_warnings.sql so that the testcase for BUG#21704 doesn't fail because of the warnings generated. Detailed revision comments: r5488 | vasil | 2009-07-09 19:16:44 +0300 (Thu, 09 Jul 2009) | 13 lines branches/5.1: Fix Bug#21704 Renaming column does not update FK definition by checking whether a column that participates in a FK definition is being renamed and denying the ALTER in this case. The patch was originally developed by Davi Arnaut <Davi.Arnaut@Sun.COM>: http://lists.mysql.com/commits/77714 and was later adjusted to conform to InnoDB coding style by me (Vasil), I also added some more comments and moved the bug specific mysql-test to a separate file to make it more manageable and flexible.
-
Alexey Kopytov authored
and base tables myrg_attach_children() could reuse a buffer that was allocated previously based on a definition of a child table. The problem was that the child's definition might have been changed, so reusing the buffer could lead to crashes or valgrind errors under some circumstances. Fixed by changing myrg_attach_children() so that the rec_per_key_part buffer is reused only when the child table have not changed, and reallocated otherwise (the old buffer is deallocated if necessary). include/myisammrg.h: Added a pointer to need_compat_check as an argument to myrg_attach_children(). mysql-test/r/merge.result: Added a test case for bug #45796. mysql-test/t/merge.test: Added a test case for bug #45796. storage/myisammrg/ha_myisammrg.cc: Pass a pointer to need_compat_check to myrg_attach_children(). storage/myisammrg/myrg_open.c: Changed myrg_attach_children() so that the rec_per_key_part buffer is reused only when the child table have not changed, and reallocated otherwise (the old buffer is deallocated if necessary).
-
Satya B authored
Detailed revision comments: r5440 | vasil | 2009-06-30 13:04:29 +0300 (Tue, 30 Jun 2009) | 8 lines branches/5.1: Fix Bug#45814 URL reference in InnoDB server errors needs adjusting to match documentation by changing the URL from http://dev.mysql.com/doc/refman/5.1/en/innodb-troubleshooting.html to http://dev.mysql.com/doc/refman/5.1/en/innodb-troubleshooting-datadict.html
-
Satya B authored
BUG#45749 - Race condition in SET GLOBAL innodb_commit_concurrency=DEFAULT Detailed revision comments: r5419 | marko | 2009-06-25 16:11:57 +0300 (Thu, 25 Jun 2009) | 18 lines branches/5.1: Merge r5418 from branches/zip: ------------------------------------------------------------------------ r5418 | marko | 2009-06-25 15:55:52 +0300 (Thu, 25 Jun 2009) | 5 lines Changed paths: M /branches/zip/ChangeLog M /branches/zip/handler/ha_innodb.cc M /branches/zip/mysql-test/innodb_bug42101-nonzero.result M /branches/zip/mysql-test/innodb_bug42101-nonzero.test M /branches/zip/mysql-test/innodb_bug42101.result M /branches/zip/mysql-test/innodb_bug42101.test branches/zip: Fix a race condition caused by SET GLOBAL innodb_commit_concurrency=DEFAULT. (Bug #45749) When innodb_commit_concurrency is initially set nonzero, DEFAULT would change it back to 0, triggering Bug #42101. rb://139 approved by Heikki Tuuri. ------------------------------------------------------------------------
-
Satya B authored
1. Fixes build warnings caused by applying snapshot 5.1-ss5282 2. Fix the Makefile.am in storage/innobase to remove the header file 'fsp0types.h' which was added twice to fix build warning generated after applying the 5.1-ss5282 snapshot Detailed revision comments: r5410 | marko | 2009-06-24 22:26:34 +0300 (Wed, 24 Jun 2009) | 2 lines branches/5.1: Add missing #include "mtr0log.h" to avoid warnings when compiling with -DUNIV_MUST_NOT_INLINE.
-
- 09 Jul, 2009 1 commit
-
-
Sergey Vojtovich authored
- when finding out a way to hide symbols, make decision basing on compiler, not operating system. - Sun Studio supports __hidden declaration specifier for this purpose.
-
- 08 Jul, 2009 3 commits
-
-
Staale Smedseng authored
unnecessarily The problem is that libmysqlclient.so is built with THREAD undefined, while a client compiling against the same header files will see THREAD as defined and definitions in my_pthread.h will be included, possibly resulting in undefined symbols that cannot be resolved with libmysqlclient.so. The suggested solution is to require that clients wanting to link with libmysqlclient.so should be built with MYSQL_CLIENT_NO_THREADS defined. This requires a documentation change, and more details for this will be supplied if this patch is approved. The MYSQL_CLIENT_NO_THREADS define was renamed from UNDEF_THREADS_HACK, to get a more suitable (less suspicious) name for the define. (The UNDEF_THREADS_HACK is retained for backwards compatibility, though.) This patch is also in anticipation of WL#4958, which will remove this problem altogether by dropping the building of libmysqlclient.
-
Georgi Kodinov authored
-
Georgi Kodinov authored
Item_field::fix_fields()
-