1. 18 Jul, 2005 1 commit
    • unknown's avatar
      Cleanups during review · 68b4d7b7
      unknown authored
      Changed defaults option --instance to --defaults-group-suffix
      Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
      Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX
      mysql_print_defaults now understands --defaults-group-suffix
      Remove usage of my_tempnam() (not safe function)
      if( -> if ( and while( to while (
      
      
      BitKeeper/deleted/.del-my_tempnam.c~a8562f15dad3012f:
        Delete: mysys/my_tempnam.c
      VC++Files/client/mysqlclient.dsp:
        Remove not used file my_tempnam.c
      VC++Files/client/mysqlclient_ia64.dsp:
        Remove not used file my_tempnam.c
      VC++Files/libmysql/libmysql.dsp:
        Remove not used file my_tempnam.c
      VC++Files/libmysql/libmysql_ia64.dsp:
        Remove not used file my_tempnam.c
      VC++Files/mysys/mysys.dsp:
        Remove not used file my_tempnam.c
      VC++Files/mysys/mysys_ia64.dsp:
        Remove not used file my_tempnam.c
      client/mysql.cc:
        Change to use get_defaults_options()
        Remove compiler warnings
      client/mysqldump.c:
        Indentation fixes
        Use quoted table name for 'primary_key_fields'
      extra/my_print_defaults.c:
        Add support for --defaults-group-suffix
        change to use get_default_options()
      extra/replace.c:
        Replace my_tempnam() with create_tmp_file() to allow us to remove my_tempnam.c
      include/config-win.h:
        Added DEFAULT_GROUP_SUFFIX_ENV
      include/my_sys.h:
        Change defaults_instance -> defaults_group_suffix
        Change get_defaults_files -> get_defaults_options
      libmysql/Makefile.shared:
        Added DEFAULT_GROUP_SUFFIX_ENV
      mysys/Makefile.am:
        Added DEFAULT_GROUP_SUFFIX_ENV
        Remove my_tempnam.c
      mysys/default.c:
        Changed --instance to --defaults-group-suffix
        Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX and moved the name to Makefile.am
        (mysys shouldn't by MySQL independent)
        Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
      mysys/default_modify.c:
        Optimized code to use allocated space more efficently
        Reduce code size
        Ensure that realloc() works independent of argument size
      mysys/my_bitmap.c:
        Added missing return
      sql/ha_innodb.cc:
        Change if( -> if (
      sql/ha_ndbcluster.cc:
        Change while( -> while (
      sql/item_cmpfunc.cc:
        Break loop early (simple optimization)
      sql/item_strfunc.cc:
        Change if( -> if (
      sql/log.cc:
        Fixed comment
      sql/mysqld.cc:
        Change if( -> if (
      sql/opt_range.cc:
        while( -> while (
        if( -> if (
      sql/parse_file.cc:
        Change if( -> if (
      sql/sql_cache.cc:
        while( -> while (
      sql/sql_parse.cc:
        Change if( -> if (
      sql/sql_prepare.cc:
        Added comment
      sql/sql_select.cc:
        while( -> while (
        Removed index variable by incrementing pointer
      sql/sql_show.cc:
        Change if( -> if (
      sql/sql_yacc.yy:
        Change if( -> if (
      tests/mysql_client_test.c:
        Added cast to first argument to bzero()
      68b4d7b7
  2. 04 Jul, 2005 5 commits
    • unknown's avatar
      Merge marko@bk-internal.mysql.com:/home/bk/mysql-5.0 · a1da992f
      unknown authored
      into hundin.mysql.fi:/home/marko/mysql-5.0-current
      
      
      sql/ha_innodb.cc:
        Auto merged
      a1da992f
    • unknown's avatar
      After merge fixes · 5d82b41e
      unknown authored
      
      mysql-test/r/group_by.result:
        After merge fix
        (Put test in same order as in 4.1)
      mysql-test/t/group_by.test:
        After merge fix
        (Put test in same order as in 4.1)
      sql/item_cmpfunc.cc:
        After merge fix (+ simple fix to not allow compiler to do tail optimization)
      sql/item_cmpfunc.h:
        After merge fix
      5d82b41e
    • unknown's avatar
      manual merge · 3c82f720
      unknown authored
      
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      strings/ctype-utf8.c:
        Auto merged
      3c82f720
    • unknown's avatar
      Fixes during review of new code · 306ebf7b
      unknown authored
      - Mostly indentation fixes
      - Added missing test
      - Ensure that Item_func_case() checks for stack overruns
      - Use real_item() instead of (Item_ref*) item
      - Fixed wrong error handling
      
      
      myisam/mi_unique.c:
        Improved comments
      myisam/myisampack.c:
        Updated version number
      mysql-test/r/group_by.result:
        Added test that was lost during earlier merge
      mysql-test/r/information_schema.result:
        Safety fix: Drop procedures before used
      mysql-test/t/group_by.test:
        Added test that was lost during earlier merge
      mysql-test/t/information_schema.test:
        Safety fix: Drop procedures before used
      mysys/hash.c:
        Updated comment
      sql/field.cc:
        false -> FALSE
      sql/ha_ndbcluster.cc:
        Fix some style issues
        - No () around argument to 'case'
        - Space before ( in switch and if
        - Removed 'goto'
        - Added {}
        - Added () to make expressions easier to read
        - my_snprintf -> strmov
      sql/handler.cc:
        if( -> if (
      sql/item.cc:
        Indentation changes
      sql/item.h:
        false -> FALSE
      sql/item_cmpfunc.cc:
        Ensure that Item_func_case() check for stack overrun properly
      sql/item_cmpfunc.h:
        Ensure that Item_func_case() check for stack overrun properly
      sql/item_func.cc:
        Indentation fixes
        Fixed wrong goto label
      sql/mysqld.cc:
        Remove test for opt_disable_networking as this flag can never be set here
      sql/opt_range.cc:
        Simplify code
      sql/sql_class.h:
        Move define out from middle of class definition
      sql/sql_parse.cc:
        Remove extra empty lines
      sql/sql_select.cc:
        use real_item() instead of (Item_ref*) item
        Modifed function comment to be align with others
        Simple optimization
      sql/sql_union.cc:
        Portability fix:
        Don't use 'bool_variable|=...'
      sql/sql_view.cc:
        Move List_iterator_fast out from loops (rewind is faster than creating a new itearator)
      strings/ctype-utf8.c:
        if( -> if (
      strings/ctype.c:
        Remove disabled code
      strings/decimal.c:
        Indentation fixes
      strings/xml.c:
        Indentation fixes
      306ebf7b
    • unknown's avatar
      After merge fixes · 428830c5
      unknown authored
      Better fix for ON DUPLICATE KEY UPDATE
      
      
      mysql-test/r/group_by.result:
        After merge fixes
      mysql-test/r/select.result:
        Reorder test to match 4.1 tests (will make future merges easier)
      mysql-test/t/group_by.test:
        Added --disable_ps_protocol to avoid extra warning
      mysql-test/t/select.test:
        Reorder test to match 4.1 tests (will make future merges easier)
      sql/mysql_priv.h:
        Better fix for ON DUPLICATE KEY UPDATE
      sql/sql_base.cc:
        After merge fixes
      sql/sql_insert.cc:
        Better fix for ON DUPLICATE KEY UPDATE
        (old solution gave problem with item->cached_table)
      sql/sql_prepare.cc:
        Better fix for ON DUPLICATE KEY UPDATE
      428830c5
  3. 03 Jul, 2005 1 commit
    • unknown's avatar
      Merge with 4.1 · eeee5fb1
      unknown authored
      
      Makefile.am:
        Auto merged
      myisam/mi_create.c:
        Auto merged
      myisam/mi_open.c:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysys/thr_alarm.c:
        Auto merged
      VC++Files/sql/mysqld.dsp:
        Keep old
      client/mysqldump.c:
        Manual merge
      client/mysqltest.c:
        Automatic merge
      configure.in:
        Manual merge
      mysql-test/r/ctype_ucs.result:
        Auto merge
      mysql-test/r/func_str.result:
        Auto merge
      mysql-test/r/group_by.result:
        Auto merge
      mysql-test/r/insert_select.result:
        Auto merge
      mysql-test/r/insert_update.result:
        Auto merge
      mysql-test/r/lowercase_table2.result:
        Auto merge
      mysql-test/r/select.result:
        Manual merge
      mysql-test/r/variables.result:
        Auto merge
      mysql-test/t/ctype_ucs.test:
        Auto merge
      mysql-test/t/func_str.test:
        Auto merge
      mysql-test/t/group_by.test:
        Auto merge
      mysql-test/t/insert_select.test:
        Auto merge
      mysql-test/t/insert_update.test:
        Auto merge
      mysql-test/t/ndb_alter_table.test:
        Auto merge
      mysql-test/t/select.test:
        Auto merge
      mysql-test/t/variables.test:
        Auto merge
      mysys/my_access.c:
        Auto merge
      scripts/make_win_src_distribution.sh:
        Auto merge
      sql/field.cc:
        Manual merge
      sql/ha_ndbcluster.cc:
        Auto merge
      sql/handler.cc:
        Auto merge
      sql/item.cc:
        Auto merge
      sql/item.h:
        Manual merge
      sql/item_cmpfunc.h:
        Auto merge
      sql/item_strfunc.cc:
        Auto merge
      sql/item_strfunc.h:
        Auto merge
      sql/mysql_priv.h:
        manual merge
      sql/mysqld.cc:
        manual merge
      sql/opt_range.cc:
        manual merge
      sql/set_var.cc:
        Auto merge
      sql/sql_base.cc:
        manual merge
        Restore processing of ON DUPLICATE KEY UPDATE
      sql/sql_insert.cc:
        manual merge
        Restore processing of ON DUPLICATE KEY UPDATE
        Simplify mysql_prepare_insert by using local variable for select_lex and save old values just before they are changed
      sql/sql_parse.cc:
        Restore processing of ON DUPLICATE KEY UPDATE
      sql/sql_prepare.cc:
        New ON DUPLICATE KEY UPDATE handling
      sql/sql_select.cc:
        manual merge
      sql/sql_table.cc:
        auto merge
      sql/sql_yacc.yy:
        auto merge
      strings/ctype-ucs2.c:
        auto merge
      strings/ctype-utf8.c:
        auto merge
      eeee5fb1
  4. 02 Jul, 2005 6 commits
  5. 01 Jul, 2005 27 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · 18266bed
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      18266bed
    • unknown's avatar
      row0sel.c: · c75eae35
      unknown authored
        Optimize speed: no need to keep track of set new rec locks in a consistent read
      
      
      innobase/row/row0sel.c:
        Optimize speed: no need to keep track of set new rec locks in a consistent read
      c75eae35
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · de21d09d
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      
      de21d09d
    • unknown's avatar
      trx0trx.h, trx0trx.ic, row0mysql.c: · c2323bae
      unknown authored
        Fix another bug in the fix of Bug #3300
      
      
      innobase/row/row0mysql.c:
        Fix another bug in the fix of Bug #3300
      innobase/include/trx0trx.ic:
        Fix another bug in the fix of Bug #3300
      innobase/include/trx0trx.h:
        Fix another bug in the fix of Bug #3300
      c2323bae
    • unknown's avatar
      trx0trx.ic, trx0trx.h: · 5bcbe404
      unknown authored
        Fix bug in the Bug #3300 bug fix
      
      
      innobase/include/trx0trx.h:
        Fix bug in the Bug #3300 bug fix
      innobase/include/trx0trx.ic:
        Fix bug in the Bug #3300 bug fix
      5bcbe404
    • unknown's avatar
      Many files: · 8561600a
      unknown authored
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      
      
      sql/ha_innodb.cc:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/row/row0mysql.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/row/row0sel.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/include/trx0trx.ic:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/include/row0mysql.h:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/include/trx0trx.h:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/lock/lock0lock.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      innobase/trx/trx0trx.c:
        Fix Bug #3300 : if innodb_locks_unsafe_for_binlog is set, release locks on rows that we do not UPDATE or DELETE
      8561600a
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · f831ab65
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-bug5-4.1
      
      
      f831ab65
    • unknown's avatar
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8d6c0896
      unknown authored
      into mysql.com:/home/svoj/devel/mysql/yassl1-mysql-5.0
      
      
      8d6c0896
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · ac480a37
      unknown authored
      into  mysql.com:/home/pem/work/mysql-5.0
      
      
      ac480a37
    • unknown's avatar
      Fix a crash I introduced by the last push. · d0df504b
      unknown authored
      d0df504b
    • unknown's avatar
      WL#2286 - Compile MySQL w/YASSL support · 672dffca
      unknown authored
      Merge with latest yaSSL. It includes fix for bigendian/littleendian
      problem (fixes func_encrypt test failure). Our trees are in sync now.
      
      
      extra/yassl/include/yassl_types.hpp:
        Merge with latest yaSSL.
      extra/yassl/src/Makefile.am:
        Merge with latest yaSSL.
      extra/yassl/src/buffer.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/cert_wrapper.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/lock.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/log.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/socket_wrapper.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/template_instnt.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/timer.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/yassl_error.cpp:
        Merge with latest yaSSL.
      extra/yassl/src/yassl_int.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/include/types.hpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/Makefile.am:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/aestables.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/algebra.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/arc4.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/coding.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/file.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/integer.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/misc.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/random.cpp:
        Merge with latest yaSSL.
      extra/yassl/taocrypt/src/template_instnt.cpp:
        Merge with latest yaSSL.
      672dffca
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 07d1323f
      unknown authored
      into  mysql.com:/home/pem/work/mysql-5.0
      
      
      07d1323f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b4751a93
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      b4751a93
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 407d245b
      unknown authored
      into  mysql.com:/home/pem/work/mysql-5.0
      
      
      407d245b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · d81f0574
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-11172-new
      
      
      sql/sql_select.cc:
        Auto merged
      d81f0574
    • unknown's avatar
      Fix a valgrind warning. · b32d2ac2
      unknown authored
      
      sql/sql_prepare.cc:
        A small fix for the previous patch: we should first free the
        prepared statement items, and then free the runtime memory root,
        as some memory used for cleanup is allocated in that mem root.
      sql/sql_select.cc:
        - ever free the cursor mem root in close() (it's too early).
      b32d2ac2
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · 120a2da1
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-5.0
      
      
      sql/sql_select.cc:
        Auto merged
      120a2da1
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-1.2310.2.2 · a58edfc5
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysqltest.c:
        Auto merged
      a58edfc5
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-1.2310.2.2 · 012f6be8
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      client/mysqltest.c:
        Auto merged
      012f6be8
    • unknown's avatar
      Win port fixes · d305f6d3
      unknown authored
      
      client/mysqltest.c:
        Check for HAVE_SYS_WAIT_H
        Define WEXITSTATUS if not defined
      d305f6d3
    • unknown's avatar
      Disabled the GOTO feature. (It's non-standard and undocumented.) · 1ff4a0eb
      unknown authored
      We want to have the defacto standard syntax for labels ("L:" instead of "label L;"),
      and fix some known bugs, before we enable this again.
      The code is left intact (#ifdef'ed SP_GOTO) and the test cases are kept in
      sp-goto.test, for the future...
      
      
      mysql-test/r/sp-error.result:
        Moved all goto tests to sp-goto.test.
      mysql-test/r/sp.result:
        Moved all goto tests to sp-goto.test.
      mysql-test/t/disabled.def:
        Disabled GOTO/LABEL (until the label syntax and some bugs can be fixed).
        We keep the tests in sp-goto.test for the future, but disable for now.
      mysql-test/t/sp-error.test:
        Moved all goto tests to sp-goto.test.
      mysql-test/t/sp.test:
        Moved all goto tests to sp-goto.test.
      sql/lex.h:
        Disabled GOTO/LABEL (until the label syntax and some bugs can be fixed).
      sql/sql_yacc.yy:
        Disabled GOTO/LABEL (until the label syntax and some bugs can be fixed).
      1ff4a0eb
    • unknown's avatar
      tests/mysql_client_test.c · eb4cb6eb
      unknown authored
          Add a test case for Bug#11656 "Server crash with mysql_stmt_fetch 
          (cursors)", the bug itself is no longer present.
      
      
      tests/mysql_client_test.c:
        Add a test case for Bug#11656 "Server crash with mysql_stmt_fetch 
        (cursors)", the bug itself is no longer present.
      eb4cb6eb
    • unknown's avatar
      - fix -ansi -pedantic error · 6c8d3975
      unknown authored
      6c8d3975
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · dc22424b
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-11172-new
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      dc22424b
    • unknown's avatar
      A fix and a test case for Bug#11172 "mysql_stmt_attr_set · d36c14f7
      unknown authored
      CURSOR_TYPE_READ_ONLY date/datetime filter server crash".
      The fix adds support for Item_change_list in cursors (proper rollback
      of the modified item tree). 
      
      
      sql/sql_class.cc:
        No need to call fatal_error() twice.
      sql/sql_prepare.cc:
        - implement proper cleanup of the prepared statement in mysql_stmt_reset
          if there is a cursor.
        - take into account thd->change_list when fetching data through a
          cursor.
      sql/sql_select.cc:
        - take into account thd->change_list when fetching data from a cursor:
          grab it when we open a cursor, and rollback the changes to the parsed
          tree when we close it.
      sql/sql_select.h:
        - Cursor::change_list added
      tests/mysql_client_test.c:
        - a test case for Bug#11172 "mysql_stmt_attr_set CURSOR_TYPE_READ_ONLY date/datetime
         filter server crash"
      d36c14f7
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 7dad490f
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7dad490f