1. 10 Aug, 2004 1 commit
    • unknown's avatar
      Fix for bug #4508 "CONVERT_TZ() function with new time zone as param crashes server". · 68d7b266
      unknown authored
      Instead of trying to open time zone tables during calculation of CONVERT_TZ() function
      or setting of @@time_zone variable we should open and lock them with the rest of 
      statement's table (so we should add them to global table list) and after that use such 
      pre-opened tables for loading info about time zones.
      
      
      mysql-test/r/timezone2.result:
        Added test for bug #4508
      mysql-test/t/timezone2.test:
        Added test for bug #4508
      scripts/mysql_create_system_tables.sh:
        Added one more test time zone to time zone tables which is needed for test for bug #4508.
      sql/item_create.cc:
        CONVERT_TZ() now is treated as special function.
      sql/item_create.h:
        CONVERT_TZ() now is treated as special function.
      sql/item_timefunc.cc:
        Item_func_convert_tz now uses list of pre-opened time zone tables instead of trying to
        open them ad-hoc. Also it avoid calling of current_thd.
      sql/item_timefunc.h:
        Added comment describing special nature of CONVERT_TZ() function.
        Optimization: Added own fix_fields() method and tz_tables member for caching pointer
        to list of open time zone tables to Item_func_convert_tz class.
      sql/lex.h:
        CONVERT_TZ() now is treated as special function.
      sql/mysql_priv.h:
        Removed function which is no longer used.
      sql/set_var.cc:
        Now my_tz_find() accepts list of pre-opened time zone tables as last argument 
        and no longer needs pointer to current THD.
      sql/set_var.h:
        Exported sys_time_zone, which is now used in sql_yacc.yy for quick finding out if we are
        setting @@time_zone variable.
      sql/sql_base.cc:
        Moved propagation of pointers to open tables from global list to local select lists to
        open_and_lock_tables(), also added implicit usage of time zone tables as condition for
        such propagation.
      sql/sql_lex.cc:
        Added fake_time_zone_tables_list which is used to indicate that time zone tables are
        implicitly used in statement.
        st_select_lex_unit::create_total_list(): if time zone tables are implicitly used in
        statement add them to global tables list.
      sql/sql_lex.h:
        Added LEX::time_zone_tables_used member which is used to indicate that time zone tables 
        are implicitly used in this statement (by pointing to fake_time_zone_table_list) and 
        for holding pointer to those tables after they've been opened.
      sql/sql_parse.cc:
        We should also create global table list if statement uses time zone tables implicitly.
        Added initialization of LEX::time_zone_tables_used to mysql_query_init().
      sql/sql_prepare.cc:
        We should also create global table list if statement uses time zone tables implicitly.
      sql/sql_select.cc:
        Removed functions which are no longer used.
      sql/sql_yacc.yy:
        CONVERT_TZ() and @@time_zone variable are handled in special way since they implicitly 
        use time zone tables.
      sql/tztime.cc:
        Fix for bug #4508 "CONVERT_TZ() function with new time zone as param crashes server".
        If statement uses CONVERT_TZ() function or @@time_zone variable is set then it implicitly
        uses time zone tables. We need to open and lock such tables with all other tables of 
        such statement.
        
        All code responsible for opening table was removed from tz_load_from_db() and function was 
        renamed to tz_load_from_open_tables() (which uses list of pre-opened tables).
        We also have new functions for construction and initialization of table list of time
        zone tables.
        my_tz_find() now always require list of pre-opened time zone tables and no longer needs
        current THD. So we have to pre-open them in my_tz_init().
        Also now we try to open time zone tables only if they were found during startup.
      sql/tztime.h:
        New function for construction of table list of time zone tables my_tz_get_table_list().
        Now my_tz_find() requires list of pre-pened time zone tables instead of current thread.
      68d7b266
  2. 09 Aug, 2004 8 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · e74007fb
      unknown authored
      into brandersnatch.localdomain:/home/dlenev/src/mysql-4.1-bg4756
      
      
      e74007fb
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 201f86ef
      unknown authored
      into mysql.com:/home/mydev/mysql-4.1-4100
      
      
      201f86ef
    • unknown's avatar
      mysqld.cc: · 17f95c28
      unknown authored
        minor option description change.
      
      
      sql/mysqld.cc:
        minor option description change.
      17f95c28
    • unknown's avatar
      Merge paul@bk-internal.mysql.com:/home/bk/mysql-4.1 · 2d919041
      unknown authored
      into kite-hub.kitebird.com:/src/extern/MySQL/bk/mysql-4.1
      
      
      2d919041
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 499a71bc
      unknown authored
      into mysql.com:/home/mydev/mysql-4.1-4100
      
      
      499a71bc
    • unknown's avatar
      bug#4369 - MySQL 4.1 regression in Alter table/tmp table from hash. · 9694a1f9
      unknown authored
      Solved performance problems by fixing a typo, which prevented enabling of write buffer.
      
      
      sql/ha_myisam.cc:
        bug#4369 - MySQL 4.1 regression in Alter table/tmp table from hash.
        Solved performance problems by fixing a typo, which prevented enabling of write buffer.
        Supplied no test case, as it required too much data to see the performance regression.
      9694a1f9
    • unknown's avatar
      configure.in: · db64c33f
      unknown authored
        Collation name fixes.
      
      
      configure.in:
        Collation name fixes.
      db64c33f
    • unknown's avatar
      mysqld.cc: · caaa692c
      unknown authored
        Put --help first, reorder other options so that they are
        alphabetical. (shouldn't have to use grep to find an option.)
        Move group_concat_max_len to variable part of list.
        Rename character_set_server, collation_server,
        shared_memory_base_name to character-set-server,
        collation-server, shared-memory-base-name.
        Make default-collation message refer to collation-server
        rather than character-set-server.
      
      
      sql/mysqld.cc:
        Put --help first, reorder other options so that they are
        alphabetical. (shouldn't have to use grep to find an option.)
        Move group_concat_max_len to variable part of list.
        Rename character_set_server, collation_server,
        shared_memory_base_name to character-set-server,
        collation-server, shared-memory-base-name.
        Make default-collation message refer to collation-server
        rather than character-set-server.
      caaa692c
  3. 08 Aug, 2004 3 commits
  4. 07 Aug, 2004 3 commits
  5. 06 Aug, 2004 5 commits
    • unknown's avatar
      libmysql.c: · 901c1db4
      unknown authored
        Can't return value from void function
      
      
      libmysql/libmysql.c:
        Can't return value from void function
      901c1db4
    • unknown's avatar
      Merge msvensson@bk-internal.mysql.com:/home/bk/mysql-4.1 · 72987924
      unknown authored
      into neptunus.(none):/home/magnus/mysql-4.1
      
      
      72987924
    • unknown's avatar
      Fixed ndb backup bug · bcdc77b3
      unknown authored
      
      ndb/src/kernel/blocks/backup/Backup.hpp:
        SCAN_FRAGCONF contains length of key(s) aswell
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Send correct signal length
      bcdc77b3
    • unknown's avatar
      Increase value of TimeBetweenWatchDogCheck to make it to start cluster on lowend machines. · 52e0926a
      unknown authored
      
      mysql-test/ndb/ndb_config_2_node.ini:
        Increase TimeBetweenWatchDogCheck to 30000
      52e0926a
    • unknown's avatar
      Fix for bug #4756 "STR_TO_DATE() returning bad results with AM/PM". · 1b0f0b0a
      unknown authored
      Added support of converion specifiers mentioned in manual but missing in code.
      
      
      mysql-test/r/date_formats.result:
        Added tests of str_to_date() with new %T, %r and %V, %v conversion specifiers, and also 
        some other specifiers for which tests were missing previously.
      mysql-test/t/date_formats.test:
        Added tests of str_to_date() and new %T, %r and %V, %v conversion specifiers, and also 
        some other specifiers for which tests were missing previously.
      sql/item_timefunc.cc:
        Added support for %T, %r, %V, %v, %X, %x conversion specifiers to extract_date_time()
        function. Also simplified a bit calculation of dates from week number.
      1b0f0b0a
  6. 05 Aug, 2004 14 commits
    • unknown's avatar
      removed unused and illegal print method · 689f4f27
      unknown authored
      689f4f27
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 67570b8b
      unknown authored
      into mysql.com:/home/kostja/mysql/mysql-4.1-root
      
      
      67570b8b
    • unknown's avatar
      Cleanup in mysql_time.h/my_time.h headers. The first is used in mysql.h, · 9919574a
      unknown authored
      the second is for the rest of time declarations in mysys.
      
      
      include/my_time.h:
        New declarations moved from mysql_time.h
      include/mysql_time.h:
        New declarations moved to my_time.h.
      sql/tztime.cc:
        Enforcing Monty's approach to header files.
      sql/tztime.h:
        Enforcing Monty's approach to header files: everything is included in
        one place.
      9919574a
    • unknown's avatar
      Merge · 432e4697
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      configure.in:
        SCCS merged
      432e4697
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:irix · e223c07e
      unknown authored
      into eel.hemma.oreland.se:/ndb/clone-mysql-4.1-ndb-daily-2004-08-04
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      ndb/src/common/debugger/signaldata/SignalDataPrint.cpp:
        Auto merged
      ndb/src/cw/cpcd/Process.cpp:
        Auto merged
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbtux/Dbtux.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbtux/DbtuxMeta.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbtux/DbtuxTree.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/test/ndbapi/testBasic.cpp:
        Auto merged
      ndb/test/run-test/main.cpp:
        Auto merged
      ndb/test/src/HugoTransactions.cpp:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      e223c07e
    • unknown's avatar
      Merge mronstrom@bk-internal.mysql.com:/home/bk/mysql-4.1 · cdca651f
      unknown authored
      into mysql.com:/Users/mikron/mysql-4.1
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      cdca651f
    • unknown's avatar
      Small fix for updated config params · 6c8df362
      unknown authored
      6c8df362
    • unknown's avatar
      Remove unused config parameters · 83c9f45f
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      83c9f45f
    • unknown's avatar
      mysqld.cc, mysql_test_run.c: · c0cc90c2
      unknown authored
        Changed URL in error message, page has moved
      
      
      netware/mysql_test_run.c:
        Changed URL in error message, page has moved
      sql/mysqld.cc:
        Changed URL in error message, page has moved
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      c0cc90c2
    • unknown's avatar
      wl1292 · 22306d05
      unknown authored
      testInterpreter is no longer built
      
      
      22306d05
    • unknown's avatar
      wl2010 · c1674294
      unknown authored
      Added NDB_DEBUG(--with-debug) and NDB_DEBUG_FULL(--with-debug=full)
      
      
      
      configure.in:
        Added NDB_DEBUG(--with-debug) and NDB_DEBUG_FULL(--with-debug=full)
      c1674294
    • unknown's avatar
      Cleanup in libmysql. · f47a0b9f
      unknown authored
      
      libmysql/libmysql.c:
        Cleanup of conversion part of libmysql (prepared statements protocol):
        - now we have basic support for any conversion sequence:
          when we don't implement direct conversion of given value to requested 
          buffer type (i.e. time -> double, or the other way around) we
          first convert i.e. time -> string and then call string -> double 
          conversion.
          param->offset is now handled only in one place.
        - conversion functions renamed from send_data_{string, long, double}
          to fetch_{string,long,double}_with_conversion. Don't be confused
          with strange diff for send_data_long: I had to move send_data_string
          before all other sends as it's used inside thesm. (Shall we have
          a forward declaration instead?-)
        - a little cleanup in read_binary_{date,time,datetime} - now type of
          date value is set inside these functions, so we can be sure
          that we always return fully filled MYSQL_TIME structure to the user
        - float -> string conversion is fixed to honor param->precision. 
          This is a step forward in fixing bug#4172
      tests/client_test.c:
        test fix: now libmysql always sets MYSQL_TIME::time_type field.
        We need to set these fields in the test as later _in values are compared
        with canonical by plain memcmp.
      f47a0b9f
    • unknown's avatar
      61528cf2
    • unknown's avatar
      39496af4
  7. 04 Aug, 2004 6 commits