- 13 Mar, 2010 1 commit
-
-
Konstantin Osipov authored
Remove unnecessary need_reopen loops.
-
- 11 Mar, 2010 6 commits
-
-
Konstantin Osipov authored
The problem is introduced by WL#4435 "Support OUT-parameters in prepared statements". When a statement that has out parameters was reprepared, the reprepare request error was ignored, and an attempt to send out parameters to the client was made. Since the out parameter list was not initialized in case of an error, this attempt led to a crash. Don't try to send out parameters to the client if an error occurred in statement execution. sql/sql_prepare.cc: Don't try to send out parameters if error. tests/mysql_client_test.c: Re-enable the test case for Bug#49972.
-
Luis Soares authored
-
Alexander Barkov authored
- Fixing crash on attempt to create a fulltext index with an utf8mb4 column - fixing wrong border width for supplementary characters in mysql client: mysql --default-character-set=utf8mb4 -e "select concat(_utf32 0x20000,'a')"
-
He Zhenxing authored
-
He Zhenxing authored
-
He Zhenxing authored
-
- 10 Mar, 2010 18 commits
-
-
Luis Soares authored
Split rpl_row_charset into: - rpl_row_utf16. - rpl_row_utf32. This way these tests can run independently if server supports either one of the charsets but not both. Cleaned up rpl_row_utf32 which had a spurious instruction: -- let $reset_slave_type_conversions= 0
-
Davi Arnaut authored
-
Luis Soares authored
In BUG#51787 we were using the wrong charset to print out the data. We were using the field charset for the string that would hold the information. This caused the assertion, because the string length was not aligned with UTF32 bytes requirements for storage. We fix this by using &my_charset_latin1 in the string object instead of the field->charset(). As a side-effect, we needed to extend the show_sql_type interface so that it took the field charset is now passed as a parameter, so that one is able to calculate the correct field size. In BUG#51716 we had issues with Field_string::pack and Field_string::unpack. When packing, the length was incorrectly calculated. When unpacking, the padding the string would be padded with the wrong bytes (a few bytes less than it should). We fix this by resorting to charset abstractions (functions) that calculate the correct length when packing and pad correctly the string when unpacking.
-
Joerg Bruehe authored
-
Alexander Nozdrin authored
-
Konstantin Osipov authored
LOCK kills the server. Prohibit FLUSH TABLES WITH READ LOCK application to views or temporary tables. Fix a subtle bug in the implementation when we actually did not remove table share objects from the table cache after acquiring exclusive locks. mysql-test/r/flush.result: Update results (Bug#51710) mysql-test/t/flush.test: Add a test case for Bug#51710. sql/sql_parse.cc: Fix Bug#51710 "FLUSH TABLES <view> WITH READ LOCK killes the server. Ensure we don't open views and temporary tables. Fix a yet another bug in the implementation which did not actually remove the tables from cache after acquiring exclusive locks.
-
Davi Arnaut authored
The problem was that in read only mode (read_only enabled), the server would mistakenly deny data modification attempts for temporary tables which belong to a transactional storage engine (eg. InnoDB). The solution is to allow transactional temporary tables to be modified under read only mode. As a whole, the read only mode does not apply to any kind of temporary table. mysql-test/r/read_only_innodb.result: Add test case result for Bug#33669 mysql-test/t/read_only_innodb.test: Add test case for Bug#33669 sql/lock.cc: Rename mysql_lock_tables_check to lock_tables_check and make it static. Move locking related checks from get_lock_data to lock_tables_check. Allow write locks to temporary tables even under read-only.
-
Joerg Bruehe authored
Plugins included into bin release cannot be installed on debug version of server Ensure that the plugin files of the debug build get into the optimized tree, so that they find their way into the final RPMs. support-files/mysql.spec.sh: Use "make install" in the debug build tree to get the debug plugin files to a temporary location, then move them to "plugin/debug/" in the optimized build tree so that the install hook in "plugin/Makefile.am" forwards them into the final installation. This fixes bug#49022 for the generic RPMs. Unrelated: The plugin objects were listed twice in the file list, do a cleanup.
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Joerg Bruehe authored
-
He Zhenxing authored
-
Joerg Bruehe authored
Plugins included into bin release cannot be installed on debug version of server IF the build process was split into separate "debug" and "optimized" builds AND the plugin files of the debug build got copied into "plugin/debug/" (both is done for MySQL release builds starting from 5.5.3), THEN these debug plugin files are to be included in the final binary package. This change deals with the inclusion only, the other parts are done in different changesets. plugin/Makefile.am: The "install" rule must not assume that "debug" files are present, this depends on the preceding steps in the build. If they are present, we cannot copy them by simply using "libtool install" (as we could do during an ordinary build) because they are already kept in "plugin/debug/". When doing the copy to the destination hierarchy, we must ensure that symlinks are not expanded but rather copied as symlinks. "cp -d" is specific to GNU, the portable way would use "cp -P", but that is not fully specified with recursion. So we fall back on "tar c | tar x", which is known to keep symlinks unchanged (and un-expanded). Using "$(TAR)" is just a precaution in case of weird path settings or other portability issues.
-
Mats Kindahl authored
-
- 09 Mar, 2010 9 commits
-
-
Marc Alff authored
This is a fix specific for HPUX, for which the compiler does not resolve properly dependencies involving unused inline functions. (See existing comments in mysql_thread.h) In include/mysql/psi/mysql_thread.h, the instrumentation helpers for mysql_prlock_* uses the pr lock apis. These apis are implemented in mysys/thr_rwlock.c, which is not linked to client code. As a result, the code does not link in libmysql_r, on HPUX. The fix is to cut dependencies explicitely, by introducing -DDISABLE_MYSQL_RWLOCK_H, when building client code.
-
Tor Didriksen authored
Ensure that we store the correct cached_field_type whenever we cache Field items (in this case it allows us to compare dates as dates, rather than strings) mysql-test/r/type_timestamp.result: Add test case. mysql-test/t/type_timestamp.test: Add test case. sql/item.h: Initialize cached_field_type from the Field item.
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
Before this fix, client tools (mysql_upgrade, mysqlcheck, mysqldump) would try to process performance schema tables, leading to failures. The fix is to align FIRST_PERFORMANCE_SCHEMA_VERSION to 5.5.3, which is the version number of mysql-trunk where the performance schema is first available.
-
- 07 Mar, 2010 6 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Marc Alff authored
Before this fix, the performance schema instrumentation in mdl.h / mdl.cc was incomplete, causing: - build warnings, - no data collection for the performance schema This fix: - added instrumentation helpers for the new preferred reader read write lock, mysql_prlock_* - implemented completely the performance schema instrumentation of mdl.h / mdl.cc
-
Marc Alff authored
-
Marc Alff authored
-
Marc Alff authored
-