- 22 Feb, 2008 2 commits
-
-
unknown authored
into kaamos.(none):/data/src/opt/bug33049/my51-bug33790 mysql-test/r/view.result: Auto merged sql/item_sum.cc: Auto merged mysql-test/t/view.test: Manual merge.
-
unknown authored
suite) Under some circumstances a combination of aggregate functions and GROUP BY in a SELECT query over a VIEW could lead to incorrect calculation of the result type of the aggregate function. This in turn could result in incorrect results, or assertion failures on debug builds. Fixed by changing the logic in Item_sum_hybrid::fix_fields() so that the argument's item is dereferenced before calling its type() method. mysql-test/r/view.result: Added a test case for bug #33049. mysql-test/t/view.test: Added a test case for bug #33049. sql/item_sum.cc: When calculating the result type of an aggregate function, dereference the argument's item before calling its type() method.
-
- 14 Feb, 2008 4 commits
-
-
unknown authored
suppress the "Out of sort memory" error in the error log.
-
unknown authored
into kaamos.(none):/data/src/opt/mysql-5.1-opt sql/filesort.cc: Auto merged mysql-test/r/order_by.result: Manual merge. mysql-test/t/order_by.test: Manual merge.
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.1-optunknown authored
into kaamos.(none):/data/src/opt/mysql-5.1-opt
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.0-optunknown authored
into kaamos.(none):/data/src/opt/mysql-5.0-opt
-
- 13 Feb, 2008 7 commits
-
-
unknown authored
into host.loc:/home/uchum/work/5.1-opt
-
unknown authored
-
unknown authored
into host.loc:/home/uchum/work/5.0-opt
-
unknown authored
into host.loc:/home/uchum/work/5.1-opt-gca mysql-test/r/select.result: Auto merged mysql-test/t/select.test: Auto merged sql/item_cmpfunc.cc: Auto merged sql/sql_acl.cc: Auto merged
-
unknown authored
for wildcard values. The server ignored escape character before wildcards during the calculation of priority values for sorting of a privilege list. (Actually the server counted an escape character as an ordinary wildcard like % or _). I.e. the table name template with a wildcard character like 'tbl_1' had higher priority in a privilege list than concrete table name without wildcards like 'tbl\_1', and some privileges of 'tbl\_1' was hidden by privileges for 'tbl_1'. The get_sort function has been modified to ignore escaped wildcards as usual. mysql-test/r/grant3.result: Added test case for bug#31194. mysql-test/t/grant3.test: Added test case for bug#31194. sql/sql_acl.cc: Fixed bug#31194. The server used the wild_prefix escape character (usually \-character) like % and _ wildcards in the get_sort function for sorting weights calculation. The get_sort function has been modified to ignore escaped wildcards and alone escapes like in the wild_case_compare function.
-
unknown authored
type conversion. Instead of copying of whole character string from a temporary buffer, the server copied a short-living pointer to that string into a long-living structure. That has been fixed. mysql-test/r/select.result: Added test case for bug#33764. mysql-test/t/select.test: Added test case for bug#33764. sql/item_cmpfunc.cc: Fixed bug#33764. Copying of a pointer has been replaced with an optional copying of a whole array to a newly allocated memory space in case of a functional source item.
-
unknown authored
into kaamos.(none):/data/src/opt/mysql-5.1-opt mysql-test/r/heap.result: Auto merged mysql-test/r/innodb.result: Auto merged mysql-test/r/myisam.result: Auto merged BitKeeper/deleted/.del-bdb.result: Auto merged mysql-test/r/strict.result: Auto merged mysql-test/r/type_binary.result: Auto merged mysql-test/r/type_set.result: Auto merged mysql-test/r/variables.result: Auto merged mysql-test/r/warnings.result: Auto merged mysql-test/t/range.test: Auto merged mysql-test/t/variables.test: Auto merged mysql-test/t/warnings.test: Auto merged sql/field.cc: Auto merged sql/field.h: Auto merged sql/item.cc: Auto merged sql/item.h: Auto merged sql/item_func.cc: Auto merged sql/sql_select.cc: Auto merged sql/mysqld.cc: Null merge. mysql-test/include/mix1.inc: Manual merge. mysql-test/r/innodb_mysql.result: Manual merge. mysql-test/r/range.result: Manual merge. mysql-test/r/sp.result: Manual merge. mysql-test/t/sp.test: Manual merge. sql/handler.cc: Manual merge.
-
- 12 Feb, 2008 6 commits
-
-
unknown authored
into kaamos.(none):/data/src/opt/mysql-5.1-opt
-
unknown authored
into kaamos.(none):/data/src/opt/mysql-5.0-opt sql/item.cc: Auto merged
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.1-optunknown authored
into kaamos.(none):/data/src/opt/mysql-5.1-opt
-
unknown authored
into mbp.:/Users/kaa/src/opt/bug33389/my51-bug25162 mysql-test/r/view.result: Auto merged mysql-test/t/view.test: Manual merge. sql/item.cc: Manual merge.
-
unknown authored
into moonbone.local:/work/31590-bug-5.0-opt-mysql
-
unknown authored
or trigger crashes server Under some circumstances a combination of VIEWs, subselects with outer references and PS/SP/triggers could lead to use of uninitialized memory and server crash as a result. Fixed by changing the code in Item_field::fix_fields() so that in cases when the field is a VIEW reference, we first check whether the field is also an outer reference, and mark it appropriately before returning. mysql-test/r/view.result: Added a test case for bug #33389. mysql-test/t/view.test: Added a test case for bug #33389. sql/item.cc: In cases when in Item_field::fix_fields() from_field is a view reference, do not return too early, i.e. before marking the reference as an outer one when needed.
-
- 11 Feb, 2008 2 commits
- 10 Feb, 2008 9 commits
-
-
unknown authored
into mysql.com:/home/hf/work/33796/my51-33796
-
unknown authored
into mysql.com:/home/hf/work/33796/my50-33796
-
unknown authored
into mysql.com:/home/hf/work/33796/my51-33796 libmysql/libmysql.c: Auto merged libmysqld/lib_sql.cc: Auto merged
-
unknown authored
into mysql.com:/home/hf/work/33796/my50-33796 libmysql/libmysql.c: merging libmysqld/lib_sql.cc: merging
-
unknown authored
Field data for a query was stored to the stmt->alloc that is emptied with mysql_stmt_close statement only. That means a lot of memory can be occupied without a reason if used doesn't call mysql_stmt_close often. libmysql/libmysql.c: Bug #33796 Memory leak for prepared statements in embedded server. Clean up result->alloc even if there's no 'data' created libmysqld/lib_sql.cc: Bug #33796 Memory leak for prepared statements in embedded server. alloc 'fields' in the 'result.alloc' as the 'mem_root' is only cleaned with mysql_stmt_close'
-
unknown authored
into mysql.com:/home/tnurnberg/21567/51-21567 sql/mysqld.cc: Auto merged
-
unknown authored
into mysql.com:/home/tnurnberg/21567/50-21567 sql/mysqld.cc: Auto merged
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.1-optunknown authored
into kaamos.(none):/data/src/opt/mysql-5.1-opt
-
unknown authored
into blasphemy.intern.azundris.com:/home/tnurnberg/21567/51-21567 sql/mysqld.cc: Auto merged
-
- 08 Feb, 2008 3 commits
-
-
unknown authored
into host.loc:/home/uchum/work/5.0-opt
-
unknown authored
SET column storing procedure has been modified to be 64bit-clean. mysql-test/r/type_set.result: Added test case for bug#15409. mysql-test/t/type_set.test: Added test case for bug#15409. sql/field.cc: Fixed bug#15409. The Field_set::store(longlong nr,...) method incompletely calculates a bit mask for the comparison with a given number: if that number is greater than 0x7F00 0000 0000 0000 (LONGLONG_MAX), it uses zero bit mask instead of 0xFFFF FFFF FFFF FFFF (ULONGLONG_MAX). Incomplete expression has been replaced with a set_bits macro call.
-
unknown authored
The out of memory error was thrown when the sort buffer size were too small. This led to a user confusion. Now filesort throws the error message about sort buffer being too small. mysql-test/t/order_by.test: Added a test case for the bug#31590: Wrong error message on sort buffer being too small. mysql-test/r/order_by.result: Added a test case for the bug#31590: Wrong error message on sort buffer being too small. sql/filesort.cc: Bug#31590: Wrong error message on sort buffer being too small. Now filesort throws the error message about sort buffer being too small instead of out of memory error.
-
- 07 Feb, 2008 7 commits
-
-
unknown authored
into mysql.com:/home/psergey/mysql-5.0-bug27732
-
unknown authored
into host.loc:/home/uchum/work/5.0-opt
-
unknown authored
Minor post-fix for bug#34223. mysql-test/r/innodb_mysql.result: Minor post-fix for bug#34223. mysql-test/r/variables.result: Minor post-fix for bug#34223. mysql-test/t/innodb_mysql.test: Minor post-fix for bug#34223. mysql-test/t/variables.test: Minor post-fix for bug#34223.
-
unknown authored
The bug was that handler::clone/handler::ha_open() call caused allocation of cloned_copy->ref on the handler->table->mem_root. The allocated memory could not be reclaimed until the table is flushed, so it was possible to exhaust memory by repeatedly running index_merge queries without doing table flushes. The fix: - make handler::clone() allocate new_handler->ref on the passed mem_root - make handler::ha_open() not allocate this->ref if it has already been allocated There is no testcase as it is not possible to check small leaks from testsuite. sql/handler.cc: BUG#27732 "Possible memory leak with index_merge" - make handler::clone() allocate new_handler->ref on the passed mem_root - make handler::ha_open() not allocate this->ref if it has already been allocated
-
unknown authored
into host.loc:/home/uchum/work/5.0-opt
-
unknown authored
Minor post-fix for bug#30059. mysql-test/r/bdb.result: Minor post-fix for bug#30059.
-
unknown authored
and my_innodb_commit_concurrency global variables. Type of the my_innodb_autoextend_increment and the my_innodb_commit_concurrency variables has been changed to GET_ULONG. mysql-test/r/variables.result: Added test case for bug#34223. mysql-test/t/variables.test: Added test case for bug#34223. sql/mysqld.cc: Fixed bug#34223. Last update of the getopt_ull_limit_value function introduced a sanity check for a variable type (only GET_UINT or GET_ULONG are valid types). However, my_innodb_autoextend_increment and my_innodb_commit_concurrency are declared as GET_LONG. Call stack is: sys_var_long_ptr_global::update() fix_unsigned() getopt_ull_limit_value() Type of the my_innodb_autoextend_increment and the my_innodb_commit_concurrency variables has been changed to GET_ULONG.
-