An error occurred fetching the project authors.
  1. 20 Jan, 2005 1 commit
    • unknown's avatar
      - renamed client_test -> mysql_client_test · c03aaf85
      unknown authored
      - renamed the tests that use the embedded server (client_test -> 
        mysql_client_test_embedded, mysqltest -> mysql_test_embedded
        and changed some Makefiles and scripts so they are installed in $bindir
        (required to be able to run the test suite against the embedded server)
      
      
      tests/mysql_client_test.c:
        Rename: tests/client_test.c -> tests/mysql_client_test.c
      libmysql/libmysql.c:
        - renamed client_test.c to mysql_client_test.c in a comment
      libmysqld/examples/Makefile.am:
        - renamed client_test -> mysql_client_test_embedded
        - renamed mysqltest -> mysqltest_embedded
        - both will be installed in $bindir
      scripts/make_binary_distribution.sh:
        - install mysql_client_test, mysql_client_test_embedded and mysqltest_embedded
          into bin directory
      tests/Makefile.am:
        - renamed client_test to mysql_client_test
      BitKeeper/etc/ignore:
        Added tests/mysql_client_test to the ignore list
      c03aaf85
  2. 17 Jan, 2005 2 commits
    • unknown's avatar
      Fixed memory leak in handle_local_infile() · 4fc1801d
      unknown authored
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      4fc1801d
    • unknown's avatar
      libmysql.c: · c72207e1
      unknown authored
        bug#7891: mysql_character_set_name() returns collation
      
      
      libmysql/libmysql.c:
        bug#7891: mysql_character_set_name() returns collation
      c72207e1
  3. 15 Dec, 2004 1 commit
    • unknown's avatar
      fix for bug #7285: Disable start of embedded server when need to · 33959dc1
      unknown authored
      connect to an external server with mysqld.
      
      
      libmysql/libmysql.c:
        fix for bug #7285: Disable start of embedded server when need to
        connect to an external server with libmysqld.
        
        Calling mysql_server_init with a negative value for argc will not
        start the embedded server.
      33959dc1
  4. 14 Dec, 2004 1 commit
    • unknown's avatar
      A fix of return value of mysql_stmt_bind_result() and cleanup. · 83fce55a
      unknown authored
      include/errmsg.h:
        New libmysql error status code CR_NO_STMT_METADATA
      libmysql/errmsg.c:
        Error message for CR_STMT_NO_METADATA.
        Adding an empty line to shorten further diffs when new error
        messages are added (as suggested by Monty).
      libmysql/libmysql.c:
        Return error from mysql_stmt_bind_result() if the statement contains
        no metadata.
        A few comments fixed.
      tests/client_test.c:
        Tests fixed: mysql_stmt_bind_result now returns error if there is no
        metadata.
      83fce55a
  5. 10 Dec, 2004 1 commit
  6. 07 Dec, 2004 1 commit
    • unknown's avatar
      Fix for a bug #6996 · 5c7949af
      unknown authored
      BitKeeper/etc/ignore:
        Added analyse.test client/mysqladmin.c to the ignore list
      libmysql/libmysql.c:
        Fix for a bug #6996
        
        This fix enables that after all rows are read from a buffered result,
        mysql_stmt_data_seek(stmt,0) can rewind a counter to the beginning,
        so that rows can be re-fetched.
      tests/client_test.c:
        Addition of a test for fix of the bug #6996 in client_test.c
      5c7949af
  7. 15 Nov, 2004 1 commit
    • unknown's avatar
      Fix for bug #6266 "Invalid DATETIME value is not handled properly". · 5d9f7edd
      unknown authored
      In server we assume that datetime values stored in MYSQL_TIME struct
      are normalized (and year is not greater than 9999), so we should 
      perform range checks in all places then we convert something to
      MYSQL_TIME. 
      
      
      include/my_time.h:
        Added one more argument to set_zero_time() function to make it more 
        convinient.
        Added comment clarifying why MAX_DATE_STRING_REP_LENGTH value is 30.
      include/mysql_time.h:
        Documented MySQL's internal assumptions for members of MYSQL_TIME
        structure.
      libmysql/libmysql.c:
        It does not make sense to set MYSQL_TIME::time_type twice in case of 
        errors.
      mysql-test/r/type_datetime.result:
        Added test for bug #6266 "Invalid DATETIME value not handled properly".
      mysql-test/t/type_datetime.test:
        Added test for bug #6266 "Invalid DATETIME value not handled properly".
      sql-common/my_time.c:
        str_to_datetime(): Added missing check for too big year values.
        set_zero_time(): added time_type argument, since MYSQL_TIMESTAMP_NONE
          is not the value that we want in most cases.
      sql/field.cc:
        Field_datetime::store_time():
          clarified why we don't perform any range checks here.
      sql/item.cc:
        Item_param::set_time():
         Added comment describing this method and range checking for TIME
         values.
      sql/sql_prepare.cc:
        Removed comments about range checking for TIME values in prepared 
        statements, which are no longer true.
        set_zero_time() has one more argument now.
      tests/client_test.c:
        Added test for bug #6266 "Invalid DATETIME value not handled properly"
      5d9f7edd
  8. 05 Nov, 2004 3 commits
    • unknown's avatar
      libmysql.c: · 2f2eceac
      unknown authored
        After-merge clean-up
      
      
      libmysql/libmysql.c:
        After-merge clean-up
      2f2eceac
    • unknown's avatar
      libmysql.def, libmysql.c: · 1ba0ad70
      unknown authored
        Clean-ups
      
      
      libmysql/libmysql.c:
        Clean-ups
      libmysql/libmysql.def:
        Clean-ups
        ,
      1ba0ad70
    • unknown's avatar
      libmysql.def, libmysql.c: · 0a4984a4
      unknown authored
        Minor clean-ups
      
      
      libmysql/libmysql.c:
        Minor clean-ups
      libmysql/libmysql.def:
        bk commit
      0a4984a4
  9. 01 Nov, 2004 1 commit
    • unknown's avatar
      Remove support for obsolete 4.1.1 prepared statements C API names: · 55974b50
      unknown authored
      having approval for it since 4.1.4, I also have some assurance that
      very few people actually used this: to enable these calls a user
      had to #define HAVE_DEPRECATED_411_API and recompile the client library.
      
      
      include/mysql.h:
        remove defines for obsolete 4.1 prepared statements C API names
      libmysql/libmysql.c:
        Remove #ifdefed implementation of obsolete mysql_prepare call.
      55974b50
  10. 27 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6096 "field.max_length is always zero for · 447fef48
      unknown authored
      numeric columns (stmt_resultset_metadata)"
      
      
      libmysql/libmysql.c:
        A fix for Bug#6096 "field.max_length is always zero for numeric columns
         (stmt_resultset_metadata)": set field->max_lenght for numeric
        columns when we set up skip_result functions. A minor drawback for this 
        approach is that field->max_length  can be not zero even if 
        STMT_ATTR_UPDATE_MAX_LENGTH is not set.
      sql-common/my_time.c:
        Fix valgrind warning.
      tests/client_test.c:
        A test case for Bug#6096 "field.max_length is always zero for numeric 
        columns (stmt_resultset_metadata)
      447fef48
  11. 26 Oct, 2004 1 commit
    • unknown's avatar
      A lot of fixes for prepared statements (PS): · 853c2c78
      unknown authored
      New mysqltest that can run mysqltest with PS
      Added support for ZEROFILL in PS
      Fixed crash when one called mysql_stmt_store_result() without a preceding mysql_stmt_bind_result()
      Updated test cases to support --ps-protocol
      (Some tests are still run using old protocol)
      Fixed crash in PS when using SELECT * FROM t1 NATURAL JOIN t2...
      Fixed crash in PS when using sub queries
      Create table didn't signal when table was created. This could cause a "DROP TABLE created_table" in another thread to wait "forever"
      Fixed wrong permissions check in PS and multi-table updates (one could get permission denied for legal quries)
      Fix for PS and SELECT ... PROCEDURE
      Reset all warnings when executing a new PS query
      group_concat(...ORDER BY) didn't work with PS
      Fixed problem with test suite when not using innodb
      
      
      BitKeeper/deleted/.del-innodb-lock-master.opt~f76a4a1999728f87:
        Delete: mysql-test/t/innodb-lock-master.opt
      client/Makefile.am:
        mysqltest now uses regex
      client/mysqltest.c:
        Added support for testing of prepared statements (with --ps-protocol)
        Main code was done by Kent, I did mainly some cleanups and minor bug fixes
        New test commands:
        --disable_ps_protocol
        --enable_ps_protocol
        NOTE: new code still has some things that needs to be cleaned up.
        For example run_query_stmt_handle_error() should be made more general so that same code can be used also by 'normal' queries
      configure.in:
        mysqltest now uses regex
      libmysql/libmysql.c:
        Reset warning_count after prepare (safety). In the future we should also provide warnings on prepare
        integer -> string conversion now handles ZEROFILL
        double -> string conversion is now closer to the one in the server
        Fixed crash when one called mysql_stmt_store_result() without preceding mysql_stmt_bind_result()
      libmysqld/examples/Makefile.am:
        mysqltest now uses regex
      mysql-test/include/have_query_cache.inc:
        Fixes for --ps-protocol
      mysql-test/include/ps_conv.inc:
        Fixes for --ps-protocol
      mysql-test/mysql-test-run.sh:
        Added options --ps-protocol
      mysql-test/r/ctype_utf8.result:
        Fixed test case
      mysql-test/r/fulltext_cache.result:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/r/fulltext_left_join.result:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/r/fulltext_multi.result:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/r/innodb-lock.result:
        Fixed test to work even if Innodb is not compiled in.
      mysql-test/t/create.test:
        Fixes for --ps-protocol
      mysql-test/t/ctype_utf8.test:
        Remove warnings
      mysql-test/t/date_formats.test:
        Fixes for --ps-protocol
      mysql-test/t/fulltext_cache.test:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/t/fulltext_left_join.test:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/t/fulltext_multi.test:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/t/func_group.test:
        Fixes for --ps-protocol
      mysql-test/t/func_sapdb.test:
        Fixes for --ps-protocol
      mysql-test/t/innodb-lock.test:
        Fixed test to work even if Innodb is not compiled in.
      mysql-test/t/insert.test:
        Fixes for --ps-protocol
      mysql-test/t/insert_select.test:
        Fixes for --ps-protocol
      mysql-test/t/insert_update.test:
        Fixes for --ps-protocol
      mysql-test/t/metadata.test:
        Fixes for --ps-protocol
      mysql-test/t/multi_statement.test:
        Fixes for --ps-protocol
      mysql-test/t/ps_1general.test:
        Fixes for --ps-protocol
      mysql-test/t/rollback.test:
        Fixes for --ps-protocol
      mysql-test/t/rpl_redirect.test:
        Fixes for --ps-protocol
      mysql-test/t/rpl_user_variables.test:
        Fixes for --ps-protocol
      mysql-test/t/select.test:
        Fixes for --ps-protocol
      mysql-test/t/status.test:
        Fixes for --ps-protocol
      mysql-test/t/type_blob.test:
        Fixes for --ps-protocol
      mysql-test/t/type_float.test:
        Fixes for --ps-protocol
      mysql-test/t/union.test:
        Fixes for --ps-protocol
      mysql-test/t/warnings.test:
        Fixes for --ps-protocol
      mysys/my_alloc.c:
        More debugging information
      sql-common/client.c:
        More debugging information
      sql-common/my_time.c:
        TIME didn't support full range with PS
      sql/field.cc:
        TIME didn't support full range with PS
      sql/item_cmpfunc.cc:
        IN(constants,...) didn't work with PS
      sql/item_subselect.cc:
        Some subqueries didn't work with PS
      sql/item_sum.cc:
        group_concat(...ORDER BY) didn't work with PS
        Removed variable warning_available as 'warning' can be used for this.
      sql/item_sum.h:
        Removed not needed variable
      sql/protocol.cc:
        TIME didn't support full range with PS
      sql/set_var.cc:
        Style fix
      sql/sql_base.cc:
        setup_wild() didn't properly restore old arena, which caused core dump in PS when using
        SELECT * FROM t1 NATURAL JOIN t2...
      sql/sql_class.cc:
        Style fix
      sql/sql_error.cc:
        Style fix
      sql/sql_insert.cc:
        Create table didn't signal when table was created. This could cause a "DROP TABLE created_table" in another thread to wait "forever"
      sql/sql_lex.h:
        Fix for PS and procedures
      sql/sql_parse.cc:
        More debugging information
        Make a copy of 'db' in PS as this may change
        Fixed wrong permissions check in PS and multi-table updates
      sql/sql_prepare.cc:
        Fix for PS and SELECT ... PROCEDURE
        Reset all warnings when executing a new query
      sql/sql_union.cc:
        Fixes for PS and SELECT ... PROCEDURE
        Reset 'with_wild' as 'wild' is resolved on prepare
      853c2c78
  12. 20 Oct, 2004 3 commits
    • unknown's avatar
      After merge fixes · 4ba94cc3
      unknown authored
      4ba94cc3
    • unknown's avatar
      A fix and test case for bug#6058 "Prepared statements return '0000-00-00' · 8fe8912f
      unknown authored
      (date) as empty  string": preserve time type (date, time, or datetime) for
      zero dates, times, and datetimes.
      
      
      libmysql/libmysql.c:
        A fix for bug#6058 "Prepared statements return '0000-00-00' (date) as empty
         string": preserve time type (date, time, or datetime) for zero 
        dates, times, and datetimes.
      tests/client_test.c:
        A test case for Bug#6058, the existing tests required some adjustments too.
      8fe8912f
    • unknown's avatar
      Code cleanups (done during review of new code) · ed8ec2cf
      unknown authored
      Rename innodb_table_locks_old_behavior -> innodb_table_locks
      Set innodb_table_locks to off by default to get same behaviour as in MySQL 4.0.20
      (This means that Innodb ignore table locks by default, which makes it easier to combine MyISAM and InnoDB to simulate a transaction)
      
      
      libmysql/libmysql.c:
        Use ulong instead of unsigned long
        Reuse _dig_vec()
      myisam/myisampack.c:
        Simplify code
      mysql-test/r/innodb-lock.result:
        new test case
      mysql-test/t/innodb-lock.test:
        new test case
      sql/ha_innodb.cc:
        Rename innodb_table_locks_old_behavior -> innodb_table_locks
      sql/mysqld.cc:
        Rename innodb_table_locks_old_behavior -> innodb_table_locks
        Set this off by default to get same behaviour as in MySQL 4.0.20
      sql/set_var.cc:
        Rename innodb_table_locks_old_behavior -> innodb_table_locks
      sql/sql_class.h:
        Rename innodb_table_locks_old_behavior -> innodb_table_locks
      ed8ec2cf
  13. 19 Oct, 2004 3 commits
    • unknown's avatar
      Review of all code pushed since last review · 4736d0fe
      unknown authored
      Simple optimzations and cleanups
      Removed compiler warnings and fixed portability issues
      Added client functions 'mysql_embedded()' to allow client to check if we are using embedded server
      Fixes for purify
      
      
      client/mysqlimport.c:
        Remove not used variable
      client/mysqltest.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
        Simplified code
        Remove usage of sprintf("%llu") as this is not portable
      include/mysql.h:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      innobase/srv/srv0start.c:
        Don't use memcmp() when using purify (to avoid false warnings)
      libmysql/libmysql.c:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      libmysql/libmysql.def:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      myisam/myisam_ftdump.c:
        Remove compiler warning
      myisam/myisamchk.c:
        Remove compiler warning
      myisam/rt_test.c:
        #ifdef not used code
      mysys/hash.c:
        Remove compiler warning (from last push)
      mysys/my_gethwaddr.c:
        Remove compiler warning
      ndb/src/ndbapi/ndberror.c:
        #ifdef not used code
      regex/regcomp.c:
        Remove not used code
      regex/regcomp.ih:
        Remove not used code (to remove compiler warnings)
      sql-common/client.c:
        Remove compiler warnings
      sql/field.cc:
        Simple optimization
      sql/ha_innodb.cc:
        Rename mysql_embedded -> mysqld_embedded
      sql/item.cc:
        Fix comments
        Move variables first on block
        Remove else after return
        Simple optimizations
        (no logic changes)
      sql/item_cmpfunc.cc:
        Added comment
      sql/mysql_priv.h:
        Rename mysql_embedded -> mysqld_embedded
      sql/mysqld.cc:
        Rename mysql_embedded -> mysqld_embedded
      sql/sql_acl.cc:
        Added comments
        simple optimization
        Fixed 'very unlikely' bug when doing REVOKE ALL PRIVILEGES
      sql/sql_select.cc:
        More comments
        Simple optimization
      sql/sql_show.cc:
        Simple changes to make similar code similar
        More comments
      sql/sql_string.cc:
        Trivial optimization and better code layout
      strings/Makefile.am:
        Change xml.c to use bcmp to avoid warnings from purify
      strings/xml.c:
        Change xml.c to use bcmp to avoid warnings from purify
      tests/client_test.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
      4736d0fe
    • unknown's avatar
      libmysql.c: · 30d33c71
      unknown authored
        Add note to mysql_hex_string() comment.
      
      
      libmysql/libmysql.c:
        Add note to mysql_hex_string() comment.
      30d33c71
    • unknown's avatar
      libmysql.c: · 2428fb5c
      unknown authored
        New function mysql_hex_string()
      
      
      libmysql/libmysql.c:
        New function mysql_hex_string()
      2428fb5c
  14. 15 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6049 "Loss of sign when using prepared · 9aefc403
      unknown authored
      statements and negative time/date values". 
      The bug was in wrong sprintf format used in the client library.
      The fix moves TIME -> string conversion functions to sql-common and
      utilized them in the client library.
      
      
      include/my_time.h:
        Declarations for new functions shared between the client and server.
      libmysql/libmysql.c:
        Fix for Bug#6049 "Loss of sign when using prepared statements and negative
        time/date values": use the same function as the server to convert
        date/time/datetime values to strings.
      sql-common/my_time.c:
        Implementation of my_{time,datetime,date,TIME}_to_str: it's
        needed by the client library, so it should be shared.
      sql/field.cc:
        Don't create String object if it's not needed.
      sql/item.cc:
        Don't create String object if it's not needed: TIME_to_string was
        moved to my_TIME_to_str, with different arguments.
      sql/item_timefunc.cc:
        Don't create String object if it's not needed.
      sql/mysql_priv.h:
        TIME_to_string and MAX_DATE_REP_LENGTH moved to the client library.
        MAX_DATE_REP_LENGTH was renamed to MAX_DATE_STRING_REP_LENGTH to not 
        conflict with the same name in libmysql.c
      sql/protocol.cc:
        Don't create String object if it's not needed.
      sql/time.cc:
        Implementation of my_{time,date,datetime,TIME}_to_str moved to my_time.c
        shared between the client and the server.
      tests/client_test.c:
        A test case for Bug#6049.
      9aefc403
  15. 14 Oct, 2004 2 commits
    • unknown's avatar
      Fix for Bug#6024 "Test "client_test" fails in 4.1.6-gamma build (1)": · 77d7398e
      unknown authored
      let's not assume that char is signed (its signedness is not defined).
      The server was also affected by the wrong typedef.
      
      
      include/my_global.h:
        Fix for Bug#6024 "Test "client_test" fails in 4.1.6-gamma build (1)":
        let's not assume that char is signed (its signedness is not defined).
      libmysql/libmysql.c:
        Fix for Bug#6024 "Test "client_test" fails in 4.1.6-gamma build (1)":
        let's not assume that char is signed (its signedness is not defined).
      77d7398e
    • unknown's avatar
      libmysql/libmysql.c: · e8bc4e16
      unknown authored
       Fix for Bug#6025 "Test "client_test" fails in 4.1.6-gamma build (2)".
       No need for a test case, the bug is covered already.
      
      
      libmysql/libmysql.c:
        Fix for Bug#6025 "Test "client_test" fails in 4.1.6-gamma build (2)":
        the bug was in assignments like:
          *row+= read_binary_time(tm, row);
        which makes two assingments without a sequence point (read_binary_*
        changes *row too) => undefined behaviour.
        The fix changes read_binary_{time,date,datetime} signature to get
        rid of any probability to fall into the same trouble in future.
      e8bc4e16
  16. 22 Sep, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#5315 "mysql_change_user() doesn't free · ccf52b4f
      unknown authored
      prepared statements."
      
      
      include/hash.h:
        New declaration for hash_reset() function. The old version was not used.
      libmysql/client_settings.h:
        Declaration for mysql_detach_stmt_list().
      libmysql/libmysql.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        add call to mysql_detach_stmt_list(prepared statements) to
        mysql_change_user(): all statements are freed by server, so client
        counterparts need to be marked as not usable.
      mysys/hash.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of hash_reset(), which frees all hash elements
        and prepares the hash for reuse.
      sql-common/client.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of mysql_detach_stmt_list(): zero connection pointer
        in given statement list, thus marking given statements as not usable.
      sql/sql_class.cc:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        reset prepared statements map in THD::change_user().
      sql/sql_class.h:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of Statement_map::reset().
        A little cleanup of ~Statement_map(): first empty names_hash, as st_hash
        has a free function, which will delete statements.
      tests/client_test.c:
        A test case for bug #5315 "mysql_change_user() doesn't free prepared
        statements".
      ccf52b4f
  17. 11 Sep, 2004 1 commit
    • unknown's avatar
      libmysql.c: · a2a0a61b
      unknown authored
        Fix typos noticed while poking around in file.
      
      
      libmysql/libmysql.c:
        Fix typos noticed while poking around in file.
      a2a0a61b
  18. 08 Sep, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#5194 "Bulk Insert Failures with Prepared · d7a23067
      unknown authored
      Statements": 
      - fix a couple of net->buff overruns in libmysql,
      - check in the server that statement parameter count is less than
        65535 (maximum value supported by prepared statements protocol).
       
      
      
      libmysql/libmysql.c:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - clean up my_realloc_str()
        - ensure that net buffer has space when storing null bits and
          parameter typecodes.
      sql/net_serv.cc:
        - set net->last_errno if packet is too big, even on client
          (Why was it ifdefed before?)
      sql/sql_prepare.cc:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - if placeholder count is bigger than 65535, give error.
          We have only 2 bytes reserved for transferring placeholder count
          in 4.1 protocol.
        - can't add a proper error code and message in 4.1 because of
          possible merge difficulties."
      tests/client_test.c:
        A test case for Bug#5194 "Bulk Insert Failures with Prepared 
        Statements".
      d7a23067
  19. 07 Sep, 2004 2 commits
  20. 02 Sep, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#4231 "Wrong result with MYSQL_TIME · 0c58737a
      unknown authored
      parameters": when unpacking binary time recieved from client, handle
      the case when length is 0: it means all MYSQL_TIME members are zero.
      
      
      include/my_time.h:
        Declaration for set_zero_time: a tiny piece of code, which I
        see no reason to not reuse.
      libmysql/libmysql.c:
        set_zero_time implementation is now shared between client and
        server.
      sql-common/my_time.c:
        set_zero_time implementation added.
      sql/sql_prepare.cc:
        A fix for Bug#4231 "Wrong result with MYSQL_TIME parameters": 
        when unpacking binary time recieved from client, handle the
        case when length is 0: it means all MYSQL_TIME members are zero.
      tests/client_test.c:
        Test case for bug#4231 "Wrong result with MYSQL_TIME parameters"
      0c58737a
  21. 26 Aug, 2004 2 commits
    • unknown's avatar
      A short fix and test case for Bug#5126 · ce91cbb8
      unknown authored
      "Mediumint and PS problem": just treat mediumint as long.
      
      
      libmysql/libmysql.c:
        A short fix for bug #5126 "Mediumint and PS problem": just
        treat mediumint as long, as it's sent just like long.
      tests/client_test.c:
        A test case for bug#5126
      ce91cbb8
    • unknown's avatar
      Portability fixes · 44b2807e
      unknown authored
      Fixed bug in end space handle for WHERE text_column="constant"
      
      
      heap/hp_hash.c:
        Optimzations (no change of logic)
      libmysql/libmysql.c:
        Added missing casts (portability fix)
      myisam/mi_key.c:
        Changed macro to take arguments and not depend on local variables
        Simple indentation fixes ?
      mysql-test/r/connect.result:
        Added test for setting empty password
      mysql-test/r/create_select_tmp.result:
        TYPE -> ENGINE
      mysql-test/r/ctype_utf8.result:
        Combine drop's
      mysql-test/r/endspace.result:
        Added more tests to test end space behaviour
      mysql-test/r/having.result:
        Added missing DROP TABLE
      mysql-test/r/type_blob.result:
        Added more tests to ensure that fix for BLOB usage is correct
      mysql-test/r/type_timestamp.result:
        Add test from 4.0
      mysql-test/t/connect.test:
        Added test for setting empty password
      mysql-test/t/create_select_tmp.test:
        TYPE -> ENGINE
      mysql-test/t/ctype_utf8.test:
        Combine drop's
      mysql-test/t/endspace.test:
        Added more tests to test end space behaviour
      mysql-test/t/having.test:
        Added missing DROP TABLE
      mysql-test/t/type_blob.test:
        Added more tests to ensure that fix for BLOB usage is correct
      mysql-test/t/type_timestamp.test:
        Add test from 4.0
      sql/field.cc:
        Removed not used variable
        Portability fix (cast)
        Simplified Field_str::double()
        Simple indentation cleanups
      sql/field.h:
        Removed not needed class variable
      sql/item_cmpfunc.cc:
        Indentation fix
      sql/item_strfunc.cc:
        Use on stack variable for Item_str_func::val() instead of str_value.
        This makes it safe to use str_value inside the Item's val function.
        Cleaned up LEFT() usage, thanks to the above change
      sql/item_sum.cc:
        Indentation cleanups
      sql/protocol.cc:
        Added missing cast
      sql/sql_acl.cc:
        Indentatin cleanups.
        Added missing cast
        Simple optimization of get_sort()
      sql/sql_select.cc:
        Don't use 'ref' to search on text field that is not of type BINARY (use 'range' instead).
        The reson is that for 'ref' we use 'index_next_same' to read the next possible row. 
        For text fields, rows in a ref may not come in order, like for 'x', 'x\t' 'x ' (stored in this order) which causes a search for 'column='x ' to fail
      sql/tztime.cc:
        Simple cleanup
      strings/ctype-bin.c:
        Comment fixes
      strings/ctype-mb.c:
        Changed variable names for arguments
      44b2807e
  22. 25 Aug, 2004 1 commit
  23. 19 Aug, 2004 1 commit
    • unknown's avatar
      Fixed symbol name problems that made build fail. · 0ed563e8
      unknown authored
      include/mysql.h:
        Fixed symbol name change.
      include/mysql_com.h:
        Reverted parts of previous changeset (name changes) to make it build.
      libmysql/libmysql.c:
        Fixed symbol name change.
      sql/sql_parse.cc:
        Fixed symbol name change.
      0ed563e8
  24. 17 Aug, 2004 1 commit
  25. 10 Aug, 2004 2 commits
  26. 06 Aug, 2004 1 commit
    • unknown's avatar
      libmysql.c: · 901c1db4
      unknown authored
        Can't return value from void function
      
      
      libmysql/libmysql.c:
        Can't return value from void function
      901c1db4
  27. 05 Aug, 2004 3 commits
    • unknown's avatar
      - rename: EXCEPTIONS->EXCEPTIONS-CLIENT · 06cd2efc
      unknown authored
      06cd2efc
    • unknown's avatar
      - Fixed libmysql license texts: added reference to the FLOSS · 7b614774
      unknown authored
         EXCEPTIONS file and amended the GPL text as requested by Zak
      
      
      libmysql/Makefile.am:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/Makefile.shared:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/conf_to_src.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/dll.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/errmsg.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/get_password.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/libmysql.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/manager.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql_r/Makefile.am:
         - Fixed license text, added reference to the EXCEPTIONS file
      7b614774
    • unknown's avatar
      Cleanup in libmysql. · f47a0b9f
      unknown authored
      libmysql/libmysql.c:
        Cleanup of conversion part of libmysql (prepared statements protocol):
        - now we have basic support for any conversion sequence:
          when we don't implement direct conversion of given value to requested 
          buffer type (i.e. time -> double, or the other way around) we
          first convert i.e. time -> string and then call string -> double 
          conversion.
          param->offset is now handled only in one place.
        - conversion functions renamed from send_data_{string, long, double}
          to fetch_{string,long,double}_with_conversion. Don't be confused
          with strange diff for send_data_long: I had to move send_data_string
          before all other sends as it's used inside thesm. (Shall we have
          a forward declaration instead?-)
        - a little cleanup in read_binary_{date,time,datetime} - now type of
          date value is set inside these functions, so we can be sure
          that we always return fully filled MYSQL_TIME structure to the user
        - float -> string conversion is fixed to honor param->precision. 
          This is a step forward in fixing bug#4172
      tests/client_test.c:
        test fix: now libmysql always sets MYSQL_TIME::time_type field.
        We need to set these fields in the test as later _in values are compared
        with canonical by plain memcmp.
      f47a0b9f