1. 31 Jan, 2012 9 commits
  2. 30 Jan, 2012 5 commits
  3. 27 Jan, 2012 1 commit
  4. 26 Jan, 2012 5 commits
    • Jorgen Loland's avatar
      BUG 13413535 followup: Fix gcc warning · 0b7831ac
      Jorgen Loland authored
      0b7831ac
    • Marko Mäkelä's avatar
      Bug #13413535 61104: INNODB: FAILING ASSERTION: PAGE_GET_N_RECS(PAGE) > 1 · 9dfc545a
      Marko Mäkelä authored
      This fix does not remove the underlying cause of the assertion
      failure. It just works around the problem, allowing a corrupted
      secondary index to be fixed by DROP INDEX and CREATE INDEX (or in the
      worst case, by re-creating the table).
      
      ibuf_delete(): If the record to be purged is the last one in the page
      or it is not delete-marked, refuse to purge it. Instead, write an
      error message to the error log and let a debug assertion fail.
      
      ibuf_set_del_mark(): If the record to be delete-marked is not found,
      display some more information in the error log and let a debug
      assertion fail.
      
      row_undo_mod_del_unmark_sec_and_undo_update(),
      row_upd_sec_index_entry(): Let a debug assertion fail when the record
      to be delete-marked is not found.
      
      buf_page_print(): Add ut_ad(0) so that corruption will be more
      prominent in stress testing with debug binaries. Add ut_ad(0) here and
      there where corruption is noticed.
      
      btr_corruption_report(): Display some data on page_is_comp() mismatch.
      
      btr_assert_not_corrupted(): A wrapper around btr_corruption_report().
      Assert that page_is_comp() agrees with the table flags.
      
      rb:911 approved by Inaam Rana
      9dfc545a
    • Guilhem Bichot's avatar
      merge from 5.1 · ce345853
      Guilhem Bichot authored
      ce345853
    • Guilhem Bichot's avatar
      Fixes for: · 440d871b
      Guilhem Bichot authored
      BUG#13519696 - 62940: SELECT RESULTS VARY WITH VERSION AND
      WITH/WITHOUT INDEX RANGE SCAN
      BUG#13453382 - REGRESSION SINCE 5.1.39, RANGE OPTIMIZER WRONG
      RESULTS WITH DECIMAL CONVERSION
      BUG#13463488 - 63437: CHAR & BETWEEN WITH INDEX RETURNS WRONG
      RESULT AFTER MYSQL 5.1.
      Those are all cases where the range optimizer got it wrong
      with > and >=.
      440d871b
    • Tor Didriksen's avatar
      5fa3887c
  5. 25 Jan, 2012 7 commits
    • Nuno Carvalho's avatar
      BUG#12403008 RPL_HEARTBEAT_BASIC FAILS SPORADICALLY ON PUSHBUILD · 279917ef
      Nuno Carvalho authored
      rpl_heartbeat_basic test fails sporadically on pushbuild because did
      not received all heartbeats from slave in circular replication.
      
      MASTER_HEARTBEAT_PERIOD had the default value (slave_net_timeout/2) so
      wait on "Heartbeat event received on master", that only waits for 1
      minute, sometimes timeout before heartbeat arrives. Fixed setting a
      smaller period value.
      279917ef
    • Tor Didriksen's avatar
      Bug#13359121 LARGE NUMBERS, /STRINGS/DTOA.C:662 · 56a2ff83
      Tor Didriksen authored
      Bug#12985021 SIMPLE QUERY WITH DECIMAL NUMBERS TAKE AN
      
      When parsing the fractional part of a string which
      is to be converted to double, we can stop after a few digits:
      the extra digits will not contribute to the actual result anyways.
      56a2ff83
    • Tor Didriksen's avatar
      6ebd4ffe
    • Tor Didriksen's avatar
      Bug#13463415 63502: INCORRECT RESULTS OF BIGINT AND DECIMAL COMPARISON · 07fd88d5
      Tor Didriksen authored
      Bug#11758543 50756: BIGINT '100' MATCHES 1.001E2
      
      Expressions of the form
            BIGINT_COL <compare> <non-integer constant>
      
            should be done either as decimal, or float.
      
            Currently however, such comparisons are done as int,
            which means that the constant may be truncated,
            and yield false positives/negatives for all queries
            where compare is '>' '<' '>=' '<=' '=' '!='.
      
            BIGINT_COL IN <list of contstants>
            and
            BIGINT_COL BETWEEN <constant> AND <constant>
            are also affected.
      07fd88d5
    • Dmitry Shulga's avatar
      Fixed bug#11753187 (formerly known as bug 44585): SP_CACHE BEHAVES AS · d460f168
      Dmitry Shulga authored
      MEMORY LEAK.
      
      Background:
       - There are caches for stored functions and stored procedures (SP-cache);
       - There is no similar cache for events;
       - Triggers are cached together with TABLE objects;
       - Those SP-caches are per-session (i.e. specific to each session);
       - A stored routine is represented by a sp_head-instance internally;
       - SP-cache basically contains sp_head-objects of stored routines, which
         have been executed in a session;
       - sp_head-object is added into the SP-cache before the corresponding
         stored routine is executed;
       - SP-cache is flushed in the end of the session.
      
      The problem was that SP-cache might grow without any limit. Although this
      was not a pure memory leak (the SP-cache is flushed when session is closed),
      this is still a problem, because the user might take much memory by
      executing many stored routines.
      
      The patch fixes this problem in the least-intrusive way. A soft limit
      (similar to the size of table definition cache) is introduced. To represent
      such limit the new runtime configuration parameter 'stored_program_cache'
      is introduced. The value of this parameter is stored in the new global
      variable stored_program_cache_size that used to control the size of SP-cache
      to overflow. 
      
      The parameter 'stored_program_cache' limits number of cached routines for
      each thread. It has the following min/default/max values given from support:
        min = 256, default = 256, max = 512 * 1024.
      Also it should be noted that this parameter limits the size of 
      each cache (for stored procedures and for stored functions) separately.
      
      The SP-cache size is checked after top-level statement is parsed.
      If SP-cache size exceeds the limit specified by parameter
      'stored_program_cache' then SP-cache is flushed and memory allocated for
      cache objects is freed. Such approach allows to flush cache safely 
      when there are dependencies among stored routines.
      d460f168
    • Marko Mäkelä's avatar
      Merge mysql-5.1 to mysql-5.5. · 7bec00e1
      Marko Mäkelä authored
      7bec00e1
    • Marko Mäkelä's avatar
      btr_cur_search_to_nth_level(): Add a debug assertion · 1f9c1f09
      Marko Mäkelä authored
      and some Valgrind instrumentation.
      1f9c1f09
  6. 24 Jan, 2012 5 commits
  7. 23 Jan, 2012 4 commits
    • Nuno Carvalho's avatar
      BUG#12364404 - UNDETERMINISTIC WAIT LOOP IN WAIT_FOR_NDB_TO_BINLOG.INC · 323bfed3
      Nuno Carvalho authored
      The wait_for_ndb_to_binlog.inc include file used by the blow rpl_tests
      common for rpl and rpl_ndb suite is simply doing a "sleep 5", this is
      not deterministic and wastes lot of test time uneccessarily. The test
      should be rewritten to check if the condition it wait for has been
      reached or not.
      
      For NDB engine all events will be added by NDB injector so tests only 
      can continue after injector is ready, this test waits for proper
      injector thread state.
      323bfed3
    • Manish Kumar's avatar
      BUG#11752315 - 43460: STOP SLAVE UNABLE TO COMPLETE WHEN SLAVE THREAD IS TRYING TO RECONNECT TO · 58a3147c
      Manish Kumar authored
      Problem : The basic problem is the way the thread sleeps in mysql-5.5 and also in mysql-5.1
                when we execute a stop slave on windows platform.
                On windows platform if the stop slave is executed after the master dies, we have 
                this long wait before the stop slave return a value. This is because there is a 
                sleep of the thread. The sleep is uninterruptable in the two above version,
                which was fixed by Davi patch for the BUG#11765860 for mysql-trunk. Backporting 
                his patch for mysql-5.5 fixes the problem. 
      
      Solution : A new pair of mutex and condition variable is introduced to synchronize thread 
                 sleep and finalization. A new mutex is required because the slave threads are 
                 terminated while holding the slave thread locks (run_lock), which can not be 
                 relinquished during termination as this would affect the lock order.
      58a3147c
    • Alexander Barkov's avatar
      Merging Bug#11752408 from mysql-5.1 · d29e871b
      Alexander Barkov authored
      d29e871b
    • Alexander Barkov's avatar
      Bug#11752408 - 43593: DUMP/BACKUP/RESTORE/UPGRADE TOOLS FAILS BECAUSE OF UTF8_GENERAL_CI · e56caa38
      Alexander Barkov authored
      Introducing new collations:
      utf8_general_mysql500_ci and ucs2_general_mysql500_ci,
      to reproduce behaviour of utf8_general_ci and ucs2_general_ci
      from mysql-5.1.23 (and earlier).
      
      The collations are added to simplify upgrade from mysql-5.1.23 and earlier.
      
      Note: The patch does not make new server start over old data automatically.
      Some manual upgrade procedures are assumed.
      
      Paul: please get in touch with me to discuss upgrade procedures
      when documenting this bug.
      
      modified:
        include/m_ctype.h
        mysql-test/r/ctype_utf8.result
        mysql-test/t/ctype_utf8.test
        mysys/charset-def.c
        strings/ctype-ucs2.c
        strings/ctype-utf8.c
      e56caa38
  8. 20 Jan, 2012 4 commits
    • Inaam Rana's avatar
      Bug#13612811 VALGRIND ERROR IN OS_AIO_INIT · 78bb7cc6
      Inaam Rana authored
      Fix valgrind warning introduced by fix for bug 11765450.
      78bb7cc6
    • Mattias Jonsson's avatar
      Bug#13500478 63623: TEST CASE PARTITION_BINLOG_STMT · 72e48049
      Mattias Jonsson authored
      CREATES A FILE IN AN IMPROPER LOCATION.
      
      Fixed by using $MYSQLTEST_VARDIR, as proposed by
      Davi Arnaut.
      
      Thank you Davi!
      72e48049
    • Georgi Kodinov's avatar
      Addendum to the fix for bug #11754014 · 93d123d7
      Georgi Kodinov authored
      - Fixed the checks to properly check for plugin_dir containing a trailing slash or backslash.
      - Fixed a under-configuration in udf_skip_grants that was preventing the test 
        from running even when there was a udf plugin.
      93d123d7
    • Dmitry Shulga's avatar
      Patch for bug#13070308 - VALGRIND failure in XA test. · 716dca03
      Dmitry Shulga authored
      The issue is that xa.test failed sporadically on some platforms.
      The reason for the test failure is a race condition in xa.test.
      The race condition occures between connection that executes statement
      INSERT INTO t2 SELECT FROM t1 and other connection that tries to run
      statements DELETE FROM t1 and COMMIT. If COMMIT statement had been executed
      before the statement INSERT INTO t2 SELECT FROM t1 was locked by lock
      on table t1 (as a result of query from table t1) then the INSERT statement
      is executed successfully and a following test for deadlock would failed.
      
      This patch fixes this race condition by moving COMMIT statement after commit
      of distributed transaction from concurrent session.
      716dca03