1. 29 Sep, 2006 6 commits
    • unknown's avatar
      After merge fixes. · 83caa434
      unknown authored
      
      mysql-test/r/sp.result:
        After merge fix.
      mysql-test/t/sp.test:
        After merge fixes. Restored test for bug 21002 which has mysteriously
        disappeared from 5.1 tree.
      83caa434
    • unknown's avatar
      Merge mockturtle.local:/home/dlenev/src/mysql-5.0-rt-merge · 35f7ae16
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-rt-merge
      
      
      BitKeeper/etc/collapsed:
        auto-union
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/r/temp_table.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      mysql-test/t/temp_table.test:
        Manual merge.
      sql/sql_select.cc:
        Manual merge.
      sql/sql_table.cc:
        Manual merge.
      35f7ae16
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · a4dda37f
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-rt-merge
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      a4dda37f
    • unknown's avatar
      Merge mockturtle.local:/home/dlenev/src/mysql-4.1-bg22338-2 · d4553e35
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-rt-merge
      
      
      mysql-test/r/temp_table.result:
        Auto merged
      mysql-test/t/temp_table.test:
        Auto merged
      sql/sql_select.cc:
        Manual merge.
      sql/sql_table.cc:
        Manual merge.
      d4553e35
    • unknown's avatar
      be6911d2
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 10c66c6a
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-rt-merge
      
      
      BitKeeper/etc/collapsed:
        auto-union
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      10c66c6a
  2. 28 Sep, 2006 10 commits
    • unknown's avatar
      Fix for bug#22338 "Valgrind warning: uninitialized variable in · 5d46e299
      unknown authored
      create_tmp_table()".
      
      The fix for bug 21787 "COUNT(*) + ORDER BY + LIMIT returns wrong
      result" introduced valgrind warnings which occured during execution
      of information_schema.test and sp-prelocking.test in version 5.0.
      There were no user visible effects.
      
      The latter fix made create_tmp_table() dependant on
      THD::lex::current_select value. Valgrind warnings occured when this
      function was executed and THD::lex::current_select member pointed
      to uninitialized SELECT_LEX instance.
      
      This fix tries to remove this dependancy by moving some logic
      outside of create_tmp_table() function.
      
      
      sql/sql_select.cc:
        create_tmp_table():
          Moved code which is responsible for determining if optimization
          which pushes down LIMIT clause to temporary table creation is
          applicable out of this function.
          Such move made this function independant of THD::lex::current_select
          value and removed valgrind warnings which occured in cases when this
          member pointed to uninitialized SELECT_LEX object (particularly these
          warnings occured in sp-prelocking.test and information_schema.test
          in 5.0). This seems like a better solution than trying to force this
          pointer always to point to relevant select because:
          - In some cases when we use create_tmp_table() there are no relevant
            SELECT_LEX object (we use it just to create temporary table/object).
          - There is only one place in code where we call this funciton and
            where this optimization can be enabled. And in this place we
            already have some logic which tries to determine if it is applicable.
      5d46e299
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 1ec1fc44
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      1ec1fc44
    • unknown's avatar
      after merge fix · 1e641502
      unknown authored
      1e641502
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · a9192a57
      unknown authored
      into  alik.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/sp.cc:
        Auto merged
      a9192a57
    • unknown's avatar
      5.0-rt -> 5.1-rt after-merge fixes. · 5871cf09
      unknown authored
      
      mysql-test/lib/mtr_im.pl:
        Fix merge.
      mysql-test/lib/mtr_process.pl:
        Fix merge.
      mysql-test/r/im_daemon_life_cycle.result:
        Fix merge.
      mysql-test/t/im_daemon_life_cycle.imtest:
        Fix merge.
      5871cf09
    • unknown's avatar
      Merge alik.:/mnt/raid/alik/MySQL/devel/5.0-rt · eaf199de
      unknown authored
      into  alik.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      BitKeeper/etc/collapsed:
        auto-union
      mysql-test/r/im_daemon_life_cycle.result:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/im_daemon_life_cycle.imtest:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      server-tools/instance-manager/instance.cc:
        Auto merged
      server-tools/instance-manager/listener.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/lib/mtr_process.pl:
        Manually merged.
      mysql-test/mysql-test-run.pl:
        Manually merged.
      eaf199de
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · 5f10ffd0
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      include/mysql_com.h:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_repl.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/sp.cc:
        manual merge
      sql/sp_head.cc:
        manual merge
      sql/sql_class.h:
        manual merge
      sql/table.cc:
        manual merge
      5f10ffd0
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · dc449f65
      unknown authored
      into  example.com:/work/mysql-5.1-runtime-fresh2
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/sp.cc:
        Auto merged
      dc449f65
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 4bbca0b6
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-4.1-runtime
      
      
      4bbca0b6
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 2d48a1f2
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/5.1-runtime-new
      
      
      sql/handler.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/sp.result:
        manual merge
      mysql-test/t/sp.test:
        manual merge
      storage/csv/ha_tina.cc:
        manual merge
      storage/myisam/ha_myisam.cc:
        manual merge
      2d48a1f2
  3. 27 Sep, 2006 11 commits
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · ca48fece
      unknown authored
      into  example.com:/work/mysql-5.0-runtime
      
      
      mysql-test/t/sp.test:
        Auto merged
      sql/sp.cc:
        Auto merged
      mysql-test/r/sp.result:
        manual merge
      ca48fece
    • unknown's avatar
      post-merge fix · 573e18e6
      unknown authored
      573e18e6
    • unknown's avatar
      Merge example.com:/work/mysql-5.0-runtime · 18651379
      unknown authored
      into  example.com:/work/mysql-5.1-runtime-fresh2
      
      
      mysql-test/t/sp.test:
        Auto merged
      sql/sp.cc:
        Auto merged
      18651379
    • unknown's avatar
      Fix for bug#21311: Possible stack overrun if SP has non-latin1 name · fcb8687a
      unknown authored
        
      There was possible stack overrun in an edge case which handles invalid body of
      a SP in mysql.proc . That should be case when mysql.proc has been changed
      manually. Though, due to bug 21513, it can be exploited without having access
      to mysql.proc only being able to create a stored routine.
      
      
      mysql-test/r/sp.result:
        update result
      mysql-test/t/sp.test:
        add a test case for the bug
      sql/sp.cc:
        Fix stack overrun. This happen mostly when mysql.proc is damaged, though
        it's possible due to another bug which creates invalid SP body in mysql.proc
        (leading quote from a label being cut) to create stack overrun even without
        having direct access to mysql.proc
      fcb8687a
    • unknown's avatar
      additional 'after merge' fix · c316933e
      unknown authored
      c316933e
    • unknown's avatar
      after merge fix · c1e264a5
      unknown authored
      c1e264a5
    • unknown's avatar
      Remove unused error messages (no release contains them · ac4b6623
      unknown authored
      at the moment, so we can safely do that). Update an error
      mesage to make it translateable.
      
      
      mysql-test/r/log_tables.result:
        update result file
      sql/share/errmsg.txt:
        remove unused error messages
      sql/sql_table.cc:
        Use name of the statements rather then English words.
        This way error message is translateable.
      ac4b6623
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/4.1 · 6d77ba47
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0
      
      
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/table.cc:
        Auto merged
      include/mysql_com.h:
        manual merge
      mysql-test/r/ctype_utf8.result:
        manual merge
      mysql-test/t/ctype_utf8.test:
        manual merge
      sql/sql_acl.cc:
        manual merge
      6d77ba47
    • unknown's avatar
      Patch for bug#21432 is reverted · abd883f4
      unknown authored
      abd883f4
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · 7c59445a
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21414
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      7c59445a
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0 · afedaa10
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug21414
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      afedaa10
  4. 26 Sep, 2006 5 commits
    • unknown's avatar
      Added more tests of field conversions. · 5529b7fb
      unknown authored
      5529b7fb
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-runtime · 4e5b560d
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-runtime
      
      
      4e5b560d
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/bug22379_runtime/my50-bug22379_runtime · bde59627
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-runtime
      
      
      server-tools/instance-manager/instance.cc:
        Auto merged
      bde59627
    • unknown's avatar
      Fix for bug#20208 · 770e9b4b
      unknown authored
      A better fix for bug#10025.
      
      Fixed test case plus added new tests.
      
      After fixing Bug#20208 "Blobs greater than 8K are being truncated to 8K"
      the fix to bug#10025 "Misleading error with COLLATE mediumtext and UNION"
      became more accurate. Earlier mediumtext got converted to longtext,
      although mediumtext was enough to contain the results. Now it converts
      correctly to mediumtext, if the length does not exceed that and if none
      of the original fields were type longtext.
      
      Type longtext still converts correctly to type longtext, as the extra
      tests prove.
      
      
      mysql-test/r/union.result:
        Fixed an earlier test case plus added two new tests.
      mysql-test/t/union.test:
        Fixed an earlier test case plus added two new tests.
      770e9b4b
    • unknown's avatar
      Merge trift2.:/MySQL/M50/clone-5.0 · 3436f0ac
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      mysql-test/r/func_time.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/func_time.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/type_date.test:
        Auto merged
      mysql-test/t/view.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      sql/item_cmpfunc.cc:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      3436f0ac
  5. 25 Sep, 2006 7 commits
    • unknown's avatar
      Fix for bug#22662 Inconsistent values displayed for event_scheduler · 070c8e74
      unknown authored
      when set to DISABLED
        
      It was a silly ordering number error.
      
      
      
      sql/events.h:
        fix ordinal number, the cause for bug #22662
        Inconsistent values displayed for event_scheduler when set to DISABLED
      mysql-test/r/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/r/events_restart_phase0.result''
      mysql-test/t/events_restart_phase0.log:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.log''
      mysql-test/t/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.result''
      070c8e74
    • unknown's avatar
      Fix for bug#22397 Events: crash with procedure which alters events · 6c9400b9
      unknown authored
        
      ALTER EVENT in stored procedure body led to a crash during the
      procedure call. Affected was only ALTER EVENT which changed the
      interval of the event. No problems with AT, STARTS, ENDS and so on.
      
      
      
      mysql-test/r/events_bugs.result:
        fix result
      mysql-test/t/events_bugs.test:
        add test case for bug 22397 : Events, crash with procedure which alters body
      sql/event_data_objects.cc:
        fix copy&paste error in code, which resulted in bug#22397
        Events: crash with procedure which alters body
      6c9400b9
    • unknown's avatar
      cleanups - fix a test and remove unneeded declaration · 038fbc27
      unknown authored
      
      mysql-test/r/events.result:
        test result
      mysql-test/t/events.test:
        fix test
      sql/sql_show.cc:
        remove unneeded declaration
      038fbc27
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/bug22379_runtime/my50-bug22379_runtime · cd6a5b87
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug22379_runtime/my51-bug22379_runtime
      
      
      server-tools/instance-manager/guardian.cc:
        Auto merged
      server-tools/instance-manager/instance.cc:
        Auto merged
      server-tools/instance-manager/instance_options.cc:
        Auto merged
      cd6a5b87
    • unknown's avatar
      207fd3fa
    • unknown's avatar
      Bug #22379 im_daemon_life_cycle.test fails on merge of 5.1 -> 5.1-engines · f91b91cf
      unknown authored
      Remove race situations that occur when removing pidfiles. Primarily each process should remove its own
      pidfile, secondly it should be removed by the process that created it and _only_ if it's
      certain the process is dead. Third, mysql-test-run.pl will remove the pidfile when process has been killed.
      - Set state of an instance to STARTING _before_ calling instance->start()
      - Check that pidfile of instance has been created before changing STARTING => STARTED
      - Only remove the pidfile if IM kills an instance with SIGKILL, otherwise the instance will remove it itself
      
      
      server-tools/instance-manager/guardian.cc:
        If state of an instance is STARTING, chech that the instance pidfile has been created
        before changing state to STARTED
        Set state to STARTING before calling instance->start(), it can take some time
        before it is fully started and during that time it should be in state STARTING
      server-tools/instance-manager/instance.cc:
        Only remove the pid file of instance manager when a SIGKILL has 
        been performed sucessfully
      server-tools/instance-manager/instance_options.cc:
        Check that fscanf returns 1 which is the number of args that should be scanned from
        the pid file
      f91b91cf
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.1 · af3f646c
      unknown authored
      into  production.mysql.com:/usersnfs/jamppa/mysql-5.1-bug-20208
      
      
      BitKeeper/deleted/.del-ps_6bdb.result:
        Auto merged
      include/mysql_com.h:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      af3f646c
  6. 24 Sep, 2006 1 commit