1. 29 Mar, 2006 2 commits
    • unknown's avatar
      Remove compiler warnings · 8ac1d552
      unknown authored
      Add missing DBUG_RETURN
      Fixed stack overflow in NdbBlob (found by ndb_gis.test)
      Fixed access to freed memory in ndb_cluster_real_free_share()
      
      
      mysys/mf_keycache.c:
        Add missing DBUG_RETURN
      sql/ha_ndbcluster.cc:
        Move free_root to after share handling, as otherwise we will free things needed by free_table_share()
      sql/item_func.cc:
        Add missing DBUG_RETURN
      sql/item_strfunc.cc:
        Add missing DBUG_RETURN
      sql/sp_head.cc:
        Add missing DBUG_RETURN
      sql/sql_base.cc:
        Add missing DBUG_RETURN
      storage/csv/ha_tina.cc:
        Add missing DBUG_RETURN
      storage/myisam/mi_key.c:
        Add missing DBUG_RETURN
      storage/myisam/mi_keycache.c:
        Add missing DBUG_RETURN
      storage/ndb/include/kernel/signaldata/ArbitSignalData.hpp:
        Remove compiler warning
      storage/ndb/include/kernel/signaldata/DictTabInfo.hpp:
        Remove compiler warning
      storage/ndb/include/transporter/TransporterDefinitions.hpp:
        Remove compiler warning
      storage/ndb/include/util/SimpleProperties.hpp:
        Remove compiler warning
      storage/ndb/include/util/SocketServer.hpp:
        Remove compiler warning
      storage/ndb/src/ndbapi/ClusterMgr.hpp:
        Remove compiler warning
      storage/ndb/src/ndbapi/NdbBlob.cpp:
        Fix stack overflow
      storage/ndb/src/ndbapi/NdbEventOperationImpl.hpp:
        Remove compiler warning
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Remove compiler warning
      8ac1d552
    • unknown's avatar
      Fixed compiler and valgrind warnings · 59eaf292
      unknown authored
      Added missing DBUG_xxx_RETURN statements
      Fixed some usage of not initialized variables (as found by valgrind)
      Ensure that we don't remove locked tables used as name locks from open table cache until unlock_table_names() are called.
      This was fixed by having drop_locked_name() returning any table used as a name lock so that we can free it in unlock_table_names()
      This will allow Tomas to continue with his work to use namelocks to syncronize things.
      
      Note: valgrind still produces a lot of warnings about using not initialized code and shows memory loss errors when running the ndb tests
      
      
      BitKeeper/etc/ignore:
        added mysql-test/r/*.log
      client/mysqltest.c:
        Change type of variables to get rid of compiler warnings
        More debugging
        Fix memory leak
      mysql-test/mysql-test-run.sh:
        Collect warnings about missing DBUG_RETURN statements
      mysql-test/r/lock_multi.result:
        Add test of new code
      mysql-test/r/ndb_condition_pushdown.result:
        Drop used tables before test
      mysql-test/t/lock_multi.test:
        Add test of new code
      mysql-test/t/ndb_condition_pushdown.test:
        Drop used tables before test
      mysql-test/valgrind.supp:
        Ignore 'safe' warnings from libz (when used with archive)
      sql/event.cc:
        More comments
        Simplify code
        Fixed memory leak found by valgrind
      sql/ha_archive.cc:
        Remove compiler warnings (Wrong handlerton structure and signed/unsigned comparison)
      sql/ha_berkeley.cc:
        Fixed compiler warning
      sql/ha_blackhole.cc:
        Fixed compiler warning
      sql/ha_federated.cc:
        Fixed compiler warning
      sql/ha_heap.cc:
        Fixed compiler warning
      sql/ha_myisam.cc:
        Fixed compiler warning
      sql/ha_myisammrg.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/ha_partition.cc:
        Fixed compiler warning
        Fixed error noticed by valgrind in ha_partition::rnd_init()
      sql/handler.cc:
        Fixed compiler warning
      sql/handler.h:
        Fixed compiler warning
      sql/item.cc:
        Fixed compiler warning
      sql/item_xmlfunc.cc:
        Fixed warning from valgrind when calling memcpy with wrong address
      sql/lock.cc:
        More debugging
      sql/log.cc:
        Fixed compiler warning
        Indentation fixes
      sql/log.h:
        Fixed compiler warning
      sql/mysql_priv.h:
        Changed prototype for 'drop_locked_tables'
      sql/opt_range.cc:
        Indentation fix
      sql/password.c:
        Removed compiler warnings
      sql/set_var.cc:
        Fixed compiler warning
      sql/slave.cc:
        Fixed compiler warning
      sql/sp_head.cc:
        Fixed compiler warning
      sql/sql_acl.cc:
        Fixed compiler warning
      sql/sql_analyse.cc:
        Added missing DBUG_RETURN statements
      sql/sql_base.cc:
        Removed de-reference of not initialized pointer
        More comments
        drop_locked_tables() changed to not delete tables used for name locking
        Fixed compiler warnings
      sql/sql_delete.cc:
        Fixed usage of not initialized variable
        (deleted could be referenced in some not common error conditions)
      sql/sql_parse.cc:
        Added missing DBUG_VOID_RETURN
        Simplify code
      sql/sql_partition.cc:
        Fixed usage of wrong variable (noticed by valgrind)
      sql/sql_plugin.cc:
        Removed compiler warning
      sql/sql_show.cc:
        Removed compiler warning
      sql/sql_table.cc:
        Ensure that we don't remove locked tables used as name locks from open table cache until unlock_table_names() are called.
        This was fixed by having drop_locked_name() returning any table used as a name lock so that we can free it in unlock_table_names()
        This will allow Tomas to continue with his work to use namelocks to syncronize things.
        
        Fixed wrong test of 'table_type' (path_length could otherwise be accessed uninitialized)
        
        Remove compile warnings about not initialized variables.
      sql/sql_yacc.yy:
        Ensure that no_write_to_binlog is properly initialized
        (Was accessed uninitialized by partition code)
      sql/table.cc:
        Removed valgrind warnings (not fatal)
        Removed compiler warnings
      sql/tztime.cc:
        Removed valgrind warning
      storage/ndb/include/ndbapi/NdbIndexStat.hpp:
        Removed compiler warning
      59eaf292
  2. 28 Mar, 2006 9 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.1-new · 73970add
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.1
      
      
      include/mysql.h:
        Auto merged
      mysql-test/lib/mtr_timer.pl:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Auto merged
      73970add
    • unknown's avatar
      Merge zim.(none):/home/ian/workspace/mysql-5.0 · effd72a9
      unknown authored
      into  zim.(none):/home/ian/workspace/mysql-5.1-new
      
      Updated bug message in disabled file -Brian
      
      
      BitKeeper/etc/ignore:
        auto-union
      include/mysql.h:
        Auto merged
      mysql-test/lib/mtr_timer.pl:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/parse_file.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Auto merged
      mysql-test/t/disabled.def:
        Changing message to add in bug numnber
      effd72a9
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/dev/mysql-5.0-0 · 6da39a4c
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.1-0
      
      
      include/mysql.h:
        Auto merged
      mysql-test/lib/mtr_timer.pl:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Auto merged
      6da39a4c
    • unknown's avatar
      Fixed bug #18386. · b0654461
      unknown authored
      An invalid assertion in Item_direct_view_ref::eq caused 
      an assertion abort in the debug version.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #18386.
      mysql-test/t/view.test:
        Added a test case for bug #18386.
      sql/item.cc:
        Fixed bug #18386.
        An invalid assertion in Item_direct_view_ref::eq caused 
        an assertion abort in the debug version.
        Changed the assertion.
      b0654461
    • unknown's avatar
      Merge igreenhoe@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4faee665
      unknown authored
      into  zim.(none):/home/ian/workspace/mysql-5.0
      
      
      4faee665
    • unknown's avatar
      Disable udf test · 63605b9f
      unknown authored
      
      BitKeeper/etc/ignore:
        Added mysql-test/r/udf.log to the ignore list
      mysql-test/t/disabled.def:
        Disable the udf test, per bug #18564. Permission by Brian
      63605b9f
    • unknown's avatar
      Removing deleted file (this fixes the pushbuild failure from Reggie's push). · 9c9e0684
      unknown authored
      There still may be issues on the Window's side from what I can see from doing a grep. 
      
      
      sql/Makefile.am:
        Removing deleted file.
      9c9e0684
    • unknown's avatar
      Disabling test for rpl_ndb_sp007 · cd493c5a
      unknown authored
      
      mysql-test/t/disabled.def:
        Adding in disabled test
      cd493c5a
    • unknown's avatar
      Fix for bug #16855 · af64d85a
      unknown authored
      
      BitKeeper/etc/ignore:
        Added mysql-test/r/bdb.log mysql-test/r/im_client_port.log to the ignore list
      client/mysql.cc:
        If --socket is not set, provides --protocol=TCP when --port=
        is specified (and --protocol= is not specified.)
      af64d85a
  3. 27 Mar, 2006 29 commits