1. 24 Mar, 2007 2 commits
    • unknown's avatar
      BUG#26257 New Federated Server Functionality Doesn't support differently named tables · 99c5c28c
      unknown authored
      * Modified Federated memory allocation to use MEM_ROOT
      * Modified sql_servers and federated to allocate share connection
        parameters to use MEM_ROOT
      * Modified Federated to allow tablename in addition to server name
      * Implicit flushing of tables using altered/dropped server name
      * Added tests to prove new functionality works
      
      Contributors to this patch: Patrick Galbraith, Antony Curtis
      
      
      mysql-test/r/federated_server.result:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
          New test results
      mysql-test/t/federated_server.test:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        New test which ensures that one can use the new 'create server'
        functionality and have tables point to the correct table, using CONNECTION='server',
        CONNECTION="server/tablename" and CONNECTION="mysql://...url"
      sql/mysql_priv.h:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        new function: close_cached_connection_tables()
      sql/sql_base.cc:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        new function: close_cached_connection_tables()
          closes all open tables which match connection string
          provides functionality to allow flushing of altered/dropped server names.
      sql/sql_servers.cc:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * Added function clone_server() to allocate a new server for use by
          get_server_by_name() when creating a federated table
        
        * Now using MEM_ROOT allocation (mark and sweep) to account for meta
          data parameters being allocated properly, particularly with regards to
          to SERVER object. Also cleans up code allocating share.
        
        * Tables using the old definition of server name are now flushed on successful
          execution of ALTER/DROP SERVER.
        
        style: fixed some line-wrapping
      sql/sql_servers.h:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * change in prototype to get_server_by_name()
          caller can now provide mem_root which strings will be copied in to.
      storage/federated/ha_federated.cc:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * Simplified share and share member memory allocaton to use MEM_ROOT
        * Modified parse_url to parse table names along with server names
      storage/federated/ha_federated.h:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * Added MEM_ROOT share member
      99c5c28c
    • unknown's avatar
      Bug#25721 · cb5b56c8
      unknown authored
        "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        Deadlock caused by inconsistant use of mutexes in sql_server.cc
        One mutex has been removed to resolve deadlock.
        Many functions were made private which should not be exported.
        Unused variables and function removed.
      
      
      mysql-test/r/federated_server.result:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        New test results
      mysql-test/t/federated_server.test:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        Test for bug by using stored procedure. Unpatched server would deadlock frequently.
      sql/sql_parse.cc:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        check for correct error code when dropping server
      sql/sql_servers.cc:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        Removed unneccessary mutex, only need THR_LOCK_servers rwlock to
        guard data structures against race conditions. Misuse of other mutex
        caused deadlock by inconsistant ordering of mutex lock operations.
        Alter order of some operations to hit memory before disk.
        Removed unused function.
        Removed servers_version and servers_cache_initialised variables.
        Made many internal functions static.
      sql/sql_servers.h:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        remove internal functions from being exported.
      cb5b56c8
  2. 23 Mar, 2007 2 commits
  3. 22 Mar, 2007 2 commits
  4. 21 Mar, 2007 4 commits
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-bug26996 · 26a34b1a
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug26996
      
      
      mysql-test/r/heap_btree.result:
        Auto merged
      mysql-test/t/heap_btree.test:
        Auto merged
      storage/heap/hp_write.c:
        Auto merged
      26a34b1a
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug26996 · 19630640
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug26996
      
      
      heap/hp_write.c:
        Auto merged
      mysql-test/r/heap_btree.result:
        Auto merged
      mysql-test/t/heap_btree.test:
        Bug#26996 - Update of a Field in a Memory Table ends with wrong result
        Manual merge from 4.1
      19630640
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · 515ff242
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG25908/mysql-5.1-engines
      
      
      storage/myisam/ha_myisam.cc:
        Auto merged
      515ff242
    • unknown's avatar
      BUG#25908 - corrupted myisam table crashes server even after repair · a5c27d6c
      unknown authored
      Opening certain tables that have different definitions in .MYI and
      .frm may result in a server crash.
      
      Compare .MYI and .frm definition when myisam table is opened. In case
      definitions are diffirent refuse to open such table.
      
      No test case, since it requires broken table.
      
      
      storage/myisam/ha_myisam.cc:
        Compare .MYI and .frm definition when myisam table is opened. In case
        definitions are diffirent refuse to open such table.
      a5c27d6c
  5. 19 Mar, 2007 1 commit
    • unknown's avatar
      Bug#26996 - Update of a Field in a Memory Table ends with wrong result · db573e63
      unknown authored
      Using a MEMORY table BTREE index for scanning for updatable rows
      could lead to an infinite loop.
      
      Everytime a key was inserted into a btree index, the position
      in the index scan was cleared. The search started from the
      beginning and found the same key again.
      
      Now we do not clear the position on key insert an more.
      
      
      heap/hp_write.c:
        Bug#26996 - Update of a Field in a Memory Table ends with wrong result
        Removed the index-scan-breaking nulling of last_pos.
        The comment behind this line ("For heap_rnext/heap_rprev")
        was misleading. It should have been "Breaks heap_rnext/heap_rprev".
      mysql-test/r/heap_btree.result:
        Bug#26996 - Update of a Field in a Memory Table ends with wrong result
        Added test result.
      mysql-test/t/heap_btree.test:
        Bug#26996 - Update of a Field in a Memory Table ends with wrong result
        Added test.
      db573e63
  6. 16 Mar, 2007 2 commits
  7. 15 Mar, 2007 8 commits
    • unknown's avatar
      Merge xiphis.org:/home/antony/work2/p1-bug25671.3 · b5d5e17b
      unknown authored
      into  xiphis.org:/home/antony/work2/p1-bug25671.4
      
      
      sql/sql_parse.cc:
        Auto merged
      b5d5e17b
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-bug25289 · 7424208d
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug25289
      
      
      storage/myisam/ha_myisam.cc:
        Bug#25289 - repair table causes "my_seek.c:56:
                    my_seek: Assertion `fd != -1' failed"
        Manual merge from 5.0
      7424208d
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug25289 · c7ce63fb
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug25289
      
      
      sql/ha_myisam.cc:
        Bug#25289 - repair table causes "my_seek.c:56:
                    my_seek: Assertion `fd != -1' failed"
        Manual merge from 4.1
      c7ce63fb
    • unknown's avatar
      Merge mockturtle.local:/home/dlenev/src/mysql-5.0-bg25966-2 · 41a7704b
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-bg25966
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      41a7704b
    • unknown's avatar
      Merge mockturtle.local:/home/dlenev/src/mysql-4.1-bg25966 · 04e727c7
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-bg25966-2
      
      
      sql/mysqld.cc:
        Auto merged
      04e727c7
    • unknown's avatar
      Fix for bug #25966 "2MB per second endless memory consumption after LOCK · cdd2a2e4
      unknown authored
      TABLE ... WRITE".
      
      Memory and CPU hogging occured when connection which had to wait for table
      lock was serviced by thread which previously serviced connection that was
      killed (note that connections can reuse threads if thread cache is enabled).
      One possible scenario which exposed this problem was when thread which
      provided binlog dump to replication slave was implicitly/automatically
      killed when the same slave reconnected and started pulling data through
      different thread/connection.
      The problem also occured when one killed particular query in connection
      (using KILL QUERY) and later this connection had to wait for some table
      lock.
      
      This problem was caused by the fact that thread-specific mysys_var::abort
      variable, which indicates that waiting operations on mysys layer should
      be aborted (this includes waiting for table locks), was set by kill
      operation but was never reset back. So this value was "inherited" by the
      following statements or even other connections (which reused the same
      physical thread). Such discrepancy between this variable and THD::killed
      flag broke logic on SQL-layer and caused CPU and memory hogging.
      
      This patch tries to fix this problem by properly resetting this member.
      
      There is no test-case associated with this patch since it is hard to test
      for memory/CPU hogging conditions in our test-suite.
      
      
      sql/mysqld.cc:
        We should not forget to reset THD::mysys_var::abort after kill operation
        if we are going to use thread to which this operation was applied for
        handling of other connections.
      sql/sp_head.cc:
        We should not forget to reset THD::mysys_var::abort after kill operation
        if we are going to use thread to which this operation was applied for
        handling of further statements.
      sql/sql_parse.cc:
        We should not forget to reset THD::mysys_var::abort after kill operation
        if we are going to use thread to which this operation was applied for
        handling of further statements.
      cdd2a2e4
    • unknown's avatar
      Fix for bug #25966 "2MB per second endless memory consumption after LOCK · db1d2f64
      unknown authored
      TABLE ... WRITE".
      
      CPU hogging occured when connection which had to wait for table lock was
      serviced by thread which previously serviced connection that was killed
      (note that connections can reuse threads if thread cache is enabled).
      One possible scenario which exposed this problem was when thread which
      provided binlog dump to replication slave was implicitly/automatically
      killed when the same slave reconnected and started pulling data through
      different thread/connection.
      In 5.* versions memory hogging was added to CPU hogging. Moreover in
      those versions the problem also occured when one killed particular query
      in connection (using KILL QUERY) and later this connection had to wait for
      some table lock.
      
      This problem was caused by the fact that thread-specific mysys_var::abort
      variable, which indicates that waiting operations on mysys layer should
      be aborted (this includes waiting for table locks), was set by kill
      operation but was never reset back. So this value was "inherited" by the
      following statements or even other connections (which reused the same
      physical thread). Such discrepancy between this variable and THD::killed
      flag broke logic on SQL-layer and caused CPU and memory hogging.
      
      This patch tries to fix this problem by properly resetting this member.
      
      There is no test-case associated with this patch since it is hard to test
      for memory/CPU hogging conditions in our test-suite.
      
      
      sql/mysqld.cc:
        We should not forget to reset THD::mysys_var::abort after kill operation
        if we are going to use thread to which this operation was applied for
        handling of other connections.
      db1d2f64
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-engines · d139d19a
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-bg25966
      
      
      d139d19a
  8. 14 Mar, 2007 14 commits
  9. 13 Mar, 2007 5 commits
    • unknown's avatar
      Removed tabs. · 8205e16c
      unknown authored
      8205e16c
    • unknown's avatar
      Bug#25671 · 6d98913b
      unknown authored
        "CREATE/DROP/ALTER SERVER should require privileges"
        Add check for SUPER privilege when executing CREATE/DROP/ALTER SERVER.
        Previously, any user even with only USAGE priv can execute those commands.
      
      
      mysql-test/r/federated_server.result:
        Bug25671 - CREATE/DROP/ALTER SERVER should require privileges
      mysql-test/t/federated_server.test:
        Bug25671 - CREATE/DROP/ALTER SERVER should require privileges
      sql/sql_parse.cc:
        Bug25671 - CREATE/DROP/ALTER SERVER should require privileges
          Add check for SUPER privilege when executing CREATE/DROP/ALTER SERVER
      6d98913b
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · cf497651
      unknown authored
      into  blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25460
      
      
      cf497651
    • unknown's avatar
      Bug#25460 - High concurrency MyISAM access causes severe mysqld crash. · cc9f5576
      unknown authored
      The previous two patches for this bug worked together so that
      no permanent table was memory mapped. The first patch tried to
      avoid mapping while a table is in use. It allowed mapping only
      if there was exactly one lock on the table, assuming that the
      calling thread owned it. During mi_open(), a different call to
      memory mapping was coded, which did not have this limitation.
      
      The second patch tried to remove the code duplication and just
      called mi_extra() from mi_open() an thus inherited the limitation.
      But on open, a thread does not have a lock on the table...
      
      A possible solution would be to check for zero or one lock.
      But since I learned that it is safe to memory map a file while
      normal file I/O is done on it, I removed the restriction altogether
      and allow to memory map while a table is in use.
      
      No test case. I do not see a chance to verify with the test suite
      which kind of I/O is used on a table.
      
      
      storage/myisam/mi_extra.c:
        Bug#25460 - High concurrency MyISAM access causes severe mysqld crash.
        Allow to memory map while table is in use.
      cc9f5576
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines · 6095508b
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines
      
      
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/mi_create.c:
        Auto merged
      6095508b