1. 08 Oct, 2008 3 commits
    • marko's avatar
      branches/zip: mysql-test/patches/innodb_file_per_table.diff: · 9baf6752
      marko authored
      @@GLOBAL.innodb_file_per_table can be 0 or 1, while
      SELECT VARIABLE_VALUE FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES
      WHERE VARIABLE_NAME='innodb_file_per_table'
      can be 'OFF' or 'ON'.  For some reason, MySQL evaluates
      (0 = 'OFF') to 1 and (1 = 'ON') to 0.  Thus, the test would
      fail if innodb_file_per_table is set.
      9baf6752
    • marko's avatar
      branches/zip: page_copy_rec_list_end(): Remove the call · 544f0db7
      marko authored
      page_zip_validate_low(new_page_zip, new_page, TRUE) because it would
      cause bogus failures in btr_compress(), as noted in Issue #79.
      544f0db7
    • marko's avatar
      branches/zip: Do not release the data dictionary latch while holding locks · 9acb92fc
      marko authored
      to the data dictionary records.  This should fix Issue #83.
      
      row_drop_table_for_mysql_no_commit(): Rename back to
      row_drop_table_for_mysql().  Commit the transaction if the data
      dictionary was not locked when the function was called.  Otherwise,
      neither commit the transaction nor unlock the data dictionary.
      
      row_merge_drop_table(): Let row_drop_table_for_mysql() take care of
      locking the data dictionary.
      
      dict_create_or_check_foreign_constraint_tables(),
      trx_rollback_active(), row_create_table_for_mysql(),
      row_create_index_for_mysql(), row_table_add_foreign_constraints():
      Explicitly commit the transaction, because row_drop_table_for_mysql()
      would no longer commit it, given that the data dictionary will be
      locked during the calls.
      
      Approved by Sunny (over IM). rb://23
      9acb92fc
  2. 07 Oct, 2008 6 commits
    • marko's avatar
      branches/zip: Improve page_zip_validate() instrumentation. · a3cc71e0
      marko authored
      btr_lift_page_up(): Invoke page_zip_validate() on every page whose level
      is adjusted.
      
      btr_compress(): Invoke page_zip_validate() on merge_page at the end.
      
      page_zip_copy_recs(): Relax the page_zip_validate(...) to
      page_zip_validate_low(..., sloppy = TRUE) to avoid bogus assertion failures.
      
      page_copy_rec_list_end(), page_delete_rec_list_start():
      Invoke page_zip_validate_low(sloppy = TRUE).
      a3cc71e0
    • marko's avatar
      branches/zip: mysql-test/patches/information_schema.diff: · d3deb635
      marko authored
      Add patches to other mysql-test results that fail because of the added
      INFORMATION_SCHEMA tables: information_schema_db.result, mysqlshow.result.
      d3deb635
    • vasil's avatar
      branches/zip: · eba3e07e
      vasil authored
      Rename type_bit_innodb.diff to bug32625.diff since an equivalent patch has
      been submitted to MySQL as Bug#32625 Make test type_bit_innodb more robust.
      eba3e07e
    • marko's avatar
      branches/zip: Add some more patches to mysql-test. · d599a75d
      marko authored
      type_bit_innodb.diff: Ignore the reported duplicate value.  The reported
      value depends on the internal workings of the merge sort in
      fast index creation.  In the built-in InnoDB of MySQL 5.1, the records
      are copied to a new temporary table in the order they were selected from
      the original table.
      
      information_schema.diff: Account for the INFORMATION_SCHEMA tables that
      were added in the InnoDB plugin.
      
      innodb_file_per_table.diff: In the InnoDB plugin, innodb_file_per_table
      is a settable global variable.
      d599a75d
    • marko's avatar
      branches/zip: Patch the mysql-test suite, so that it will not fail · 6d2e65e6
      marko authored
      because innodb_lock_wait_timeout is a settable session variable as of r2716.
      
      mysql-test/patches/innodb_lock_wait_timeout.diff: New file.
      6d2e65e6
    • calvin's avatar
      Delete the recently added files from MySQL source tree, for · d6904e4c
      calvin authored
      Windows plugin. Instead, we will commit diff only.
      d6904e4c
  3. 06 Oct, 2008 5 commits
    • marko's avatar
      branches/zip: Improve the diagnostics of issue #79. · 690e2f54
      marko authored
      page_zip_fail_func(): Display the timestamp.
      
      page_zip_validate_low(): Display information about ignored min_rec_flag
      differences.
      690e2f54
    • marko's avatar
      branches/zip: Relax the page_zip_validate() check during crash recovery: · 082f28dc
      marko authored
      ignore intermittent differences in the "predefined minimum record" flag.
      
      page_zip_validate_low(): Renamed from page_zip_validate(), with an
      additional parameter: ibool sloppy.  Ignore REC_INFO_MIN_REC_FLAG when
      sloppy == TRUE.
      
      page_zip_validate(): Wrapper for page_zip_validate_low().  Pass
      sloppy = recv_recovery_is_on().
      
      recv_recover_page(): After applying the changes from the redo log to a
      compressed B-tree page, invoke page_zip_validate_low() in strict mode.
      082f28dc
    • vasil's avatar
      branches/zip: · cefd498e
      vasil authored
      Add more ChangeLog entries from the merge
      of 2702:2722 from branches/5.1 (r2723).
      cefd498e
    • vasil's avatar
      branches/zip: · 641a36e2
      vasil authored
      Add entry for Bug#37788 InnoDB Plugin: AUTO_INCREMENT wrong for compressed tables
      in the ChangeLog
      641a36e2
    • vasil's avatar
      branches/zip: · 4ef28fde
      vasil authored
      Add entry for Bug#39830 Table autoinc value not updated on first insert
      in the ChangeLog.
      4ef28fde
  4. 05 Oct, 2008 1 commit
  5. 04 Oct, 2008 4 commits
    • sunny's avatar
      branches/zip: Fix the handler class method return type. Change ulong to ulint · 2e935591
      sunny authored
      so that it conforms to InnoDB's internal error/return code type.
      2e935591
    • sunny's avatar
      branches/zip: Simplify the autoinc initialization code. This removes the · 47db86be
      sunny authored
      non-determinism related to reading the table's autoinc value for the first
      time. This change has also reduced the sizeof dict_table_t by sizeof(ibool)
      bytes because we don't need the dict_table_t::autoinc_inited field anymore.
      
      This also fixes Bug#39830 Table autoinc value not updated on first insert.
      rb://16
      47db86be
    • sunny's avatar
      branches/zip: Check column value against the col max value before updating · 2abb3f19
      sunny authored
      the table's global autoinc counter value. This is part of simplifying the
      AUTOINC sub-system. We extract the type info from MySQL data structures at
      runtime.
      
      This fixes Bug#37788 InnoDB Plugin: AUTO_INCREMENT wrong for compressed tables
      2abb3f19
    • sunny's avatar
      branches/zip: Merge revisions 2702:2722 from branches/5.1: · 00189b7a
      sunny authored
        ------------------------------------------------------------------------
        r2702 | sunny | 2008-09-30 11:41:56 +0300 (Tue, 30 Sep 2008) | 13 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
        
        branches/5.1: Since handler::get_auto_increment() doesn't allow us
        to return the cause of failure we have to inform MySQL using the
        sql_print_warning() function to return the cause for autoinc failure.
        Previously we simply printed the error code, this patch prints the
        text string representing the following two error codes:
        
        DB_LOCK_WAIT_TIMEOUT
        DB_DEADLOCK.
        
        Bug#35498 Cannot get table test/table1 auto-inccounter value in ::info
        
        Approved by Marko.
        
        ------------------------------------------------------------------------
        r2709 | vasil | 2008-10-01 10:13:13 +0300 (Wed, 01 Oct 2008) | 10 lines
        Changed paths:
           M /branches/5.1/include/lock0lock.h
           M /branches/5.1/lock/lock0lock.c
           A /branches/5.1/mysql-test/innodb_bug38231.result
           A /branches/5.1/mysql-test/innodb_bug38231.test
           M /branches/5.1/row/row0mysql.c
        
        branches/5.1:
        
        Fix Bug#38231 Innodb crash in lock_reset_all_on_table() on TRUNCATE + LOCK / UNLOCK
        
        In TRUNCATE TABLE and discard tablespace: do not remove table-level S
        and X locks and do not assert on such locks not being wait locks.
        Leave such locks alone.
        
        Approved by:	Heikki (rb://14)
        
        ------------------------------------------------------------------------
        r2710 | vasil | 2008-10-01 14:13:58 +0300 (Wed, 01 Oct 2008) | 6 lines
        Changed paths:
           M /branches/5.1/include/sync0sync.ic
        
        branches/5.1:
        
        Silence a compilation warning in UNIV_DEBUG.
        
        Approved by:	Marko (via IM)
        
        ------------------------------------------------------------------------
        r2719 | vasil | 2008-10-03 18:17:28 +0300 (Fri, 03 Oct 2008) | 49 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           A /branches/5.1/mysql-test/innodb_bug39438-master.opt
           A /branches/5.1/mysql-test/innodb_bug39438.result
           A /branches/5.1/mysql-test/innodb_bug39438.test
        
        branches/5.1:
        
        Fix Bug#39438 Testcase for Bug#39436 crashes on 5.1 in fil_space_get_latch
        
        In ha_innobase::info() - do not try to get the free space for a tablespace
        which has been discarded with ALTER TABLE ... DISCARD TABLESPACE or if the
        .ibd file is missing for some other reason.
        
        ibd_file_missing and tablespace_discarded are manipulated only in
        row_discard_tablespace_for_mysql() and in row_import_tablespace_for_mysql()
        and the manipulation is protected/surrounded by
        row_mysql_lock_data_dictionary()/row_mysql_unlock_data_dictionary() thus we
        do the same in ha_innobase::info() when checking the values of those members
        to avoid race conditions. I have tested the code-path with UNIV_DEBUG and
        UNIV_SYNC_DEBUG.
        
        Looks like it is not possible to avoid mysqld printing warnings in the
        mysql-test case and thus this test innodb_bug39438 must be added to the
        list of exceptional test cases that are allowed to print warnings. For this,
        the following patch must be applied to the mysql source tree:
        
          --- cut ---
          === modified file 'mysql-test/lib/mtr_report.pl'
          --- mysql-test/lib/mtr_report.pl	2008-08-12 10:26:23 +0000
          +++ mysql-test/lib/mtr_report.pl	2008-10-01 11:57:41 +0000
          @@ -412,7 +412,10 @@
           
                           # When trying to set lower_case_table_names = 2
                           # on a case sensitive file system. Bug#37402.
          -                /lower_case_table_names was set to 2, even though your the file system '.*' is case sensitive.  Now setting lower_case_table_names to 0 to avoid future problems./
          +                /lower_case_table_names was set to 2, even though your the file system '.*' is case sensitive.  Now setting lower_case_table_names to 0 to avoid future problems./ or
          +
          +                # this test is expected to print warnings
          +                ($testname eq 'main.innodb_bug39438')
           		)
                       {
                         next;                       # Skip these lines
          
          --- cut ---
        
        The mysql-test is currently somewhat disabled (see inside
        innodb_bug39438.test), after the above patch has been applied to the mysql
        source tree, the test can be enabled.
        
        rb://20
        
        Reviewed by:	Inaam, Calvin
        Approved by:	Heikki
        
        ------------------------------------------------------------------------
        r2720 | vasil | 2008-10-03 19:52:39 +0300 (Fri, 03 Oct 2008) | 8 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
        
        branches/5.1:
        
        Print a warning if an attempt is made to get the free space for a table
        whose .ibd file is missing or the tablespace has been discarded. This is a
        followup to r2719.
        
        Suggested by:	Inaam
        
        ------------------------------------------------------------------------
        r2721 | sunny | 2008-10-04 02:08:23 +0300 (Sat, 04 Oct 2008) | 6 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
        
        branches/5.1: We need to send the messages to the client because
        handler::get_auto_increment() doesn't allow a way to return the
        specific error for why it failed.
        
        rb://18
        
        ------------------------------------------------------------------------
        r2722 | sunny | 2008-10-04 02:48:04 +0300 (Sat, 04 Oct 2008) | 18 lines
        Changed paths:
           M /branches/5.1/dict/dict0mem.c
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/include/dict0mem.h
           M /branches/5.1/include/row0mysql.h
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
           M /branches/5.1/row/row0mysql.c
        
        branches/5.1: This bug has always existed but was masked by other errors. The
        fix for bug# 38839 triggered this bug. When the offset and increment are > 1
        we need to calculate the next value taking into consideration the two
        variables. Previously we simply assumed they were 1 particularly offset was
        never used. MySQL does its own calculation and that's probably why it seemed
        to work in the past. We would return what we thought was the correct next
        value and then MySQL would recalculate the actual value from that and return
        it to the caller (e.g., handler::write_row()). Several new tests have been
        added that try and catch some edge cases. The tests exposed a wrap around
        error in MySQL next value calculation which was filed as bug#39828. The tests
        will need to be updated once MySQL fix that bug.
        
        One good side effect of this fix is that dict_table_t size has been
        reduced by 8 bytes because we have moved the autoinc_increment field to
        the row_prebuilt_t structure. See review-board for a detailed discussion.
        
        rb://3
        
        ------------------------------------------------------------------------
      00189b7a
  6. 03 Oct, 2008 3 commits
    • vasil's avatar
      branches/zip: · 46c7c2ba
      vasil authored
      ChangeLog:
      Use "Fix Bug#NNNNN bug summary text" for bugfixes, as for other entries
      in the file.
      46c7c2ba
    • marko's avatar
      branches/zip: innodb-index.test: Make the pattern for temporary table names · 01aba6f8
      marko authored
      more generic.  The previous pattern could fail if other test cases were run
      before this one.  Since r2716, the MySQL server is not restarted for this test.
      01aba6f8
    • marko's avatar
      branches/zip: Make innodb_lock_wait_timeout a settable session variable · 4d6c1573
      marko authored
      (Bug #36285, rb://9).
      
      innodb-index.test, innodb-index.result: Set innodb_lock_wait_timeout as
      a session variable instead of relying on the global value.
      
      innodb-index-master.opt: Remove.
      
      innodb-timeout.test: Test that setting the innodb_lock_wait_timeout
      works as advertised.
      
      thd_lock_wait_timeout(): New function, to retrieve the lock wait timeout
      for a given MySQL client connection (thd), or the global value (thd==NULL).
      
      srv_lock_wait_timeout, innobase_lock_wait_timeout: Remove.
      
      Replace MYSQL_SYSVAR_LONG(lock_wait_timeout)
      with MYSQL_THDVAR_ULONG(lock_wait_timeout).  
      4d6c1573
  7. 01 Oct, 2008 3 commits
    • marko's avatar
      branches/zip: page_mem_free(): Remove the obsolete remark that there · dd5c8747
      marko authored
      should be space left in the modification log of the compressed page.
      Record deletion does not require any space in the modification log.
      dd5c8747
    • marko's avatar
      branches/zip: page_zip_validate(): On page header mismatch, · 54fbfaa8
      marko authored
      dump the data structures.  This was forgotten in r2698.
      54fbfaa8
    • marko's avatar
      branches/zip: Merge revisions 2630:2702 from branches/5.1: · eb8b2948
      marko authored
        ------------------------------------------------------------------------
        r2702 | sunny | 2008-09-30 11:41:56 +0300 (Tue, 30 Sep 2008) | 13 lines
      
        branches/5.1: Since handler::get_auto_increment() doesn't allow us
        to return the cause of failure we have to inform MySQL using the
        sql_print_warning() function to return the cause for autoinc failure.
        Previously we simply printed the error code, this patch prints the
        text string representing the following two error codes:
      
        DB_LOCK_WAIT_TIMEOUT
        DB_DEADLOCK.
      
        Bug#35498 Cannot get table test/table1 auto-inccounter value in ::info
      
        Approved by Marko.
        ------------------------------------------------------------------------
        rb://18
      eb8b2948
  8. 30 Sep, 2008 1 commit
    • vasil's avatar
      branches/zip: · 7548c3d8
      vasil authored
      Change the patch to fix the failing mysql-test index_merge_innodb.
      
      The previous variant is inappropriate because myisam results are different
      (2 instead of 4) and then the index_merge_myisam test fails.
      7548c3d8
  9. 29 Sep, 2008 3 commits
  10. 26 Sep, 2008 4 commits
  11. 25 Sep, 2008 5 commits
    • marko's avatar
      branches/zip: Non-functional change: · f74acc25
      marko authored
      page_zip_copy_recs(): Rename from page_zip_copy().
      Update the function comment.
      f74acc25
    • marko's avatar
    • marko's avatar
      14d5f725
    • marko's avatar
      branches/zip: page_zip_copy(): Skip PAGE_MAX_TRX_ID, because · fdfdf385
      marko authored
      page_copy_rec_list_end(), page_copy_rec_list_start() and friends do
      not copy it either.
      fdfdf385
    • marko's avatar
      branches/zip: page_zip_copy(): Copy only those B-tree page header · 731ead1d
      marko authored
      fields that are related to the records stored in the page.
      
      page_zip_copy() is a fall-back method in certain B-tree operations
      (tree compression, splitting or merging nodes).  The contents of a
      page may fit in the compressed page frame when it has been modified in
      a certain sequence, but not when the page is recompressed.  Sometimes,
      copying all or part of the records to an empty page could fail because
      of compression overflow.  In such cases, we copy the compressed and
      uncompressed pages bit for bit and delete any unwanted records from
      the copy.  (Deletion is guaranteed to succeed.)  The method
      page_zip_copy() is invoked very rarely.
      
      In one case, page_zip_copy() was called in btr_lift_page_up() to move
      the records to the root page of the B-tree.  Because page_zip_copy()
      copied all B-tree page header fields, it overwrote the file segment
      header fields PAGE_BTR_SEG_LEAF and PAGE_BTR_SEG_TOP.  This is the
      probable cause of the corruption that was reported as Mantis issue #63
      and others.
      731ead1d
  12. 24 Sep, 2008 2 commits