An error occurred fetching the project authors.
  1. 26 May, 2005 1 commit
  2. 25 May, 2005 1 commit
    • unknown's avatar
      Fix that we can read tables with the 'older' decimal format used in 5.0.3 & 5.0.4 · 1834f889
      unknown authored
      We will however give a warning when opening such a table that users should use ALTER TABLE ... FORCE to fix
      the table. In future release we will fix that REPAIR TABLE will be able to handle this case
      
      
      sql/sql_lex.h:
        Support for ALTER TABLE ... FORCE
      sql/sql_table.cc:
        CHECK TABLE now gives a note if table->s->crashed was set
      sql/sql_yacc.yy:
        Support for ALTER TABLE ... FORCE
      sql/table.cc:
        
        Fix that we can read tables with the 'older' decimal format used in 5.0.3 & 5.0.4
        (Now we store display length in the .frm table while we previously stored precision)
      sql/table.h:
        Store in TABLE_SHARE version number of MySQL where table was created (or checked)
      1834f889
  3. 18 May, 2005 1 commit
    • unknown's avatar
      Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE · 0461b482
      unknown authored
      After review version.
      Added a condition for MERGE tables. These do not have unique
      indexes. But every key could be a unique key on the underlying
      MyISAM table. So get the maximum key length for MERGE tables
      instead of the maximum unique key length. This is used for
      buffer allocation in write_record().
      
      
      mysql-test/r/merge.result:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        The test result.
      mysql-test/t/merge.test:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        The test case does not in all cases show the problem
        without the bugfix. The improper memory allocation
        might get through undetected in many cases.
      sql/ha_myisammrg.h:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Set a table_flag for the MERGE engine telling that any index
        might be unique without being specified as such.
      sql/handler.h:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Added a new table_flag telling that any index
        might be unique without being specified as such.
      sql/sql_insert.cc:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Changed the freeing of the memory to be symmetric to its
        allocation (my_safe_alloc -> my_safe_afree).
        This is not directly related to the bug.
      sql/table.cc:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Added a condition for MERGE tables. These do not have unique
        indexes. But every key could be a unique key on the underlying
        MyISAM table. So get the maximum key length for MERGE tables
        instead of the maximum unique key length. This is used for
        buffer allocation in write_record().
      0461b482
  4. 10 May, 2005 1 commit
    • unknown's avatar
      Many files: · e02416c5
      unknown authored
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      view.test:
        Added test case for bug #8528.
      view.result:
        Added test case for bug #8528. Fixed other test cases.
      
      
      mysql-test/r/view.result:
        Added test case for bug #8528. Fixed other test cases.
      mysql-test/t/view.test:
        Added test case for bug #8528.
      sql/sql_base.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_delete.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_insert.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_parse.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_prepare.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_select.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_update.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_view.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/table.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/table.h:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      e02416c5
  5. 07 May, 2005 1 commit
  6. 12 Apr, 2005 1 commit
  7. 02 Apr, 2005 1 commit
    • unknown's avatar
      - stackoverflow check added for view of view processing · a50bf2f0
      unknown authored
      - fixed bug in join view processing
      - postreview fixes (BUG#9398 & BUG#8703)
      
      
      sql/sql_base.cc:
        used original TABLE object to get correct name of table and db
      sql/sql_view.cc:
        fixed bug of assigning select_lex for join view
      sql/table.cc:
        comment fixed
        stack overflow check added
        new method for underlying base table finding
      sql/table.h:
        comment fixed
        new method for underlying base table finding
      a50bf2f0
  8. 31 Mar, 2005 1 commit
    • unknown's avatar
      Fixes for bugs reported by Stefano Di Paola (stefano.dipaola@wisec.it) · 896e6e56
      unknown authored
      Originally contained in 2005/03/03 19:51:29+01:00 serg@serg.mylan;
      contained in MySQL 4.1.10a;
      re-committed for archival purposes.
      
      
      include/my_global.h:
        O_NOFOLLOW
      isam/create.c:
        create table files with O_EXCL|O_NOFOLLOW
      merge/mrg_create.c:
        create table files with O_EXCL|O_NOFOLLOW
      myisam/mi_create.c:
        create files of temporary tables with O_EXCL|O_NOFOLLOW
      myisammrg/myrg_create.c:
        create table files with O_EXCL|O_NOFOLLOW
      mysys/mf_tempfile.c:
        create temporary files with O_EXCL|O_NOFOLLOW
      sql/ha_myisam.cc:
        let mi_create know if the table is TEMPORARY
      sql/mysql_priv.h:
        --allow_suspicious_udfs
      sql/mysqld.cc:
        --allow_suspicious_udfs
      sql/share/english/errmsg.txt:
        typo
      sql/sql_udf.cc:
        --allow_suspicious_udfs
        don't allow xxx() udf without any of xxx_init/deinit/add/reset
        check paths when loading from mysql.func
      sql/table.cc:
        create frm of temporary table with O_EXCL|O_NOFOLLOW
      896e6e56
  9. 22 Mar, 2005 2 commits
    • unknown's avatar
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if · 8fc710ce
      unknown authored
      the row type is dynamic (For 4.1 tables old 'VARCHAR' fields are converted to
      true VARCHAR in the next ALTER TABLE)
            
      This ensures that one can use MySQL 5.0 privilege tables with MySQL 4.1.
      
      (Fix imported from main 5.0 tree to 5.0.3 build tree.)
      
      
      mysql-test/r/information_schema.result:
        Update results (for .frm version number change)
      mysql-test/r/ndb_autodiscover.result:
        Update results (for .frm version number change)
      mysql-test/r/ps_1general.result:
        Update results (for .frm version number change)
      mysql-test/r/show_check.result:
        Update results (for .frm version number change)
      mysql-test/r/view.result:
        Update results (for .frm version number change)
      scripts/fill_func_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_create_system_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/sql_table.cc:
        Only set create_info->varchar if we are using the new VARCHAR field
      scripts/mysql_fix_privilege_tables.sh:
        Fixed bug that made it impossible to run the script from the mysql source dist
      scripts/mysql_fix_privilege_tables.sql:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/table.cc:
        Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if
        the row type is dynamic (For 4.1 tables old 'VARCHAR' fields are converted to
        true VARCHAR in the next ALTER TABLE)
      8fc710ce
    • unknown's avatar
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if... · a99cb51c
      unknown authored
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if the row type is dynamic
      (For 4.1 tables old 'VARCHAR' fields are converted to true VARCHAR in the next ALTER TABLE)
      
      This ensures that one can use MySQL 5.0 privilege tables with MySQL 4.1
      
      
      mysql-test/r/information_schema.result:
        Update results (for .frm version number change)
      mysql-test/r/ndb_autodiscover.result:
        Update results (for .frm version number change)
      mysql-test/r/ps_1general.result:
        Update results (for .frm version number change)
      mysql-test/r/show_check.result:
        Update results (for .frm version number change)
      mysql-test/r/view.result:
        Update results (for .frm version number change)
      scripts/fill_func_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_create_system_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_fix_privilege_tables.sh:
        Fixed bug that made it impossible to run the script from the mysql source dist
      scripts/mysql_fix_privilege_tables.sql:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/sql_table.cc:
        Only set create_info->varchar if we are using the new VARCHAR field
      sql/table.cc:
        Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if the row type is dynamic
        (For 4.1 tables old 'VARCHAR' fields are converted to true VARCHAR in the next ALTER TABLE)
      a99cb51c
  10. 15 Mar, 2005 1 commit
    • unknown's avatar
      Code cleanups during review of pushed code · ef7ebed4
      unknown authored
      sql/mysql_priv.h:
        Added 'const' to some arguments
      sql/sp_head.cc:
        Added comments
        code cleanup
        acceess -> access
      sql/sql_acl.cc:
        Simply code by making check_routine_level_acl() available also in embedded server
      sql/sql_acl.h:
        Added 'const' to some arguments
      sql/sql_parse.cc:
        Added 'const' to some arguments
        Fixed the check_rounte_level_acl() is always called
        (old code didn't properly check access privilges if grant_option was not set)
      sql/sql_show.cc:
        Simplify usage of get_field()
        Now we can always call check_some_routine_access()
      sql/sql_udf.cc:
        Don't give warnings for suspicios UDF's if --log-warnings isn't given
      sql/table.cc:
        Simplify usage of get_field()
      ef7ebed4
  11. 03 Mar, 2005 1 commit
    • unknown's avatar
      Fixes for bugs reported by Stefano Di Paola (stefano.dipaola@wisec.it) · 8104faa0
      unknown authored
      include/my_global.h:
        O_NOFOLLOW
      isam/create.c:
        create table files with O_EXCL|O_NOFOLLOW
      merge/mrg_create.c:
        create table files with O_EXCL|O_NOFOLLOW
      myisam/mi_create.c:
        create files of temporary tables with O_EXCL|O_NOFOLLOW
      myisammrg/myrg_create.c:
        create table files with O_EXCL|O_NOFOLLOW
      mysys/mf_tempfile.c:
        create temporary files with O_EXCL|O_NOFOLLOW
      sql/ha_myisam.cc:
        let mi_create know if the table is TEMPORARY
      sql/mysql_priv.h:
        --allow_suspicious_udfs
      sql/mysqld.cc:
        --allow_suspicious_udfs
      sql/share/english/errmsg.txt:
        typo
      sql/sql_udf.cc:
        --allow_suspicious_udfs
        don't allow xxx() udf without any of xxx_init/deinit/add/reset
        check paths when loading from mysql.func
      sql/table.cc:
        create frm of temporary table with O_EXCL|O_NOFOLLOW
      8104faa0
  12. 26 Feb, 2005 1 commit
    • unknown's avatar
      Fixes while during review of last pull · 25e03cdf
      unknown authored
      Temporary patch to remove some warnings
      
      
      sql/item.cc:
        Trivial optimization
      sql/protocol.cc:
        Fixed spelling error
      sql/sql_parse.cc:
        Fix to not get warnings during inital temp open (should be deleted after Dimitri's next push)
        Style fixes
      sql/table.cc:
        Ensure that cleanup is done, even if we get an error
      25e03cdf
  13. 23 Feb, 2005 1 commit
    • unknown's avatar
      Post review changes · b1b896cf
      unknown authored
      sql/table.cc:
        added comments
        small optimisation
        fixed bug: in case of view based on several views, set_uncestor called only for first
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      b1b896cf
  14. 15 Feb, 2005 1 commit
  15. 11 Feb, 2005 3 commits
    • unknown's avatar
      select.result: · aa3727d7
      unknown authored
        After revision of the fix for bug #7520.
      table.cc:
        Revised the fix for bug #7520.
        Made it compliant with 5.0 code where the bug does not exist.
      
      
      sql/table.cc:
        Revised the fix for bug #7520.
        Made it compliant with 5.0 code where the bug does not exist.
      mysql-test/r/select.result:
        After revision of the fix for bug #7520.
      aa3727d7
    • unknown's avatar
      After merge fix. · 58de6bb9
      unknown authored
      58de6bb9
    • unknown's avatar
      select.result, select.test: · 95409456
      unknown authored
        Added a test case for bug #7520.
      table.cc:
        Fixed bug #7520.
        The bug was caused by a wrong calculation of the field max_key_length for
        a TABLE structure when there was an index on a blob field.
      
      
      sql/table.cc:
        Fixed bug #7520.
        The bug was caused by a wrong calculation of the field max_key_length for
        a TABLE structure when there was an index on a blob field.
      mysql-test/t/select.test:
        Added a test case for bug #7520.
      mysql-test/r/select.result:
        Added a test case for bug #7520.
      95409456
  16. 10 Feb, 2005 1 commit
    • unknown's avatar
      Better emulation correct SELECT tree for fields expressions of merging view... · 615616b7
      unknown authored
      Better emulation correct SELECT tree for fields expressions of merging view during name resolving (BUG#6394)
      
      
      mysql-test/r/view.result:
        added test with subquery in the FROM clause
      mysql-test/t/view.test:
        added test with subquery in the FROM clause
      sql/table.cc:
        use SELECT in which view is merging as main SELECT for nameresolving to make correct support for subqueries in the view.
      615616b7
  17. 31 Jan, 2005 1 commit
  18. 26 Jan, 2005 1 commit
    • unknown's avatar
      Fixes for windows compilation bugs · 86016aeb
      unknown authored
      (After review of cs georg:1.1800 by Monty)
      
      
      VC++Files/libmysqld/libmysqld.dsp:
        removed ha_isammrg.cpp (doesn't exist anymore)
      VC++Files/mysqldemb/mysqldemb.dsp:
        removed ha_isammrg.cpp (doesn't exist anymore)
      extra/comp_err.c:
        renamed DATADIR to DATADIRECTORY (DATADIR is a windows internal
        enumeration type)
      innobase/ut/ut0ut.c:
        gettimeofday is not available under Windows. Added conditional define
        which uses GetLocalTime for windows
      libmysql/libmysql.c:
        fixed prototype for setup_one_fetch_function which differed from
        function declaration.
        Fixed not supported unsigned __int64 to double conversion
      sql/field.h:
        fixed typecast error (windows)
      sql/item_sum.cc:
        fixed typecast errors (windows)
      sql/key.cc:
        fixed typecast errors (windows)
      sql/opt_range.cc:
        fixed not supported unsigned __int64 to double conversion
      sql/sql_acl.cc:
        fixed typecast errors (windows)
      sql/table.cc:
        fixed typecast errors (windows)
      86016aeb
  19. 24 Jan, 2005 1 commit
  20. 18 Jan, 2005 1 commit
  21. 17 Jan, 2005 1 commit
  22. 13 Jan, 2005 1 commit
    • unknown's avatar
      Fix accesses to uninitialized memory (found by valgrind) · 90b9065d
      unknown authored
      mysys/my_alloc.c:
        Added comment for free_root
      sql/filesort.cc:
        Removed valgrind warning
      sql/sql_select.cc:
        Remove not needed my_casedn_str() for internal files
        (Old code actually didn't do any god as it was accessing not used memory)
      sql/sql_view.cc:
        Removed access to uninitialized memory
      sql/table.cc:
        Cleanup of error handling
      90b9065d
  23. 12 Jan, 2005 1 commit
    • unknown's avatar
      Fixed memory reference errors found by valgrind · 24a02757
      unknown authored
      sql/ha_federated.cc:
        Change mode to -rw-rw-r--
      myisam/mi_create.c:
        Ensure that all referenced memory is reset
      mysql-test/r/type_timestamp.result:
        More tests
      mysql-test/t/func_compress.test:
        Added comment
      mysql-test/t/type_timestamp.test:
        More tests
      sql/field.h:
        Count number of varchars in table
      sql/item_cmpfunc.cc:
        Safety fix (to avoid warning from valgrind)
      sql/opt_range.cc:
        Simple optimzation
      sql/sql_acl.cc:
        Safety fix (to avoid warning from valgrind)
      sql/sql_parse.cc:
        Safety fix for prepared statements
      sql/sql_show.cc:
        Move variable declarations first in function
        Remove hidden variable (it)
        Remove accessing freed memory (table_list->table_name)
      sql/sql_update.cc:
        Compare records with varchars correctly
      sql/table.cc:
        Safety fix when running with purify/valgrind
        Fix wrong memory reference in case of errors
      sql/table.h:
        Added counting of varchar fields
      strings/ctype-mb.c:
        Fill max_str properly
      24a02757
  24. 06 Jan, 2005 1 commit
    • unknown's avatar
      First stage of table definition cache · acf76e3b
      unknown authored
      Split TABLE to TABLE and TABLE_SHARE (TABLE_SHARE is still allocated as part of table, will be fixed soon)
      Created Field::make_field() and made Field_num::make_field() to call this
      Added 'TABLE_SHARE->db' that points to database name; Changed all usage of table_cache_key as database name to use this instead
      Changed field->table_name to point to pointer to alias. This allows us to change alias for a table by just updating one pointer.
      Renamed TABLE_SHARE->real_name to table_name
      Renamed TABLE->table_name to alias
      Renamed TABLE_LIST->real_name to table_name
      
      
      include/myisam.h:
        Added const before names
      mysql-test/r/group_min_max.result:
        Make results repeatable
      mysql-test/t/group_min_max.test:
        Make results repeatable
      sql/field.cc:
        Created Field::make_field() and made Field_num::make_field() to call this
        Use TABLE_SHARE
        Use sql_strmake() instead of sql_memdup() to simplify code
      sql/field.h:
        Changed table_name to be pointer to table_name. This allows us to change alias for all fields by just changing one pointer.
        Use TABLE_SHARE
      sql/field_conv.cc:
        Use TABLE_SHARE
      sql/filesort.cc:
        Use TABLE_SHARE
      sql/ha_berkeley.cc:
        Use TABLE_SHARE
      sql/ha_heap.cc:
        Use TABLE_SHARE
      sql/ha_innodb.cc:
        Use TABLE_SHARE
      sql/ha_myisam.cc:
        Use TABLE_SHARE
      sql/ha_myisammrg.cc:
        Use TABLE_SHARE
        Change some pointer handling to use const char*
      sql/ha_ndbcluster.cc:
        Use TABLE_SHARE
      sql/handler.cc:
        Use TABLE_SHARE
      sql/item.cc:
        Use TABLE_SHARE
      sql/item_func.cc:
        Use TABLE_SHARE
      sql/item_subselect.cc:
        Use TABLE_SHARE
      sql/item_sum.cc:
        Use TABLE_SHARE
      sql/key.cc:
        Use TABLE_SHARE
      sql/lock.cc:
        Use TABLE_SHARE
      sql/log_event.cc:
        real_name -> table_name
      sql/mysql_priv.h:
        Use TABLE_SHARE
      sql/opt_range.cc:
        Use TABLE_SHARE
      sql/opt_sum.cc:
        Use TABLE_SHARE
      sql/records.cc:
        Use TABLE_SHARE
      sql/repl_failsafe.cc:
        real_name -> table_name
      sql/slave.cc:
        Use TABLE_SHARE
      sql/sp.cc:
        Use TABLE_SHARE
      sql/sp_head.cc:
        real_name -> table_name
      sql/sql_acl.cc:
        Use TABLE_SHARE
        removed unnecessary assert
        fixed indentation
        changed some char * -> const char*
      sql/sql_acl.h:
        changed some char* -> const char*
      sql/sql_base.cc:
        Use TABLE_SHARE
      sql/sql_cache.cc:
        Use TABLE_SHARE
      sql/sql_class.cc:
        Use TABLE_SHARE
      sql/sql_db.cc:
        real_name -> table_name
      sql/sql_delete.cc:
        Use TABLE_SHARE
      sql/sql_derived.cc:
        Use TABLE_SHARE
      sql/sql_handler.cc:
        Use TABLE_SHARE
      sql/sql_help.cc:
        Use TABLE_SHARE
      sql/sql_insert.cc:
        Use TABLE_SHARE
      sql/sql_load.cc:
        Use TABLE_SHARE
      sql/sql_parse.cc:
        Use TABLE_SHARE
      sql/sql_rename.cc:
        real_name -> table_name
      sql/sql_select.cc:
        Use TABLE_SHARE
        table->blob_fields now points to field offsets, not fields
        tmp_table->table_name now points to alias name
      sql/sql_show.cc:
        Use TABLE_SHARE
      sql/sql_table.cc:
        Use TABLE_SHARE
      sql/sql_test.cc:
        Use TABLE_SHARE
      sql/sql_trigger.cc:
        Use TABLE_SHARE
      sql/sql_udf.cc:
        Use TABLE_SHARE
      sql/sql_union.cc:
        real_name -> table_name
      sql/sql_update.cc:
        Use TABLE_SHARE
      sql/sql_view.cc:
        Use TABLE_SHARE
      sql/table.cc:
        Split TABLE to TABLE and TABLE_SHARE
        Changed blob_field to be field offsets instead of pointer to fields
        Only initialize table->s->default_values with default record (not all table->record[#])
        Some indentation changes
      sql/table.h:
        Split TABLE to TABLE and TABLE_SHARE
      sql/tztime.cc:
        real_name -> table_name
      sql/unireg.cc:
        Use TABLE_SHARE
      sql/unireg.h:
        Use TABLE_SHARE
      acf76e3b
  25. 05 Jan, 2005 1 commit
    • unknown's avatar
      fixed views with PS protocol · 47dc78e6
      unknown authored
      mysql-test/r/view.result:
        query cache part moved to separate test
      mysql-test/t/view.test:
        query cache part moved to separate test
      sql/item_func.cc:
        fixed for safety
      sql/sql_base.cc:
        do not use real table call with view
        fixed wrapping * substitured items
        fixed fix_fields call parameter (refference)
      sql/sql_yacc.yy:
        added initialisation of SELECT in commands which can use subqueries
      sql/table.cc:
        fised fix_fields call parameter
      sql/table.h:
        new view specific method
      47dc78e6
  26. 04 Jan, 2005 1 commit
    • unknown's avatar
      fixed bugs in view code with prepared statemnts · 34f313ee
      unknown authored
      sql/sql_acl.cc:
        block checking view underlying tables
      sql/sql_base.cc:
        item registration fixed
        fixed non registred item resolving
        fixed result of outo-merge
        fixed creation reference if alias used
      sql/sql_insert.cc:
        layout fixed
        removed unused variable
      sql/sql_parse.cc:
        block checking view underlying tables
      sql/sql_prepare.cc:
        make preparation check same as usual check
      sql/sql_update.cc:
        made want_privilege assignment simplier
        block checking view underlying tables
      sql/sql_view.cc:
        belong_to_view assignmebt moved after privileges check
      sql/table.cc:
        check option fix field added
        arena management added
      34f313ee
  27. 03 Jan, 2005 1 commit
    • unknown's avatar
      Remove clear_insert_values() because it was far from trivial to handle the cleanup in all cases · e055be66
      unknown authored
      (Old code failed for INSERT ... ON DUPLICATE with prepared statements) 
      Instead, always reset table->insert_values on open.
      
      
      mysql-test/t/trigger.test:
        Fix test for --ps-protocol
      sql/sql_base.cc:
        Clear insert_values on open_table
      sql/sql_insert.cc:
        Remove clear_insert_values()
      sql/sql_parse.cc:
        Remove clear_insert_values()
      sql/sql_prepare.cc:
        Remove clear_insert_values()
      sql/table.cc:
        Remove clear_insert_values()
      sql/table.h:
        Remove clear_insert_values()
      e055be66
  28. 31 Dec, 2004 1 commit
    • unknown's avatar
      Fix max_key_length and max_unique_length to take into account varchar and null extra lengths · 7ea744f7
      unknown authored
      This fixes a bug found by bdb.test
      Fixes a portability issue with bdb tables
      
      
      mysql-test/include/varchar.inc:
        Fix test to be reproducable
        (Either key v or v_2 could be used here)
      mysql-test/r/bdb.result:
        Fix test to be reproducable
        (Either key v or v_2 could be used here)
      mysql-test/r/myisam.result:
        Fix test to be reproducable
        (Either key v or v_2 could be used here)
      sql/table.cc:
        Fix max_key_length and max_unique_length to take into account varchar and null extra lengths
        This fixes a bug found by bdb.test
      7ea744f7
  29. 30 Dec, 2004 1 commit
    • unknown's avatar
      After merge fixes · 2e8d13c7
      unknown authored
      config/ac-macros/character_sets.m4:
        Added latin1_spanish_ci
      dbug/dbug_analyze.c:
        Remove compiler warnings
      include/my_handler.h:
        Reorder structure arguments to be more optimal
      innobase/dict/dict0load.c:
        Fixed wrong define tag (for MySQL 5.0)
      innobase/fil/fil0fil.c:
        Fixed compiler warning
      innobase/os/os0file.c:
        Fixed compiler warning
      myisam/ft_boolean_search.c:
        Fixed compiler warning
      myisam/ft_static.c:
        Update to use new HA_KEYSEG structure
      myisam/mi_open.c:
        Simple optimization
      myisammrg/myrg_static.c:
        Removed compiler warning
      mysql-test/r/grant.result:
        Update results after merge
      mysql-test/r/index_merge.result:
        Update results after merge
      mysql-test/r/information_schema_inno.result:
        Add missing drop table
      mysql-test/r/lowercase_table.result:
        safety fix
      mysql-test/r/multi_update.result:
        safety fix
      mysql-test/r/ps_1general.result:
        safety fix
      mysql-test/r/ps_2myisam.result:
        Update results after merge
        (set is not anymore of binary type)
      mysql-test/r/ps_3innodb.result:
        Update results after merge
      mysql-test/r/ps_4heap.result:
        Update results after merge
      mysql-test/r/ps_5merge.result:
        Update results after merge
      mysql-test/r/ps_6bdb.result:
        Update results after merge
      mysql-test/r/show_check.result:
        Update results after merge
      mysql-test/r/subselect.result:
        Update results after merge
        (added missing quotes)
      mysql-test/r/timezone2.result:
        Update results after merge
      mysql-test/r/view.result:
        Update results after merge
        (note that INSERT IGNORE will work again after next merge from 4.1)
      mysql-test/t/derived.test:
        Removed empty line
      mysql-test/t/grant.test:
        Update results after merge
      mysql-test/t/information_schema_inno.test:
        added missing drop table
      mysql-test/t/lowercase_table.test:
        safety fix
      mysql-test/t/multi_update.test:
        safety fix
      mysql-test/t/ps_1general.test:
        safety fix
      mysql-test/t/view.test:
        update error codes after merge
      ndb/src/mgmsrv/main.cpp:
        after merge fix
      ndb/tools/ndb_test_platform.cpp:
        removed compiler warnings
      regex/main.c:
        remove compiler warnings
      sql/field.cc:
        Remove compiler warning
      sql/gen_lex_hash.cc:
        Added DBUG support
      sql/ha_myisam.cc:
        Removed warning from valgrind
      sql/ha_ndbcluster.cc:
        Remove compiler warning
      sql/item_cmpfunc.cc:
        Better to use val_int() instead of val_real() as we don't want Item_func_nop_all to return different value than the original ref element
      sql/mysqld.cc:
        Remove compiler warning
      sql/sql_acl.cc:
        More debugging
      sql/sql_lex.cc:
        Remove unnecessary 'else'
      sql/sql_parse.cc:
        After merge fixes
        Simplify reset of thd->server_status for SQLCOM_CALL
      sql/sql_prepare.cc:
        After merge fixes
        Removed possible core dump in mysql_stmt_fetch()
      sql/sql_update.cc:
        After merge fixes (together with Sanja)
      strings/ctype-czech.c:
        Remove compiler warning
      strings/ctype-ucs2.c:
        Remove compiler warning
      strings/ctype-win1250ch.c:
        Remove compiler warning
      strings/xml.c:
        Remove compiler warning
      tests/client_test.c:
        Fix test to work with 5.0
      vio/test-sslserver.c:
        Portability fix
      2e8d13c7
  30. 23 Dec, 2004 1 commit
    • unknown's avatar
      WL#1895 - Print message to error log in case of detected MyISAM corruption · bec3feaa
      unknown authored
      Changed my_error() to print error messages, which come from
      arbitrary registered ranges of error messages. Messages can
      be unregistered (and should be at end of the program).
      Added registration of handler error messages.
      Added a new mi_print_error() macro and a new 
      mi_report_error() function, which supply error
      messages with a table name.
      Added calls to mi_print_error() or mi_report_error()
      at all places in MyISAM, where table corruption is detected.
      
      
      extra/comp_err.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added prints for ER_ERROR_FIRST and ER_ERROR_LAST.
        Removed print for ER_ERROR_MESSAGES.
      include/errmsg.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added declaration for a new function.
        Added first and last error number defines.
      include/my_base.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added first and last error number defines.
      include/my_sys.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Removed obsolete defines.
        Removed a global variable, which held pointers to the error message arrays.
        Added declarations for new functions.
      include/mysys_err.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Removed an obsolete define.
        Changed two defines to use the new defines.
        Added first and last error number defines.
      libmysql/errmsg.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Replaced global array initialization by proper registration
        and unregistration of client error messages.
      libmysql/libmysql.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added a call for unregistration of client error messages.
      myisam/mi_delete.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
        Added a debugging call to test undefined error numbers in case a special
        debug string is set.
      myisam/mi_extra.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_info.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added the error logging function.
      myisam/mi_key.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_keycache.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_locking.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_open.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/mi_page.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_range.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_rkey.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_search.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_update.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/mi_write.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/myisamdef.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added the declaration of the new error logging function
        and a new macro.
      mysql-test/r/merge.result:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed test results. These come from the changed error reporting
        in openfrm().
      mysql-test/r/repair.result:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed test results. These come from the changed error reporting
        in openfrm().
      mysql-test/t/merge.test:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changederror numbers. These come from the changed error reporting
        in openfrm().
      mysys/errors.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Dropped the assignment of the global errors to the
        dropped global pointer array.
      mysys/my_error.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed my_error() from using a static array of pointers to
        error message arrays to using a linked list of structures
        with pointers to array message arrays.
        Added functions for registering and unregistering error 
        message arrays to the chain.
      sql/derror.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed reading of mysqld error messages to using the new
        registering and unregistering functions.
      sql/handler.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added initialization and deinitialization of handler error messages.
        Included more handler error messages in the mapping to
        mysqld error messages.
      sql/mysqld.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed deinitialization of error messages to proper
        unregistration.
      sql/table.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed error reporting in openfrm() so that error messages from
        handler::ha_open() are reported by handler::print_error(). This
        changed messages from "Can't open 't1.MYI' (errno: 130)" to
        "Incorrect file format 't1'" for example.
      sql/unireg.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed two defines to use the new defines.
      bec3feaa
  31. 22 Dec, 2004 1 commit
  32. 21 Dec, 2004 1 commit
  33. 19 Dec, 2004 1 commit
    • unknown's avatar
      Merge with global tree · 06904103
      unknown authored
      Fixed some found bugs in BIT fields
      Added more test cases for BIT fields and varchar
      
      
      include/my_base.h:
        Merge
        Added HA_BIT_PART for easier test in key.cc
      innobase/os/os0proc.c:
        Fixed typo
      myisam/mi_dbug.c:
        Add printing of BIT types when debugging
      mysql-test/r/show_check.result:
        Set 'Avg_row_length' to # as this value is different between 32 and 64 bit machines
      mysql-test/r/type_bit.result:
        More tests
      mysql-test/r/type_varchar.result:
        More tests
      mysql-test/t/show_check.test:
        Set 'Avg_row_length' to # as this value is different between 32 and 64 bit machines
      mysql-test/t/type_bit.test:
        More tests
      mysql-test/t/type_varchar.test:
        More tests
      sql/field.cc:
        Added Field::val_int_as_str() to get better logging of bit fields
        Merged new_key_field with move_field() to fix some problems with bit fields
        Fixed some bugs with bit fields
      sql/field.h:
        Added Field::val_int_as_str() to get better logging of bit fields
        Merged new_key_field with move_field() to fix some problems with bit fields
        Fixed some bugs with bit fields
      sql/ha_myisam.cc:
        Fixed problem with unintialized memory (not critical)
      sql/key.cc:
        Fix so that 'key_cmp_if_same' works with bit fields.
      sql/opt_range.cc:
        Move declarations first in function
        Nice printing of bit fields in debug log
      sql/sql_prepare.cc:
        Fixed old merge error (not critical)
      sql/sql_select.cc:
        Use new interface to new_key_field
      sql/sql_select.h:
        Use new interface to new_key_fields()
        This fixes a bug with BIT fields where the upper bit of the data was not stored in the key buffer
      sql/structs.h:
        Extend key_part_flag to be able to add HA_BIT_PART to it
      sql/table.cc:
        Mark BIT key parts with HA_BIT_PART to make test in key.cc simpler
      06904103
  34. 17 Dec, 2004 1 commit
  35. 16 Dec, 2004 1 commit
  36. 07 Dec, 2004 1 commit
  37. 06 Dec, 2004 1 commit