An error occurred fetching the project authors.
  1. 14 Dec, 2006 1 commit
    • unknown's avatar
      BUG#24687 func_misc test fails on win64 · 29bcffd7
      unknown authored
       - Use same precision (milliseconds) for all time functions
         used  when calculating time for pthread_cond_timedwait
       - Use 'GetSystemTimeAsFileTime' for both start and curr time
      
      
      include/config-win.h:
        Move all defines for 'pthread_cond_timedwait' to my_pthread.h
      include/my_global.h:
        Move all defines for 'pthread_cond_timedwait' to my_pthread.h
      include/my_pthread.h:
        Redefine "struct timespec" to better suite the needs 
        of 'pthread_cond_timedwait' for windows implementation
        Add windows specific define for set_timespec_nsec
        Move all defines related to pthread_cond_timed wait to same file
        Declare union for reading FILETIME as __int64 with correct alignment
      mysys/my_wincond.c:
        Use 'GetSystemTimeAsFileTime()' both for getting start and current time
        Use new members of "struct timespec"
        Make sure the calculated timeout value never exceeds the value
        passed to set_timespec/set_timespec_nsec
      server-tools/instance-manager/guardian.cc:
        Use set_timespec macro
      server-tools/instance-manager/instance.cc:
        Use set_timespec macro
      29bcffd7
  2. 21 Nov, 2006 2 commits
    • unknown's avatar
      Polishing: · 7c35c3d5
      unknown authored
        - change some return types from int to bool;
        - add [ERROR] tag to log_error() output;
        - add [INFO] tag to log_info() output;
        - change log messages to be more consistent.
      
      
      server-tools/instance-manager/IMService.cpp:
        Log polishing.
      server-tools/instance-manager/commands.cc:
        Log polishing.
      server-tools/instance-manager/commands.h:
        Eliminate warnings.
      server-tools/instance-manager/instance.cc:
        Log polishing.
      server-tools/instance-manager/instance_map.cc:
        Log polishing.
      server-tools/instance-manager/instance_options.cc:
        1) Log polishing.
        2) Change int-return type to bool.
      server-tools/instance-manager/instance_options.h:
        Change int-return type to bool.
      server-tools/instance-manager/listener.cc:
        Log polishing.
      server-tools/instance-manager/log.cc:
        Log polishing.
      server-tools/instance-manager/log.h:
        Log polishing.
      server-tools/instance-manager/manager.cc:
        Log polishing.
      server-tools/instance-manager/mysql_connection.cc:
        Log polishing.
      server-tools/instance-manager/mysql_connection.h:
        Change int-return type to bool.
      server-tools/instance-manager/mysqlmanager.cc:
        Log polishing.
      server-tools/instance-manager/priv.cc:
        Log polishing.
      server-tools/instance-manager/thread_registry.cc:
        1. Print pthread_t as (unsigned long), not as (signed long)
        to avoid negative identifiers in output.
        2. Print thread id after it will be initialized, not before.
      server-tools/instance-manager/user_map.cc:
        Log polishing.
      7c35c3d5
    • unknown's avatar
      Polishing: · cbfff730
      unknown authored
      1) add support for joinable threads to Thread class;
      2) move checking of thread model to Manager from mysqlmanager.cc,
      because it is needed only for IM-main process.
      
      
      server-tools/instance-manager/instance.cc:
        Use Manager::is_linux_threads() instead of global variable.
      server-tools/instance-manager/listener.cc:
        Use Thread::start(DETACHED) instead of Thread::start_detached().
      server-tools/instance-manager/manager.cc:
        1. Use Thread::start(DETACHED) instead of Thread::start_detached();
        2. Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/manager.h:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/mysqlmanager.cc:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/priv.cc:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/priv.h:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/thread_registry.cc:
        Add support of joinable threads to Thread class.
      server-tools/instance-manager/thread_registry.h:
        Add support of joinable threads to Thread class.
      cbfff730
  3. 17 Nov, 2006 3 commits
    • unknown's avatar
      Port cleanups, trivial refactoring and code rearrangements from · c95482d4
      unknown authored
      Alik's patch for BUG#22306: STOP INSTANCE can not be applied for 
      instances in Crashed, Failed and Abandoned" to ease review process.
      Evaluate global variable linuxthreads before starting threads to avoid
      a race.
      
      
      server-tools/instance-manager/buffer.cc:
        Fix spelling.
      server-tools/instance-manager/command.h:
        Fix spelling.
      server-tools/instance-manager/commands.cc:
        Fix spelling.
      server-tools/instance-manager/commands.h:
        Fix spelling, tidy up.
      server-tools/instance-manager/guardian.cc:
        Cleanup logging, options.get_shutdown_delay() is a method, tidy up.
      server-tools/instance-manager/instance.cc:
        Rearrange methods to be the same as in Alik's patch, fix spelling errors,
        clean up logging texts, port comments from Alik's patch, 
        implement some basic renames from his patch.
        No real changes.
      server-tools/instance-manager/instance.h:
        Tidy up, renames.
      server-tools/instance-manager/instance_map.cc:
        Fix spellings, port some refactoring from Alik's patch.
      server-tools/instance-manager/instance_map.h:
        Cleanup.
      server-tools/instance-manager/instance_options.cc:
        Cleanup. Implement Instance_options::get_shutdown_delay() and
        Instance_options::get_mysqld_port().
      server-tools/instance-manager/instance_options.h:
        Cleanup.
      server-tools/instance-manager/listener.cc:
        Cleanup.
      server-tools/instance-manager/log.cc:
        Fix spelling.
      server-tools/instance-manager/manager.cc:
        Cleanup.
      server-tools/instance-manager/manager.h:
        Add getters for Manager members.
      server-tools/instance-manager/mysqlmanager.cc:
        Evaluate linuxthreads before starting threads to avoid a race.
      server-tools/instance-manager/parse_output.cc:
        Fix spelling.
      server-tools/instance-manager/priv.cc:
        Cleanup.
      server-tools/instance-manager/priv.h:
        Cleanup.
      server-tools/instance-manager/user_management_commands.cc:
        Fix spelling.
      server-tools/instance-manager/user_management_commands.h:
        Fix spelling.
      server-tools/instance-manager/user_map.cc:
        Fix spelling.
      c95482d4
    • unknown's avatar
      Polishing: generate more warnings and make code warnings-free. · 3bb26768
      unknown authored
      server-tools/instance-manager/Makefile.am:
        Generate more warnings.
      server-tools/instance-manager/commands.cc:
        Eliminate warnings.
      server-tools/instance-manager/commands.h:
        Eliminate warnings.
      server-tools/instance-manager/instance.cc:
        Eliminate warnings.
      server-tools/instance-manager/mysql_connection.cc:
        Eliminate warnings.
      server-tools/instance-manager/parse.cc:
        Eliminate warnings.
      server-tools/instance-manager/user_map.cc:
        Eliminate warnings.
      server-tools/instance-manager/user_map.h:
        Eliminate warnings.
      3bb26768
    • unknown's avatar
      Replace the approach using Foo_thread_args + Foo_thread and manually · a163ae30
      unknown authored
      spawned threads with a reusable class Thread.
      
      This is the second idea implemented in the Alik's patch for
      BUG#22306: STOP INSTANCE can not be applied for instances in Crashed,
      Failed and Abandoned.
      Commiting separately to ease review process. 
      
      
      server-tools/instance-manager/commands.cc:
        Remove an unused header.
      server-tools/instance-manager/guardian.cc:
        Use Thread framework instead of manually spawning the Guardian thread.
        Tidy up.
      server-tools/instance-manager/guardian.h:
        Use Thread framework instead of manually spawning the Guardian thread.
      server-tools/instance-manager/instance.cc:
        Use Thread framework instead of manually spawning the instance
        monitoring thread.
      server-tools/instance-manager/listener.cc:
        Use Thread framework instead of manually spawning the 
        mysql connection thread.
      server-tools/instance-manager/listener.h:
        Use Thread framework instead of manually spawning the 
        mysql connection thread.
        Rename Listener_thread to Listener for brevity.
      server-tools/instance-manager/manager.cc:
        Change references to pointers, as per the coding style.
        Use Thread framework instead of manually spawning threads.
      server-tools/instance-manager/mysql_connection.cc:
        Get rid of Mysql_connection_thread_args. Use class Thread framework
        instead. Rename Mysql_connection_thread to Mysql_connection for brevity.
      server-tools/instance-manager/mysql_connection.h:
        Get rid of Mysql_connection_thread_args. Use class Thread framework
        instead. Rename Mysql_connection_thread to Mysql_connection for brevity.
      server-tools/instance-manager/priv.cc:
        Move set_stacksize_and_create_thread to thread_registry.cc and make it
        static: it is not used anywhere else now.
      server-tools/instance-manager/priv.h:
        No public set_stacksize_n_create_thread
      server-tools/instance-manager/thread_registry.cc:
        Implement a base Thread class to be used for all Instance Manager
        threads.
      server-tools/instance-manager/thread_registry.h:
        Implement a base Thread class to be used for all Instance Manager
        threads.
      a163ae30
  4. 01 Nov, 2006 1 commit
    • unknown's avatar
      Fixed a lot of compiler warnings (Mainly in mysqld and instance manager) · 07d8be45
      unknown authored
      Fixed some possible fatal wrong arguments to printf() style functions
      Initialized some not initialized variables
      Fixed bug in stored procedure and continue handlers
      (Fixes Bug#22150)
      
      
      include/mysql/plugin.h:
        Remove compiler warning
      mysql-test/mysql-test-run.pl:
        Ensure that --extern works on a clean tree (when 'var' directory doesn't exists)
      server-tools/instance-manager/commands.cc:
        Fixed possible use of unitialized variable
      server-tools/instance-manager/guardian.cc:
        Fixed wrong arguments to log_info() that could cause crashes
      server-tools/instance-manager/instance.cc:
        Fixed wrong arguments to log_info() and log_error() that could cause crashes
      server-tools/instance-manager/instance_options.cc:
        Fixed wrong arguments to log_error() that could cause crashes
      server-tools/instance-manager/mysql_connection.cc:
        Fixed wrong arguments to log_info()
      server-tools/instance-manager/parse.cc:
        Fixed possible use of unitialized variable
      server-tools/instance-manager/user_map.cc:
        Fixed wrong arguments to log_error() that could cause crashes
      sql/Makefile.am:
        Fix for bison 1.875
        (It write an __attribute__() tag that was causing compiler failures)
      sql/ha_ndbcluster.cc:
        Fixed wrong snprintf() arguments
        Remoed not used variables
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warning (unsigned/signed comparision)
      sql/handler.cc:
        Fixed wrong parameter to hton->binlog_func()
      sql/item_cmpfunc.cc:
        Removed compiler warnings
      sql/item_timefunc.cc:
        Removed compiler warnings
      sql/log.cc:
        fixed wrong argument to snprintf()
      sql/mysqld.cc:
        Removed compiler warnings
        Fixed wrong arguments to printf()
      sql/partition_info.cc:
        Removed compiler warnings
      sql/protocol.cc:
        reset is_fatal_error for stored procedures
        (Fix for Bug#22150)
      sql/sp_head.cc:
        More DBUG information
        Reset is_fatal_error in case of continue handler.
        (Fix for Bug#22150)
      sql/sql_base.cc:
        Removed compiler warnings
      sql/sql_class.h:
        More DBUG information
      sql/sql_insert.cc:
        Removed compiler warnings
        Initialize not initialized variable (fatal bug)
      sql/sql_parse.cc:
        Added DBUG_ASSERT to detect if stored procedure code returns with a wrong state
        Removed compiler warning
      sql/sql_plugin.cc:
        Fied wrong aruguments to printf() (Fatal bug)
      sql/sql_select.cc:
        Initailize not initialized variable.
        Remove compiler warnings
        Fixed wrong argument to printf() (Possible fatal error)
      sql/sql_view.cc:
        Removed compiler warnings
      sql/table.cc:
        Fixed wrong argument to printf() (Possible fatal)
      07d8be45
  5. 24 Oct, 2006 1 commit
    • unknown's avatar
      Fix for BUG#17486: IM: race condition on exit. · aeec4593
      unknown authored
      The problem was that IM stoped guarded instances on shutdown,
      but didn't wait for them to stop.
      
      The fix is to wait for guarded instances to stop before exitting
      from the main thread.
      
      The idea is that Instance-monitoring thread should add itself
      to Thread_registry so that it will be taken into account on shutdown.
      However, Thread_registry should not signal it on shutdown in order to
      not interrupt wait()/waitpid().
      
      
      server-tools/instance-manager/guardian.cc:
        Be more verbose.
      server-tools/instance-manager/instance.cc:
        Register mysqld-monitoring thread in Thread_registry.
      server-tools/instance-manager/instance.h:
        Add reference to Thread_registry.
      server-tools/instance-manager/instance_map.cc:
        Pass Thread_registry reference to Instance.
      server-tools/instance-manager/instance_map.h:
        Add reference to Thread_registry.
      server-tools/instance-manager/listener.cc:
        Be more verbose.
      server-tools/instance-manager/manager.cc:
        Be more verbose.
      server-tools/instance-manager/mysql_connection.cc:
        Eliminate type-conversion warnings.
      server-tools/instance-manager/thread_registry.cc:
        Be more verbose.
      server-tools/instance-manager/thread_registry.h:
        Eliminate copy&paste, make impl-specific constructor private.
      aeec4593
  6. 23 Oct, 2006 1 commit
    • unknown's avatar
      Post-merge fixes. · 66b87280
      unknown authored
      mysql-test/r/sp.result:
        Update results.
      mysql-test/r/view.result:
        Update results.
      server-tools/instance-manager/guardian.cc:
        Post-merge fixes (instance_name is a LEX_STRING).
      server-tools/instance-manager/instance.cc:
        Post-merge fixes (instance_name is a LEX_STRING).
      66b87280
  7. 20 Oct, 2006 1 commit
    • unknown's avatar
      Instance Manager polishing. · 8db4dc3f
      unknown authored
      server-tools/instance-manager/guardian.cc:
        1. Removed unused stop_instances_arg from request_shutdown() and
        stop_instances() methods.
        
        2. Changed log-output statements so that instance name is passed
        correctly (char *, not LEX_STRING)
      server-tools/instance-manager/guardian.h:
        Removed unused stop_instances_arg from request_shutdown() and
        stop_instances() methods.
      server-tools/instance-manager/instance.cc:
        Removed unused stop_instances_arg from request_shutdown() and
        stop_instances() methods.
      server-tools/instance-manager/listener.cc:
        Be more verbose in log.
      server-tools/instance-manager/manager.cc:
        Removed unused stop_instances argument.
      8db4dc3f
  8. 25 Sep, 2006 1 commit
    • unknown's avatar
      Bug #22379 im_daemon_life_cycle.test fails on merge of 5.1 -> 5.1-engines · f91b91cf
      unknown authored
      Remove race situations that occur when removing pidfiles. Primarily each process should remove its own
      pidfile, secondly it should be removed by the process that created it and _only_ if it's
      certain the process is dead. Third, mysql-test-run.pl will remove the pidfile when process has been killed.
      - Set state of an instance to STARTING _before_ calling instance->start()
      - Check that pidfile of instance has been created before changing STARTING => STARTED
      - Only remove the pidfile if IM kills an instance with SIGKILL, otherwise the instance will remove it itself
      
      
      server-tools/instance-manager/guardian.cc:
        If state of an instance is STARTING, chech that the instance pidfile has been created
        before changing state to STARTED
        Set state to STARTING before calling instance->start(), it can take some time
        before it is fully started and during that time it should be in state STARTING
      server-tools/instance-manager/instance.cc:
        Only remove the pid file of instance manager when a SIGKILL has 
        been performed sucessfully
      server-tools/instance-manager/instance_options.cc:
        Check that fscanf returns 1 which is the number of args that should be scanned from
        the pid file
      f91b91cf
  9. 17 Aug, 2006 1 commit
    • unknown's avatar
      A couple of adjustments to the merge to fix the broken build · 55fb3cae
      unknown authored
      instance.cc:
        Removed wrongly placed closing brace
      item_geofunc.cc:
        needed to pass in a TABLE_SHARE* instead of a TABLE*
      
      
      server-tools/instance-manager/instance.cc:
        Removed wrongly placed closing brace
      sql/item_geofunc.cc:
        needed to pass in a TABLE_SHARE* instead of a TABLE*
      55fb3cae
  10. 12 Jul, 2006 1 commit
    • unknown's avatar
      Bug #12673: Instance Manager: allows to stop the instance many times · 812c9cc8
      unknown authored
        The instance manager was not actually checking whether an instance
        was actually running before trying to stop it. Now it checks first.
      
      
      mysql-test/r/im_life_cycle.result:
        Add new results
      mysql-test/t/im_life_cycle.imtest:
        Add new regression test
      server-tools/instance-manager/instance.cc:
        Fix Instance::stop() to report ER_INSTANCE_IS_NOT_STARTED when that is
        the case. Also removed unnecessary goto.
      server-tools/instance-manager/messages.cc:
        Fix messages with missing spaces
      812c9cc8
  11. 19 Jun, 2006 1 commit
  12. 18 May, 2006 1 commit
    • unknown's avatar
      This is an implementation of two WL items: · 8b4fcf6e
      unknown authored
        - WL#3158: IM: Instance configuration extensions;
        - WL#3159: IM: --bootstrap and --start-default-instance modes
      
      The following new statements have been added:
        - CREATE INSTANCE;
        - DROP INSTANCE;
      
      The behaviour of the following statements have been changed:
        - SET;
        - UNSET;
        - FLUSH INSTANCES;
        - SHOW INSTANCES;
        - SHOW INSTANCE OPTIONS;
      
      
      BitKeeper/deleted/.del-im_options_set.imtest~b53d9d60e5684833:
        Delete: mysql-test/t/im_options_set.imtest
      BitKeeper/deleted/.del-im_options_set.result~59278f56be61d921:
        Delete: mysql-test/r/im_options_set.result
      BitKeeper/deleted/.del-im_options_unset.imtest~768eb186b51d0048:
        Delete: mysql-test/t/im_options_unset.imtest
      BitKeeper/deleted/.del-im_options_unset.result~20a4790cd3c70a4f:
        Delete: mysql-test/r/im_options_unset.result
      client/get_password.c:
        Change prototype to avoid casting when using C-strings (char *).
      include/m_string.h:
        Moved LEX_STRING to global header from sql/ to be accessible
        from all components (IM for one).
      include/my_sys.h:
        Added constants for modify_defaults_file().
      include/mysql_com.h:
        Removed duplicated declarations. my_sys.h should be used instead.
      libmysql/get_password.c:
        Change prototype to avoid casting when using C-strings (char *).
      mysql-test/mysql-test-run.pl:
        Added environment variables to be used from tests.
      mysql-test/r/im_daemon_life_cycle.result:
        Column name has been changed in SHOW INSTANCES.
      mysql-test/r/im_life_cycle.result:
        1. Column name has been changed in SHOW INSTANCES.
        2. Removed redundant SHOW INSTANCE STATUS statements.
      mysql-test/r/im_utils.result:
        Updated the result file.
      mysql-test/t/im_daemon_life_cycle-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      mysql-test/t/im_daemon_life_cycle.imtest:
        Get Instance Manager and managed mysqld-instances enough time to start.
      mysql-test/t/im_life_cycle.imtest:
        1. Polishing;
        2. Fixed a test error in 1.1.2.
      mysql-test/t/im_utils.imtest:
        Get Instance Manager and managed mysqld-instances enough time to start.
      mysys/default.c:
        Pass the name of the section to the handler function as well.
      mysys/default_modify.c:
        Added REMOVE_SECTION functionality.
      server-tools/instance-manager/IMService.cpp:
        Polishing: be more verbose.
      server-tools/instance-manager/IMService.h:
        Polishing: added copyright.
      server-tools/instance-manager/Makefile.am:
        Added new files.
      server-tools/instance-manager/WindowsService.cpp:
        Polishing: according to The Coding Style, TRUE/FALSE must be
        used instead of true/false.
      server-tools/instance-manager/WindowsService.h:
        Polishing: added copyright.
      server-tools/instance-manager/command.h:
        Polishing: provide a comment for the main operation of "Command" class.
      server-tools/instance-manager/commands.cc:
        1. Added support for CREATE INSTANCE, DROP INSTANCE statements;
        2. Added "deprecated" column in output of SHOW INSTANCE OPTIONS;
        3. Modified the behaviour of SET/UNSET, FLUSH INSTANCES statements;
      server-tools/instance-manager/commands.h:
        1. Added support for CREATE INSTANCE, DROP INSTANCE statements;
        2. Added "deprecated" column in output of SHOW INSTANCE OPTIONS;
        3. Modified the behaviour of SET/UNSET, FLUSH INSTANCES statements;
      server-tools/instance-manager/guardian.cc:
        Added operations to retrieve state of managed instances.
      server-tools/instance-manager/guardian.h:
        Added operations to retrieve state of managed instances.
      server-tools/instance-manager/instance.cc:
        1. Provided an operation to check validity of instance name.
        2. Added an attribute to distiguish mysqld-instances,
           whose configuration should be kept backward-compatible.
      server-tools/instance-manager/instance.h:
        1. Provided an operation to check validity of instance name.
        2. Added an attribute to distiguish mysqld-instances,
           whose configuration should be kept backward-compatible.
      server-tools/instance-manager/instance_map.cc:
        1. Used the operation to check validity of instance name;
        2. Added operations to manage instances.
      server-tools/instance-manager/instance_map.h:
        Added operations to manage instances.
      server-tools/instance-manager/instance_options.cc:
        Changed Instance_options so that it will be possible to manage
        options on the fly.
      server-tools/instance-manager/instance_options.h:
        Changed Instance_options so that it will be possible to manage
        options on the fly.
      server-tools/instance-manager/listener.cc:
        1. Remove reference to the instance of Options;
        2. Use new Options naming scheme.
      server-tools/instance-manager/listener.h:
        Remove reference to the instance of Options;
      server-tools/instance-manager/log.cc:
        Polishing: use TRUE/FALSE instead of true/false.
      server-tools/instance-manager/manager.cc:
        Added a common for IM operation to work with configuration file.
      server-tools/instance-manager/manager.h:
        Added a common for IM operation to work with configuration file.
      server-tools/instance-manager/messages.cc:
        Added messages for new errors.
      server-tools/instance-manager/mysql_connection.cc:
        1. Move a constant to common place.
        2. Polishing.
      server-tools/instance-manager/mysql_manager_error.h:
        Added new errors.
      server-tools/instance-manager/mysqlmanager.cc:
        1. Use error code from Options::load();
        2. Eliminate type-casting warning on Windows.
      server-tools/instance-manager/options.cc:
        Added support for user-management command-line options.
      server-tools/instance-manager/options.h:
        Added support for user-management command-line options.
      server-tools/instance-manager/parse.cc:
        1. Added support of new statements:
           - CREATE INSTANCE;
           - DROP INSTANCE.
        2. Modified SET/UNSET.
      server-tools/instance-manager/parse.h:
        1. Added support of new statements:
           - CREATE INSTANCE;
           - DROP INSTANCE.
        2. Modified SET/UNSET.
      server-tools/instance-manager/parse_output.cc:
        Sorted out header files.
      server-tools/instance-manager/parse_output.h:
        Sorted out header files.
      server-tools/instance-manager/portability.h:
        1. Added constants for Windows.
        2. Moved system-dependent defines from instance_options.cc.
      server-tools/instance-manager/priv.cc:
        Updated version.
      server-tools/instance-manager/priv.h:
        Added some global constants.
      server-tools/instance-manager/protocol.cc:
        Replaced NAME_WITH_LENGTH by LEX_STRING.
      server-tools/instance-manager/protocol.h:
        Replaced NAME_WITH_LENGTH by LEX_STRING.
      server-tools/instance-manager/thread_registry.cc:
        Polishing: use TRUE/FALSE instead of true/false.
      server-tools/instance-manager/user_map.cc:
        Added support for managing password database.
      server-tools/instance-manager/user_map.h:
        Added support for managing password database.
      sql/sp.cc:
        Replaced LEX_STRING_WITH_INIT by LEX_STRING + struct initialization.
      sql/sp_head.cc:
        Replaced LEX_STRING_WITH_INIT by LEX_STRING + struct initialization.
      sql/spatial.cc:
        Removed LEX_STRING_WITH_INIT.
      sql/spatial.h:
        Removed LEX_STRING_WITH_INIT.
      sql/sql_string.h:
        Moved STRING_WITH_LEN() macro out from sql (to m_string.h).
      sql/sql_trigger.cc:
        Moved STRING_WITH_LEN() macro out from sql (to m_string.h).
      sql/structs.h:
        Removed LEX_STRING_WITH_INIT.
      support-files/mysql.server.sh:
        Instruct Instance Manager to work in mysqld-safe compatible mode
        for backward compatibility.
      mysql-test/r/im_cmd_line.result:
        Added result file.
      mysql-test/r/im_instance_conf.result:
        Added result file.
      mysql-test/r/im_options.result:
        Added result file.
      mysql-test/t/im_cmd_line.imtest:
        IM command-line options test.
      mysql-test/t/im_instance_conf-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      mysql-test/t/im_instance_conf.imtest:
        Added a new test case for checking instance-management.
      mysql-test/t/im_life_cycle-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      mysql-test/t/im_options.imtest:
        Join im_options_set and im_options_unset and add new tests.
      mysql-test/t/im_utils-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      server-tools/instance-manager/exit_codes.h:
        New file for defining exit codes for user-management mode.
      server-tools/instance-manager/user_management_commands.cc:
        User-management commands implementation.
      server-tools/instance-manager/user_management_commands.h:
        User-management command declarations.
      8b4fcf6e
  13. 09 Feb, 2006 1 commit
    • unknown's avatar
      a bunch of IM fixes from the GUI team · d7ddf0e0
      unknown authored
      mysql-test/r/im_life_cycle.result:
        correct result
      mysql-test/t/im_life_cycle.imtest:
        check that wrong command is processed correctly
      server-tools/instance-manager/Makefile.am:
        always look for passwords in /etc/ on unixes
      server-tools/instance-manager/commands.cc:
        fix warning
      server-tools/instance-manager/instance.cc:
        fix monitoring capabilities, when no port was specified
        for an instance
      server-tools/instance-manager/instance_map.cc:
        allow relative paths in --defaults-file option
      server-tools/instance-manager/mysqlmanager.cc:
        fix windows warning
      server-tools/instance-manager/options.cc:
        add vars to allow relative paths in --defaults-file option
      server-tools/instance-manager/options.h:
        add an option
      server-tools/instance-manager/parse.cc:
        check for get_text_id return value
      server-tools/instance-manager/portability.h:
        add _snprintf define, move platfrom-independent
        ifdefs to priv.h
      server-tools/instance-manager/priv.cc:
        increase net timeout. it should be equal to mysqld's
      server-tools/instance-manager/priv.h:
        move platform-independent ifdefs here
      d7ddf0e0
  14. 23 Dec, 2005 1 commit
    • unknown's avatar
      locking issues, · bcc1ecd3
      unknown authored
      test for LONGLONG_MIN in decimal.c
      
      
      myisam/mi_create.c:
        lock THR_LOCK_myisam later
      mysys/thr_alarm.c:
        remove misplaced comment and "safety" if()
      server-tools/instance-manager/instance.cc:
        add unlock
      strings/decimal.c:
        correct the test for LONGLONG_MIN. fix debug sprintf
      bcc1ecd3
  15. 25 Oct, 2005 1 commit
  16. 20 Oct, 2005 1 commit
    • unknown's avatar
      Fix Bug#14107 (IM test failures on QNX) · a5f2355c
      unknown authored
      (v.2 with post-review fixes)
      
      
      server-tools/instance-manager/instance.cc:
        On QNX one cannot use fork() in multithreaded environment. Therefore we should use QNX's spawn()
      a5f2355c
  17. 11 Oct, 2005 1 commit
    • unknown's avatar
      Reviewing new pushed code · 0ce12f70
      unknown authored
      - CHAR() now returns binary string as default
      - CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
      - Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        (Some old systems returns ETIME and it's safer to test for both values
         than to try to write a wrapper for each old system)
      - Fixed new introduced bug in NOT BETWEEN X and X
      - Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      - Use octet2hex() for all conversion of string to hex
      - Simplify and optimize code
      
      
      client/mysqldump.c:
        Simple optimizations of new code
        Indentation fixes
      client/mysqltest.c:
        Removed not needed variable
      include/mysql_com.h:
        Made octec2hex() more usable
      mysql-test/r/ctype_utf8.result:
        CHAR() now returns binary string as default
      mysql-test/r/func_str.result:
        CHAR() now returns binary string as default
      mysql-test/r/range.result:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/r/user_var-binlog.result:
        CHAR() now returns binary string as default
      mysql-test/r/view.result:
        More tests of view rename
      mysql-test/t/ctype_utf8.test:
        CHAR() now returns binary string as default
      mysql-test/t/func_str.test:
        CHAR() now returns binary string as default
      mysql-test/t/range.test:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/t/view.test:
        More tests of view rename
      mysys/mf_keycache.c:
        Indentation changes
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/my_os2cond.c:
        Fix to MySQL coding style
        Optimized functions
      mysys/thr_lock.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/thr_mutex.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/instance.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/thread_registry.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/ha_federated.cc:
        Use octet2hex()
      sql/ha_ndbcluster.cc:
        Removed not used variable
      sql/handler.cc:
        Simplify code
        Use *NONE* instead of 'none' for not existing storage engine
        Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      sql/item.h:
        Remove not needed test for *ref.  (If ref is set, it should never point at 0)
      sql/item_func.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        Simplify code
        More comments
        Require that last argument to find_and_check_access() is given
        (Made code shorter and faster)
      sql/item_strfunc.cc:
        Changed CHAR() to return result in binary collation
        CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
        
        Bar will shortly add the following syntax:
        CHAR(.... USING character_set)
        and ensure that
        CONVERT(CHAR(....) USING utf8) cuts not legal utf8 strings
        Use ocet2hex()
      sql/item_strfunc.h:
        CHAR() now returns a binary string
      sql/log_event.cc:
        Use octet2hex()
        Simplify code
      sql/parse_file.cc:
        Indentation fixes
        Use for() instead of while()
      sql/password.c:
        Make octet2hex() more generally usable by returning pointer to end 0
      sql/slave.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_base.cc:
        Indentation fixes
      sql/sql_insert.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_manager.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_parse.cc:
        Don't check thd->db when checking for function privileges
      sql/sql_prepare.cc:
        Fixed wrong merge
      sql/sql_select.cc:
        Fixed new bug for NOT BETWEEN X and X
      sql/sql_show.cc:
        Removed not used variable
      sql/sql_table.cc:
        Indentation fixed
        Removed DBUG_PRINT that is obvious from context
      sql/sql_view.cc:
        Simplify code
      sql/unireg.cc:
        Use octet2hex()
      0ce12f70
  18. 08 Oct, 2005 1 commit
  19. 23 Sep, 2005 1 commit
    • unknown's avatar
      Some minor fixes revealed as warnings by · ab0d7e2a
      unknown authored
      Intel compiler.
      
      
      client/mysqltest.c:
        Fixed a warning from using reference to a memory area,
        which is outside an object. This is just a minor
        clean-up, not a bug fix.
      server-tools/instance-manager/buffer.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/buffer.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/command.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/command.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/guardian.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/guardian.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_map.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_map.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_options.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_options.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/listener.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/listener.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/mysql_connection.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/mysql_connection.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/options.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/options.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/parse_output.cc:
        Removed unused goto.
      server-tools/instance-manager/thread_registry.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/thread_registry.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/user_map.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/user_map.h:
        Fixed pragma warning for those compilers that do
        not support it.
      sql/field.cc:
        Fixed a warning about overflow.
      sql/item.h:
        Fixed implicit function declaration warning.
      sql/item_sum.cc:
        Fixed implicit function declaration warning.
      ab0d7e2a
  20. 13 Sep, 2005 1 commit
    • unknown's avatar
      fixed the service bits of the IM · c6dfe79b
      unknown authored
      server-tools/instance-manager/IMService.cpp:
        * setting username and password to NULL so that the 
        IM runs at LocalSystem (this should be changed soon)
        * implemented stop service by raising a sigterm
        * implemented start service by loading options and calling manager()
      server-tools/instance-manager/IMService.h:
        changed the sig for Run()
      server-tools/instance-manager/WindowsService.cpp:
        default debugging to false
        changed the sig of RuN()
      server-tools/instance-manager/WindowsService.h:
        change the sig of run()
      server-tools/instance-manager/instance.cc:
        * remove the inclusion of process.h
        * concat all args into a single buffer to pass to CreateProcess
      server-tools/instance-manager/instance_options.cc:
        quoting the binary to handle paths with quotes
      server-tools/instance-manager/listener.cc:
        use a timeval for select so that our select will only run
        for 100 msec before we check to see if we are shutting down
      server-tools/instance-manager/mysqlmanager.cc:
        if we are given the stand alone option, then run the manager as 
        standalone
      server-tools/instance-manager/options.cc:
        Added stand alone command line arg
      server-tools/instance-manager/options.h:
        Added stand alone command line arg
      c6dfe79b
  21. 07 Sep, 2005 1 commit
    • unknown's avatar
      A few changes to fix compiling on Windows · 9f92c88f
      unknown authored
      VC++Files/mysql.sln:
        Added instance manager project
      VC++Files/mysys/mysys.vcproj:
        Added mf_unixpath.c
      scripts/make_win_src_distribution.sh:
        Updated to include server-tools folder (which includes IM)
      server-tools/instance-manager/instance.cc:
        fixed typo
      server-tools/instance-manager/mysqlmanager.vcproj:
        fixed up all the filenames in the IM project
      9f92c88f
  22. 19 Aug, 2005 1 commit
    • unknown's avatar
      Fix for BUG#10957 "stop instance, issued after flush instances causes IM to crash" · 933db613
      unknown authored
      Recommited with post-review fixes
      
      
      server-tools/instance-manager/instance.cc:
        fix behaviour of monitoring routines: they should not  rely on the fact that instance object
        which was used when the instances started exists at stop(). Instead routines should save the
        name of the instance and look for it in the instance_map when needed.
      server-tools/instance-manager/instance.h:
        new functions declared. functions, which were converted to static removed from the class.
      server-tools/instance-manager/instance_options.cc:
        fix valgrind warning
      933db613
  23. 05 Aug, 2005 2 commits
    • unknown's avatar
      New "Instance Manager" code: · ba6c1738
      unknown authored
      Rename "port.h" to "portability.h" to avoid conflict with system header file name,
      and include the file in "Makefile.am".
      
      
      server-tools/instance-manager/Makefile.am:
        Ensure that the (recently added) header "portability.h" (renamed from "port.h") gets included in the source packages.
      server-tools/instance-manager/guardian.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/instance.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/instance_options.h:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/listener.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/log.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/mysqlmanager.vcproj:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/options.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/parse_output.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/portability.h:
        Adapt the protective CPP symbol to the changed file name.
      server-tools/instance-manager/priv.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/priv.h:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      ba6c1738
    • unknown's avatar
      IM port cleanup · cd3fa684
      unknown authored
      server-tools/instance-manager/IMService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.h:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/instance.cc:
        cleanup & coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/listener.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/manager.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/options.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/user_map.cc:
        simplify password file processing
      cd3fa684
  24. 03 Aug, 2005 1 commit
    • unknown's avatar
      alot of formatting changes that came out of JimW's review · 55b4cb00
      unknown authored
      server-tools/instance-manager/IMService.cpp:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/WindowsService.cpp:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/WindowsService.h:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/commands.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/instance.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/instance_map.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/listener.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/manager.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/options.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/user_map.cc:
        fixed tabs and spacing per JimW's review
      55b4cb00
  25. 20 Jul, 2005 1 commit
    • unknown's avatar
      initial import of Windows port of IM. · 875b0e63
      unknown authored
      server-tools/instance-manager/commands.cc:
        type cleanups for compiling on Windows
        now using Options::config_file for the location of the single 
        my.cnf file we are using
      server-tools/instance-manager/guardian.cc:
        pthread_mutex_lock and unlock do not return a value on Windows
        so we return 0 in all cases
      server-tools/instance-manager/instance.cc:
        big changes here.
        Had to implement Windows versions of launch_and_wait and kill()
      server-tools/instance-manager/instance.h:
        added some function defs
      server-tools/instance-manager/instance_map.cc:
        pthread_mutex_lock and unlock do not return a value on Windows
        Also, now using only the file named as Options::config_file
      server-tools/instance-manager/instance_options.h:
        added reference to port.h
      server-tools/instance-manager/listener.cc:
        reworked and simplified the socket handling code.
        Added windows versions of the code that sets the sockets to be
        non-blocking and non-inheritable
      server-tools/instance-manager/listener.h:
        change Options to always be a struct.  Really surprised GCC was 
        letting this go.  Options was declared to be struct in some places
        and class in other places.
      server-tools/instance-manager/log.cc:
        added reference to port.h
      server-tools/instance-manager/manager.cc:
        moved all the signal code inside some #ifndef __WIN__ blocks
      server-tools/instance-manager/manager.h:
        change Options to always be a struct.  Really surprised GCC was 
        letting this go.  Options was declared to be struct in some places
        and class in other places.
      server-tools/instance-manager/mysqlmanager.cc:
        added in the Windows service code.
      server-tools/instance-manager/options.cc:
        Added in the windows options for running as a service and the code
        for loading settings only from a single file
      server-tools/instance-manager/options.h:
        added definitions for the new Windows service vars and routines
      server-tools/instance-manager/parse_output.cc:
        added reference to port.h
      server-tools/instance-manager/priv.cc:
        added reference to port.h
      server-tools/instance-manager/priv.h:
        linuxthreads should not be visible on Windows
      server-tools/instance-manager/thread_registry.cc:
        more __WIN__ blocking
      server-tools/instance-manager/user_map.cc:
        fixed passwd file code to handle files with \r\n line endings
      server-tools/instance-manager/IMService.cpp:
        New BitKeeper file ``server-tools/instance-manager/IMService.cpp''
      server-tools/instance-manager/IMService.h:
        New BitKeeper file ``server-tools/instance-manager/IMService.h''
      server-tools/instance-manager/WindowsService.cpp:
        New BitKeeper file ``server-tools/instance-manager/WindowsService.cpp''
      server-tools/instance-manager/WindowsService.h:
        New BitKeeper file ``server-tools/instance-manager/WindowsService.h''
      server-tools/instance-manager/mysqlmanager.vcproj:
        New BitKeeper file ``server-tools/instance-manager/mysqlmanager.vcproj''
      server-tools/instance-manager/port.h:
        New BitKeeper file ``server-tools/instance-manager/port.h''
      875b0e63
  26. 07 Jun, 2005 1 commit
    • unknown's avatar
      post-review fixes · 4a43ecca
      unknown authored
      server-tools/instance-manager/commands.cc:
        remove commented out code
      server-tools/instance-manager/instance.cc:
        use flag instead of int variable
      server-tools/instance-manager/instance.h:
        no more default values
      server-tools/instance-manager/instance_map.cc:
        use flag to be more verbose
      server-tools/instance-manager/instance_options.cc:
        don't read options when looking for an option, use strmake instead of strchr
      server-tools/instance-manager/instance_options.h:
        fix comment, use flag instead of int value
      server-tools/instance-manager/listener.cc:
        don't like c++ comments
      server-tools/instance-manager/log.cc:
        safety: strmake adds trailing zero to the string
      server-tools/instance-manager/parse_output.cc:
        use strmake instead of strncpy, renamed varianles to make code more readable
      server-tools/instance-manager/parse_output.h:
        get rid of default value
      4a43ecca
  27. 15 May, 2005 1 commit
    • unknown's avatar
      post-review fixes · 6b4dbcb4
      unknown authored
      include/my_sys.h:
        added prototype for the defaults correction function
      libmysql/Makefile.shared:
        my_chsize added to libmysql to let my_correct_defaults_file be used from libmysql
      mysys/default.c:
        New defaults function added we use it to correct defaults file. Currently the function doesn't lock defaults
        file. This is because of the linking and backwards-compatibility issues. This needs to be fixed later.
      mysys/my_chsize.c:
        comment added
      server-tools/instance-manager/buffer.cc:
        cleanup
      server-tools/instance-manager/commands.cc:
        refactoring: removed do_command method from most of the classes
      server-tools/instance-manager/commands.h:
        cleanup
      server-tools/instance-manager/guardian.cc:
        cleanup
      server-tools/instance-manager/instance.cc:
        cleanup
      server-tools/instance-manager/instance_map.cc:
        cleanup
      server-tools/instance-manager/instance_options.cc:
        cleanup
      server-tools/instance-manager/instance_options.h:
        cleanup
      server-tools/instance-manager/listener.cc:
        cleanup
      server-tools/instance-manager/log.cc:
        cleanup
      server-tools/instance-manager/manager.cc:
        cleanup
      server-tools/instance-manager/messages.cc:
        new errors added
      server-tools/instance-manager/mysql_connection.cc:
        cleanup
      server-tools/instance-manager/mysql_manager_error.h:
        new error codes added
      server-tools/instance-manager/mysqlmanager.cc:
        clenup
      server-tools/instance-manager/options.cc:
        cleanup
      server-tools/instance-manager/parse.cc:
        removed unused function
      server-tools/instance-manager/parse.h:
        removed prototype
      server-tools/instance-manager/protocol.cc:
        cleanup
      server-tools/instance-manager/protocol.h:
        added enum to be used in protocol.cc instead of the constants
      6b4dbcb4
  28. 11 Apr, 2005 1 commit
  29. 22 Mar, 2005 1 commit
  30. 21 Mar, 2005 1 commit
    • unknown's avatar
      Fix for AIX compilation failure: sacred knowledge of my_global.h nature (it should be · ddfdd6aa
      unknown authored
      included before any other include) was hidden from me.
      
      
      server-tools/instance-manager/commands.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/commands.h:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/factory.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/guardian.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/guardian.h:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/instance.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/instance.h:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/instance_map.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/instance_map.h:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/instance_options.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/log.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/manager.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/messages.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/messages.h:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/mysql_connection.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/mysqlmanager.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/options.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/parse.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/parse_output.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/protocol.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/protocol.h:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/thread_registry.cc:
        Fix for AIX compilation failure & cleanup
      server-tools/instance-manager/user_map.h:
        Fix for AIX compilation failure & cleanup
      ddfdd6aa
  31. 27 Feb, 2005 1 commit
    • unknown's avatar
      post-review fixes + cleanup + some minor fixes · dc9059e0
      unknown authored
      server-tools/instance-manager/buffer.cc:
        coding style fixes
      server-tools/instance-manager/buffer.h:
        wrong constructor initialisation fixed
      server-tools/instance-manager/commands.cc:
        cleanup
      server-tools/instance-manager/guardian.cc:
        cleanup + added lock/unlock routines
      server-tools/instance-manager/guardian.h:
        GUARD_NODE moved to the header
      server-tools/instance-manager/instance.cc:
        Fix for the linuxthreads/POSIX signal handling problem (see comments in the code)
      server-tools/instance-manager/instance.h:
        condition variable renamed and commented
      server-tools/instance-manager/instance_map.cc:
        We need to refresh guardian during flush_instances
      server-tools/instance-manager/instance_map.h:
        removed obsolete function declaration
      server-tools/instance-manager/instance_options.cc:
        added caching of computed values
      server-tools/instance-manager/instance_options.h:
        added vars to cache some option values
      server-tools/instance-manager/listener.cc:
        check whether we are running on the linux threads
      server-tools/instance-manager/manager.cc:
        lock guardian before init()
      server-tools/instance-manager/parse_output.cc:
        cleanup
      server-tools/instance-manager/priv.cc:
        added global variables to detect whether we are running on the LinuxThreads
      server-tools/instance-manager/priv.h:
        added global variables to detect whether we are running on the LinuxThreads
      dc9059e0
  32. 18 Feb, 2005 1 commit
    • unknown's avatar
      made IM to work with --defaults-file smoothly · e2d78b85
      unknown authored
      BitKeeper/deleted/.del-my.cnf~9322f78f12eb2f3c:
        Delete: support-files/my.cnf
      include/my_sys.h:
        fixed prototype to reflect changes in default.c
      mysys/default.c:
        use my_search_option_files instead of process_default_option_files. This is used from the IM.
      server-tools/instance-manager/instance.cc:
        added parameter to complete_initialization(). this ine marks whether we are creating the only instance
        (for instance, when no config file given)
      server-tools/instance-manager/instance.h:
        prototype changed
      server-tools/instance-manager/instance_map.cc:
        Now call my_search_option_files to work smootly with --defaults-file
      server-tools/instance-manager/instance_map.h:
        added first_option member. This is set of mysqlmanager was started with --defaults-file or with
        --extra-defaults-file to be passed to the my_search_option_files
      server-tools/instance-manager/instance_options.cc:
        if we have only one instance, name the pidfile `hostname`.pid for compatibility reasons.
      server-tools/instance-manager/instance_options.h:
        header fixed according to .cc
      server-tools/instance-manager/manager.cc:
        prototype fixed
      server-tools/instance-manager/options.cc:
        save --defaults-file of --defaults-extra-file to pass it to my_search_option_files
      server-tools/instance-manager/options.h:
        added an optin to save --default-file options
      support-files/Makefile.am:
        revert changes
      e2d78b85
  33. 15 Feb, 2005 1 commit
    • unknown's avatar
      some more cleanups and fixes · deba12cd
      unknown authored
      server-tools/instance-manager/commands.cc:
        typo fixed
      server-tools/instance-manager/instance.cc:
        moved options.complete_initialization to the instance::complete_initialization
      server-tools/instance-manager/instance.h:
        moved options.complete_initialization to the Instance::complete_initialization
      server-tools/instance-manager/instance_map.cc:
        moved options.complete_initialization to the Instance::complete_initialization, added code to create
        default instance if none is given iin config. file
      server-tools/instance-manager/instance_map.h:
        complete_initialization now returns an error in case of a problem
      server-tools/instance-manager/instance_options.cc:
        some error handling added
      server-tools/instance-manager/instance_options.h:
        error handling added
      server-tools/instance-manager/manager.cc:
        error handling added
      server-tools/instance-manager/mysqlmanager.cc:
        stop mysqlmanager if options were not loaded correctly
      server-tools/instance-manager/options.cc:
        return-value added
      server-tools/instance-manager/options.h:
        return-value added to the OPtions::load()
      server-tools/instance-manager/parse_output.cc:
        no need to examine mysqld --help -v termination status
      deba12cd
  34. 11 Feb, 2005 1 commit
    • unknown's avatar
      Post-review fixes + some bugs fixed + several minor features · dce2554f
      unknown authored
      BitKeeper/deleted/.del-client_func.c~3476a8a85cbd3c29:
        Delete: server-tools/instance-manager/client_func.c
      server-tools/instance-manager/Makefile.am:
        clien_func removed
      server-tools/instance-manager/buffer.cc:
        several methods added
      server-tools/instance-manager/buffer.h:
        Some error-handling fixes.
      server-tools/instance-manager/commands.cc:
        check for Buffer errors
      server-tools/instance-manager/guardian.cc:
        Guardian rewiriten. Not it works in a finite state machine-way.
      server-tools/instance-manager/guardian.h:
        Appropriate (to .cc) changes in the header + some comment added
      server-tools/instance-manager/instance.cc:
        added proxy thread to monitor instance. Two kinds of stop() now -- stop() and kill_instance which
        only sends a signal
      server-tools/instance-manager/instance.h:
        appropriate changes
      server-tools/instance-manager/instance_map.cc:
        cleanup
      server-tools/instance-manager/instance_map.h:
        cleanup
      server-tools/instance-manager/instance_options.cc:
        Caching of the pid-file-name is added. some comments added
      server-tools/instance-manager/instance_options.h:
        cleanup
      server-tools/instance-manager/listener.cc:
        listener my_thread_init added (though it doesn't use any mysys functions). Just in case
      server-tools/instance-manager/manager.cc:
        SIGCHLD handler removed. now instance monitoring is implemented through proxy threads. This is to work nicely
        with LinuxThreads
      server-tools/instance-manager/options.cc:
        added option to create a password file entry (this was implemented by Sergei Vojtovich)
      server-tools/instance-manager/parse.cc:
        inline function get_word moved to the header
      server-tools/instance-manager/parse.h:
        get_word moved here to use form parse_output
      server-tools/instance-manager/parse_output.cc:
        get_word() clone removed. now looking through the output linewise
      server-tools/instance-manager/protocol.cc:
        Buffer error chech added
      server-tools/instance-manager/user_map.cc:
        typo fixed
      dce2554f
  35. 03 Feb, 2005 1 commit
    • unknown's avatar
      Various fixes (cleanups, valgrind, makefiles, ...) · ab432d6c
      unknown authored
      server-tools/instance-manager/Makefile.am:
        increased default_monitoring interval
      server-tools/instance-manager/guardian.cc:
        some fixes for proper shutdown
      server-tools/instance-manager/guardian.h:
        removed init() prototype, as it was never used
      server-tools/instance-manager/instance.cc:
        cleanup() function removed
      server-tools/instance-manager/instance.h:
        cleanup() prototype removed
      server-tools/instance-manager/instance_map.cc:
        Instance_map::cleanup() removed, as instances have nothing to clean up
      server-tools/instance-manager/instance_map.h:
        Instance_map::cleanup() prototype removed
      server-tools/instance-manager/instance_options.cc:
        added print_argv() function for debug purposes
      server-tools/instance-manager/instance_options.h:
        declared print_argv()
      server-tools/instance-manager/listener.cc:
        some fixed in listener for proper shutdown
      server-tools/instance-manager/log.cc:
        cleanup
      server-tools/instance-manager/log.h:
        cleanup
      server-tools/instance-manager/manager.cc:
        some comments added
      server-tools/instance-manager/mysqlmanager.cc:
        we need to free memory in the very end
      server-tools/instance-manager/options.cc:
        fixed default options handling (as they were not working properly), added new method to cleanup Options
      server-tools/instance-manager/options.h:
        cleanup() declared
      server-tools/instance-manager/thread_registry.cc:
        cleanup
      server-tools/instance-manager/user_map.cc:
        missing password file is not a critical error anymore, as IM should be able to work as mysqld_safe only
      ab432d6c
  36. 31 Jan, 2005 1 commit
    • unknown's avatar
      more fixes for IM to substitude mysqld_safe in startup scripts · 92a52ccc
      unknown authored
      BitKeeper/deleted/.del-thread_repository.cc~bba09f64f8cb4037:
        Delete: server-tools/instance-manager/thread_repository.cc
      BitKeeper/deleted/.del-thread_repository.h~e6a3b9cab7a6612a:
        Delete: server-tools/instance-manager/thread_repository.h
      server-tools/instance-manager/commands.cc:
        All instances are guarded by default now, so we need to perform check on whether the instance is nonguarded,
        rather then guarded when adding it to the list of guarded instnces.
      server-tools/instance-manager/guardian.cc:
        Guardian rewritten to start instances by default, and shut them down, when exiting. Behaviour of the guardian
        in case of the instance crash has changed. Now it tries to restart an instance constantly in the first 2 
        seconds after the crash was noticed, and then it tries restart an instance once in the MONITORING_INTERVAL.
        If it failed to restart instance for "restart_retry" (compiled-in value) times, guardian stops trying to
        restart it.
      server-tools/instance-manager/guardian.h:
        Several new functions and variables declared.
      server-tools/instance-manager/instance.cc:
        now start doesn't call stop(), but rather tries to remove the pidfile itself
      server-tools/instance-manager/instance.h:
        cleanup
      server-tools/instance-manager/instance_map.cc:
        no more "admin" options
      server-tools/instance-manager/instance_map.h:
        User and password purged from instance_map options, as IM shouldn't know them
      server-tools/instance-manager/instance_options.cc:
        new option added -- shutdown_delay, guarded option now called nonguaded and has the opposite meaning
      server-tools/instance-manager/instance_options.h:
        appropriate changes, reflecting options addition/removal
      server-tools/instance-manager/manager.cc:
        shutdown process is complicated a bit -- at first signal thread should stop guardian, and only then the IM
        itself
      server-tools/instance-manager/messages.cc:
        update error message
      server-tools/instance-manager/options.cc:
        admin user/password purged from mysqlmanager options
      92a52ccc